public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Manish Jha <manishj@ami.com>
To: 'gaoliming' <gaoliming@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"isaac.w.oram@intel.com" <isaac.w.oram@intel.com>,
	Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Cc: "'Desimone, Nathaniel L'" <nathaniel.l.desimone@intel.com>,
	Felix Polyudov <Felixp@ami.com>,
	Harikrishna Doppalapudi <Harikrishnad@ami.com>,
	Zachary Bobroff <zacharyb@ami.com>
Subject: Re: [EXTERNAL] 回复: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error
Date: Fri, 11 Jun 2021 05:25:08 +0000	[thread overview]
Message-ID: <MN2PR10MB31658FDD6D6E90C497BD3548AA349@MN2PR10MB3165.namprd10.prod.outlook.com> (raw)
In-Reply-To: <002d01d75e73$aec476c0$0c4d6440$@byosoft.com.cn>

Liming,

IPMI_SET_BOOT_OPTIONS_RESPONSE is consumed in edk2-platforms repository in the below files:

edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg\Library\IpmiCommandLib\IpmiCommandLibNetFnChassis.c
EFI_STATUS
EFIAPI
IpmiSetSystemBootOptions (
  IN  IPMI_SET_BOOT_OPTIONS_REQUEST   *BootOptionsRequest,
  OUT IPMI_SET_BOOT_OPTIONS_RESPONSE  *BootOptionsResponse
  )


edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg\Include\Library\IpmiCommandLib.h
EFI_STATUS
EFIAPI
IpmiSetSystemBootOptions (
  IN  IPMI_SET_BOOT_OPTIONS_REQUEST  *BootOptionsRequest,
  OUT IPMI_SET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse
  );

Thanks,
Manish.

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Thursday, June 10, 2021 11:42 PM
To: devel@edk2.groups.io; isaac.w.oram@intel.com; Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Cc: 'Desimone, Nathaniel L' <nathaniel.l.desimone@intel.com>; Felix Polyudov <Felixp@ami.com>; Harikrishna Doppalapudi <Harikrishnad@ami.com>; Manish Jha <manishj@ami.com>; Zachary Bobroff <zacharyb@ami.com>
Subject: [EXTERNAL] 回复: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

KARP:
  I don't find the source code in
edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg to consume new struct IPMI_SET_BOOT_OPTIONS_RESPONSE. Can you point which source file depend on new definition?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Oram, Isaac W
> 发送时间: 2021年6月11日 8:13
> 收件人: KARPAGAVINAYAGAM, MANICKAVASAKAM
> <manickavasakamk@ami.com>; devel@edk2.groups.io
> 抄送: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>;
> Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; Jha,
> Manish <manishj@ami.com>; Bobroff, Zachary <zacharyb@ami.com>
> 主题: Re: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and
> Structure Defintions to resolve the IPMI build error
>
> Please comment the following commenting per normal style
>
/*--------------------------------------------------------------------------
--------------
>    Definitions for Get BMC Execution Context
>
----------------------------------------------------------------------------
------------*/
>
> Which would correctly be:
> //
> // Definitions for Get BMC Execution Context //
>
> Please don't use EFI_ or Efi prefix for items that are not part of
> UEFI
owned
> specifications.  Please correct:
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE
> and any uses.
>
> Thanks,
> Isaac
>
> -----Original Message-----
> From: manickavasakam karpagavinayagam <manickavasakamk@ami.com>
> Sent: Thursday, June 10, 2021 4:41 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Felixp@ami.com; DOPPALAPUDI,
> HARIKRISHNA <harikrishnad@ami.com>; Jha, Manish <manishj@ami.com>;
> Bobroff, Zachary <zacharyb@ami.com>
> Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure
> Defintions to resolve the IPMI build error
>
> Build error reported for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE, EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
> macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
> ---
>  MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h  |  4 ++++
> MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19
> +++++++++++++++++++
>  2 files changed, 23 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 +186,10 @@ typedef struct {
>    UINT8                                  ParameterData[0];
>
>  } IPMI_SET_BOOT_OPTIONS_REQUEST;
>
>
>
> +typedef struct {
>
> +  UINT8   CompletionCode:8;
>
> +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
>
> +
>
>  //
>
>  //  Definitions for Get System Boot options command
>
>  //
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> index 2d892dbd5a..1c692cc792 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 +17,23 @@
>  // All Firmware commands and their structure definitions to follow
> here
>
>  //
>
>
>
>
+/*---------------------------------------------------------------------
+----
---------------
>
> +    Definitions for Get BMC Execution Context
>
>
+-----------------------------------------------------------------------
+----
-------------*/
>
> +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT  0x23
>
> +
>
> +//
>
> +//  Constants and Structure definitions for "Get Device ID" command
> +to
> follow here
>
> +//
>
> +typedef struct {
>
> +  UINT8   CurrentExecutionContext;
>
> +  UINT8   PartitionPointer;
>
> +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP;
>
> +
>
> +//
>
> +// Current Execution Context responses
>
> +//
>
> +#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME        0x10
>
> +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE  0x11
>
> +
>
>  #endif
>
> --
> 2.25.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited.  Please promptly notify the sender by reply
> e-mail or by telephone at 770-246-8600, and then delete or destroy all
> copies of the transmission.
>
>
> 
>



-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

      reply	other threads:[~2021-06-11  5:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210610234121.7409-1-manickavasakamk@ami.com>
2021-06-11  0:12 ` [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Oram, Isaac W
2021-06-11  3:14   ` [EXTERNAL] " Manickavasakam Karpagavinayagam
2021-06-11  3:41   ` 回复: [edk2-devel] " gaoliming
2021-06-11  5:25     ` Manish Jha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR10MB31658FDD6D6E90C497BD3548AA349@MN2PR10MB3165.namprd10.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox