From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.4234.1578395367400127163 for ; Tue, 07 Jan 2020 03:09:27 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ytso0n7D; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: mateusz.albecki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 03:09:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,406,1571727600"; d="scan'208";a="215515608" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga008.jf.intel.com with ESMTP; 07 Jan 2020 03:09:26 -0800 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 03:09:26 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX112.amr.corp.intel.com (10.22.240.13) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 03:09:26 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 03:09:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fF6YUy3eAllLXjinEtBEmQTk0QXGhTMWTwR4lVvrTk3dJPanpZCoTEVVqEBqcvCNGW8DEpiG113GsXy44f3WKBxr7t4pvxTMSVIaFfeU8lq3GwoeR1QrNJ8bamvKxXYa+QwISiN6QlM753fe3H5tKt9+LX7xMOL7fzyjNXzNXf7Q1A/HNJmEkouS2qy9TlK62kAwCN5APran+jGHrwPcxEUPz+pIOOxyRLWB+r2JG6dW2x0XufTZGXipxdtXDY5ySZZyzZg6yKqiih5ff41cK83isjHMIkGRWZaPY7zBITxUVmPcN2tTVfOtPqpISlJ7Gxho5q97L/l/7+C+UcIRFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJ+qYxn/EDxpImkmAV1lispxHDt5I8iN9WrKMgb7Khw=; b=fwKgxrNVnQP69AIySAldYxm3b5iCg6wYrlWGpZ4IhyZ3xV0I9HBr8L4xvSKYJ0Q/P9J5jhK7Ku2OEZbnFecGpglx2x/DjJAcY7lUo8ee76fPlVhNQ5hv7+W7yIOAIbmeTWZpv7AjK11C/BGM7Ea7XM9cF/JtTbox2QhTMBptocjRMirdg6bj8HUIoyN57XiUqs5ABwN6K8xnF8dyyzzwMk8SvxwxbMZzrqGhJ5CfPtvRgX5kafVrfr0zlCFqBNm2UnrBPfOc2/FTHndgaERJkMbFFXoI1pgEKsPHv78jP7d5wCDb/pYyh/wzogTQuUVsDRG9RGELaTJhqy81whsc5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eJ+qYxn/EDxpImkmAV1lispxHDt5I8iN9WrKMgb7Khw=; b=ytso0n7Dk2kO9WQo/PU3ESfuo0UNQPdbVyZ4A4+FTOcivJJDcHYKIJ/yaFzsNoEq3tILtjoD6F22BBcgziiWdueNvVDhPdClY6QCIpJafYAtVyPeMxPeDjfr2AIWEc1TTSElnvZfmPOGoFflaIjq9aAl+JZj25l0iXvT+xxrS4s= Received: from MN2PR11MB3600.namprd11.prod.outlook.com (20.178.254.142) by MN2PR11MB4350.namprd11.prod.outlook.com (52.135.39.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.15; Tue, 7 Jan 2020 11:09:12 +0000 Received: from MN2PR11MB3600.namprd11.prod.outlook.com ([fe80::a47a:3dc2:c4aa:4ede]) by MN2PR11MB3600.namprd11.prod.outlook.com ([fe80::a47a:3dc2:c4aa:4ede%4]) with mapi id 15.20.2602.015; Tue, 7 Jan 2020 11:09:12 +0000 From: "Albecki, Mateusz" To: "devel@edk2.groups.io" CC: "Wu, Hao A" , Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" Subject: Re: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Topic: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Index: AQHVxUqawhFRLe/UaEKhHlGGRBDNY6ffCq1w Date: Tue, 7 Jan 2020 11:09:11 +0000 Message-ID: References: <20200107110621.232-1-mateusz.albecki@intel.com> In-Reply-To: <20200107110621.232-1-mateusz.albecki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTVkMmM2ODYtY2RlOS00ZTk5LTk4ZmUtZTEyMDdjNTg3N2QwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRkRNVWdmbzJWODlLdDEzcTlsRWJmNHNXakN1N2szR1NrTXZLMSs1bnFtYnp2bzE1TzlJcmRWbnZuNDJWdWhNUyJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=mateusz.albecki@intel.com; x-originating-ip: [134.191.221.108] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: afa3e3e6-1683-4e7b-dd03-08d793620694 x-ms-traffictypediagnostic: MN2PR11MB4350: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 027578BB13 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(366004)(136003)(396003)(346002)(376002)(39860400002)(189003)(199004)(13464003)(52536014)(5660300002)(8936002)(81166006)(8676002)(81156014)(55016002)(107886003)(76116006)(64756008)(66446008)(66556008)(2906002)(86362001)(9686003)(66476007)(71200400001)(66946007)(4326008)(6916009)(966005)(186003)(26005)(33656002)(478600001)(316002)(54906003)(6506007)(53546011)(7696005);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR11MB4350;H:MN2PR11MB3600.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: McpxRW7wtwxfYOubNS69RE+CdJIuaAw3uFVfjENS8JiQvlStn+tBvgIlqu+UvhikCmqB/9TH+bVQz2Nnh0bJC2qO6eokyB2UHToy+f79iOfgqJimlQTTzXTulistwQFX9okAUyGjPKuzY4Hb1rzy/Ad4aXuhhR2Z5I0yBUEqNch52yjMlKx5J4xpWjD/7rgJy/yb87uHErxmvPNSE/vOg0SdrKeul9RWSHNnJQPoxh+0pbZUfX3hCQLo+2uef9l1wpPrinh2eWyRkb+WFLETy/v9Hd76Cv9uxzQj6/FhH9djn0kAekbKKeyckB6tfgci6MyuloJJyglnHgMK2bu+NuJfpBcQ9gO/AIhTKYCjMTlmjcLrE4m4hgEl2YKGHlv9fEnFk27bLxj8BTPty2pXCaj+MSUcvHF0WbPKC4hdWO4JeDG9zbv0TMlx39FLqAsuGGW+33PRznoKWk9hvXAlmBA24i+KHuNyU36Kmgy4N0M9Jof3KbHhWM+2zZt6/DHbfVSnGsupIdZAvQ0YRRzCCLJvauQ9rtrE4ihb7EPSDpc= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: afa3e3e6-1683-4e7b-dd03-08d793620694 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2020 11:09:12.1832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O1RxMwNPL6UVTzTfyF3KlNiWW3HRV+930tD+UiDc1YckG+n/XEwDIRF7pH5KBwB30TdJjOmsY46paVCcqTYvQh9A6sbt/V5l0ZjAWVzBwmo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4350 Return-Path: mateusz.albecki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Missed github info: Clean patch series is here: https://github.com/malbecki/edk2/tree/sdmmc_ret= ries Patch series with the applied CRC simulation code is here: https://github.c= om/malbecki/edk2/tree/sdmmc_retries_with_test_code Thanks, Mateusz > -----Original Message----- > From: Albecki, Mateusz > Sent: Tuesday, January 7, 2020 12:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz ; Wu, Hao A > ; Marcin Wojtas ; Gao, Zhichao > ; Gao, Liming > Subject: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the > commands that failed due to CRC error > = > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1140 > = > Some of the boards report that just after we change the clock frequency to > 200MHz link is unable to stabilize fast enough and when driver sends the > CMD13 it will often fail randomly with CRC error. To protect against this= kind > of random failures this patch series will make the driver retry the comma= nds > that failed due to random CRC errors. > = > Since async code has not yet been tested it has been put into separate pa= tch. > That patch is not needed to solve most pressing CMD13 issues. > = > Tets performed: > -Boot eMMC in HS400 > -Boot eMMC in HS400 with simulated CRC error on every first CMD13 > = > Cc: Hao A Wu > Cc: Marcin Wojtas > Cc: Zhichao Gao > Cc: Liming Gao > = > Signed-off-by: Mateusz Albecki > = > Mateusz Albecki (3): > MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection > MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands > MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands > = > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 +++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 235 > ++++++++++++++------- > 3 files changed, 221 insertions(+), 108 deletions(-) > = > -- > 2.14.1.windows.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.