From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.1800.1588209418775228814 for ; Wed, 29 Apr 2020 18:16:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZkPoFgTH; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: tien.hock.loh@intel.com) IronPort-SDR: zpfF1eFRt/INTyf7eRRnFivkuQyvYTxZpJZYC71WwC7QlAiHFLdepxc0S2XVkMaK6HZwZYt9WM h8qdvSaW1uGw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 18:16:57 -0700 IronPort-SDR: 7ixwEK8YTI1hsJXPwk87nO+FFJg0AyCId78DauO8uO0vclEMiL8RA5rUq3bNYEB/qhR2vlUpe4 LUe47q1sxVXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="367980241" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 29 Apr 2020 18:16:57 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:16:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:16:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eK+E1piecu3lHMzIRz/FQ7ITpHTVv7ZPuWBhEGSxJAWZWhPLeGLJ4usrEEValkczQDdkASqMJpnA7nVRI5EUvOcMNMOfgjmKrDjADjMLJsTuijAj5uIRohNd+u0ifXK2iH26czjplzQanQNwQ5gpacdzE9VU62e3okG8CuBA5qAY4mp86KdA4ZA7R0q10Cuxwm9rVCh8gkoC9c/PfCYMQR1ge9UbJBJwww1VUIuMqScBABveOvBivVTK6BYPgM7RDGBH9qhx8i4WZjTbVbOjMUCqajZRCw1fSbtQ3jYVmKc16JhXTM8L2IXevM0wTr3CoZsio4F+ZMI+aHnkq9icEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TH1/hZZGwm8I49Vp+Wq0zITMMEDTwajE6t4GTSAwnnI=; b=nDmNbSUZ7aTVJNQFKJG0y7vCFel2lr6uQJ4pGHkHDf7FmL2GtDjkdSUv9yZHoSKAp0aaTOyQUrSjKCvl77RXRWvKFka3ITQd/FXtr+C44M2mhvjFhNWCHHRH+yyF1oFGjZRZtwrrABZsNtNR27iOYHwm8jych0p4Yuo+Luc33KRhYJCBNmoQWijw+oGX+OZy7n/mD0P0lBCCsg17/h14EH5N4PozaTfKsTjvzXetySRj+lap56hTrJ/q2zOJXKlv3Q1tT1bFrKTEp9PWT+30a+tCdpmoExMn9fYqI10/gBS1gheVr0D75UhNbbiDMIHzIfLpr9h5csuJk0bf/iDW2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TH1/hZZGwm8I49Vp+Wq0zITMMEDTwajE6t4GTSAwnnI=; b=ZkPoFgTHyfRK6DbaGLrsDejuvQX0MIW6Sd4EojEv3HEiSflP/jBPAZiXqr7OwevflWz1Enh4agnpyxguOWd71Atr3MBr06GxdIY2cp0T+nru6ns+K1V0wKthdAtaxXrwDQ9E0H8jXOIUY0DmuW+kzivlnl8V2MbEdzVYVh+0EZA= Received: from MN2PR11MB3869.namprd11.prod.outlook.com (2603:10b6:208:138::16) by MN2PR11MB4709.namprd11.prod.outlook.com (2603:10b6:208:267::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 30 Apr 2020 01:16:46 +0000 Received: from MN2PR11MB3869.namprd11.prod.outlook.com ([fe80::2d69:be8f:10a3:7849]) by MN2PR11MB3869.namprd11.prod.outlook.com ([fe80::2d69:be8f:10a3:7849%7]) with mapi id 15.20.2937.028; Thu, 30 Apr 2020 01:16:46 +0000 From: "Loh, Tien Hock" To: Leif Lindholm CC: Pankaj Bansal , Ard Biesheuvel , Gaurav Jain , "Meenakshi Aggarwal" , "devel@edk2.groups.io" , Haojian Zhuang , "Varun Sethi" Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W. Thread-Topic: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W. Thread-Index: AQHWDBzofcsD7xNxxEOSr+rMWAtEz6hsIpWAgCB8yACAAwslIIAAbHkAgADo3jA= Date: Thu, 30 Apr 2020 01:16:46 +0000 Message-ID: References: <1585905847-16380-1-git-send-email-gaurav.jain@nxp.com> <20200406140819.GI14075@vanye> <3d55018b-8751-bbe1-b1ac-98ac36e16e1c@arm.com> <20200429111618.GF21486@vanye> In-Reply-To: <20200429111618.GF21486@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [42.189.237.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5dc9016-eacb-4082-1110-08d7eca426f9 x-ms-traffictypediagnostic: MN2PR11MB4709: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR11MB3869.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(366004)(396003)(376002)(346002)(5660300002)(6916009)(33656002)(26005)(4326008)(186003)(86362001)(2906002)(55016002)(478600001)(66946007)(52536014)(71200400001)(66446008)(66476007)(9686003)(54906003)(316002)(8936002)(7696005)(53546011)(6506007)(8676002)(66556008)(76116006)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t+eLFB8GOOMgtAGUykudjEN0FE3DDKM8z4ATvnnUhTBdY+vBQWIoXbjaTEN5/ZVw95RrTzqiB8B/mG0vmBrqsUyPLgUiHiIREfZxd2ht302js6VKd0IskCYdTt49BvBiqAjq49yau5L0th65RtIqD7W3V1R7Wj8hI+Z6p6EF7rKOuh6vnYyrq2xdJE6ljw/VNVsssuOZhB3N019In5fQ3bq2ZocdikRJCIgHDW0C2ECFUBa6fkVjtl0TSj3oMbz1wYCdZzJko9MqEDM4oplk9i5wMww6f4BWw9zJ9syG8SobyTcv22FOS+R955TNbSpmBjKh3T81wZ90M9DaHKou48C+PReqJl15KEyAAT8PIKlQfNSQwU0zUj+uqQuMuVlQQ2CQTy6i36AxpCyww4E8sEoZc215xz3+6s6aPbaFx11zj5cRFGIEeaaH0wCwj5jx x-ms-exchange-antispam-messagedata: USfOGMLMoo7dnb+ofzAqwhhA6FUA8TCBn/qfkUdzJZuuM2RUP3t3mroUH1m5UoBbJ+XpWJvBhvO3gHyFiaQO/azC5pWarO1+oLOVK4KkJNEgzWYGhjowE6D5mOZRGkViaV60gyS5ejueAJvn7pnkzFg8rQ/N6rINWSsrdFNRISAl7VEqU/8C4tZ0BQ7cngHnXiX/XSpjqbxvZZm1jBEEK/Da3KYEV5ptRGwIjhdhFir4sc616TsqX7JPKuxfTQQs86nMCPYe6P9Uzsbz2H6xE8YGt4Uj0phLrsYunSpaHswgrRYC79RNTWEbG3M6YhsUokP2+Zc9rkQbJTYmiLqovQ0B7sYWQlMTrC/RkdUQ7X+N57lAx1sUZezQwgCaxetszBT+IEzKfYsxYTbMQVm+S3bKKIC8FWWmr5xqr4JcET0Yfx8diQHfU1aK8KnctKoU/rQH8xOliM4/9rEDe5eRPo5D54nUwc2H8dBWHVWIfjRtWOMMa+fQCGt3NXKaEi+1JaJKYYzL3YxH9HbEDDpvVdgkZ1RF9NODEoE/PYSHvkWBwF3kT8vSJPRgnntjkh3aBljNCLK0K/SrXoyDfd4hADr9pXeSx7LhDMW4dd09fTBne6ZlIK6TmfgGUy/BINIwq0Gvro/nnxVmSVrF7ByXVT4+xgzhYjtWDAAUxBs/zBNuWterjKB13sGOD+JXveOqLl9R+sFwLBot1OWs208IxzrDX3/cTzToNExP7Tp9ItJtfuaqL0MDhh8ucfyGhQnUNe7dtTkwa/otjHsQ7q0ktodmWYc/X6RLoxqeApnWASw= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c5dc9016-eacb-4082-1110-08d7eca426f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 01:16:46.7364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ADYqzXbuEc2rRoJ5a+BKDuihw7hLiYAU7GB1uR4ZjA8Z0jRgNvZ/RcIkiVKhU0UxejzyXtzze1PtyVb1rtZhTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4709 Return-Path: tien.hock.loh@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Yes, that's a Reviewed-by.=20 Thanks.=20 > -----Original Message----- > From: Leif Lindholm > Sent: Wednesday, April 29, 2020 7:16 PM > To: Loh, Tien Hock > Cc: Pankaj Bansal ; Ard Biesheuvel > ; Gaurav Jain ; Meenakshi > Aggarwal ; devel@edk2.groups.io; Haojian > Zhuang ; Varun Sethi > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer > Limit 65535 in R/W. >=20 > Hi Tien Hock, >=20 > Can I take that as a Reviewed-by:? >=20 > Regards, >=20 > Leif >=20 > On Wed, Apr 29, 2020 at 05:17:18 +0000, Loh, Tien Hock wrote: > > Hi Ard, > > > > I have checked the patch and it looks good. > > > > However, I can no longer test the patch as the new DwMmc driver no long= er > uses the protocol. > > Sorry for the delay, I initially thought I can test it until I investig= ated further > today. > > > > Thanks > > > > > > > -----Original Message----- > > > From: Pankaj Bansal > > > Sent: Monday, April 27, 2020 2:19 PM > > > To: Ard Biesheuvel ; Leif Lindholm > > > ; Gaurav Jain ; Meenakshi > > > Aggarwal > > > Cc: devel@edk2.groups.io; Haojian Zhuang > > > ; Loh, Tien Hock > > > ; Varun Sethi > > > Subject: RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > Transfer > > > Limit 65535 in R/W. > > > > > > + Meenakshi > > > > > > > -----Original Message----- > > > > From: Ard Biesheuvel > > > > Sent: Monday, April 6, 2020 7:42 PM > > > > To: Leif Lindholm ; Gaurav Jain > > > > > > > > Cc: devel@edk2.groups.io; Pankaj Bansal ; > > > > Haojian Zhuang ; Loh, Tien Hock > > > > > > > > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > > > > Transfer Limit 65535 in R/W. > > > > > > > > On 4/6/20 4:08 PM, Leif Lindholm wrote: > > > > > Hi Gaurav, > > > > > > > > > > Haojian, Tien Hock - can you help review/test this change? > > > > > > > > > > Best Regards, > > > > > > > > > > Leif > > > > > > > > > > On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote: > > > > >> Moved BlockCount calculation below BufferSize Validation checks. > > > > >> First Ensure Buffersize is Not Zero and multiple of Media BlockS= ize. > > > > >> then calculate BlockCount and perform Block checks. > > > > >> > > > > >> Corrected BlockCount calculation, as BufferSize is multiple of > > > > >> BlockSize, So adding (BlockSize-1) bytes to BufferSize and then > > > > >> divide by BlockSize will have no impact on BlockCount. > > > > >> > > > > >> Reading Large Images from MMC causes errors. > > > > >> As per SD Host Controller Spec version 4.20, Restriction of > > > > >> 16-bit Block Count transfer is 65535. > > > > >> Max block transfer limit in single cmd is 65535 blocks. > > > > >> Added Max Block check that can be processed is 0xFFFF. > > > > >> then Update BlockCount on the basis of MaxBlock. > > > > >> > > > > >> Signed-off-by: Gaurav Jain > > > > > > > > > > > > Hello Gaurav, > > > > > > > > Could you please elaborate on the underlying need for this change? > > > > If you are considering using this driver for future NXP platforms, > > > > I should point out that this legacy driver is only kept around for > > > > existing users, and new users should use the driver stack in > > > > MdeModulePkg, which is based on the UEFI spec. > > > > > > > > -- > > > > Ard. > > > > > > > > > > > > > >