From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.6306.1592296717362891466 for ; Tue, 16 Jun 2020 01:38:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Kq2O3iC1; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: tien.hock.loh@intel.com) IronPort-SDR: HNVrJUDpwuX/bdFlPeRsoQWQfxg/Lxz5E+T4Df1NLenX2VFZr4jvTAg7buIk4u4p5LJwwchk/a /JntChxKLFug== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2020 01:38:36 -0700 IronPort-SDR: snKwjtCMnBz4ZnjKMidRjgdOZFGngLm3YeB10Etn31S9lJWTbtbEpt8147IJpnnS9qPRndkpvj IZGzNPC7J2Pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,518,1583222400"; d="scan'208";a="476328052" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 16 Jun 2020 01:38:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 01:38:36 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 16 Jun 2020 01:38:35 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 16 Jun 2020 01:38:36 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 01:38:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nDix2YgQJcjO9aZ+O8D2r+8UdOVeRri+94317Skcr6Y74NXLm0waKbbH51240uyZ8XSaEwepS6TGd9P1lSc+VYiXf5bkX97XCI5UYwpZw2KmoK05LalAgnJUpO6Gy+M7i1FZVMRSaCsPtnB5xI2Z/w0X1TUo2XEStLF0RLijO+t0DtE/nKiVLkLFX17xhEbhS06VjdARwzkoGED1poZrWT9t4ifLgdsTHL2PU9NyQWyYMfBJmb4SrSHeOABTX+5NSbiz5e2IPluxP08MgengQbBFttgaXV4CWfHVg+uHcBoBpW05wpX5LosIXHGEKdT7Nvwfi/p+wL0bmjBK2POlxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FC9kSYgjPOq7zVJ/eN2NhuZvyPjfQESFKBLlQBIYVog=; b=BvntD8bbfDfHdFxfzYZT7jcGeZjb/BYHeb8+4T1wMpNHx3Et+coL4FfeFDc95moYXDuE5zQMIQ1b4hTrmMVOZflPuIlf6BDf7a9ly6BGTgaBSW65Ok7KQpYpYrS0gME6lTA38oZ9vs8JtQYlNA8hObdjSuiJI4RkjNPXVCRWY7wdninVXtqCXmjP/kN0ElrHl0TkZI4MulaaB4Nz7w9bhtX/Ot2gwtC+dIMd84usPvkAf9Ea/gSbXuZBSWYtN6eVZvUMcy+lTcbMUvOfDcSkvYITdsGQyakYXac6S9VOwykMxX3y1I8c/lxab4tRx9Xk1Wh03TtX3u5wNSKln8zv0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FC9kSYgjPOq7zVJ/eN2NhuZvyPjfQESFKBLlQBIYVog=; b=Kq2O3iC1LjlCq1pemVA2JPMfL5dqsbIcjpacoY6Z3MKps/XKOeMVgk00XGHxW3WRmfatlXnaVVsH5rbvQIz+rj7qXXefxooxybt8GLySLSrVhkMUjtWSNYYMpIDc8AguqJqi0eCASwN11tEmwVVt0o/b0AcpG0zLq28UWtYDvew= Received: from MN2PR11MB3869.namprd11.prod.outlook.com (2603:10b6:208:138::16) by MN2PR11MB3712.namprd11.prod.outlook.com (2603:10b6:208:f6::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.22; Tue, 16 Jun 2020 08:38:34 +0000 Received: from MN2PR11MB3869.namprd11.prod.outlook.com ([fe80::2c62:503b:c5d4:d25f]) by MN2PR11MB3869.namprd11.prod.outlook.com ([fe80::2c62:503b:c5d4:d25f%5]) with mapi id 15.20.3088.028; Tue, 16 Jun 2020 08:38:34 +0000 From: "Loh, Tien Hock" To: Haojian Zhuang , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" , "christopher.Co@microsoft.com" CC: "devel@edk2.groups.io" , "thloh85@gmail.com" Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver Thread-Topic: [PATCH v2 0/3] add DwMmcHcDxe driver Thread-Index: AQHVQgHjv9n2w3nTgkexcjW/jhKm4abiR+kAgBnGCbCAG8pEAIAP8SvwgbUkV1A= Date: Tue, 16 Jun 2020 08:38:34 +0000 Message-ID: References: <20190724092606.185319-1-tien.hock.loh@intel.com> <20190730073300.GH6058@gmail.com> <20190902093116.GA29393@hackbox2.linaro.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9105d49-35d6-435d-aabf-08d811d0a831 x-ms-traffictypediagnostic: MN2PR11MB3712: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 04362AC73B x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0+vq+ee571tpwyMdV0HgC0kiDQqzw1TDBAUcDFSwUwl7snr2s4pTtReAznrgbuw9hkhYb+p78LvQJ/tun0kiJoiuG2x18eGwf9ktyMKBIWmTSbMOV5lmNIvcuJUFxBwBO7BvxumOYcu86/yM7aZqj9CxR5eT8Yhej5jtQ98wc6FmKLIdXqAVos3nCWdu1k/qwbVdvHeGoMbXryaRFOG97WFND3PDtadbPvS6b8gOwU0gU/+W2ICjVeOabreP6Jd1L9YHNrAhmDkgD2Za5rMnm2QqCIYwIbkibBgA2FtWcHe33y0wggXOXiASPJKtNZJR/pO6evAr1Kk1kfhzwMsfbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR11MB3869.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(396003)(346002)(136003)(376002)(39860400002)(366004)(52536014)(8936002)(7696005)(53546011)(6506007)(2906002)(76116006)(86362001)(83380400001)(4326008)(8676002)(316002)(55016002)(66476007)(66446008)(186003)(71200400001)(26005)(64756008)(45080400002)(478600001)(54906003)(5660300002)(33656002)(110136005)(66556008)(66946007)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: J7kOg0IwqCmxDv5uHJZrvqbW3Bn3owSb9UoYY583HrM2lhrMxcuScIiiElxs+zq/Q+CN1xtOwuMGjBRAJVCDUth5V1TWN4N5ScJhXWljZC44ppgBlzmjanFuM5UNBOpaSqhryikZlM2y8KxBRwqVk+qZFBDol+UCCa9bmImv6vEYr9yI+Mgtwc3Tn9kUchjCb8lDym7cekYlJzvaX5PLCTqtgEs9gKWq0kielWAAVBSogFGsjvFJQcsaGalmRoxtEXwnK+QOpuM3CsxDUtcSu0m1pA4vJ3KgXk9OinTIcJESvFK8UTkihF57TiTD9lli1mYhmjpgDc2Wa4cwoY1oeqE5RMLQ06kpkU51QjxTMFcxtxm4v+QIdZlDbqUYebM+EbeNVd04e9CL9Xv8P554pWC921l0q11VJZaXDWIj0A/iBikQNeRBX5SoAOZjEoLJU2Q/EKxLfHG9H5wX2TQPZbFhsbzS5vzkfFM1V8mJ3A0MRBYdjJyAcm80MP3ApbhG x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e9105d49-35d6-435d-aabf-08d811d0a831 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2020 08:38:34.4392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rTqrgKswaDtwr/HKkqUjRlkL2eEiwH7pqpVREgh1kDUhj1/N49TRPS72zTwmFByrXnqop9ppdZPF/884FD+3rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3712 Return-Path: tien.hock.loh@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Ard, I talked to Haojian and got to know that you wanted the patch to go into th= e MdeModulePkg.=20 I don't have a lot of context on it, do you have specific requirement? The driver at its current state already uses the MdeModulePkg's SdDxe's API= , so some more specific changes would help me understand and fix the concer= n you have. Thanks > -----Original Message----- > From: Loh, Tien Hock > Sent: Thursday, September 12, 2019 12:59 PM > To: Haojian Zhuang ; leif.lindholm@linaro.org; > ard.biesheuvel@linaro.org; christopher.Co@microsoft.com > Cc: devel@edk2.groups.io; thloh85@gmail.com > Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver >=20 > Hi Ard, Leif, Christopher, >=20 > Any comments on the patches? >=20 > Thanks! > Tien Hock > > -----Original Message----- > > From: Haojian Zhuang > > Sent: Monday, September 2, 2019 5:31 PM > > To: Loh, Tien Hock > > Cc: leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > > christopher.Co@microsoft.com; devel@edk2.groups.io; thloh85@gmail.com > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > Hi Leif, Ard, Christopher, > > > > Could you help to share the comments on this patch set? Thanks a lot. > > > > Best Regards > > Haojian > > > > On Thu, Aug 15, 2019 at 09:09:19AM +0000, Loh, Tien Hock wrote: > > > Hi Leif, Ard, Christopher, > > > > > > Haojian and I have tested the driver on 2 platforms, any further > > > comments > > on this? > > > > > > Thanks > > > Tien Hock > > > > > > > -----Original Message----- > > > > From: Haojian Zhuang > > > > Sent: Tuesday, July 30, 2019 3:33 PM > > > > To: Loh, Tien Hock ; > > > > leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > > > > christopher.Co@microsoft.com > > > > Cc: devel@edk2.groups.io; thloh85@gmail.com > > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > > > > > On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock.loh@intel.com > > wrote: > > > > > From: "Tien Hock, Loh" > > > > > > > > > > Changelog: > > > > > v3: > > > > > * Fix an issue in NonDiscoverableDeviceDxe driver where it did > > > > > not > > > > invalidate > > > > > cache before copying the memory. > > > > > v2: > > > > > *Split DwMmcHcDxe driver into two patches. One is for > > > > > PlatformDwMmc > > > > protocol, > > > > > and the other is for DwMmcHcDxe driver. > > > > > v1: > > > > > *Add NonDiscoverableDeviceDxe for embedded platform. Make > > > > DwMmcHcDxe driver > > > > > to support both eMMC and SD controller. > > > > > > > > > > Haojian Zhuang (3): > > > > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > > > > > EmbeddedPkg: add PlatformDwMmc protocol > > > > > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > > > > > > > > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 > > > > +++++++++ > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 > > ++++++ > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 > > > > +++++++++++++++++ > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 +++++++ > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 > > ++++++++ > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > > > > > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > > > > > .../NonDiscoverableDeviceDxe.c | 243 ++ > > > > > .../NonDiscoverableDeviceDxe.inf | 52 + > > > > > .../NonDiscoverableDeviceIo.c | 976 +++++++ > > > > > .../NonDiscoverableDeviceIo.h | 92 + > > > > > 16 files changed, 9495 insertions(+) create mode 100644 > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > > > > > create mode 100644 > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > > > > > create mode 100644 > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > > > > > create mode 100644 > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > > > > > create mode 100644 > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > > > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > > > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > > > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > > > > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > > > > > create mode 100644 > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > > > > > create mode 100644 > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > > > > > create mode 100644 > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > eDx > > > > > e.c create mode 100644 > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > eDx > > > > > e.inf create mode 100644 > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > eIo > > > > > .c create mode 100644 > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > eIo > > > > > .h > > > > > > > > > > -- > > > > > 2.19.0 > > > > > > > > > > > > > Hi Leif, Ard & Chris, > > > > > > > > Could you help to share your comments on this patch set? > > > > > > > > Best Regards > > > > Haojian