From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.6018.1675305689803114542 for ; Wed, 01 Feb 2023 18:41:29 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Jf+fQ28J; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675305689; x=1706841689; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SEQjczCK88hM47FCAx9EeUurjJPJKK2iOG8L28Eob5o=; b=Jf+fQ28JIMjyfMKq41NXzQ+WLHUbgENEjQ758UK9F7nGA+8iJRh45gPg 7vJMKmdv/wwf+w0+DqiAHIqVLj9h2ZpbXZHXAo9yJMibJoY0NQHv2orku TBhIcXTU48R+4sUwZyf9GjK+9+yUMkH1flpPIRREwKwrP+9N/CREk+x3W gXKoPVhbgX6zkeeohWxOa89HONbq3d8+DY8OTpHPoC0D5sdl40K8edOvx 29k0uYG4FYAr/lXJpXpSaG6vpS0ETUd/AnRKaKInQ9Q+uU+pfOLKu+q0W dRnP6P8JOtgnKcpGtV9bzWCKgwkMj0/+bx1u0QsbvrhedbKTrH0BxcC4v A==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="330467824" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="330467824" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 18:41:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="658557736" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="658557736" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 01 Feb 2023 18:41:25 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 18:41:25 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 18:41:24 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 18:41:24 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 18:41:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jIC8mo2x2XsEY8+laqZ2W/+kQCIsmGXB80C76Ju750gi8dQyhRLAeKQwSCVYBpb0ZqtyInVWLYRsxYqQgpsccwhWwPClAgo8OHa32Xbn1EhylGhb8wyzOoLpdr58A9i+zCNivSOM3Wfirez5yS75bxlMY7BF7S/F5Wgm1GHcMx0wWIQkBRxGMPDFNAy3KTGu3dIIFQGQL6CJAmTOW9uk+V22XA8WynIGYkbGs/JQKQg0SFZ05g+bFTQC/6t3tyq3EmvZxz4+TYrBZLt7ljng4ymgSulg9IqJxRA0jBQSMdTxIS5o85RTFa92Hh8CahSDzxQhErEOHu910/ozYy1fWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m/d+0LJwqasJ6cQ7Ou+rafHU4In2t3IXuKHmGaIJDLs=; b=BYANBQQXBzU9rFxTC0p1Dwfm1aP+i/SMbYmAAWHo3HSWd7YZh+ohmmGUi9uDOQwBOdB72m3jJDuXeIqckMES6p6xVUW2h5MIIcJvL+zlxqK+V6lesAkOW1JxYiaDPp/sA5Gvr8xAD0KVlAVHuiTa/20hrR++U+LQ09fcUYgjsmnCbYhfmW6Pe4fuKkPc16SseVslnU/oLZ2sgQrcAxNqUE6WAWIfQSmvDAuq/HyvOfqZGyzFM0fNV4+rSKS/+D5T4pJmFUtXA/9PJxE6VRHRDHYPCJtUmH04Kr9ZvYLPM4HakxD8gfVJZirYO+kaFRERiLP/KILvx1MjaMf1wDlsQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN2PR11MB4031.namprd11.prod.outlook.com (2603:10b6:208:150::18) by PH7PR11MB7717.namprd11.prod.outlook.com (2603:10b6:510:2b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Thu, 2 Feb 2023 02:41:17 +0000 Received: from MN2PR11MB4031.namprd11.prod.outlook.com ([fe80::e086:f4b4:bb08:af59]) by MN2PR11MB4031.namprd11.prod.outlook.com ([fe80::e086:f4b4:bb08:af59%7]) with mapi id 15.20.6064.025; Thu, 2 Feb 2023 02:41:17 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Zhu, Weipu" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg: Add NVMe boot partition header definition Thread-Topic: [edk2-devel] [PATCH 2/2] MdePkg: Add NVMe boot partition header definition Thread-Index: AQHZNnIw4kSEXHH840+oCd0VM+9Q/a668IGw Date: Thu, 2 Feb 2023 02:41:17 +0000 Message-ID: References: <2e4c3646b03b7660b7e6430b202ea01ee3cee0be.1673939866.git.weipu.zhu@intel.com> <16678aa67fac85fd6daf80d63b40a55d9785e517.1673939866.git.weipu.zhu@intel.com> In-Reply-To: <16678aa67fac85fd6daf80d63b40a55d9785e517.1673939866.git.weipu.zhu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR11MB4031:EE_|PH7PR11MB7717:EE_ x-ms-office365-filtering-correlation-id: 12c43287-7c96-46ca-bb09-08db04c6f5d1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4yyDOsVDBJBdJWnDs7X/0Jl3qOzhiuankzspRAX3Jk1W056tTrudDhJv49SROwVuAFUDCz0UphGO1HuYCWu2AtCxwy9AL1R5Wzfq+vDO+BdmUmwrVbmq1qBwkpuGpZ8aUbPD4DQnB7/Ct/Uxr4PRVpyeECBC6TD1ecddc++L5Yh7COnsshlvgqWLoWVIVCfWDCxOxYDzeeXtQ1DgUBklS+HYIwqscF1LhAnypb2LtQBgkvDTlz/T5vMDl+2J8ynnyUkBXEVIY3If5PBFY1uf2PIGht/ObbdcLxiKLuxlsUMdoc4xW3PNPyZtpjK2WQZpzqs8+5zs+ymHrzwBGbU2AZrTB7NXi8M+pwnaw1MJCqwGzaT+zYv17n3TSeKagiQGfqGwKvwpNoBpuQcbrqPt3dyeRrbJt2Kj7T/PTRfc49q1b4+6i5MlMrcl6DhamPFixXtYmZ4JITHEcjgUn26nBLD2Em3MH03IYQeJ797vNefYwpyYHCWt438XlS21v1j1ty+xlFxisE3HdI2fsCy+03hG0avpZZ3twuVdEjkutksNYRKvKzgX5fwAhciKN9h6vPS7JTKx9WIEcZRz/g23n3OExGcMstJ5Dp9vdgV05HBWRXt03PWMuCqSJk8gbpiTLuxp9nWMk8+9fQOMpKAHDkg9L3boZbiCHpLEzFZWo8Kmr4vI6jrANyRj8JqqdvlqTYcknePAlfgnN1iSycRbve3riqdPVRHQN66mjozHevR6d49fOIdBQ+KVXd0WHUS/GJoA7txZ+i7o/Ak0HEeVGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR11MB4031.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(366004)(136003)(396003)(39860400002)(451199018)(54906003)(110136005)(6636002)(83380400001)(186003)(9686003)(316002)(2906002)(33656002)(26005)(82960400001)(66446008)(66899018)(38100700002)(66946007)(478600001)(8676002)(76116006)(66556008)(86362001)(8936002)(71200400001)(122000001)(6506007)(53546011)(55016003)(107886003)(7696005)(4326008)(41300700001)(966005)(64756008)(66476007)(38070700005)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J9vGETLYkdmauzKi6R/FpiIJVpEn3usDfO6pPHYBrwqX3tbRZQuxoQaTAPzu?= =?us-ascii?Q?JeWpcgevIUcE0XImpuwPxzLdkKcBjQAokIlm6KOHqzqPenXPzH1YDX9E5e/q?= =?us-ascii?Q?MXZeaaggAZlbnz/vMhNgLEtxfRIBN36IjmJ0TWzgn7NLJwV4lecOM0pQaNa3?= =?us-ascii?Q?NoDL0aTG3aYkKyreBViX+H/yeCSOsARNVipbz4mnzuZnW/2sAbXsQiIHxQdJ?= =?us-ascii?Q?JwohN4v212knVcBJzaiHIE/RTAarBUFaUjmoQgb7Q5KiOu0RWpQaFxW/I031?= =?us-ascii?Q?0nP4umHsJU1XgGrtot6eqRI6d5DQl3qGJdcqQe3h6laPyg8VmQKuVePArBsW?= =?us-ascii?Q?UzLghbq0Ze1dgi2+5MXb5FRL5likUpWBq0zIMr3HxrDzwEjARxTdj15RLqeY?= =?us-ascii?Q?EW08zaeup9q1sB9eID0SzSWvsRu6e9/dd5HqLYFnj9yRbhlnSc6vw2oHrqEH?= =?us-ascii?Q?1x6ikNyNrq+fnq3mdwVAMSoYI7WHJgjEV+/ZZ1TKg1ABv+lCkw8dB+RpEcH0?= =?us-ascii?Q?iPKNP5x5w3V/p4I98LSHi2tx59KT7IZ4y7BGq3oPA+r2TerhGSklqmklLDq+?= =?us-ascii?Q?U+5AP8gF3KHhgAqjqYZk4QtIJeJi7ZImGEoVsOBCzUd5ouXcicJNPyjNizu/?= =?us-ascii?Q?h9k0AfdDdM9ykQ2Hv/fV9XhbY8aNSPX8LSvZnHIr3qRKxbdtzmcIm0SUJQjz?= =?us-ascii?Q?LuPqX5JzDT8RnlbjGPhQsoH7l9lj9Ufa7+3qs6xE931GU2hRRSDmDimA+8vY?= =?us-ascii?Q?/gyES+f+fo3WnM2mmKg0J9++X5xA3MdxnKwQ/f1KcVT8qcVshuROi/6zXOq4?= =?us-ascii?Q?FmVUoOqqoKKIFkwaVL0UdK4xYJ5fBujQsIr8tkWnnc6Q4gaIUrN+zX06t0t6?= =?us-ascii?Q?Y5LbLnLuMfFSInHGdmAPUcyQrFXYO95XvxBZMal6ppidC6fS25lV0urLwZYW?= =?us-ascii?Q?aUCUX0F3Y5ubDZCORjjQJB74VNpJrVh2qE0YfEN7pIGKFOkua/f8kagm3ekz?= =?us-ascii?Q?pBDqQqdCzVm18fZPnp7LIZqV7b55klvMXhWJ9Zau5iAYcSpr4HD/lfXYRPA8?= =?us-ascii?Q?XgNu3SjzWF9FZjfC+zE/fR4cq52WEnYoXizo6jn4hrbDMvLXRZd6a6+0iBbH?= =?us-ascii?Q?yK3QfdXYYJPVaCQjTDOtw6jHvphEMh859r/d/YoUcJsE8owhjYIurkLaV06i?= =?us-ascii?Q?YgZLSIx+oQJHeVSP9grfcBmw9HwC2Gcllac6ciA/d7ELsAoQ5ABY7xqcNfUe?= =?us-ascii?Q?qL7oegLLJhTFmu7QDzKBH1PT9zkS1jg+T8nETG2Vy/1DP8UKgpsUNhgkk+6Z?= =?us-ascii?Q?ZpUEUiTcd/VdjR7eiEBqgDA+S/8xfrJQ0qQ1NUQe4j6mgXfGVgFNPq3hVdRo?= =?us-ascii?Q?mx//rC+GR4qIzXotODAMiA/eVdGnZEprAzOsnVrho6Fq7PoARh+vX6wU9b9W?= =?us-ascii?Q?SGYe4HCKeGj0jc0A3Ln5ltIAT64XYkS/rAcsAGeqXnJ3Fg7UKGVR9iBdv8+Y?= =?us-ascii?Q?+Fierhis/7UyP4lmTiCpKEOxjFAuu+3/7BMBWJB3gqf233Jkp5x7FjqWTG+Z?= =?us-ascii?Q?4rXNobgYaCZ4gV2+mAQRMo2GT2QCBwvfsPLVaH7Z?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4031.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12c43287-7c96-46ca-bb09-08db04c6f5d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 02:41:17.6943 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bv2A+sl82OL83cgrfMxjFFtKqbwAfzoH1mhpKpQFUkZgxAiYIkEPiQ2tSevAkU5qzJM9Zm9NZeU1XlajPUg/Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7717 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add MdePkg maintainers & reviewers. One inline comment below: > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Weipu > Zhu > Sent: Wednesday, February 1, 2023 2:27 PM > To: devel@edk2.groups.io > Cc: Zhu, Weipu > Subject: [edk2-devel] [PATCH 2/2] MdePkg: Add NVMe boot partition header > definition >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4304 >=20 > Add NVMe boot partition header definition to NVMe.h > according to NVMe spec 2.0. >=20 > Signed-off-by: Weipu Zhu > --- > MdePkg/Include/IndustryStandard/Nvme.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Nvme.h > b/MdePkg/Include/IndustryStandard/Nvme.h > index c37cd762b9..41d40edbba 100644 > --- a/MdePkg/Include/IndustryStandard/Nvme.h > +++ b/MdePkg/Include/IndustryStandard/Nvme.h > @@ -546,6 +546,17 @@ typedef struct { > #define RPMB_RESULT_AUTHKEY_NOT_PROGRAMMED 0x07 > #define RPMB_RESULT_INVALID_DCB 0x08 >=20 > +// > +// Get Log Page - Boot Partition Log Header. > +// (ref. NVMe Base spec. v2.0 Figure 262). > +// > +typedef struct { > + UINT8 LogIdentifier; /* Log Identifier, shall be set to 15h *= / > + UINT8 Rsvd1[3]; /* Reserved as of Nvm Express 2.0 Spec *= / > + NVME_BPINFO BpInfo; /* Boot Partition Information, Brs in > NVME_BPINFO is not available here */ I suggest to not directly use NVME_BPINFO here. Since the 'Boot Partition Information' within 'Boot Partition Header' is no= t exactly the same with the one defined for controller properties (no BRS fie= ld like you mentioned in the comment). How about adding field definition for 'ABPID' & 'BPSZ' instead? Best Regards, Hao Wu > + UINT8 Rsvd2[8]; /* Reserved as of Nvm Express 2.0 Spec *= / > +} NVME_BOOT_PARTITION_HEADER; > + > // > // NvmExpress Admin Identify Cmd > // > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20