From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "gopic@ami.com" <gopic@ami.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk
Date: Thu, 27 Oct 2022 02:48:32 +0000 [thread overview]
Message-ID: <MN2PR11MB4031482DDF734022D5B6F702CA339@MN2PR11MB4031.namprd11.prod.outlook.com> (raw)
In-Reply-To: <17380.1666791847771103171@groups.io>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
Thanks a lot.
Just one minor comment, in RemoveTrailingSpaces(), could you help to refine:
String[Length] = 0;
to:
String[Length] = '\0';
Also, could you help to send a V2 patch (the change made in the below pull request) to the mailing list?
(Mainly step 12 in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-developer-process-for-the-edk-ii-project)
I will follow up with the code reviewing and merging. Thanks in advance.
Best Regards,
Hao Wu
From: gopic via groups.io <gopic=ami.com@groups.io>
Sent: Wednesday, October 26, 2022 9:44 PM
To: Wu; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk
created pull request.
Pull request link: MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drives by GopiCheripally · Pull Request #3537 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3537>
[-- Attachment #2: Type: text/html, Size: 3771 bytes --]
prev parent reply other threads:[~2022-10-27 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 6:52 [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk Cheripally Gopi
2022-10-18 4:05 ` Wu, Hao A
2022-10-26 13:44 ` [edk2-devel] " gopic
2022-10-27 2:48 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4031482DDF734022D5B6F702CA339@MN2PR11MB4031.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox