Thanks a lot.

 

Just one minor comment, in RemoveTrailingSpaces(), could you help to refine:

  String[Length] = 0;

to:

  String[Length] = '\0';

 

Also, could you help to send a V2 patch (the change made in the below pull request) to the mailing list?

(Mainly step 12 in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-developer-process-for-the-edk-ii-project)

I will follow up with the code reviewing and merging. Thanks in advance.

 

Best Regards,

Hao Wu

 

From: gopic via groups.io <gopic=ami.com@groups.io>
Sent: Wednesday, October 26, 2022 9:44 PM
To: Wu; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk

 

created pull request.
Pull request link: MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drives by GopiCheripally · Pull Request #3537 · tianocore/edk2 (github.com)