From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.83709.1677474998373331893 for ; Sun, 26 Feb 2023 21:16:38 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=b1w4HXLc; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677474998; x=1709010998; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=A5E5fHLRRwMxmIwf195c9JFC2vudToP9MvvslSJ6CFw=; b=b1w4HXLcH+bR4cnoLr1x9CDONtJbMlySbKaHQJF8/H2JX8Zcp2IsA3Us yX74+ov6F75YW96lb+SGYlVjpRFgTBni24z6JHAxMQeMrtXheMeFeDpAO YTVkoBO906e23P6LL2s9UOTFPxKXj9u1/VNU+AWErVKcFh+O06ikl+8Wp 04hGC8HGhz4IxG2j/ALjthma0rSCcTKqSPMZ/VK0EI8Zs3hd1WNLzDk7q X/Z8oj5CHZiSmCRC83jgahV2fX+DGMOzpD9BQp/DSy3N33wyQnQdKvlTc 2wTnIToPnKFXpxCLmB+v8xr/EIhCQCzYgJvu7KRcXmsWdMJq331vHTI8k Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="336059426" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="336059426" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2023 21:16:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="623432576" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="623432576" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 26 Feb 2023 21:16:37 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 21:16:37 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 21:16:36 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 26 Feb 2023 21:16:36 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 26 Feb 2023 21:16:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdS8zh30Qd11OMJ5N9X8eqGa6NHfJaFjrDXs7PVFiXLcHPrud4dwAJrM1jJt4ZfZmBuVqmlHu+JHpcPrV9viyrYeHCu+LrNMqBxg5e3zv6bILVDfXiP+0AdW08Rw1/HW2vz+jnWCnMCN5iSq7zzg6Rg1toq31JfQ5DuDwP7HItBUyV3rOZCfnwOLBe/weVYs5NRCHAAaQnbhICU/rirT2d/ZfVzfeWt+RNeu0hvzzlKKJ/QYwrjAglJZW74om6KENXC0P2WoWHijp9zvCMARMUTzV/7ZGZpgn4/oQzVZku6BKyPrCv6UlUdNfNV6//7fXdqyWgtOKisvEzs0XGX7rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yHhuu83M4kzHQWW/M4D1QTiVj5hi99T3F+uVO9bb9Ug=; b=Rllka6/8jJmm7Y6ExXbLdEafTif8/rn5UK1+Wrxay6HzX2GZmwLDd3OZxdnrYXPIJQWzxHBhRZmwkwyDpi8uqNFIORQn6WMG8INdHzRvstOsATo81VJWO33jGVi7pHjqVVUO5cA6OKP1DY2H2BJKi1XgWERhEJumwgvS56Z+MsjgirUyec/h7B3P9qwTOGk60XUqRwFzM7DPV0edcaLWHBgkMyAHW/B0tpOLL1TiPITuDuKmUKxEk+04iB3RfHokSgKHXRl3hfLf8PMNkHwiLUqW2SR2jmAcOnMV/DimHxzy7NONoAoW2SsyR7dupU0j4wkS+8jICJimOEolb8ruGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN2PR11MB4031.namprd11.prod.outlook.com (2603:10b6:208:150::18) by IA1PR11MB7774.namprd11.prod.outlook.com (2603:10b6:208:3f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 05:16:27 +0000 Received: from MN2PR11MB4031.namprd11.prod.outlook.com ([fe80::b2a7:96fa:719d:f9a0]) by MN2PR11MB4031.namprd11.prod.outlook.com ([fe80::b2a7:96fa:719d:f9a0%4]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 05:16:27 +0000 From: "Wu, Hao A" To: Rebecca Cran , "devel@edk2.groups.io" , "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" Subject: Re: [PATCH v2 1/1] MdeModulePkg: Improve formatting of DEBUG messages in UsbBusDxe Thread-Topic: [PATCH v2 1/1] MdeModulePkg: Improve formatting of DEBUG messages in UsbBusDxe Thread-Index: AQHZR+WB+Y0KAJVwqUG0DbX8pIuEI67iRWRA Date: Mon, 27 Feb 2023 05:16:27 +0000 Message-ID: References: <20230224001801.77708-1-rebecca@bsdio.com> <20230224001801.77708-2-rebecca@bsdio.com> In-Reply-To: <20230224001801.77708-2-rebecca@bsdio.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR11MB4031:EE_|IA1PR11MB7774:EE_ x-ms-office365-filtering-correlation-id: 3b8c39e2-c6e1-4bcb-19cf-08db1881c724 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zJ5/gxv38fWfFug1xl9b4ieLIq7ni0PvlXcXqEvoYT4O8TMPuPZKjaQ6HjkTl7TRsXmK+Wj7ankVskHT73g1I+Vqm1JBMVsD4mI84LcwPDn3VpszIZBxliH7PWjWqyIiU0wwWWehAl8k+1XTgTo+Q1M02Za/kgFHatDucfLO/ujqqYV4YPByfiz7cGFNFZDFkMzIA/W33Myej/g8ohSKPKt/VypaYKArLLoooKja/FdnnrFeBi74mAy3jsNj+IonE+ciDeL43X22YqsLYJvu9yrTaMhqRgRiQEvaC7kGGHi6pS2sGoQ79RbUS9uSphvWWI7cLXa8iZOH2APvYfDafaZlIHsEQbtPaSPOppG7BAHfDnccUeuuowHptLiqIP/fYvALia9KqHCvbO/aWiyLKWe91SW5yCRC9+TvQ44UljBnVqxsvRUQpGazCl2ujXRp9YwIclbyEEoabfuTqI8rRQ+1HFNDjCzLjCwFB59wy1EX2G6/YTUSaauTwB4Bt05P69wUXcq1QDY2laiHB4dAOUQba/nehQUsRcRskJ12V8W2BXhl1HS261x3ngdwd7/EABiIETCsjEdjFXLuBINSXhk+AFAcpYXtxNx+8RKv14xn+IUcFjnRfRnWTQCxnnufpCANueGXQlI/KXJSQp+Uuo88LW58oRWPODSacLZoIWeKf901+lPrxPoKNHe/+5FN/UFNiG6nIV86B5Yyj/+E/g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR11MB4031.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199018)(316002)(110136005)(6636002)(33656002)(86362001)(55016003)(38070700005)(38100700002)(82960400001)(122000001)(6506007)(53546011)(83380400001)(9686003)(186003)(26005)(5660300002)(7696005)(71200400001)(8936002)(2906002)(52536014)(478600001)(41300700001)(15650500001)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8QvMtuV/Q/aprjozeoi9DqZl8RZqZYWxK5e6xogsDEW1CFeVpbimv6Pr5Rmv?= =?us-ascii?Q?9UK7OitIuzq8NPSVfrkVTUPcs/LUTMmmEHjRYLJOrU488QfCDqSfZ8hhh1Mt?= =?us-ascii?Q?shvY3xrFYR55ZDU8qg8ZnHaoemEd2p2z07rWbvVr/fRTJiUKeF3PytR+nLb5?= =?us-ascii?Q?2yjpcn04jgDirT4CjGr3raT+fasmmX+0evcQ1V9qLB8ijsO/FGyx9eGJQsDL?= =?us-ascii?Q?UAeeWn0AfsGND6CZatS3SE5fCztPILUO5pVkCDoVuqwiiK81h1ccA2a/ADfk?= =?us-ascii?Q?zgLM6cr7xOOBTZil6qwEooTuziu2i5snvrOT1mi5AqsXpaNv3U3uGjIP8T8t?= =?us-ascii?Q?kLhac3VwR1Q3CrXWVg55vUVxzO2tSdYff0MdVbPtnbXoByIM/7J777YBLV1e?= =?us-ascii?Q?Ff88Ird0VscSB34KoOYIysh/q2qax1FnDT4aMI5n0rwQZICW8Qm3hqkNcYpf?= =?us-ascii?Q?viHn/fSWl6RqinVAsuqbTqLbAS+1eT7N/7vz2CzrmXYCxAgSGC9mtXwbtaPx?= =?us-ascii?Q?uBk9PX59ACviXzkScusYS+3sJYrm+U1EFQivg+uWEc9ayE0vpQigLFD1EErp?= =?us-ascii?Q?mwOHYREgGMXNMIwNghu1s8BitiZTRWYBYrw3ZmS+CTsdirDlNGV2ZhyW82mA?= =?us-ascii?Q?zBBQL0Qi9KcojUrlo3M3mUiAcfnDPkUtW4oyNSUrKZVGU7YVlnkmPYBk2y1y?= =?us-ascii?Q?5ltKXGHCLniDKJledJpWN6e1ev71I2o0O7+vgWBmCjd1DqqtE/At2SfGZIAx?= =?us-ascii?Q?Jve8imYWAA4S5PBQ6uzfXTZ/y/uS5iznklsGKiNwiS++eW8PlKF7TAX5WvuC?= =?us-ascii?Q?2Nf6HIf54V75Lk+XtsOeUcteqroNgSjH6JpTF6mpMGU14DT0vbzfnbvnS6h0?= =?us-ascii?Q?7MLPp1f2jOCSWo55VdkCA6Q56LSdNI/bixpLA9Y2Xni0Gy8+UfTU1chFGM1n?= =?us-ascii?Q?+WY8OuJOkcISMy2zqnC/wnu8io3Mi4HyTBbHQ/43gc+3h//6YW1YXa2fWb+l?= =?us-ascii?Q?mhh4tFFKVs8urvm/OTHF0X9Zqz2U4625c0Sksr6ilAbsElHoBc2rJUPVltIZ?= =?us-ascii?Q?9lI2mwjz3mwfr3uG0c1PvQjAEVLws3ERp7I7UAezrAnha2OTG8CpZAuLM1KT?= =?us-ascii?Q?8jcNi2GvUM4mI8+Tf2QFMmq7IHaZnXDFqgr+Uzw922y3kdVS5pngdqxBP2D4?= =?us-ascii?Q?+IywJZpGfOY/e140tnL7rKM0M/O1TsCCsf10N5qWdwWWj1Zji/vV6XK9n5Ns?= =?us-ascii?Q?pgYfiUlO5hvgXy0jYqMd9z7pkCqUdxYIcHI1eXRuzLrkO8vZOxbmDhhsEhC8?= =?us-ascii?Q?GRCUmPyGUhjB0haEPMnVbukxN0kauOx94TD7DQgyVUmVF+aeptwem0s2ux0h?= =?us-ascii?Q?hPIs5Cg9Z1QOU3Ypx+NfqbgHT0XTitLa4biTfy26d5jlgNkwwPwpD5n79cGK?= =?us-ascii?Q?mWqYmSabgRMY199G9OJJUM5h9S0BXM9biZiGDowGSXSwutLPAfrUHu6FTprY?= =?us-ascii?Q?/HitLL4ISPdDuGBxXWRtLoIqNBPDU/D+jpJJMJVcl0RfZ9g68kq6fOMe1y1U?= =?us-ascii?Q?DSMRq7fUCwm90il0ifvm5DCzG9Nk7wFM8SBuj8Y2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4031.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b8c39e2-c6e1-4bcb-19cf-08db1881c724 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 05:16:27.3311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pkbYHVSbXzEcq8YJF3vSSgWkLcBDWwUF+zLXxgN6zQakMz2FaMgpMOjJoarrn0wTGjvGyAQ5ZCUj5HfspdJazw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7774 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu . Will merge it after the upcoming stable tag announcement. Best Regards, Hao Wu > -----Original Message----- > From: Rebecca Cran > Sent: Friday, February 24, 2023 8:18 AM > To: devel@edk2.groups.io; Wang, Jian J ; Gao, Limi= ng > ; Wu, Hao A ; Ni, Ray > > Cc: Rebecca Cran > Subject: [PATCH v2 1/1] MdeModulePkg: Improve formatting of DEBUG > messages in UsbBusDxe >=20 > Improve the formatting of DEBUG messages in UsbBusDxe by adding > a hyphen to separate the EFI_STATUS code. >=20 > Signed-off-by: Rebecca Cran > --- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++++++------ > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 6 +++--- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 2 +- > 4 files changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > index 6a3ac63c3aa0..c25f3cc2f279 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > @@ -838,7 +838,7 @@ UsbIoPortReset ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "UsbIoPortReset: failed to reset hub port %d@hub %d, %r \n", > + "UsbIoPortReset: failed to reset hub port %d@hub %d - %r\n", > Dev->ParentPort, > Dev->ParentAddr, > Status > @@ -945,7 +945,7 @@ UsbBusBuildProtocol ( > ); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open device path %r\n", > Status)); > + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open device path - %r\n= ", > Status)); >=20 > FreePool (UsbBus); > return Status; > @@ -978,7 +978,7 @@ UsbBusBuildProtocol ( > ); >=20 > if (EFI_ERROR (Status) && EFI_ERROR (Status2)) { > - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open > USB_HC/USB2_HC %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to open USB_HC/USB2_HC - > %r\n", Status)); >=20 > Status =3D EFI_DEVICE_ERROR; > goto CLOSE_HC; > @@ -1006,7 +1006,7 @@ UsbBusBuildProtocol ( > ); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to install bus protocol %r= \n", > Status)); > + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to install bus protocol - = %r\n", > Status)); > goto CLOSE_HC; > } >=20 > @@ -1054,7 +1054,7 @@ UsbBusBuildProtocol ( > Status =3D mUsbRootHubApi.Init (RootIf); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to init root hub %r\n", > Status)); > + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to init root hub - %r\n", > Status)); > goto FREE_ROOTHUB; > } >=20 > @@ -1102,7 +1102,7 @@ UsbBusBuildProtocol ( > ); > FreePool (UsbBus); >=20 > - DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to start bus driver %r\n", > Status)); > + DEBUG ((DEBUG_ERROR, "UsbBusStart: Failed to start bus driver - %r\n", > Status)); > return Status; > } >=20 > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c > index a620a670748c..8b078e7e4936 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c > @@ -761,7 +761,7 @@ UsbGetOneConfig ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_ERROR, > - "UsbGetOneConfig: failed to get descript length(%d) %r\n", > + "UsbGetOneConfig: failed to get descript length(%d) - %r\n", > Desc.TotalLength, > Status > )); > @@ -787,7 +787,7 @@ UsbGetOneConfig ( > Status =3D UsbCtrlGetDesc (UsbDev, USB_DESC_TYPE_CONFIG, Index, 0, Buf= , > Desc.TotalLength); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "UsbGetOneConfig: failed to get full > descript %r\n", Status)); > + DEBUG ((DEBUG_ERROR, "UsbGetOneConfig: failed to get full descript - > %r\n", Status)); >=20 > FreePool (Buf); > return NULL; > @@ -891,7 +891,7 @@ UsbBuildDescTable ( > Status =3D UsbBuildLangTable (UsbDev); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_INFO, "UsbBuildDescTable: get language ID table %r\n", > Status)); > + DEBUG ((DEBUG_INFO, "UsbBuildDescTable: get language ID table - %r\n= ", > Status)); > } >=20 > return EFI_SUCCESS; > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c > index aed34596f469..b3a40639f280 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c > @@ -440,7 +440,7 @@ UsbSelectConfig ( > if (EFI_ERROR (Status)) { > DEBUG (( > DEBUG_WARN, > - "UsbSelectConfig: failed to connect driver %r, ignored\n", > + "UsbSelectConfig: failed to connect driver - %r, ignored\n", > Status > )); > } > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c > index 0497a73f443c..1a473d099892 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c > @@ -609,7 +609,7 @@ UsbHubInit ( > Status =3D UsbHubReadDesc (HubDev, HubDesc); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "UsbHubInit: failed to read HUB descriptor %r\n= ", > Status)); > + DEBUG ((DEBUG_ERROR, "UsbHubInit: failed to read HUB descriptor - > %r\n", Status)); > return Status; > } >=20 > -- > 2.37.1 (Apple Git-137.1)