From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.13142.1576254334350232675 for ; Fri, 13 Dec 2019 08:25:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=MND8U1t4; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: prince.agyeman@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 08:25:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="216683604" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 13 Dec 2019 08:25:33 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 08:25:33 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Dec 2019 08:25:32 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Dec 2019 08:25:32 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 08:25:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3mjKbEmPjpfZ+ZWTGn2Mf+IjAHlrG8jo+9Kc3Wqgj8+WbzsPe/oLG03nuR5FlJ1BpaAWefCs7uU4MTDaRfyMfcELMvQKSaB9xXHu3fDy862SAamMraboZ3iF90IixeDqhYaGHTg75S1ajyEzU4eUXq0juqGkaBIMYw9fP2YYlWx+D0R0ewPcoPv51OA6pws2tbTK9Js2WrCqEMqt48ET6LkeevL0YNQXVc74ESPQuhPe6s0XEF4odGMdtw9Ke8ZG/c2ei60t8ivTt89cZWYGkkPhu0GGupN6oV1o3tJWjN8RPPKKTsNPxOz9Uh+JC16kN28pOU5n1VOWc7VjhKffg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miC5NesNlQGqkQKSHcm5OVD3RqrF6AbkEUEefs04sOk=; b=T7eazErxbDMi6ZTSZzPBPNdjWJ/3oJ6owy85tHRkOIt6NROq+6eVwgoy8WtI+QVE6gg1Hs5qlyGoqTzTorQLCTdOUPybcbL/xBZow4RbkZQI0FVJagKVpnUEDg5KRnTkIFdUZwtu20GQ0VyjlfH9QkxOqCj4WGbdLvm/KqX9yYf+B+CCEXwS48snMF2HFOaiPlaYi7MjfygCxNlWjgn08iFpBw0tN1yBc4/DJKAfmKtW60nqCeHaxaIM0qwQ9+lu/O4JMdhTVYPz3ZHRJxTr46cJT4SXNu1yTjJj1E+zPWjHTL2j0JWv3UoStLUpOCAH1VcwXWeOdguZmJgHQZBc0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miC5NesNlQGqkQKSHcm5OVD3RqrF6AbkEUEefs04sOk=; b=MND8U1t4JfFk0ZZUf1/3tXeQCeu8vFgYxknmdYegYUMYq/cDUjrQn/RsWKdANkgo5Og/CIUru3vnRLebIHm5sObMsLqMGIr0HW0kE0/8QwS3BIkMCK/LSRnj8CJTf0cAE+N3z9pEI89JVk/0C5sTOAOkyEEbVi8mGM/6BUaHnDY= Received: from MN2PR11MB4064.namprd11.prod.outlook.com (20.179.150.18) by MN2PR11MB4445.namprd11.prod.outlook.com (52.135.37.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Fri, 13 Dec 2019 16:25:30 +0000 Received: from MN2PR11MB4064.namprd11.prod.outlook.com ([fe80::6885:ec2c:49a6:d2b]) by MN2PR11MB4064.namprd11.prod.outlook.com ([fe80::6885:ec2c:49a6:d2b%6]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 16:25:30 +0000 From: "Agyeman, Prince" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVsUDLCpLnppya+0qRFHy0v0XiTae4NcqQ Date: Fri, 13 Dec 2019 16:25:29 +0000 Message-ID: References: <20191212011314.6860-1-prince.agyeman@intel.com> <02A34F284D1DA44BB705E61F7180EF0AB5C47702@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AB5C47702@ORSMSX114.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTRjY2UzZjMtZDYzNy00YjJjLTk1NTMtZWZmOTdjYTA3YjAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSFFLamd2NFRuQ0ZUTnk4d1hDXC9WQmo4T2lMUFY1Nk04cjRtcmUyVlBZcGdKcldjSWtuV1hlMWJzY1pibnVnS1cifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=prince.agyeman@intel.com; x-originating-ip: [134.134.136.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eea13874-be47-47d5-3a79-08d77fe911fc x-ms-traffictypediagnostic: MN2PR11MB4445: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(136003)(396003)(366004)(39860400002)(376002)(199004)(189003)(13464003)(7696005)(52536014)(53546011)(71200400001)(4326008)(33656002)(107886003)(15650500001)(5660300002)(6506007)(966005)(54906003)(55016002)(316002)(86362001)(26005)(19627235002)(81166006)(8936002)(81156014)(8676002)(110136005)(186003)(66946007)(66446008)(76116006)(2906002)(66556008)(66476007)(64756008)(9686003)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR11MB4445;H:MN2PR11MB4064.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FB/Y8up1aOcHzXVutrc/npXhEFDq/AY2xQ7G5Dc3QBQ53lcy/aSBrFrPAhN9AGIaKXt2QYY/DiDAwNKp+cQ9ut7dviDKsaJiAL9Se09yFZz9vDMWx8er01sSPFW4P6x78L5QrhTpYHXe67Scz2tR2IRVCMIpSYmBTmbBdFqy/g7bcJncwe/egp6LwDpgkPMC2YsuFChhzkZrsMsNQXP9t63SOu5XMcvpWglb6z78ZsUXll84ROu6Fankoli2O6NdTKu0pW3tv5St1/+BaIaVC7zDvHQfBAjRMXkVjpzesMynoptznK6EaquVVl7Ia4OaptkoUxk7WLtfMGwErOsjRAx6Ph8cbJ+oCIBetQjdPFWqum1y7MVVAD2rgSdLwAhKvVgMJHuG20gMamU9kqnQ+UcDZZGvB9ttMpkTzB4KUlrbZztAQydI4UEiXJ4cm8qv9BVhu/HfGXuX9B94QTfYzPD+6PA/y+SmeAZluJKjy+Wc+TVsmHILM98t3CX7w1BiOi4Kg5pNY4ehtG1n7AltY2aypRh6VAVdEiNAA0xmj9g= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: eea13874-be47-47d5-3a79-08d77fe911fc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 16:25:30.0235 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LAYFWIVHqgqTU14WyC0/Ah7T5ESWWjLLLUgJEmEolfULPKYjGzxJ713k+M6FIKNUqcdQCvpwWpZc1JjB4LsCsGPQfNVNGGgbElEr+lvSDQo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4445 Return-Path: prince.agyeman@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nate, Which 256KB are you referring to ? The temporary ram size was reduced from 152KB (0x26000) to 64KB (0x10000) With stack sharing enabled in FSP, temp ram size of 0x26000 causes system = to hang during memory training. - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize |0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Thursday, December 12, 2019 3:07 PM To: Agyeman, Prince ; devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A Subject: RE: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs = to enable stack sharing Hi Prince, Is 256KB really necessary? Could you try the 152KB (0x26000) that we had pr= eviously? Thanks, Nate -----Original Message----- From: Agyeman, Prince Sent: Wednesday, December 11, 2019 5:13 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to e= nable stack sharing REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP bina= ry (v 7.0.68.41) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Prince Agyeman --- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoa= rdPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkgPcd.dsc index 906f7b7ade..b3e1da3970 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk +++ gPcd.dsc @@ -54,15 +54,14 @@ gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 =20 # - # FSP API mode does not share stack with the boot loader, - # so FSP needs more temporary memory for FSP heap + stack size. + # When sharing stack with boot loader, FSP only needs small temp ram=20 + for heap # - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 + # - # FSP API mode does not need to enlarge the boot loader stack size - # since the stacks are separate. + # Boot loader stack size has to be big enough to executing FSP # - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 =20 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 -- 2.19.1.windows.1