From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.1389.1576280380760845479 for ; Fri, 13 Dec 2019 15:39:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VzTaeSm+; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: prince.agyeman@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 15:39:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,311,1571727600"; d="scan'208";a="265663390" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 13 Dec 2019 15:39:40 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 15:39:40 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 15:39:39 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 15:39:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oU9NRQX0ZmPWt8Q01rPPzJROMnW+fcK1eKdojZwYNBjC1owibC5B5cpmsG9yweoTTmMBYyKmj0QRF/p6zVLJrQL74WOFbZxg7g3fkS7px6AsAqyKfsKhFyx8AcbzPcBgFpgCRQX7SNQuSzTMX0IlyDd7Wvl6WQvl2U7kSrAY0Tyj9fNdluihcYdrgQNdS5+hAEDx3tJAYXNcszGQKJ+3+FfXTdsla5dswkn8Z0z0LJ7LMPMaZl9WiF4sjrNBxLl9TPSXY2HXA7RAXzRbCph/Lifu+LfAAbIxErk36zAIBktDF5My36rMpqvUckAWxclMDOeEU0ZhkKV95F7IHcg9EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FdmDG/hRmxZYl0EW8EVTuXOg7KSEyjSFmhRJ7hDLJ9Q=; b=LYvDyA+bHI1I79qFp5EpJc5V3UhaS2Harzax4TxGBYjellJM7kyGVB+KMx4vCJ/sA9G3V3LnnQjInGHILSem2GoLoGFPhfLEnRF1J8ugw5M1lef/4f8NElO1MmxpzO1KVW4vU8+YD/OWAanv3WQBHysSOVMlevoBHPJQCsUElWdAhi56buGixYhRFM2KWXVmTdQEyn0oWr2YLSIyP4Lx6DDsZnAxs2TZTBA9sPn75VHzJCX2U1PtaAP85bmEy/PT+RDibccS+hHR1XpvEEDnI0Bqd2tNIE1gsolcKaaCIBruhQGMfsPXNwswMDwMNDcDj12QZAnri64CZNI+5fEjPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FdmDG/hRmxZYl0EW8EVTuXOg7KSEyjSFmhRJ7hDLJ9Q=; b=VzTaeSm+yrTjgRj5D0hVCoXNu0FhNBiTdMnjik4FpabhquuSmzrDD26Kon1zJNEGzeNwlO4By3yR3+XQX5M9mjIYRp62jFiHmcpePSeY8QvDNYHC+RtOL8gtm1wV5v2i7qwlFGtuZIr5tiKW7xIdUD/CkQW3+7wRLp//3lM4q8A= Received: from MN2PR11MB4064.namprd11.prod.outlook.com (20.179.150.18) by MN2PR11MB4302.namprd11.prod.outlook.com (52.135.36.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Fri, 13 Dec 2019 23:39:36 +0000 Received: from MN2PR11MB4064.namprd11.prod.outlook.com ([fe80::6885:ec2c:49a6:d2b]) by MN2PR11MB4064.namprd11.prod.outlook.com ([fe80::6885:ec2c:49a6:d2b%6]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 23:39:36 +0000 From: "Agyeman, Prince" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kubacki, Michael A" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVsUDLCpLnppya+0qRFHy0v0XiTae3IDHwgAGotoD//9f8IIAABq9wgAAD+XA= Date: Fri, 13 Dec 2019 23:39:35 +0000 Message-ID: References: <20191212011314.6860-1-prince.agyeman@intel.com> <02A34F284D1DA44BB705E61F7180EF0AB5C47702@ORSMSX114.amr.corp.intel.com> <15E00DF9E44B8812.24131@groups.io> <02A34F284D1DA44BB705E61F7180EF0AB5C4C811@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AB5C4C811@ORSMSX114.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTRjY2UzZjMtZDYzNy00YjJjLTk1NTMtZWZmOTdjYTA3YjAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSFFLamd2NFRuQ0ZUTnk4d1hDXC9WQmo4T2lMUFY1Nk04cjRtcmUyVlBZcGdKcldjSWtuV1hlMWJzY1pibnVnS1cifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=prince.agyeman@intel.com; x-originating-ip: [134.134.136.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 568036c6-5162-4f28-cec2-08d78025b688 x-ms-traffictypediagnostic: MN2PR11MB4302: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39860400002)(136003)(396003)(376002)(346002)(13464003)(189003)(199004)(4326008)(8936002)(33656002)(478600001)(110136005)(26005)(8676002)(53546011)(86362001)(9686003)(55016002)(81156014)(81166006)(19627235002)(186003)(7696005)(107886003)(316002)(71200400001)(76116006)(15650500001)(66446008)(52536014)(2906002)(54906003)(66946007)(66556008)(64756008)(966005)(6506007)(66476007)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR11MB4302;H:MN2PR11MB4064.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: plF1D7SkpxEyoxu889HCO+rj3qHRRMWm94rAENBQTKfFZlGKdCRPWMEIuj0E6+hUAv2mNQrK0gNF3zzqHbK0pEVoC3o8x8PlUmbp/VCz7LbYjKUXyKAs8VjYrGOl/3vs9DZDQ3aNpjMU/YeItZKWwIFtncsmHl8kzGQ5sXUY0orJ6VsH7ZLAuTXNU2jWaxIIoBHu6cjYPNFKuV5S+jhGMLn2ydVsxwPhvXR+OW7RiS/Rs5lp1H71eKmgyzJLBi51bbG8mTsLBqBl6vCl1Z4xOqGWs/J3ufcDjjAI17elnEz8dBYRmB6/yekVR5Uo7cWqJ3p3DQkNrVy0pxIJGat8/calhJAhd/9zxUwngEGMdCbHX8nM8tBASOWz7vxSzEcK8W618ZHa/C3nJpd4nG8ya41NbNTRI0jp61j7zvC8yS1Da26wTBMxKQIuQmVFGT2Z79OeZk5RcBBBXdpgo+vbJhDhpunAle0XcVf7FC6hX2KWrp9ZwDl/Q2dWb2zFVoeqv4Bz/8r5Z4pIIZyCvEglT8Z8FcbiTwJioRWypVqNcxc= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 568036c6-5162-4f28-cec2-08d78025b688 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 23:39:35.8720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v3qB/vK6TG66D9Xj7XEFfjCJfMbOK9JwxODJ74NfbKYAZJwEjDWd/bUjhV0gAOhZKVH32VTFYBk0f+uGF/XC4ibqId0Hy7cm6MhFrGJJaAo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4302 Return-Path: prince.agyeman@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for clarifying.=20 Yes the minimum stack size of 160KB works as well. I will update this patch Thanks Prince -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Friday, December 13, 2019 2:27 PM To: devel@edk2.groups.io; Desimone, Nathaniel L ; Agyeman, Prince Cc: Chiu, Chasel ; Kubacki, Michael A Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg= : Update PCDs to enable stack sharing Actually looking at the CoffeeLake FSP Integration Guide it states the min= imum stack size to be 160KB (0x28000) so I guess a slight revision to my pr= evious statement: gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x28000 Thanks, Nate -----Original Message----- From: devel@edk2.groups.io On Behalf Of Nate DeSimo= ne Sent: Friday, December 13, 2019 2:14 PM To: Agyeman, Prince ; devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg= : Update PCDs to enable stack sharing Hi Prince, Looking at your patch I see the following two changes: 1. Reduce FSP Temp Ram size from 152KB to 64KB: - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 This makes sense because now that the FSP is using the single stack it doe= s not need as much temp ram. 2. Increase the size of the platform's PEI phase stack from 128KB to 256KB= : - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 This also makes sense because the FSP is now running on the same stack as = the rest of the platform code, so more space will be needed to run MRC. Wha= t I am questioning is if we really need 256KB? Looking at the numbers from = before, it seems like MRC was running OK with only 152KB of stack space, do= es platform code really use that much stack space _at_the_same_time_ that M= RC is running? Or maybe, the newer version of MRC uses more stack space now= ? The basic summary is... have you tried booting with gSiPkgTokenSpaceGuid.P= cdPeiTemporaryRamStackSize|0x26000? Thanks, Nate -----Original Message----- From: Agyeman, Prince =20 Sent: Friday, December 13, 2019 8:25 AM To: Desimone, Nathaniel L ; devel@edk2.gro= ups.io Cc: Chiu, Chasel ; Kubacki, Michael A Subject: RE: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs= to enable stack sharing Hi Nate, Which 256KB are you referring to ? The temporary ram size was reduced from 152KB (0x26000) to 64KB (0x10000) With stack sharing enabled in FSP, temp ram size of 0x26000 causes system= to hang during memory training. - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize |0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 -----Original Message----- From: Desimone, Nathaniel L Sent: Thursday, December 12, 2019 3:07 PM To: Agyeman, Prince ; devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A Subject: RE: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs= to enable stack sharing Hi Prince, Is 256KB really necessary? Could you try the 152KB (0x26000) that we had p= reviously? Thanks, Nate -----Original Message----- From: Agyeman, Prince Sent: Wednesday, December 11, 2019 5:13 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to = enable stack sharing REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP bin= ary (v 7.0.68.41) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Prince Agyeman --- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBo= ardPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Open= BoardPkgPcd.dsc index 906f7b7ade..b3e1da3970 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgP= cd.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk +++ gPcd.dsc @@ -54,15 +54,14 @@ gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 =20 # - # FSP API mode does not share stack with the boot loader, - # so FSP needs more temporary memory for FSP heap + stack size. + # When sharing stack with boot loader, FSP only needs small temp ram=20 + for heap # - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 + # - # FSP API mode does not need to enlarge the boot loader stack size - # since the stacks are separate. + # Boot loader stack size has to be big enough to executing FSP # - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 =20 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 -- 2.19.1.windows.1