public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"samer.el-haj-mahmoud@arm.com" <samer.el-haj-mahmoud@arm.com>,
	"rebecca@bsdio.com" <rebecca@bsdio.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Ni, Ray" <ray.ni@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile
Date: Mon, 20 Apr 2020 21:04:41 +0000	[thread overview]
Message-ID: <MN2PR11MB446121E065CB3F38336B7177D2D40@MN2PR11MB4461.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DB7PR08MB3260BDA713FF4D7209101D0390D40@DB7PR08MB3260.eurprd08.prod.outlook.com>

The default build of the shell does not include AcpiView.

However, there is a second version of the shell built from
ShellPkg.dsc that does include the AcpiView command.

  #
  # Build a second version of the shell with all commands integrated
  #
  ShellPkg/Application/Shell/Shell.inf {
   <Defines>
      FILE_GUID = EA4BB293-2D7F-4456-A681-1F22F42CD0BC
    <PcdsFixedAtBuild>
      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
    <LibraryClasses>
      NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
  }

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Samer El-Haj-Mahmoud
> Sent: Monday, April 20, 2020 1:52 PM
> To: devel@edk2.groups.io; rebecca@bsdio.com
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: Re: [edk2-devel] ShellPkg: acpiview command
> doesn't appear to be included in any profile
> 
> smbiosview (and other standard commands) are defined in
> the UEFI Shell specification, which specifies the
> profiles/for each command (UEFI Shell Spec 2.2, Table
> 11). For instance, smbiosview is defined as part of the
> Debug1 profile. This is why the code registers that
> command in UefiShellDebug1CommandsLib
> 
> acpiview is not a standard command, so it is not
> included in any of the UEFI Shell specification defined
> profiles.
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Rebecca
> > Cran via groups.io
> > Sent: Monday, April 20, 2020 4:23 PM
> > To: devel@edk2.groups.io
> > Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao
> <zhichao.gao@intel.com>
> > Subject: [edk2-devel] ShellPkg: acpiview command
> doesn't appear to be
> > included in any profile
> >
> > I noticed there's an acpiview command, in
> UefiShellAcpiViewCommandLib, but
> > unlike similar commands like smbiosview it's not
> included in any of the shell
> > profiles. Is that deliberate?
> >
> >
> > --
> > Rebecca Cran
> >
> >
> >
> >
> 
> IMPORTANT NOTICE: The contents of this email and any
> attachments are confidential and may also be
> privileged. If you are not the intended recipient,
> please notify the sender immediately and do not
> disclose the contents to any other person, use it for
> any purpose, or store or copy the information in any
> medium. Thank you.
> 
> 


  reply	other threads:[~2020-04-20 21:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 20:22 ShellPkg: acpiview command doesn't appear to be included in any profile Rebecca Cran
2020-04-20 20:52 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-20 21:04   ` Michael D Kinney [this message]
2020-04-20 21:05 ` Rothman, Michael A
2020-04-21 12:55   ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB446121E065CB3F38336B7177D2D40@MN2PR11MB4461.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox