From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Chao Zhang <chao.b.zhang@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>, Andrew Fish <afish@apple.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Lu, XiaoyuX" <xiaoyux.lu@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH 00/15] Add a plugin LicenseCheck in open ci
Date: Wed, 29 Jul 2020 01:32:33 +0000 [thread overview]
Message-ID: <MN2PR11MB4461593503A36469F8525E56D2700@MN2PR11MB4461.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB16301B7392E39BC459B4BFAD80700@MWHPR11MB1630.namprd11.prod.outlook.com>
Hi Liming,
There are exception to PatchCheck as well for line endings and tabs.
Seems like a similar problem, and a single CI plugin could
support all these cases.
Mike
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Tuesday, July 28, 2020 6:12 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> Zhang, Shenglei <shenglei.zhang@intel.com>;
> devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Chao Zhang
> <chao.b.zhang@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni,
> Ray <ray.ni@intel.com>; Lu, XiaoyuX
> <xiaoyux.lu@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>; Leif Lindholm
> <leif@nuviainc.com>; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in
> open ci
>
> Mike:
> Previous discussion
> (https://edk2.groups.io/g/devel/message/62494) is to
> revert the license check change in PatchCheck, and
> enable license check as plugin. If so, the package
> maintainers can configure the package level exception
> list to allow some special cases, such as autogen file.
>
> Thanks
> Liming
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: 2020年7月29日 7:34
> To: Zhang, Shenglei <shenglei.zhang@intel.com>;
> devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Chao Zhang
> <chao.b.zhang@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> Gao, Liming <liming.gao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>;
> Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm
> <leif@nuviainc.com>
> Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in
> open ci
>
> CI already runs PatchCheck. If we ported PatchCheck to
> a CI plugin, then the plugin could perform both the
> current PatchCheck features and the license check.
>
> What this option evaluated?
>
> If we did provide PatchCheck as a CI plugin, developers
> I believe developers could run a stuart command likely
> for the NOOPT target to run a PatchCheck CI plugin
> locally.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: Zhang, Shenglei <shenglei.zhang@intel.com>
> > Sent: Monday, July 20, 2020 1:37 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Sean Brogan
> > <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Dong, Eric
> <eric.dong@intel.com>;
> > Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao
> > <zhichao.gao@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Chao
> > Zhang <chao.b.zhang@intel.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>; Maciej Rabeda
> > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Fu,
> > Siyuan <siyuan.fu@intel.com>; Gao, Liming
> <liming.gao@intel.com>;
> > Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>;
> > Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>; Leif
> > Lindholm <leif@nuviainc.com>
> > Subject: [PATCH 00/15] Add a plugin LicenseCheck in
> open ci
> >
> > REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2691
> > REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2833
> > LicenseCheck is now enabled in PatchCheck.py. But
> there's a patch
> > "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
> > to suggest revert the change.These patch series
> introduce a plugin
> > LicenseCheck into open ci so that license issues can
> still be checked
> > after the checker is disabled in PatchCheck.py.
> > 1/15 is the plugin implementation.
> > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow
> developers to
> > skip license check for some files like generated
> files.
> >
> > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can
> pass this
> > checker.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> > Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> > Cc: Siyuan Fu <siyuan.fu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Shenglei Zhang (15):
> > .pytool/Plugin: Add a plugin LicenseCheck
> > FatPkg/FatPkg.ci.yaml: Add configuration for
> LicenseCheck
> > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for
> LicenseCheck
> > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for
> LicenseCheck
> > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration
> for LicenseCheck
> > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration
> for
> > LicenseCheck
> > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration
> for
> > LicenseCheck
> > MdePkg/MdePkg.ci.yaml: Add configuration for
> LicenseCheck
> > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for
> LicenseCheck
> > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for
> LicenseCheck
> > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add
> configuration for
> > LicenseCheck
> > SecurityPkg/SecurityPkg.ci.yaml: Add configuration
> for LicenseCheck
> > ShellPkg/ShellPkg.ci.yaml: Add configuration for
> LicenseCheck
> > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for
> LicenseCheck
> > UnitTestFrameworkPkg: Add configuration for
> LicenseCheck in yaml
> > file
> >
> > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118
> > ++++++++++++++++++
> > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11
> ++
> > .pytool/Plugin/LicenseCheck/Readme.md | 17
> +++
> > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 +
> > CryptoPkg/CryptoPkg.ci.yaml | 3 +
> > EmulatorPkg/EmulatorPkg.ci.yaml | 4 +
> > FatPkg/FatPkg.ci.yaml | 3 +
> > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +
> > MdeModulePkg/MdeModulePkg.ci.yaml | 4 +
> > MdePkg/MdePkg.ci.yaml | 4 +
> > NetworkPkg/NetworkPkg.ci.yaml | 3 +
> > OvmfPkg/OvmfPkg.ci.yaml | 4 +
> > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +
> > SecurityPkg/SecurityPkg.ci.yaml | 3 +
> > ShellPkg/ShellPkg.ci.yaml | 3 +
> > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +
> > .../UnitTestFrameworkPkg.ci.yaml | 4 +
> > 17 files changed, 194 insertions(+)
> > create mode 100644
> > .pytool/Plugin/LicenseCheck/LicenseCheck.py
> > create mode 100644
> > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml
> > create mode 100644
> > .pytool/Plugin/LicenseCheck/Readme.md
> >
> > --
> > 2.18.0.windows.1
next prev parent reply other threads:[~2020-07-29 1:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 8:36 [PATCH 00/15] Add a plugin LicenseCheck in open ci Zhang, Shenglei
2020-07-20 8:36 ` [PATCH 01/15] .pytool/Plugin: Add a plugin LicenseCheck Zhang, Shenglei
2020-07-28 23:29 ` Michael D Kinney
2020-07-29 6:06 ` Zhang, Shenglei
2020-07-29 7:29 ` Liming Gao
2020-07-20 8:36 ` [PATCH 02/15] FatPkg/FatPkg.ci.yaml: Add configuration for LicenseCheck Zhang, Shenglei
2020-07-20 8:36 ` [PATCH 03/15] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 21:59 ` Laszlo Ersek
2020-07-20 8:36 ` [PATCH 04/15] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 14:23 ` [edk2-devel] " Yao, Jiewen
2020-07-21 1:31 ` Guomin Jiang
2020-07-20 8:36 ` [PATCH 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 8:37 ` [PATCH 06/15] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
2020-07-21 1:31 ` [edk2-devel] " Guomin Jiang
2020-07-28 23:30 ` Michael D Kinney
2020-07-20 8:37 ` [PATCH 07/15] MdeModulePkg/MdeModulePkg.ci.yaml: " Zhang, Shenglei
2020-07-21 0:34 ` [edk2-devel] " Wu, Hao A
2020-07-20 8:37 ` [PATCH 08/15] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
2020-07-20 8:37 ` [PATCH 09/15] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
2020-07-21 16:42 ` [edk2-devel] " Maciej Rabeda
2020-07-20 8:37 ` [PATCH 10/15] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 22:01 ` Laszlo Ersek
2020-07-27 6:21 ` Zhang, Shenglei
2020-07-27 9:50 ` Laszlo Ersek
2020-07-28 1:11 ` Zhang, Shenglei
2020-07-28 9:56 ` Laszlo Ersek
2020-07-20 8:37 ` [PATCH 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 8:37 ` [PATCH 12/15] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 14:24 ` Yao, Jiewen
2020-07-20 8:37 ` [PATCH 13/15] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
2020-07-27 6:28 ` [edk2-devel] " Gao, Zhichao
2020-07-20 8:37 ` [PATCH 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
2020-07-20 21:59 ` Laszlo Ersek
2020-07-21 0:24 ` Dong, Eric
2020-07-20 8:37 ` [PATCH 15/15] UnitTestFrameworkPkg: Add configuration for LicenseCheck in yaml file Zhang, Shenglei
2020-07-28 23:29 ` [edk2-devel] " Michael D Kinney
2020-07-25 1:38 ` [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci Rebecca Cran
2020-07-27 2:34 ` Liming Gao
[not found] ` <16257B609DB8C7F6.7401@groups.io>
2020-07-31 3:50 ` Liming Gao
2020-07-31 4:17 ` Rebecca Cran
2020-07-27 3:00 ` Liming Gao
[not found] ` <1623691E419E189F.16344@groups.io>
2020-07-27 6:26 ` [edk2-devel] [PATCH 15/15] UnitTestFrameworkPkg: Add configuration for LicenseCheck in yaml file Zhang, Shenglei
2020-07-28 23:33 ` [PATCH 00/15] Add a plugin LicenseCheck in open ci Michael D Kinney
2020-07-29 1:11 ` Liming Gao
2020-07-29 1:32 ` Michael D Kinney [this message]
2020-07-29 7:37 ` Liming Gao
2020-07-29 9:21 ` Laszlo Ersek
2020-07-29 15:21 ` [edk2-devel] " Andrew Fish
2020-07-30 0:59 ` Liming Gao
2020-07-29 9:12 ` Laszlo Ersek
2020-07-29 12:12 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4461593503A36469F8525E56D2700@MN2PR11MB4461.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox