Re: [PATCH v1 1/7] FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: michael.kubacki@outlook.com
> <michael.kubacki@outlook.com>
> Sent: Thursday, July 30, 2020 8:15 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Subject: [PATCH v1 1/7] FmpDevicePkg/FmpDependencyLib:
> Correct ValidateDependency() documentation
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Modifies the return value documentation to state that
> the BOOLEAN
> value indicates whether a given dependency expression is
> valid
> not a capsule.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki
> <michael.kubacki@microsoft.com>
> ---
> 
> FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c
> | 5 +++--
>  FmpDevicePkg/Include/Library/FmpDependencyLib.h
> | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git
> a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib
> .c
> b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib
> .c
> index 91dc0b9abd33..28358069950a 100644
> ---
> a/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib
> .c
> +++
> b/FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib
> .c
> @@ -1,6 +1,7 @@
>  /** @file
>    Supports Fmp Capsule Dependency Expression.
> 
> +  Copyright (c) Microsoft Corporation.<BR>
>    Copyright (c) 2020, Intel Corporation. All rights
> reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -433,8 +434,8 @@ EvaluateDependency (
>    @param[in]   MaxDepexSize   Max size of the
> dependency.
>    @param[out]  DepexSize      Size of dependency.
> 
> -  @retval TRUE    The capsule is valid.
> -  @retval FALSE   The capsule is invalid.
> +  @retval TRUE    The dependency expression is valid.
> +  @retval FALSE   The dependency expression is invalid.
> 
>  **/
>  BOOLEAN
> diff --git
> a/FmpDevicePkg/Include/Library/FmpDependencyLib.h
> b/FmpDevicePkg/Include/Library/FmpDependencyLib.h
> index 1110eefa9a54..c732903425b4 100644
> --- a/FmpDevicePkg/Include/Library/FmpDependencyLib.h
> +++ b/FmpDevicePkg/Include/Library/FmpDependencyLib.h
> @@ -2,6 +2,7 @@
>    Fmp Capsule Dependency support functions for Firmware
> Management Protocol based
>    firmware updates.
> 
> +  Copyright (c) Microsoft Corporation.<BR>
>    Copyright (c) 2020, Intel Corporation. All rights
> reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -29,8 +30,8 @@ typedef struct {
>    @param[in]   MaxDepexSize   Max size of the
> dependency.
>    @param[out]  DepexSize      Size of dependency.
> 
> -  @retval TRUE    The capsule is valid.
> -  @retval FALSE   The capsule is invalid.
> +  @retval TRUE    The dependency expression is valid.
> +  @retval FALSE   The dependency expression is invalid.
> 
>  **/
>  BOOLEAN
> --
> 2.27.0.windows.1