public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
Date: Fri, 14 Aug 2020 01:58:13 +0000	[thread overview]
Message-ID: <MN2PR11MB4461A1E5315FC236A2AE7DA6D2400@MN2PR11MB4461.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200811070204.55160-17-shenglei.zhang@intel.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Tuesday, August 11, 2020 12:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
> 
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
> Besides, add submodule path in IgnoreFiles section.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> index fc5b3b387664..9e9ffc1af113 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> @@ -9,6 +9,18 @@
>      "LicenseCheck": {
>          "IgnoreFiles": []
>      },
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        ## Both file path and directory path are accepted.
> +        "IgnoreFiles": [
> +            "Library/CmockaLib/cmocka"
> +        ]
> +    },
>      ## options defined .pytool/Plugin/CompilerPlugin
>      "CompilerPlugin": {
>          "DscPath": "UnitTestFrameworkPkg.dsc"
> --
> 2.18.0.windows.1


  reply	other threads:[~2020-08-14  1:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11  7:01 [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 01/16] pip-requirements.txt: Add Ecc required lib Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 02/16] .pytool/Plugin: Add a plugin EccCheck Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 03/16] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  8:14   ` Ard Biesheuvel
2020-08-11  7:01 ` [PATCH v9 05/16] CryptoPkg/CryptoPkg.ci.yaml: " Zhang, Shenglei
2020-08-11 11:21   ` [edk2-devel] " Guomin Jiang
2020-08-11  7:01 ` [PATCH v9 06/16] EmulatorPkg/EmulatorPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 07/16] FatPkg/FatPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 09/16] MdePkg/MdePkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 10/16] NetworkPkg/NetworkPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:01 ` [PATCH v9 11/16] OvmfPkg/OvmfPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:02 ` [PATCH v9 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:02 ` [PATCH v9 13/16] SecurityPkg/SecurityPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:02 ` [PATCH v9 14/16] ShellPkg/ShellPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:02 ` [PATCH v9 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: " Zhang, Shenglei
2020-08-11  7:02 ` [PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file Zhang, Shenglei
2020-08-14  1:58   ` Michael D Kinney [this message]
2020-08-11 15:35 ` [edk2-devel] [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Laszlo Ersek
2020-08-12  1:23   ` Zhang, Shenglei
2020-08-12  1:07 ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4461A1E5315FC236A2AE7DA6D2400@MN2PR11MB4461.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox