From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "michael.kubacki@outlook.com" <michael.kubacki@outlook.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Jiang, Guomin" <guomin.jiang@intel.com>,
"Xu, Wei6" <wei6.xu@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Matthew Carlson <matthewfcarlson@gmail.com>
Subject: Re: [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC
Date: Fri, 16 Oct 2020 15:12:05 +0000 [thread overview]
Message-ID: <MN2PR11MB4461A3B0711E0821210BAACDD2030@MN2PR11MB4461.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR07MB3440B00553D390B272E7D869E9020@MWHPR07MB3440.namprd07.prod.outlook.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> Sent: Thursday, October 15, 2020 1:43 PM
> To: devel@edk2.groups.io
> Cc: Jiang, Guomin <guomin.jiang@intel.com>; Xu, Wei6 <wei6.xu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Matthew Carlson <matthewfcarlson@gmail.com>
> Subject: [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3010
>
> Commit b5701a4 in CryptoPkg introduced a dependency on RngLib.
>
> The FmpDevicePkg build currently fails since it does not specify
> a RngLib instance and OpensslLib links against RngLib.
>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Matthew Carlson <matthewfcarlson@gmail.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> FmpDevicePkg/FmpDevicePkg.dsc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc
> index bdb73f28288f..cfeadd833038 100644
> --- a/FmpDevicePkg/FmpDevicePkg.dsc
> +++ b/FmpDevicePkg/FmpDevicePkg.dsc
> @@ -6,7 +6,7 @@
> # Capsules. The behavior of the Firmware Management Protocol instance is
> # customized using libraries and PCDs.
> #
> -# Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.<BR>
> # Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.<BR>
> # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> #
> @@ -57,6 +57,7 @@ [LibraryClasses]
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> + RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf
> !endif
> FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
> CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdatePolicyLibNull.inf
> --
> 2.28.0.windows.1
next prev parent reply other threads:[~2020-10-16 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 20:42 [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC Michael Kubacki
2020-10-16 0:56 ` 回复: [edk2-devel] " gaoliming
2020-10-16 15:12 ` Michael D Kinney [this message]
2020-10-19 1:49 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4461A3B0711E0821210BAACDD2030@MN2PR11MB4461.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox