Re: [edk2-devel] [PATCH v1 6/7] FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Michael Kubacki
> Sent: Thursday, July 30, 2020 8:15 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH v1 6/7]
> FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid
> ImageIdName
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Updates the debug error message to include the GUID of
> the FMP
> instance that encountered the issue to help the user
> better
> isolate the problem.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki
> <michael.kubacki@microsoft.com>
> ---
>  FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index 14994ce4ee0e..a3e342591936 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -1679,7 +1679,7 @@ FmpDxeEntryPoint (
>      //
>      // PcdFmpDeviceImageIdName must be set to a non-
> empty Unicode string
>      //
> -    DEBUG ((DEBUG_ERROR, "FmpDxe:
> PcdFmpDeviceImageIdName is an empty string.\n"));
> +    DEBUG ((DEBUG_ERROR, "FmpDxe(%g):
> PcdFmpDeviceImageIdName is an empty string.\n",
> &gEfiCallerIdGuid));
>      ASSERT (FALSE);
>      return EFI_UNSUPPORTED;
>    }
> --
> 2.27.0.windows.1
> 
> 
>