Bret,

I wonder if this is an order of operations issue.

Those 2 commits convert Brotli support to submodules. One for the FW decompress lib, and the other for the compression tool. The patch adds both submodule links to CISettings.py and we know that works for FW components. However, this may be the first time it is used for a C tool in BaseTools.

In order for BaseTool/EDK2ToolsBuild.py to complete, all the sources need to be present. So does CISettings.py need to be processed before running BaseTool/EDK2ToolsBuild.py?

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
Sent: Thursday, April 23, 2020 9:34 AM
To: Navdeeppal.Singh@dell.com; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Confirmed that it seems related to these two commits:

https://github.com/tianocore/edk2/commit/58802e02c41bd715a5d3586f4bf2a4b1c46e9274

https://github.com/tianocore/edk2/commit/06033f5abad3815e8d80de22c97ba38a05017262

If I roll back to the commit prior, the Tools build works. Anyone involved in BaseTools have an idea? @Feng, Bob C or @Liming Gao?

- Bret

From: Navdeeppal.Singh@dell.com
Sent: Thursday, April 23, 2020 9:21 AM
To: Bret Barkelew; devel@edk2.groups.io
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup

I will roll back to 202002 stable tag and try.

Thank you

Navdeep

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: Thursday, April 23, 2020 9:48 PM
To: Singh, Navdeeppal; devel@edk2.groups.io
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup

[EXTERNAL EMAIL]

Yeah, I was noticing some problems with BrotliCompress the other day. Seems like a relatively recent change. I know the 202002 stable tag was fine.

I’ll try to dig into this a bit. Thanks for bring it to our attention!

- Bret

From: Navdeeppal.Singh@dell.com
Sent: Thursday, April 23, 2020 9:14 AM
To: Bret Barkelew; devel@edk2.groups.io
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup

Hi Bret,

Yes PIP requirements are up to date.

On further digging through the logging file BASETOOLS_BUILD.txt.

INFO - subprocess not exit successfully

INFO - Error while execute command 'nmake all' in direcotry C:\edk2\BaseTools\Source\C\BrotliCompress

Regards,

Navdeep

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: Thursday, April 23, 2020 9:37 PM
To: devel@edk2.groups.io; Singh, Navdeeppal
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup

[EXTERNAL EMAIL]

Have you installed the up-to-date Python requirements? “pip install –upgrade -r pip-requirements.txt”?

That’s the first thing I would check. Otherwise, happy to look at the problem with you.

- Bret

From: NAVDEEPPAL_SINGH via groups.io
Sent: Thursday, April 23, 2020 6:05 AM
To: devel@edk2.groups.io
Subject: [EXTERNAL] [edk2-devel] EDK2 environment setup

I am trying to setup EDK2 environment setup from Tianocore/EDK2.
While doing the Base Tool setup. After running BaseTool/EDK2ToolsBuild.py -t VS2019
Getting following error :-
c:\edk2\BaseTools>python Edk2ToolsBuild.py  -t VS2019
SECTION - Init SDE
SECTION - Loading Plugins
SECTION - Start Invocable Tool
Traceback (most recent call last):
  File "Edk2ToolsBuild.py", line 177, in <module>
    main()
  File "Edk2ToolsBuild.py", line 173, in main
    Edk2ToolsBuild().Invoke()
  File "C:\Program Files\Python38\lib\site-packages\edk2toolext\base_abstract_invocable.py", line 141, in Invoke
    retcode = self.Go()
  File "Edk2ToolsBuild.py", line 139, in Go
    raise Exception("Failed to build.")
Exception: Failed to build.

set EDK_TOOLS_PATH=C:\edk2\BaseTools
set EDK_TOOLS_BIN=C:\edk2\BaseTools\Bin\Win32
Can some one help