* [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters
@ 2022-05-11 17:18 sureshkumarp
2022-05-18 22:17 ` Oram, Isaac W
[not found] ` <16F052F14A8CB153.2722@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: sureshkumarp @ 2022-05-11 17:18 UTC (permalink / raw)
To: devel
Cc: Isaac Oram, Nate DeSimone, Harikrishna Doppalapudi,
Manickavasakam Karpagavinayagam
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="[UTF-8]", Size: 10117 bytes --]
Unrecognized characters present in StructurePcd.dsc causes build issues in non-english machines
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Harikrishna Doppalapudi <harikrishnad@ami.com>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Signed-off-by: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
---
Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc | 50 ++++++++++----------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc b/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
index 0e00a72fcd..ec75bac06f 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
@@ -5262,26 +5262,26 @@ gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PEXPHIDE[82]|0x0
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PEXPHIDE[83]|0x0 # Hide Port?
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.Pci64BitResourceAllocation|0x1 # PCI 64-Bit Resource Allocation
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.Pcie10bitTag|0x2 # PCIe 10-bit Tag Enable
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[0]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[1]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[2]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[3]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[4]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[5]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[6]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[7]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[8]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[9]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[10]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[11]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[12]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[13]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[14]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[15]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[16]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[17]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[18]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[19]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[0]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[1]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[2]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[3]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[4]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[5]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[6]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[7]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[8]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[9]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[10]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[11]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[12]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[13]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[14]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[15]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[16]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[17]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[18]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[19]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[0]|0x0 # Hot Plug Capable
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[1]|0x0 # Hot Plug Capable
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[2]|0x0 # Hot Plug Capable
@@ -7394,11 +7394,11 @@ gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[92]|0x0
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[93]|0x0 # VMD port B
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[94]|0x0 # VMD port C
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[95]|0x0 # VMD port D
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VTdSupport|0x1 # Intel� VT for Directed I/O
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[0]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[1]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[2]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[3]|0x0 # Intel� VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VTdSupport|0x1 # Intel VT for Directed I/O
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[0]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[1]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[2]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[3]|0x0 # Intel VT-d Disable Mask
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit0|0x0 # Source Validation
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit1|0x0 # Translation Blocking
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit2|0x1 # P2P Request Redirect
--
2.31.0.windows.1
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters
2022-05-11 17:18 [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters sureshkumarp
@ 2022-05-18 22:17 ` Oram, Isaac W
[not found] ` <16F052F14A8CB153.2722@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Oram, Isaac W @ 2022-05-18 22:17 UTC (permalink / raw)
To: Ponnusamy, Suresh, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, DOPPALAPUDI, HARIKRISHNA,
KARPAGAVINAYAGAM, MANICKAVASAKAM
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
Sent: Wednesday, May 11, 2022 10:18 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>
Subject: [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters
Unrecognized characters present in StructurePcd.dsc causes build issues in non-english machines
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Harikrishna Doppalapudi <harikrishnad@ami.com>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Signed-off-by: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
---
Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc | 50 ++++++++++----------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc b/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
index 0e00a72fcd..ec75bac06f 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
@@ -5262,26 +5262,26 @@ gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PEXPHIDE[82]|0x0
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PEXPHIDE[83]|0x0 # Hide Port?
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.Pci64BitResourceAllocation|0x1 # PCI 64-Bit Resource Allocation
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.Pcie10bitTag|0x2 # PCIe 10-bit Tag Enable
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[0]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[1]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[2]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[3]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[4]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[5]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[6]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[7]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[8]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[9]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[10]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[11]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[12]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[13]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[14]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[15]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[16]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[17]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[18]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[19]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[0]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[1]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[2]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[3]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[4]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[5]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[6]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[7]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[8]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[9]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[10]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[11]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[12]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[13]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[14]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[15]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[16]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[17]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[18]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[19]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[0]|0x0 # Hot Plug Capable
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[1]|0x0 # Hot Plug Capable
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[2]|0x0 # Hot Plug Capable
@@ -7394,11 +7394,11 @@ gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[92]|0x0
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[93]|0x0 # VMD port B
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[94]|0x0 # VMD port C
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[95]|0x0 # VMD port D
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VTdSupport|0x1 # Intel� VT for Directed I/O
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[0]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[1]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[2]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[3]|0x0 # Intel� VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VTdSupport|0x1 # Intel VT for Directed I/O
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[0]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[1]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[2]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[3]|0x0 # Intel VT-d Disable Mask
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit0|0x0 # Source Validation
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit1|0x0 # Translation Blocking
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit2|0x1 # P2P Request Redirect
--
2.31.0.windows.1
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters
[not found] ` <16F052F14A8CB153.2722@groups.io>
@ 2022-05-18 22:40 ` Oram, Isaac W
0 siblings, 0 replies; 3+ messages in thread
From: Oram, Isaac W @ 2022-05-18 22:40 UTC (permalink / raw)
To: devel@edk2.groups.io, Oram, Isaac W, Ponnusamy, Suresh
Cc: Desimone, Nathaniel L, DOPPALAPUDI, HARIKRISHNA,
KARPAGAVINAYAGAM, MANICKAVASAKAM
Pushed as: 03d1c51272..9997f9a1f2
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, Isaac W
Sent: Wednesday, May 18, 2022 3:17 PM
To: Ponnusamy, Suresh <sureshkumarp@ami.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
Sent: Wednesday, May 11, 2022 10:18 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>
Subject: [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters
Unrecognized characters present in StructurePcd.dsc causes build issues in non-english machines
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Harikrishna Doppalapudi <harikrishnad@ami.com>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Signed-off-by: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
---
Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc | 50 ++++++++++----------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc b/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
index 0e00a72fcd..ec75bac06f 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/StructurePcd.dsc
@@ -5262,26 +5262,26 @@ gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PEXPHIDE[82]|0x0
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PEXPHIDE[83]|0x0 # Hide Port?
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.Pci64BitResourceAllocation|0x1 # PCI 64-Bit Resource Allocation
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.Pcie10bitTag|0x2 # PCIe 10-bit Tag Enable
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[0]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[1]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[2]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[3]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[4]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[5]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[6]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[7]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[8]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[9]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[10]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[11]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[12]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[13]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[14]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[15]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack1
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[16]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack2
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[17]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack3
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[18]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack4
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[19]|0x0 # Intel� AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[0]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[1]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[2]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[3]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[4]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[5]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[6]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[7]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[8]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[9]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[10]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[11]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[12]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[13]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[14]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[15]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack1
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[16]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack2
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[17]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack3
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[18]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack4
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICEnabled[19]|0x0 # Intel AIC Retimer/AIC SSD HW at Stack5
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[0]|0x0 # Hot Plug Capable
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[1]|0x0 # Hot Plug Capable
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.PcieAICHotPlugEnable[2]|0x0 # Hot Plug Capable
@@ -7394,11 +7394,11 @@ gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[92]|0x0
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[93]|0x0 # VMD port B
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[94]|0x0 # VMD port C
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VMDPortEnable[95]|0x0 # VMD port D
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VTdSupport|0x1 # Intel� VT for Directed I/O
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[0]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[1]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[2]|0x0 # Intel� VT-d Disable Mask
-gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[3]|0x0 # Intel� VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VTdSupport|0x1 # Intel VT for Directed I/O
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[0]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[1]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[2]|0x0 # Intel VT-d Disable Mask
+gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdDisabledBitmask[3]|0x0 # Intel VT-d Disable Mask
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit0|0x0 # Source Validation
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit1|0x0 # Translation Blocking
gStructPcdTokenSpaceGuid.PcdSocketIioConfig.VtdPciAcsCtlBit2|0x1 # P2P Request Redirect
--
2.31.0.windows.1
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-18 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-11 17:18 [edk2-platforms][PATCH V1] WhitleyOpenBoardPkg: Removed unrecognized characters sureshkumarp
2022-05-18 22:17 ` Oram, Isaac W
[not found] ` <16F052F14A8CB153.2722@groups.io>
2022-05-18 22:40 ` [edk2-devel] " Oram, Isaac W
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox