From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mx.groups.io with SMTP id smtpd.web10.6100.1581398562465228740 for ; Mon, 10 Feb 2020 21:22:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=ZZVhj8L6; spf=pass (domain: nvidia.com, ip: 216.228.121.143, mailfrom: ashishsingha@nvidia.com) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 10 Feb 2020 21:21:38 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 10 Feb 2020 21:22:41 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 10 Feb 2020 21:22:41 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 11 Feb 2020 05:22:41 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.51) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 11 Feb 2020 05:22:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hu+VcLVMWY3BQ1AZ6voQ59V3Wt2nPRuAqUDWOJyzCRYnfbaWhC1XcwkfFabr1PhxsPQNQ00XqBUfcxcSKOPo3/GRnZndsPepGmpMEUi0IZ9XpSEutnSLRLZx2EZsbny9id0ppNXnuv9wqS+Eb24dbjB8QWYYz/F043FcY0MTefYt54iPho2PBHmzV81jT0ct+/mOzv9Wj4sR0HHlJkX87l8NoRCX/+Ujs1qWIcBZWrdujFwn38o1JnZuTtRW8Fa8k7m4t3p3DFq5wWYg6+i3oWCjvZuXUvcuU9MuGKM2H+/0oPZj2kfSMZJiSt7LivxNFTnQoueI4lja38oLC60P9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CIpP2/0MCLpWAAV6JppdIxIlViwC96Yt5JrgmVj340U=; b=K3rBFvUu6ayC862JDaB9era3Db+tgizT+MPOZpfSskdSXKSFTuHt5NC3w8EhTkBLDY51si9FWBfInKFBf0CCzXyY/MV3NWkqM0i5DZ6nnbtUz/+8adt1JiVHmGrNxPu4pJYBRwtsh5uYP7ZrotmX1i2DZnR6eL78s4SPJXCosa4ivoUG/U93Zw81mjHIgk47C3fAoMBCl2LrM6184lkj/DI/7UYyQsK/QGkf8QDvEcl26Zk98/vRXaZNzo8PZn9HWb+k/8MQ2HZEm7/tTY+eG37ddUKBW2fWWLTrgqVcaZb+9nnDwsEundzwOqZt/z5AGfBKxwikGcq5MqNPdMl22A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB2909.namprd12.prod.outlook.com (20.179.82.205) by MN2PR12MB4286.namprd12.prod.outlook.com (10.255.125.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.24; Tue, 11 Feb 2020 05:22:40 +0000 Received: from MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7493:bc65:1fe6:ead6]) by MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7493:bc65:1fe6:ead6%3]) with mapi id 15.20.2707.030; Tue, 11 Feb 2020 05:22:40 +0000 From: "Ashish Singhal" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Topic: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Index: AQHVz1S76mKn+oSl4EuAekfFnBqRZ6fzK6gAgAuj+9CABYF7AIAQgi/ggACbO4CAACk2QA== Date: Tue, 11 Feb 2020 05:22:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-02-10T17:39:20.5462936Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=bcdce489-c8a6-499c-aa20-247f4d792d7d; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0133d0be-d0f2-4dfb-47c0-08d7aeb269ed x-ms-traffictypediagnostic: MN2PR12MB4286: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:849; x-forefront-prvs: 0310C78181 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(376002)(346002)(136003)(366004)(189003)(199004)(71200400001)(9686003)(110136005)(86362001)(64756008)(55016002)(66946007)(2906002)(33656002)(52536014)(66446008)(26005)(316002)(8936002)(966005)(478600001)(7696005)(186003)(66476007)(8676002)(76116006)(66556008)(6506007)(81156014)(53546011)(5660300002)(81166006)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR12MB4286;H:MN2PR12MB2909.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cRaeLg99FZT3wW0Q3hUj+6fVBZ1EbYepq15DoJuwc41KanAULmhUJKP7E8nFeFb7HhJnd4klzh62PaiFngKWduqy3e8VEmeoEdcm63vEtwvUoT38HMM1kF1YgJPw7P0YuocdaIUaDB9HRz7c/yuB60/GneBQ+aLgmwEXyoQ/HcS4FAwpAiWESSUnTwr7ENfAx1C3U+V8gUmEztBKkpcqTunmNw5mDXA2vJf3smdKfuUAzKkEsNF4LezWbgu7IUJnJ61JAYCicUB2dPF6OHNOMQUSCJFlUREfF8c2hrKBFPFbFLG2bqrRk9cPcUJlP0kNg7UWHSEodmXF0hE0LZFlavozAWmBIPBG8+MI0srmqQTxZPz7DvCCxazw+KUz32RfaLYMsSH/JeqDpY4tgLA8LNhqyQ+N6tIhyaApiyEPJZ+VjbJF+qOJjgz1sQFVBzcd2ZcgqZ2a1hb4b+xTNzv3sF8FNBz8Jty6ChFZQXGTy0R9ZMFotd57Heg8cherBb7Dycmy/UrBSWBB1TpAJxOReLU6o1fSp2DjjAzHfqlVsT74wCmSR4GljbfAejIzGdAl x-ms-exchange-antispam-messagedata: c449IcQXuGEiDNjJOLH9VoCoJ6bBFSUvfg7tEGdAjLiJlHcyy6O+/jFfI0mMTwEpjD/sEF+y4526fHLAJIHgE3f7Zj+K56+qmHcVf8eyAilG7VXIU/h8ImDWwPOHNDItOnLNvB9yJ40cwyTDJ3X0vQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0133d0be-d0f2-4dfb-47c0-08d7aeb269ed X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2020 05:22:39.8935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tqNhATAy6Z9LsDHWu/N4mR7YLqGAPJcdVM6PQuss+iUKaEXsAXVutcxU3VP7Yi6rWmO6h6+TX9m6OnCxqi4oBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4286 Return-Path: ashishsingha@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1581398498; bh=CIpP2/0MCLpWAAV6JppdIxIlViwC96Yt5JrgmVj340U=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=ZZVhj8L6OQ7KER/GDSsU7sJp+JNXMEe6Xj+9d95IF76ALOw7c9orNrp5lDSnJb8cL C/kA9O3PfxucanqgNo/7/eVgfWa6a6QrnAlnrPLi/a/ibNtkeFYUhYTJ9ulObB3dF0 fFoy88RpqROoIyqCZ8SYHF2eLe+eSLjiiFytH8xuYR76XPBPQe5nyffWLS6oEmsdgb iFLN7ByPUIOtkayqY2AmxzXExR914BF7uqfmAW8xb7p9M1TU5q1O82y+fH3BCdRR9j 5Hn70KvJ/LxWDx6QnyfA4utorAoCQusWOZS1MCioo3jIctrGqqazPjaoEG4XFudp3T VwDWUYlNj+vqg== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Zhichao, Just saw a bunch of ShellPkg changes got merged including mine. Thanks Ashish -----Original Message----- From: Gao, Zhichao =20 Sent: Monday, February 10, 2020 7:55 PM To: devel@edk2.groups.io; Ashish Singhal ; Ni, Ra= y Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fi= x FADT Parser External email: Use caution opening links or attachments The patch is already merged in the trunk. 66360134f8049cc70765cd3f119a5e2b= e2b67aa4 Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ashish=20 > Singhal > Sent: Tuesday, February 11, 2020 1:39 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni,=20 > Ray > Subject: Re: [edk2-devel] [PATCH]=20 > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > Hello Ray, > > Any update on this one? > > Thanks > Ashish > > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, January 30, 2020 10:33 PM > To: Ashish Singhal ; devel@edk2.groups.io;=20 > Ni, Ray > Subject: RE: [edk2-devel] [PATCH]=20 > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > External email: Use caution opening links or attachments > > > Actually I have no permission to create the pull request. I would help= =20 > to send the patch to Ray and he would create the pull request. > > Thanks, > Zhichao > > > -----Original Message----- > > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > > Sent: Tuesday, January 28, 2020 1:29 AM > > To: Gao, Zhichao ; devel@edk2.groups.io; Ni,=20 > > Ray > > Subject: RE: [edk2-devel] [PATCH] > > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > > > Hello Zhichao, > > > > Do you know by when this may be merged? > > > > Thanks > > Ashish > > > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Monday, January 20, 2020 12:42 AM > > To: devel@edk2.groups.io; Ashish Singhal ;=20 > > Ni, Ray > > Subject: RE: [edk2-devel] [PATCH] > > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > > > External email: Use caution opening links or attachments > > > > > > Reviewed-by: Zhichao Gao > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf= =20 > > > Of Ashish Singhal > > > Sent: Monday, January 20, 2020 1:45 PM > > > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao= =20 > > > > > > Cc: Ashish Singhal > > > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: > > > Fix FADT Parser > > > > > > FADT parser was checking for reduced ACPI flag incorrectly leading= =20 > > > to incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL=20 > > > are both 0. > > > > > > Signed-off-by: Ashish Singhal > > > --- > > > .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2= +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars= er. > > > c > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars= er. > > > c > > > index 5b8cc174f1..8acfbac3b1 100644 > > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars= er. > > > c > > > +++ > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPa > > > rs > > > +++ er.c > > > @@ -253,7 +253,7 @@ ParseAcpiFadt ( > > > // present. > > > if ((Trace) && > > > (Flags !=3D NULL) && > > > - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) { > > > + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D > > > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > > > IncrementErrorCount (); > > > Print (L"ERROR: No FACS table found, " > > > L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are=20 > > > zero.\n"); > > > -- > > > 2.17.1 > > > > > > > > > > > > > -------------------------------------------------------------------- > > -- > > ------------- This email message is for the sole use of the intended > > recipient(s) and may contain confidential information. Any=20 > > unauthorized review, use, disclosure or distribution is prohibited. > > If you are not the intended recipient, please contact the sender by=20 > > reply email and destroy all copies of the original message. > > -------------------------------------------------------------------- > > -- > > ------------- > >=20