Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

["Ashish Singhal" <ashishsingha@nvidia.com>]

Hello Ray,

Any update on this one?

Thanks
Ashish

-----Original Message-----
From: Gao, Zhichao <zhichao.gao@intel.com> 
Sent: Thursday, January 30, 2020 10:33 PM
To: Ashish Singhal <ashishsingha@nvidia.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

External email: Use caution opening links or attachments


Actually I have no permission to create the pull request. I would help to send the patch to Ray and he would create the pull request.

Thanks,
Zhichao

> -----Original Message-----
> From: Ashish Singhal [mailto:ashishsingha@nvidia.com]
> Sent: Tuesday, January 28, 2020 1:29 AM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Ni, 
> Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH] 
> ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser
>
> Hello Zhichao,
>
> Do you know by when this may be merged?
>
> Thanks
> Ashish
>
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Monday, January 20, 2020 12:42 AM
> To: devel@edk2.groups.io; Ashish Singhal <ashishsingha@nvidia.com>; 
> Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH] 
> ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser
>
> External email: Use caution opening links or attachments
>
>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf 
> > Of Ashish Singhal
> > Sent: Monday, January 20, 2020 1:45 PM
> > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao 
> > <zhichao.gao@intel.com>
> > Cc: Ashish Singhal <ashishsingha@nvidia.com>
> > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib:
> > Fix FADT Parser
> >
> > FADT parser was checking for reduced ACPI flag incorrectly leading 
> > to incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are 
> > both 0.
> >
> > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> > ---
> >  .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c       | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> > c
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> > c
> > index 5b8cc174f1..8acfbac3b1 100644
> > ---
> > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> > c
> > +++
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars
> > +++ er.c
> > @@ -253,7 +253,7 @@ ParseAcpiFadt (
> >      // present.
> >      if ((Trace) &&
> >          (Flags != NULL) &&
> > -        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) {
> > +        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=
> > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) {
> >        IncrementErrorCount ();
> >        Print (L"ERROR: No FACS table found, "
> >                 L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are 
> > zero.\n");
> > --
> > 2.17.1
> >
> >
> > 
>
> ----------------------------------------------------------------------
> ------------- This email message is for the sole use of the intended 
> recipient(s) and may contain confidential information.  Any 
> unauthorized review, use, disclosure or distribution is prohibited.
> If you are not the intended recipient, please contact the sender by 
> reply email and destroy all copies of the original message.
> ----------------------------------------------------------------------
> -------------