From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mx.groups.io with SMTP id smtpd.web12.1504.1581356368834015721 for ; Mon, 10 Feb 2020 09:39:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=U8EY+utI; spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ashishsingha@nvidia.com) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 11 Feb 2020 01:39:26 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate101.nvidia.com (PGP Universal service); Mon, 10 Feb 2020 09:39:26 -0800 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Mon, 10 Feb 2020 09:39:26 -0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 10 Feb 2020 17:39:26 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 10 Feb 2020 17:39:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CVDuRIcRZJoQMl9M7gRP6ZXRztyimZCpQjASgw+QopH9MoBatpeSys2a/w2DMYj7gfFZ0gsxgO4/JpK2hJvcuENnJOD7ZCqAdDrWkMs1CGZmPOuX8rcIkKW6bzBZx78EEPzSlegb+aqnL5qu1Ps3lp2vKJdIMsGLgSsqDu4yEg/KaiSvuYhRzjkXgWUb0rn6gh+yoHFzlsz6BvFnTQ+tA9rCI4uLCc2WHmh7e4ns/VyFo1gkpIf+xL4PnVTMvaS3ANUpD5od7xFuXjCabdySDTU+NWUPmUozNdj3fJ5F/8CP2qU3j2D4zvZobgTHPRmzCKaL4pENCQ5zT+dD69hk+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sq++Y/K+/VTDViFfNCLDjJMi4JOLRCYW7rqx1nROecQ=; b=XeWhKY8HEqDu92Gdzqatdumt7decWqVjIrgqr4Ow/NPw+aoJWgxkk9aFFAynq+IQS8pqPGqU/0ndTyNpuaLi78FIUjlo3+IO6q1GGyxgKTSBXhv/hjU01+2zJ9z5eptmqaqGRKsoQc1aRn74k9Qv7EPK+9MUOq6n6JovM3iBEMdcrreqf+pUy3FJP+tsVyYX0vGZyhCQ5kKtYhKAKJ90mVyhUQ23D10IZxKEInmS3qiQtP1iyvHzafj9sDP0QPjd9wuetTbAJ1axJkJsbFCtNWslicEol9O063JRpzWUDew6UEjlT1gm90LEKydO2RIJaq0oXr6kiX+XsSQRwduAGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB2909.namprd12.prod.outlook.com (20.179.82.205) by MN2PR12MB3838.namprd12.prod.outlook.com (10.255.238.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Mon, 10 Feb 2020 17:39:23 +0000 Received: from MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7493:bc65:1fe6:ead6]) by MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7493:bc65:1fe6:ead6%3]) with mapi id 15.20.2707.030; Mon, 10 Feb 2020 17:39:23 +0000 From: "Ashish Singhal" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Topic: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Index: AQHVz1S76mKn+oSl4EuAekfFnBqRZ6fzK6gAgAuj+9CABYF7AIAQgi/g Date: Mon, 10 Feb 2020 17:39:22 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-02-10T17:39:20.5462936Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=bcdce489-c8a6-499c-aa20-247f4d792d7d; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 377930e3-1871-4506-9f47-08d7ae502ae3 x-ms-traffictypediagnostic: MN2PR12MB3838: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 03094A4065 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(376002)(396003)(39860400002)(136003)(346002)(199004)(189003)(8936002)(7696005)(966005)(53546011)(33656002)(6506007)(86362001)(71200400001)(26005)(186003)(2906002)(8676002)(81166006)(81156014)(9686003)(5660300002)(66446008)(52536014)(66946007)(76116006)(316002)(64756008)(66556008)(66476007)(110136005)(55016002)(478600001)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR12MB3838;H:MN2PR12MB2909.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IrJQoQV13g1YlhpaGXMCv7VYpAvp0SoXd+aT+plpt3y9pJuZ9AE9n64FTvbfzerENvdOSwBV80l9BxuwE2pdXxILSDh4lwdm2jMEpDzf5f1t3kDunERltI1s6vlSDyeVa+YeAXmTatls3W8lmlBI8fU4Hl8kV5aOAeoJEAuyW4ZzOlq1t6Q65Ou5IJP6Z+ekjXrokPxHa3IyF6+B1TVJ2M4rTzvCAeX7LLDty80C9uGqVPY9++Img261cUgtLcP7d4WUWgnk23tsbAbTYfcZRl6MYl4fWrnmHcLnbVqK0X1texkcJXrGm55r4OcEKGYXF+jkfTCp4EmhckV3jL1E30lNTtxrjekW8iTrqQBF9Z0ZQ+b6U0TWCQ9nXagBAvTVIXniV9IRIMp6S+5t407zolL5qFDL19jzG8rAO2ODn+aN4rg0QWKIYnljNH2n149U9gIQvZ6gkPRriu+qXBVCbRGiMCXPfZ6CnQ/ors/PD07h/TpRh3fLCdvfIFSATrFMvjcZAGGECd98/sBSNz/4Zyg+GDuW1/eJzrdF51rqqMY9esC3bRadMnFKLxnGDZP7 x-ms-exchange-antispam-messagedata: BlkAdWNGPHLigeESYWztSgkm/em9uVhoBeiuMI2V7Kb1E2Tn6BQwaL2RgHFyvgnyQBm1MR56Cr2HSjIlXfBRjXzXuOFQgb+sHz+LDLl/+IwEaQH4PXKNSU4ya2a2nhITieFA3ubH/F6g2elW/ehrFw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 377930e3-1871-4506-9f47-08d7ae502ae3 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2020 17:39:23.4632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LkBjZ+ADH4XqWr+OFLpFwuKsYVZlwFBgc89XL0IZ2UKvPlt+bLaHGWeUKWxaWvsBX0OK3mDaKXWkZmylRewDDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3838 Return-Path: ashishsingha@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1581356366; bh=Sq++Y/K+/VTDViFfNCLDjJMi4JOLRCYW7rqx1nROecQ=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=U8EY+utIiZi6lMRhhHseQfRzvs2r2E4olWN0M1r0YS+qx0GXnzKwogAfSsDNLNild HOyIVjdZk02MJeYk7tjV+MZ28mR6Qp34+BQyNRrkMfyVR1Ll0seLcm10rMLZjBrcoV SQi9IhUflep7mvWxX1dnLLsj5gAkJ/hqISBkIB3bSl+x00/22LKuxmkLDzFIHKnyJS 7kjaoNoBNOQAROzCQiw84Hhli5TlYXH85hPNi09a9MMGtCwgTWQWKJUUOqnPY4KPer yfwJUGG/fZn55u32raZBJAv1Wmh9U4ydUrtIP684QxBQ6eHkDoEtQ7bATjZ1l/1Sz0 tJu9CSXe2pSPw== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Ray, Any update on this one? Thanks Ashish -----Original Message----- From: Gao, Zhichao =20 Sent: Thursday, January 30, 2020 10:33 PM To: Ashish Singhal ; devel@edk2.groups.io; Ni, Ra= y Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fi= x FADT Parser External email: Use caution opening links or attachments Actually I have no permission to create the pull request. I would help to = send the patch to Ray and he would create the pull request. Thanks, Zhichao > -----Original Message----- > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > Sent: Tuesday, January 28, 2020 1:29 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni,=20 > Ray > Subject: RE: [edk2-devel] [PATCH]=20 > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > Hello Zhichao, > > Do you know by when this may be merged? > > Thanks > Ashish > > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, January 20, 2020 12:42 AM > To: devel@edk2.groups.io; Ashish Singhal ;=20 > Ni, Ray > Subject: RE: [edk2-devel] [PATCH]=20 > ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser > > External email: Use caution opening links or attachments > > > Reviewed-by: Zhichao Gao > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf=20 > > Of Ashish Singhal > > Sent: Monday, January 20, 2020 1:45 PM > > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao=20 > > > > Cc: Ashish Singhal > > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: > > Fix FADT Parser > > > > FADT parser was checking for reduced ACPI flag incorrectly leading=20 > > to incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are=20 > > both 0. > > > > Signed-off-by: Ashish Singhal > > --- > > .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 += - > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser= . > > c > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser= . > > c > > index 5b8cc174f1..8acfbac3b1 100644 > > --- > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser= . > > c > > +++ > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars > > +++ er.c > > @@ -253,7 +253,7 @@ ParseAcpiFadt ( > > // present. > > if ((Trace) && > > (Flags !=3D NULL) && > > - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) { > > + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D > > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > > IncrementErrorCount (); > > Print (L"ERROR: No FACS table found, " > > L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are=20 > > zero.\n"); > > -- > > 2.17.1 > > > > > >=20 > > ---------------------------------------------------------------------- > ------------- This email message is for the sole use of the intended=20 > recipient(s) and may contain confidential information. Any=20 > unauthorized review, use, disclosure or distribution is prohibited. > If you are not the intended recipient, please contact the sender by=20 > reply email and destroy all copies of the original message. > ---------------------------------------------------------------------- > -------------