From: "He, Jiangang" <Jiangang.He@amd.com>
To: "Chang, Abner" <Abner.Chang@amd.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Lin, Kuei-Hung (Timothy)" <Kuei-Hung.Lin@amd.com>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Kirkendall, Garrett" <Garrett.Kirkendall@amd.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library
Date: Thu, 12 Jan 2023 16:08:38 +0000 [thread overview]
Message-ID: <MN2PR12MB3421BE6B801CF2D64CB1FFFBFDFD9@MN2PR12MB3421.namprd12.prod.outlook.com> (raw)
In-Reply-To: <MN2PR12MB396636EF5E28A3B8B3FD4CE2EAFD9@MN2PR12MB3966.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 4188 bytes --]
[AMD Official Use Only - General]
Timothy will answer the question.
From: Chang, Abner <Abner.Chang@amd.com>
Sent: Thursday, January 12, 2023 10:05 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>; He, Jiangang <Jiangang.He@amd.com>
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library
[AMD Official Use Only - General]
Hi Mike,
CC Jiangang, he can give the clear answer.
Thanks
Abner
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Sent: Thursday, January 12, 2023 11:23:48 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>>
Cc: Bi, Dandan <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com<mailto:Garrett.Kirkendall@amd.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Hi Abner,
What was the failure before this change?
This looks like something that would always break the build of source files were missing.
Mike
> -----Original Message-----
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Chang, Abner via groups.io
> Sent: Wednesday, January 11, 2023 9:08 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Bi, Dandan <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Garrett Kirkendall <garrett.kirkendall@amd.com<mailto:garrett.kirkendall@amd.com>>;
> Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library
>
> From: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
>
> Add missing source files to Brotli library INF.
>
> Signed-off-by: Jiangang He <jiangang.he@amd.com<mailto:jiangang.he@amd.com>>
> Cc: Dandan Bi <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>
> Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com<mailto:garrett.kirkendall@amd.com>>
> Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>>
> ---
> .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> index 525e92408d6..244c2e35023 100644
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> @@ -5,6 +5,7 @@
> # Brotli was released on the website https://github.com/google/brotli.
> #
> # Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -41,6 +42,10 @@
> # Wrapper header files end #
> brotli/c/common/dictionary.c
> brotli/c/common/transform.c
> + brotli/c/common/context.c
> + brotli/c/common/platform.c
> + brotli/c/common/constants.c
> + brotli/c/common/shared_dictionary.c
> brotli/c/dec/bit_reader.c
> brotli/c/dec/decode.c
> brotli/c/dec/huffman.c
> --
> 2.37.1.windows.1
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 9081 bytes --]
next prev parent reply other threads:[~2023-01-12 16:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 5:08 [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Chang, Abner
2023-01-12 15:23 ` [edk2-devel] " Michael D Kinney
2023-01-12 16:05 ` Chang, Abner
2023-01-12 16:08 ` He, Jiangang [this message]
2023-01-12 22:18 ` Lin, Kuei-Hung (Timothy)
2023-01-29 7:35 ` 回复: " gaoliming
2023-01-31 0:49 ` Lin, Kuei-Hung (Timothy)
2023-01-31 1:15 ` Michael D Kinney
2023-01-31 2:46 ` Lin, Kuei-Hung (Timothy)
2023-01-31 5:15 ` 回复: " gaoliming
2023-01-31 5:21 ` Lin, Kuei-Hung (Timothy)
2023-02-02 3:11 ` 回复: " gaoliming
2023-01-18 3:19 ` 回复: " gaoliming
2023-01-18 3:27 ` Chang, Abner
2023-01-18 23:44 ` [edk2-devel] " Timothy Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3421BE6B801CF2D64CB1FFFBFDFD9@MN2PR12MB3421.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox