From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.44]) by mx.groups.io with SMTP id smtpd.web11.59411.1673539721761317610 for ; Thu, 12 Jan 2023 08:08:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=HVmSjGpS; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.44, mailfrom: jiangang.he@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZf8UXep/e6hIejmZixCcm0QqHkk787w+pWxCwXvhjwekusVVXrxFLtbEwB7BCyPdSLk8UW8zAMDYAMR7PPdNMxjci4sEXoh+WqDCR9QSBm8pSy7VQOz6pUpVsGY4NDYIVaHXfm3prQfAU+p1zwqfQjLTcNPOGwdY8giDYe0BESZqy3nrw0P+8R3nKFfPQxqkUMtlxlWKK7PYX24Oa/UgAWvj91uKyOtwfGTRyNhW0MTt3m4Ua5QRze1+XcvmxCh31sQQZlkkGsLwa+X9jTVBegQf4XJPXc0RGASMF9oH7PfdOtHAXkVFi1yvHYHkvF4hiv13gb3CZi0xK+L5xk/QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e8VOB8+qlLGPWbzgapkZm8kP7AXWUCO1yCVKdRrQsX0=; b=niSeqbe4YBReIDA3Om/yp/e9FDGeAy8MW2n4XynzIE8Pwsn5pktjcHT1jDOopTXo5uz/0I5M7PeLTjh6ahS6DTd+W0KSZTxuT4ETaQgWkrMOY3xb4ASG2eyfJWI2wGpauZnNgshy+YJUNEUDpVy03FMfvRyT3rPhdVJpdEUY8/vF7m662Ra31ItVkiOGPtYtFzlDlr6tmpG5k6Z9hS7SQlSWzIcwheZma1x31Dnvk/RmICWL69HqWbEXyGUWCPajBXPUKengmyvxEcf7WcBQCmcHVOmDnswD1SkL8aNBhS4TIEJZDKaZ3CnXi4LDe8b5IS3F9PeOeRbA3Mbj4ftK3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8VOB8+qlLGPWbzgapkZm8kP7AXWUCO1yCVKdRrQsX0=; b=HVmSjGpStAnU3JB0FFkJIEOrC5O9nWmp2LFVBKk6gzWvrFUujdhpMAf2glZsZ19rc6+hByS6AIQKrAnyE/j1w5YgBL2Bki8/9zqDvG7X4RYf2e2qeLAJ0Q+n7SQIWnRLtiru1M2kyjwit/msHrS+2xYnerdaZWVhGq1H0M9L2jc= Received: from MN2PR12MB3421.namprd12.prod.outlook.com (2603:10b6:208:cd::24) by PH7PR12MB5806.namprd12.prod.outlook.com (2603:10b6:510:1d2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 16:08:38 +0000 Received: from MN2PR12MB3421.namprd12.prod.outlook.com ([fe80::528d:f20:ddc3:2bd9]) by MN2PR12MB3421.namprd12.prod.outlook.com ([fe80::528d:f20:ddc3:2bd9%5]) with mapi id 15.20.5986.019; Thu, 12 Jan 2023 16:08:38 +0000 From: "He, Jiangang" To: "Chang, Abner" , "Kinney, Michael D" , "devel@edk2.groups.io" , "Lin, Kuei-Hung (Timothy)" CC: "Bi, Dandan" , "Gao, Liming" , "Kirkendall, Garrett" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Thread-Topic: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Thread-Index: AQHZJkP0ez06IqtD6EWknFffBlQE0q6a5zQAgAAK7eOAAAFJkA== Date: Thu, 12 Jan 2023 16:08:38 +0000 Message-ID: References: <20230112050822.1940-1-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-12T16:02:54.5750706Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3421:EE_|PH7PR12MB5806:EE_ x-ms-office365-filtering-correlation-id: 75433bc3-eebd-4fc7-61e3-08daf4b74422 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HWiPlVbQMqx4brklH4n0+9HKOPh+THY98LFx8eP6u/5K7u1T7nonGNg1pG5e3wRyowAQhMlG/gFmWr5GU1jPdGnnntCud0Cvn3OdhR4tRI1ElaOsh4olVZDyhyzOzPCV9uUKTzXPs/zgUb08g/cNVwZVRlLWIozcRrYzvJlPJ5lhpjV1N61ESD3gQk/EOGsgOTKB3qJU2eLEYGpcfEUO4mWYJ0JOJ9mSFHYRYlwd7GjKB+KksgjnVM6qrIUxxHUUh2jUNtcSUdyEJ7D9jPOoJrARYxVWW/gY1IzYow4b3OmA2/E2leVimtK0T5RJTf2YuRlc+tUQTwl7rHAu24CT8akJPYrKfXIiTLXCNrrg6T1+8HfVZHUEa8ahIk7qtx+8icwBmmrur2cB9N8zcAdYjPt11zt0z0x0jGpfDY37JjMAk+VoGO3DAjJoF7+of/Z6UJ25KD6yLoeytCICIZtqiTHMvvPeYCgb2x7irUH471oBOtTcphReCk/HB/l0FFV88G+QsOU+IYD8Tr12iaOycwVtkqy2EhA+1hrhDgwg1RCet7uYVuoMsQ2dRo4fuBT8gQuxd2DnTm13Kt1Vja2ih7aYGiMzeudDLIgs/oQT/1UQfg35jGi/X8dqDtbJUnu1+nsXK28Jk+JdiRqgOWlhFMHF85OUMGW97GkOblq+cM4AduRZ6oMyvBeUdiwyZ9g8h0cRp91vuIU9BACpXtKQdCiEiGw/0FUDkDoNhoyKJWzxSo9zU2JcWZByS7oMXRNadYdXBvH7UqIAuYHqTVFREw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3421.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(396003)(376002)(39860400002)(451199015)(6636002)(41300700001)(4326008)(110136005)(66446008)(55016003)(8676002)(83380400001)(66946007)(64756008)(54906003)(66476007)(316002)(45080400002)(76116006)(66556008)(86362001)(38070700005)(5660300002)(166002)(8936002)(38100700002)(122000001)(33656002)(52536014)(2906002)(66899015)(6506007)(71200400001)(53546011)(966005)(478600001)(186003)(9686003)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qp+PRzO9XQ8EAMICJOL1J/UqSZHt1cV6gTC7xpIwHhJWFCb/+zppfPLvf1kA?= =?us-ascii?Q?CX0szQOSbzeNxDumDxBoNR1G5jhNHzxGUDlGRGk9pp8ANrDciYWxdj6kUrL6?= =?us-ascii?Q?2c3vLPevHLxgenpPObA6DqqKdzqWY4fGPTMRb0Nit2TbxysyR4ltU8lQPgf9?= =?us-ascii?Q?KNw5bW8nPpWhQmc7JFKKAUHnH7lrjlPVFFpiryJVwnHA5KPvLtEit0h6CGKY?= =?us-ascii?Q?QxnofTT0rkcQNjNA0lK8O7RmGJBLg9ixgabuVCW3Q1bvjPjCm1hZZUQk9uAs?= =?us-ascii?Q?UgtyMRtYUjemPE2mIu0Pnr9MHY+lJh2zhss8v/+zbA24XD/BFAgPew644pgl?= =?us-ascii?Q?oPAgeBUKMSinGyz0NHeSK7CIV1roJNNtP+zlaVqw+4STwTe065GOtyZUWXaA?= =?us-ascii?Q?aS5hH/lg4fkJmTtZ61aLJH3oZVj1uVM44UrfzI5q8FcsPEqQ5p6VdiajzsmI?= =?us-ascii?Q?6XAaaEsoPvUWTCTt8pdTBR5MSTgEo6rdNluNDZxjTe/PCsmWFEnl0R64N2A6?= =?us-ascii?Q?itEKMj2I0Lg870c4cIcMGSVbzg75TBS0j+o+QfGSP8NAXNk31jmQSmc+FfO+?= =?us-ascii?Q?4pe9Frik2fpNoIzMgHUHv8xyoCEiE0/5K60xHPbB3N5coPz9Vi8l4NMe8GFz?= =?us-ascii?Q?RF8dzKsSkiegK9i69aRvocdDhncWdq3xRw3+tZXx8v4NS1EvIHwfS6AGigul?= =?us-ascii?Q?ZtSoU2jcAege/41nDJcTDoTDZH4umxvAZqV3N3YvbXVQklwFIMLq0zY5dci6?= =?us-ascii?Q?55enO6Cns0JgitFZ10CxcEpN1lkwKTvYcVltEY1kC/GOZlWdV1VtJkwyTgmo?= =?us-ascii?Q?KL+IHjZj6fobrzXs526m0nfgg72LVKDAfR1b5+/iZquj2N3RnBTL1IyvahG7?= =?us-ascii?Q?62kHl/Xbr6HDIaI3Z8lFeHx9ZAUslHqZSrC/J+9hXCc1ZTfBUYtoTgSAlssx?= =?us-ascii?Q?TKCKDPXC+h8/mqYoXORj/NSvqihrh4SHY6pxAyau0tLA5NfSbeMVFOuBWRoM?= =?us-ascii?Q?KznAicL8+2TABmqLOMBA23CUsiDTPV1dbVF1Q2S8n2tpvHrehFoxa+owNSir?= =?us-ascii?Q?vaCHORlNXdmkOG4946Fxvc9bLsicgFRKgg6Y/lC3GR5vfLHN5wbzztiz/JzN?= =?us-ascii?Q?PFYgWs3fFJo+XC/PPkp4cnEL6yaiXfLnDckuRW/MGS2z4G9UAt1lEckQraqC?= =?us-ascii?Q?vRwRXB++DtH+qfTv98pJCYiBoT6dQrzqNVagl9jc5o0kttWeOG1prf/yCA8M?= =?us-ascii?Q?To4MjMia1vdYtnddCDroZJgG4XoFAjUqfewcHblmpr92KQUEo1Ys9N57LsNL?= =?us-ascii?Q?o77+tjqDh41qTnGRy7A3Wt4Wt//qKt9LDlzahM5ZU39Wa98hMkiwzGfldDda?= =?us-ascii?Q?EJ3DsmG2+5CF/Xs3xCVveRPcp3tplXFSP+4ZboNm5raNunrWliQZP5yC5ed+?= =?us-ascii?Q?LP5uDvJtLl1z1rNwTPVnvMCMlI/MpF9B9irBx0VRnq6ZtaGqIB9OxQnZr/j0?= =?us-ascii?Q?gFU5oGkprVLhk0ZYlVf5rnKTI9JUzkoLn0ii02up2t4xzmNvrK66jc3VdLq3?= =?us-ascii?Q?qvVR0nYtIYUALfsYBu0vyFTgTpKPv2aspBLbTT2DfmHKimiloWwWYuTtNpJU?= =?us-ascii?Q?sZ7S277GrFH1KghNOYLzssY=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3421.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75433bc3-eebd-4fc7-61e3-08daf4b74422 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 16:08:38.5486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M5faqryX6nm3DWJ47h5XPLPRXe3+zI3nKrdh89FiGJWuIltm4KQ3v7/FSZa82MjzLv+O4aSNxclYJ4Sr0vUIxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5806 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3421BE6B801CF2D64CB1FFFBFDFD9MN2PR12MB3421namp_" --_000_MN2PR12MB3421BE6B801CF2D64CB1FFFBFDFD9MN2PR12MB3421namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Timothy will answer the question. From: Chang, Abner Sent: Thursday, January 12, 2023 10:05 AM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Kirkendall, Garrett ; Kinney, Michael D ; He, Jiangang Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing s= ource file to Brotli library [AMD Official Use Only - General] Hi Mike, CC Jiangang, he can give the clear answer. Thanks Abner Get Outlook for Android ________________________________ From: Kinney, Michael D > Sent: Thursday, January 12, 2023 11:23:48 PM To: devel@edk2.groups.io >; Chang, Abner > Cc: Bi, Dandan >; Gao, Limi= ng >; Kirkendall,= Garrett >; K= inney, Michael D > Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing s= ource file to Brotli library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, What was the failure before this change? This looks like something that would always break the build of source files= were missing. Mike > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Chang, Abner via groups.io > Sent: Wednesday, January 11, 2023 9:08 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan >; Gao, Li= ming >; Garrett K= irkendall >; > Abner Chang > > Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing sou= rce file to Brotli library > > From: Abner Chang > > > Add missing source files to Brotli library INF. > > Signed-off-by: Jiangang He > > Cc: Dandan Bi > > Cc: Liming Gao = > > Cc: Garrett Kirkendall > > Cc: Abner Chang > > --- > .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomD= ecompressLib.inf > b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLi= b.inf > index 525e92408d6..244c2e35023 100644 > --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf > +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf > @@ -5,6 +5,7 @@ > # Brotli was released on the website https://github.com/google/brotli. > # > # Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved. > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -41,6 +42,10 @@ > # Wrapper header files end # > brotli/c/common/dictionary.c > brotli/c/common/transform.c > + brotli/c/common/context.c > + brotli/c/common/platform.c > + brotli/c/common/constants.c > + brotli/c/common/shared_dictionary.c > brotli/c/dec/bit_reader.c > brotli/c/dec/decode.c > brotli/c/dec/huffman.c > -- > 2.37.1.windows.1 > > > >=20 > --_000_MN2PR12MB3421BE6B801CF2D64CB1FFFBFDFD9MN2PR12MB3421namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Timothy will answer th= e question.

 

From: Chang, Abner <Abner.Chang@amd.com>= ;
Sent: Thursday, January 12, 2023 10:05 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2= .groups.io
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaolimin= g@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>= ;; Kinney, Michael D <michael.d.kinney@intel.com>; He, Jiangang <J= iangang.He@amd.com>
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mi= ssing source file to Brotli library

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Mike, 

CC Jiangang, he can give the clear answer.

 

Thanks

Abner 

 

From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Thursday, January 12, 2023 11:23:48 PM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Chang, Abner <Abner.Chang@amd.com= >
Cc: Bi, Dandan <dandan.bi@= intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Kinney, Michael D <michae= l.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mi= ssing source file to Brotli library

 

Caution: This message= originated from an External Source. Use proper caution when opening attach= ments, clicking links, or responding.


Hi Abner,

What was the failure before this change?

This looks like something that would always break the build of source files= were missing.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Chang, Abner via groups.io
> Sent: Wednesday, January 11, 2023 9:08 PM
> To: devel@edk2.groups.io > Cc: Bi, Dandan <dandan.bi@in= tel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Garrett Kirkendall <garrett.kirkendall@amd.com>;
> Abner Chang <abner.chang@amd= .com>
> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing = source file to Brotli library
>
> From: Abner Chang <abner.cha= ng@amd.com>
>
> Add missing source files to Brotli library INF.
>
> Signed-off-by: Jiangang He <= jiangang.he@amd.com>
> Cc: Dandan Bi <dandan.bi@int= el.com>
> Cc: Liming Gao <gaolimi= ng@byosoft.com.cn>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang= @amd.com>
> ---
>  .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf = ; | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCust= omDecompressLib.inf
> b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompres= sLib.inf
> index 525e92408d6..244c2e35023 100644
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf
> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf
> @@ -5,6 +5,7 @@
>  #  Brotli was released on the website https://github.com/google/brotli.
>  #
>  #  Copyright (c) 2017 - 2020, Intel Corporation. All rights= reserved.<BR>
> +#  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights re= served.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -41,6 +42,10 @@
>    # Wrapper header files end #
>    brotli/c/common/dictionary.c
>    brotli/c/common/transform.c
> +  brotli/c/common/context.c
> +  brotli/c/common/platform.c
> +  brotli/c/common/constants.c
> +  brotli/c/common/shared_dictionary.c
>    brotli/c/dec/bit_reader.c
>    brotli/c/dec/decode.c
>    brotli/c/dec/huffman.c
> --
> 2.37.1.windows.1
>
>
>
>
>

--_000_MN2PR12MB3421BE6B801CF2D64CB1FFFBFDFD9MN2PR12MB3421namp_--