From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.47]) by mx.groups.io with SMTP id smtpd.web10.16405.1685544514052923998 for ; Wed, 31 May 2023 07:48:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=XzlXzGnK; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.47, mailfrom: jiangang.he@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYFTflf7tZQ4r8zZD0tkA/LMI6yMW6Ekyvh5z3Ibm/dN2BUFkS8QOgZi2MvQd1YUbuki32nNS4IwDG35NU0AjFhKx8cyV1DrOAsjn4dZNUNncpvCqlLrHEXrr+c1OrXqabpTcfVNvoTbXUo07VQwXT8n4GrNrMjbOR8QRc913n8BiW9yxW88fODLU2DNNFRKWtEl18LgZN47jwbnBpObzVNNnzMUuHohyUmMDMKZlRx9g0mEK6e8JYSIug76nhO4my/LzdSwjjPcPkBtR/j3QBveN3VNrDVv6c17gQXoR1MBnUETXMO3BG1QBpQSI/40kSk6l9fUXyon2l6YvFhWRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=chvsfQLF/MlJNf+ziQ5GPnhYA2julqwbPwHzRfQEFMQ=; b=FAvCoWe1qRBvCSpILDoJ5sR5xjo+8fuKzAtZCAYhUOZgrO+1QHfEwfWTrgon20PIwYrKHDAj5PzT1YjjAszn+7lCtQ4rYK57+gPZyYX2egngjAWbwU/SlQtlu9qpKfIUhpCvCyp7qSpdq8fUCjl/4/G7/wFOHDCxrFAs0Z0xjj03vm/i5pSjKmzB2C2JVQyqRPlPa3qFyVNIKcfpEcdnsZH3TFYkA0EGJrG7Rukk7+MUsawbWp6gBau4ZXgOwyThmdStBU+4c1MoeUVyS4ktGGXY27ljO8MDa8l6K+w7PC3DI9ICliW+zM2KQFEaBIXOBqVTlO8n4f7NudHZZgAI9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=chvsfQLF/MlJNf+ziQ5GPnhYA2julqwbPwHzRfQEFMQ=; b=XzlXzGnKyW1SravwYF8vJoiAIOYwCXuGNIep2spurE5jnawopZZMFhU6UAjlBMZTt9iUcVto9BfxA/hiuHKKrIsQEscU12kRJTqVn6iEf5AcF/DwuWHIayl8LyWqyQklJpb+ICQL9YW+SsgKaf6QbWTDd1bMkHpGyN8kM6XQ2Ts= Received: from MN2PR12MB3421.namprd12.prod.outlook.com (2603:10b6:208:cd::24) by CY8PR12MB7753.namprd12.prod.outlook.com (2603:10b6:930:85::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Wed, 31 May 2023 14:48:30 +0000 Received: from MN2PR12MB3421.namprd12.prod.outlook.com ([fe80::54bd:2cc4:d9de:9ea3]) by MN2PR12MB3421.namprd12.prod.outlook.com ([fe80::54bd:2cc4:d9de:9ea3%5]) with mapi id 15.20.6455.020; Wed, 31 May 2023 14:48:30 +0000 From: "He, Jiangang" To: "Wu, Hao A" , "devel@edk2.groups.io" , "Hsueh, Hong-Chih (Neo)" CC: "Chang, Abner" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjZkbgL80ntTxJkKMfHfvppTpYa9zxQmAgAC7v1A= Date: Wed, 31 May 2023 14:48:30 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d21dead0-8696-4352-9606-25ca7d77c028;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-31T14:41:31Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3421:EE_|CY8PR12MB7753:EE_ x-ms-office365-filtering-correlation-id: c376718b-3d2e-4c6c-ccda-08db61e619c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sFZPHPl68WiCT5Bd64SOP41bKbLfivgPDRWvcOeTX0ANIICaor43wargtHSD2kjytg2MbIotlTSjZ34/kyh8ljk4vf4WjH2Q76PHhXPnFt2c8vVSOf4I/ZZ5C3hDi9RRpxjYfGRPZL+de8OA3uEz2gXVQKIGHU15m7CnmLnyHPo/r/ZtJwACO6IHE/nbvk6Hw0StylB2/MvC/X3lAXTPAMK5lXzpn6L7NFHpXdb3imyWL8GUeu6v8i3NT6ZEAe6OsWhd6dKNaQP4Gai+k5sUxj4TqRYK+j7QjrMdlDYRbBr2bBwuQ+yzvfMMNIbWvS7nH9J71B+prq+nEEbTKRXwzp7wulucYEBgLg+8Ai8bghv/VJeUMe6P3+HW2Ty70cwkx66oD76mg6KPmCQFl9ukBj0xd8UP8Bo3W3fw8Bq1vBk4mVLM3e0tEba43mgfdN60wSLiGeZMCvYoLCRyUFCgfGUVoGBz1Uiy3veVXS6cpoQUdMcXcYLb7VIIDhorem/gm7sV2h/2ZjGsFf3sl1wBkLqB7o6Zh1GTpL9dNrjAyMSOhKS1GvZxUDHUi/cPw8liVNup15Vm2ifXBWSgoqrg6weqHsE4qc7U4o5gSSsk3xQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3421.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(39860400002)(396003)(366004)(451199021)(6636002)(66946007)(4326008)(66476007)(64756008)(76116006)(66446008)(66556008)(86362001)(478600001)(7696005)(41300700001)(5660300002)(8936002)(52536014)(966005)(8676002)(110136005)(33656002)(9686003)(71200400001)(316002)(66899021)(53546011)(6506007)(186003)(38070700005)(83380400001)(2906002)(55016003)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b1YAoHZ/DsR8/5P23dTJ6CnD0enks1JG/SrW51RjKzeke0AN9RZZLySiYx97?= =?us-ascii?Q?km5xaLRIcP3KO+0oKEO+WiuocY7RQUq7E3SG/fYzZSnVuM4u3i6EbEgmt0UE?= =?us-ascii?Q?g/rT9343WEClyQFN8tpCSj4K23SKlqvIZSUir8624njMtftLGIBPrnl2y+Wg?= =?us-ascii?Q?RqgW1wYKIQ+n0citaAeTH5E24dUbOTh3D8fWUQZCN+3AzBTFjYpTPskWAU48?= =?us-ascii?Q?YLSF8DgSEgZ0oc5oWBhQ1Ak3b8UurgywGxQRO1eSLvgGaCOyXJPw/+l0WLxA?= =?us-ascii?Q?pa98hWvOIJooXwXv8PVzDuZ9WN4Lnpm51yBWjX+E5FehwAOguQovZOBQei7t?= =?us-ascii?Q?3BehtUFtEV5QbWviQ6iJqY3CReVcQZBEZ3G1+iKx5OJ5zu4SSyxNdsNQKN7D?= =?us-ascii?Q?4X5JBCiDRMzUzuJPn0UL3vhdeCt0msNB5S4zY1OE8lmHY6lLSZQ5CqpHikDy?= =?us-ascii?Q?MR2s/DpW1k9KsC+Z2ASv7rnGCC+BXNRbOCpvNfk2aZeWXJUFNJDGemld4rc9?= =?us-ascii?Q?IDzojxhk2UiHKO8QSSdclEcWRPWFL+ggsLc56HBBNiovzyXV/q5M8+YUv9mP?= =?us-ascii?Q?kGlx2oIvc4EcHtudbAz5Gx+4QbF0lU70grx5UE5hAuNMCUoR9+6mfHFZF0Ie?= =?us-ascii?Q?yHnRr9UmIvAxl6SC4KuRphfbXFQyKE8LpXs7S1hWdu6vBDmoKVD15zOZI71u?= =?us-ascii?Q?F3/9DFcPwdy6/2RCW/rTNCWizyqyikOhCTb4psJvpuCDkcRfhaeKOFtODPj9?= =?us-ascii?Q?n1cQncD62SZL6lyW+PPCSnZnTpffECk/AiLEsBt6QY+GuSfJLL0orQok6j4s?= =?us-ascii?Q?ZinWxIMfbW06UPfKwGVVa+GcdS5+3TnwGQWQUftj5LN1yV7Bnkk3Q6sTACEc?= =?us-ascii?Q?rttOQv04S/ELzzf0wP5J/eX7ygk6Bhaxt3/z/9ypU4vRi2z5V9XAiP9AZVhA?= =?us-ascii?Q?l1DDbqoCEmrNsuRgK88RfhlNZWtDKfHu5dCLPHQ51oPCtksWm7b9qR53FP1/?= =?us-ascii?Q?GIvE1CoCa/0rtKuGNYIAf7Ay/ME6pZ74uDU5nnzZFQ77VDiBIeJuxWJGVToh?= =?us-ascii?Q?2DZunHSFnaakPflBBT774XvKHlrDFyoJFTkWWzGy9xpSMbOBKuhVCavyO370?= =?us-ascii?Q?hDnETh5GQOe8vg5OzBm7wGuM09VvMYzrRUoYGbSM5FSz6F4vb+iyi9loyTxI?= =?us-ascii?Q?h43JOmKoHUtiUqJLy9Q9CAoEO3KOU5mMMfMORq4NE0FiwKYeJFFyJUN04Xm1?= =?us-ascii?Q?ucINVczSyxhzXB5zMawFVn9xFC/BDtuZxtB/MOEBraI90CAY8zYxY+ob0vWI?= =?us-ascii?Q?mdoesKR9sEmdrMAF+WEA0o9zEGut9t1pBC3IrjsERJ99vHeJJNksqgC90Ajd?= =?us-ascii?Q?K8nYVzgjePsdAzdjaO8exKpGZ+NwXy7ZEeENXlMUsHUbHUKQmfMRkhgC6bpN?= =?us-ascii?Q?XyLNUFWygWWL3EyoFol99oQutkj1MBhWPe/8rBgndzkiEbuGSN8G2HrAv0Oo?= =?us-ascii?Q?BfTL8+A+auyifJ2YyfvzLUdtF7AteeARNavqEwYe7ogUrc2wYymUmKOEODxT?= =?us-ascii?Q?7l4ThckP7RG84GtfdbXKOYHgFW2IkPeSQx9BBKQOw3D0ZNwKZgJLVOK0utIt?= =?us-ascii?Q?X9s6IzRyUMdTz7/jA7a83Ng=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3421.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c376718b-3d2e-4c6c-ccda-08db61e619c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 14:48:30.5614 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DTjOOFgSV9LUCTKJwiQNEKRZGnny8LuFFNfStNXqgJUaq06LRONbuHd2eAczUApMRWlADGMrWYHBGgUhn3t5VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7753 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] We did crisis recovery and Opal HD password unlock from S3 resume from SATA= HD test on two different version of AHCI host controllers. Thanks, Jiangang -----Original Message----- From: Wu, Hao A Sent: Tuesday, May 30, 2023 10:30 PM To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) Cc: He, Jiangang ; Chang, Abner Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks, the code changes look good to me. May I know what tests have been performed for the patch? Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Neo > Hsueh via groups.io > Sent: Wednesday, May 24, 2023 1:07 AM > To: devel@edk2.groups.io > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh Chih.Hsueh@amd.com> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > in AhciPei PEIM > > If there is no port multiplier, PortMultiplierPort should be converted > to 0 to follow AHCI spec. > The same logic already applied in AtaAtapiPassThruDxe driver. > > Signed-off-by: Neo Hsueh > --- > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > index cd55272c96..7bd04661d0 100644 > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > @@ -3,6 +3,7 @@ > mode at PEI phase. > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > + reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > EFI_STATUS Status; > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > + // > + // If there is no port multiplier, PortMultiplierPort will be 0xFFFF > + // according to UEFI spec. Here, we convert its value to 0 to follow > + // AHCI spec. > + // > + PortMultiplierPort =3D 0; > + } > + > switch (Packet->Protocol) { > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > Status =3D AhciNonDataTransfer ( > -- > 2.40.0.windows.1 > > > >=20 >