From: ipark@nvidia.com
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "eric.jin@intel.com" <eric.jin@intel.com>
Subject: Re: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid
Date: Thu, 28 May 2020 20:06:40 +0000 [thread overview]
Message-ID: <MN2PR12MB3469A5B62D3BA7048BE5E4DAC98E0@MN2PR12MB3469.namprd12.prod.outlook.com> (raw)
In-Reply-To: <d444524d6c149fae10241d3aa11fe02ed6829ab7.1590609580.git.ipark@nvidia.com>
-----Original Message-----
From: Irene Park <ipark@nvidia.com>
Sent: Thursday, May 28, 2020 3:19 PM
To: devel@edk2.groups.io
Cc: Irene Park <ipark@nvidia.com>
Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid
From: Irene Park <ipark@nvidia.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
Signed-off-by: Irene Park <ipark@nvidia.com>
---
.../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++--
.../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c
index d495afd..fe973a3 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl
+++ ackBoxTest/Dependency/SampleDriver/DriverSample.c
@@ -1893,7 +1893,7 @@ DriverSampleInit (
EFI_STRING NameRequestHdr;
MY_EFI_VARSTORE_DATA *VarStoreConfig;
EFI_INPUT_KEY HotKey;
- EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx;
+ EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx;
#if 1
EFI_STRING Progress;
EFI_STRING Results;
@@ -2190,7 +2190,7 @@ DriverSampleInit (
//
// Example of how to use BrowserEx protocol to register HotKey.
//
- Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, (VOID **) &FormBrowserEx);
+ Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL,
+ (VOID **) &FormBrowserEx);
if (!EFI_ERROR (Status)) {
//
// First unregister the default hot key F9 and F10.
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf
index cfa049e..75cb6fb 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl
+++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf
@@ -99,7 +99,7 @@
gEfiFormBrowser2ProtocolGuid ## CONSUMES
gEfiHiiDatabaseProtocolGuid ## CONSUMES
gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES
- gEfiFormBrowserExProtocolGuid ## CONSUMES
+ gEdkiiFormBrowserExProtocolGuid ## CONSUMES
gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES
[Depex]
--
2.7.4
next prev parent reply other threads:[~2020-05-28 20:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 19:19 [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Name
2020-05-28 20:06 ` ipark [this message]
[not found] ` <16134CAE37D4DAC5.10634@groups.io>
2020-06-01 20:33 ` [edk2-devel] " Irene Park
2020-06-01 20:51 ` Samer El-Haj-Mahmoud
2020-06-03 7:30 ` Irene Park
2020-06-03 7:53 ` edhaya.chandran
2020-06-05 7:30 ` Irene Park
2020-06-05 8:11 ` G Edhaya Chandran
2020-06-22 18:30 ` Irene Park
[not found] ` <HE1PR0801MB1691E592BFCB7B44E6ECAAAAE8970@HE1PR0801MB1691.eurprd08.prod.outlook.com>
[not found] ` <BN8PR12MB34583B559CB0E3748D6FCCD3C9920@BN8PR12MB3458.namprd12.prod.outlook.com>
[not found] ` <MN2PR12MB3469ED3ED21B3D2503942E15C96D0@MN2PR12MB3469.namprd12.prod.outlook.com>
2020-07-06 16:48 ` Irene Park
2020-07-15 5:56 ` Irene Park
2020-07-15 6:09 ` G Edhaya Chandran
2020-07-26 20:09 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3469A5B62D3BA7048BE5E4DAC98E0@MN2PR12MB3469.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox