From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.60]) by mx.groups.io with SMTP id smtpd.web11.8477.1683076323656277209 for ; Tue, 02 May 2023 18:12:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=pUnjHZ0E; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.60, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i70IclGzzYbtROBnmtUKZLfxJYEQuY+0QlvDjfHGKinw93Gslkxj3QbhWj8UfAdXpPVMfB7qnKMv6awyBj92lmLocZRA8aKSYFefHbNlrPZyQq+njx9gYPSbxtUGlpelAloL5l1/CGclukZcWP907ZDxGAQzwgYs72UNAmBTwMgZ55ZNnyt+7ECU4U0F+essGTZotTRtU3U+dL1OiWnAhY/cKi0tAw/Olx/s/tN/O1PfBthX/s1JfvxMeFGM2u6BJiyzwq+Lk20ju2IOc3GLXqO29VPmbpf1soRBUayh++SZgm96jRMfTHJwxMuPuuOT77Ozq+7Fah1xFNF1RcJdPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IpO2ZbiipnqWyMDR2hthKkgeRhJBMy1zlmjH3BUaLtk=; b=XYmaBYvQjKQpUIYnfWS5ogdTWBSwadJZJcJZ3wA+W83FHr2OKqmqgbAjHV+aYJX/nXZOaSNENkNBukhZHNtSX2UIerulXwBl7Q7OQeWpDZmw6OhMmd3AGf1zLUSVyQbLkP67EuiLMa2LISbqyRtVZeoTBOZCjVslueb3CT6QXFoevQ44ZinmmuRwG/tputdex7a0ld09cmFY6kCnDjNFMgL4LL7tI+xwpOq0p6WvHzSI7Z14K6tfNpZM/WOFfqAXzyt93oeLmCwj6nyeQ8ElhENtJZjHZ0/T8y4P7HmV1uB2EUTKbyHaPFNlnHgBkoFI9KBvoTzJZjynX6EWurseOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IpO2ZbiipnqWyMDR2hthKkgeRhJBMy1zlmjH3BUaLtk=; b=pUnjHZ0EYNTYXaeUnsMhlqz38hqasCVisD0xePG/ETPU6Y1eTPqn8QEjmE/w6kBC+g1f7ejN3PS1qGh6xBbVieXrnSZ8umgGbK/7IhoZacC5Hjl6Fbb+rzBCViHZ4lBK6OZni6d1lKfkUZyuzZE3btQZi0DJ2jLLvH51t331ccI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5149.namprd12.prod.outlook.com (2603:10b6:5:390::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Wed, 3 May 2023 01:12:01 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 01:12:00 +0000 From: "Chang, Abner" To: Tinh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" Subject: Re: [PATCH v2 1/3] MdePkg/IndustryStandard: Add definitions for IPMI SSIF Thread-Topic: [PATCH v2 1/3] MdePkg/IndustryStandard: Add definitions for IPMI SSIF Thread-Index: AQHZfR1F9EaiNM9j50OtUVV4Pnkgaa9HvJsg Date: Wed, 3 May 2023 01:12:00 +0000 Message-ID: References: <20230502173945.2016719-1-tinhnguyen@os.amperecomputing.com> <20230502173945.2016719-2-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230502173945.2016719-2-tinhnguyen@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-03T01:11:58Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=65bfec8a-2fc6-4398-b70a-a4f6e23ae1b3; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5149:EE_ x-ms-office365-filtering-correlation-id: e7890907-e372-4ac7-956e-08db4b7365ea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S9c2HrM2G7KqlqPaciGO+YLn/k9JJEWd0OSozdyABZFGIaOOBak5meL74svmfSL15uMWFg7vGpe0rFp1y/0QBoNpowHKrrcMv9Mc4mGus3YoUNfjla0E6fBaS30ejC7Q/3EvbiWq8VkQOutyUHcOZU8PmjvtrrSphNd5h1S1rqKDs4/QS67AsbzvnSKpZqPH3G+urXMXFWX3BhPtiTOSMBarzFZU8gG2rK7ag6s5DTEZCc/ClPcdpCCajw1cxBR8TwFh4N0Z9AdQoG2srz2TjXgmoKZymeO8F/YS4HitZtMI3iXw3Rq9aFA1rp50Vt+Vpf+4h4KnIQEKGAsm46iJddAdrjwIEbvVIVxLhLOsjfwSBsN6ZHlDbT8s0hS4GywVWHrtkCSB1rTqyWNMKdNNIMLkgMd9ay49tvO0PDby2yrRU5hdWperC0zkveBWKpF2+hJtmBONwcBJ8a86J+BWW7S/TYUYNhvNjxJubfI2co1tc8ZjEhhGRaLARDc6j8Rb1Wv/Xvq3fW/QfCxBiGkjnw4CjpMqC+CHlX/CuvveAR0/uLvR520P6FN0I0aaOsJ9WAGYbiGMFxZALoiJc6aXygP3MmIsNUR71w1S3vE3JuzHEIwcw8F95Dn2VOT2waoDYJL1vjvifdJLUH/6OeYRIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(366004)(376002)(451199021)(122000001)(2906002)(38100700002)(8936002)(5660300002)(52536014)(33656002)(86362001)(55016003)(8676002)(38070700005)(478600001)(110136005)(54906003)(6506007)(26005)(9686003)(53546011)(7696005)(186003)(83380400001)(71200400001)(966005)(76116006)(66476007)(66446008)(4326008)(66556008)(64756008)(41300700001)(66946007)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EQeGKtFxYKognwkAU1I5ctblOdjFEySvcPwG8Q5nFkKQ+EAbrRAEugYU8tzy?= =?us-ascii?Q?SgVv/8KVSXGNuN89Q5m5wrqlWE3hsW2bM9Uuyo0pL85n8cSB3YX0fC6Suw1H?= =?us-ascii?Q?pesczNnFxFZG52+Cu9e3WfkGq2aMg5JxT8HJ2Uvq1GTPLQRFEuPmiMFK8qfW?= =?us-ascii?Q?e1rva9485hRvo2E0ZoyNvZbzEF+IlJePAFuth5s5TpzKurkE2SPmfBbkHTxv?= =?us-ascii?Q?mYnfILWUoO79ohyZ3nGePijtvdmM78zj5xdeyhOUS78pKVzDXZWDod1U35H/?= =?us-ascii?Q?BOIWyxY4ov1VnA08BuPVYIUhEL3UHacqJWqcAcbTcE9RTqRaokpDKx+Q1ozv?= =?us-ascii?Q?zQEZYewr7edWSHDh0+VLK+n8bOQGJgbD8xKMaTNFtqWnwERMAHplaEwBgpZ+?= =?us-ascii?Q?oow2AZs73bjEUOFwa+D5tQ+o/yQiAfBuphXbCy2NEF8U5QQlWdnO72P5aZnj?= =?us-ascii?Q?4vgteU84Kc+YBMIzBl9I/u7rJ4kjghJZZI4PM8gsSPz0QVgMhC8yyDCgKnDT?= =?us-ascii?Q?OP7azyg4t9IKwaDbsFrQ4IZJ+DX8EIwYHJh7gzV3MqrgcxyYvGcgqnnYS9UW?= =?us-ascii?Q?2z5YoJ4SUSkFHmyOvAEj0ZfVWSFtMuNyQ5nOMoKmZASiftzf3kYoApBGTUvd?= =?us-ascii?Q?Hqk6irb03TBdCx5dTVtgvlFKSW7vAnVKNwsehJAkI4qZJ96VPo/yc6kI/P/Q?= =?us-ascii?Q?JAB1G/VwGERnYBXDj7s9YMcTrIEB/dPFnQzbMWIe1J8OkopcIb63B4uO5rPt?= =?us-ascii?Q?VLvXQ+BWjltwKXijq/wMjlgCMk4PQEGPI9O6O0DRX7k7zZr6Z8NNZFkdUGC8?= =?us-ascii?Q?0YX7ELcaS5nyLl1UH/YFKfTb380sZN/JKvnIcrp1TwSCzZAnd1NR10B/4gju?= =?us-ascii?Q?78IYYnuazMHzQ9muh6pVYUdTVNYfIg3KBSROpRVx/eWI99jRhijQzTBKiQrp?= =?us-ascii?Q?6/ldu3wfN4e9OERX0JLFyvGVPpOq9Hh17ojRZmjLQblJwRkGvmZKKwA0BsrQ?= =?us-ascii?Q?HXwzsY1E1eGipdfu1+fkPXxcxf+IkK2Ny9CJn5fr5I6ePdZuBdgF3FrrIrYf?= =?us-ascii?Q?1n4fqaczjOXpVvDECP8b8CIubxSY4zHhblpt21zgHDd+VwNX1KIYTlLHAPJs?= =?us-ascii?Q?DPwUPJAvVmloxEZ7JvD5Nm1roxnn9jDOo5YFiCW6MvKwKHR9OVWyEs48rf0q?= =?us-ascii?Q?CvbZd/Ss9/I63Jxpby5Qz3RRr5y9hxJ3nls+wKeeQcM0e0ELH1hrxp7sJc0I?= =?us-ascii?Q?t0ES2gh1j9dXSJ5YwajFdURfYt45mhQp9zqTqTbI7oT+2MaXMVy0kSY50Y28?= =?us-ascii?Q?SeKF60qbQEgW0x7v6DEtWDl7GIguL/hqkfHp4cHYGQ1ZBv9B8Y/d7EBpWeJj?= =?us-ascii?Q?YgdG1eAZVov2WPoq3gXNX9DJmDsQuRrCoelT4s3zjonLLahYO0oQIc44ZVST?= =?us-ascii?Q?MUen80GKhESUH6e42bTclRaJiT1ep/tonK0rKyaZy16e4BJdDahYqARDBHEI?= =?us-ascii?Q?LAZxVxaQG8muC/oz+6EziGUVd1L6WSVgvN2CsMa3bDS+1fNzPy5DblIIM3t6?= =?us-ascii?Q?dzv+dDoOPHP/jjr+SksJ3OHsCz4C4HruH7hROxKl?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7890907-e372-4ac7-956e-08db4b7365ea X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 01:12:00.5671 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GNA1jSoT2ETGLkSJarzl13v0Lntg6f9A76+Z45UCMJz+BuMJUA0iKyE5wXkPcEmZE5DGE/ngRK38uxrlABDjSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5149 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang BTW, I don't see maintainers are CCed in the commit message. Not sure if th= is is acceptable as usually we can see who are the maintainers in the commi= t message (either in patch email or git commit history) instead of looking = at Cc in email. Abner > -----Original Message----- > From: Tinh Nguyen > Sent: Wednesday, May 3, 2023 1:40 AM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner > ; Tinh Nguyen > > Subject: [PATCH v2 1/3] MdePkg/IndustryStandard: Add definitions for IPMI > SSIF >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Specification reference: > https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i > pmi-second-gen-interface-spec-v2-rev1-1.html >=20 > Signed-off-by: Tinh Nguyen > --- > MdePkg/Include/IndustryStandard/IpmiSsif.h | 98 > ++++++++++++++++++++ > 1 file changed, 98 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiSsif.h > b/MdePkg/Include/IndustryStandard/IpmiSsif.h > new file mode 100644 > index 000000000000..a5bfa14a9dfa > --- /dev/null > +++ b/MdePkg/Include/IndustryStandard/IpmiSsif.h > @@ -0,0 +1,98 @@ > +/** @file > + IPMI SSIF Definitions > + > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Revision Reference: > + - IPMI Specification > + Version 2.0, Rev. 1.1 > + > + > +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ > ipmi > +-second-gen-interface-spec-v2-rev1-1.html > +**/ > + > +#ifndef IPMI_SSIF_H_ > +#define IPMI_SSIF_H_ > + > +/// > +/// Definitions for SMBUS Commands for SSIF /// Table 12 - Summary of > +SMBUS Commands for SSIF /// > + > +/// Write block > +#define IPMI_SSIF_SMBUS_CMD_SINGLE_PART_WRITE 0x02 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_WRITE_START 0x06 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_WRITE_MIDDLE 0x07 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_WRITE_END 0x08 > + > +/// Read block > +#define IPMI_SSIF_SMBUS_CMD_SINGLE_PART_READ 0x03 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_START 0x03 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_MIDDLE 0x09 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_END 0x09 > +#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_RETRY 0x0A > + > +/// > +/// Definitions for Multi-Part Read Transactions /// Section 12.5 /// > +#define IPMI_SSIF_MULTI_PART_READ_START_SIZE 0x1E > +#define IPMI_SSIF_MULTI_PART_READ_START_PATTERN1 0x00 #define > +IPMI_SSIF_MULTI_PART_READ_START_PATTERN2 0x01 > +#define IPMI_SSIF_MULTI_PART_READ_END_PATTERN 0xFF > + > +/// > +/// IPMI SSIF maximum message size > +/// > +#define IPMI_SSIF_INPUT_MESSAGE_SIZE_MAX 0xFF > +#define IPMI_SSIF_OUTPUT_MESSAGE_SIZE_MAX 0xFF > + > +/// > +/// IPMI SMBus system interface maximum packet size in byte /// #define > +IPMI_SSIF_MAXIMUM_PACKET_SIZE_IN_BYTES 0x20 > + > +typedef enum { > + IpmiSsifPacketStart =3D 0, > + IpmiSsifPacketMiddle, > + IpmiSsifPacketEnd, > + IpmiSsifPacketSingle, > + IpmiSsifPacketMax > +} IPMI_SSIF_PACKET_ATTRIBUTE; > + > +#pragma pack (1) > +/// > +/// IPMI SSIF Interface Request Format > +/// Section 12.2 and 12.3 > +/// > +typedef struct { > + UINT8 NetFunc; > + UINT8 Command; > +} IPMI_SSIF_REQUEST_HEADER; > + > +/// > +/// IPMI SSIF Interface Response Format /// Section 12.4 and 12.5 /// > +typedef struct { > + UINT8 StartPattern[2]; > + UINT8 NetFunc; > + UINT8 Command; > +} IPMI_SSIF_RESPONSE_PACKET_START; > + > +typedef struct { > + UINT8 BlockNumber; > +} IPMI_SSIF_RESPONSE_PACKET_MIDDLE; > + > +typedef struct { > + UINT8 EndPattern; > +} IPMI_SSIF_RESPONSE_PACKET_END; > + > +typedef struct { > + UINT8 NetFunc; > + UINT8 Command; > +} IPMI_SSIF_RESPONSE_SINGLE_PACKET; > + > +#pragma pack () > + > +#endif /* IPMI_SSIF_H_ */ > -- > 2.40.0