From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.70]) by mx.groups.io with SMTP id smtpd.web12.8468.1666106597144072266 for ; Tue, 18 Oct 2022 08:23:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=zGfgb5ZM; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.70, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DUqvdZCUjGgiSHNdi1RYWU6J5Golb2jrw6c7WEGXMVLs7cpjesy7jqGoavzeOgZmawh6RGJy92j5Tke2gucYoMgZXpG7kGkolV6Tw8UNtSUkNzhNd8aDavp8+WMd98E/soSEVfYz4ixDUR2xKiiAyWaY3TiERSiunTIOY5x3427ajDE7vDBfFpLX8w6xqWKGeFRMNtSReYjFmvivBnLVt0S1xaNko2I4TkqAyyI/wxcejiGBpzawiQMNnbc36u1OypuYmSnVTu0wydO5odZV+EmEsCYC2Tcpp0ducv/Hc5LN44NgNDYK3XIkGwL/tfu3M1XHO/TwvYk6ZaBmK3cUyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cqX3y3AM7Pd3WKlGlkyGLunLUhbNJxJ+IziWlDI1veQ=; b=FjurhD0B3jJyaaSc8r2ToMKBQr20epgiP8pAbPnNrfAUvQMUaHHsyPwyVTrYMWtrrV37bfW2jTA6lA010SaDV5xevc845BWo+OHTaMqtTin2/Gmq2V+Y4l92f1hwVWG0jXHkstKehvhP8D7TcZqZL56yYpnP0HVcL236IUg4/5VG6OyhayNthQHtCch17H22NoMCsCP2voeNS3V6TGcYvROdlkygbBQDC8lAa338efHdNhSpfeIJdeMFAM0Cmklqf0LGJUWPos/uZ9n/0oamVoidNDMVZHM0cd+RgsiWFV6cqLTmelB45pCKIz2VEx065z72u23lSakuUj5AcGYxWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqX3y3AM7Pd3WKlGlkyGLunLUhbNJxJ+IziWlDI1veQ=; b=zGfgb5ZMmouiXsnVbgPejt86zkWfbiNqrimBuXQmsdTK4rEbilPc1YKQCeRZjgj2QIdYXNBLw1dlkSbZBs4ymnMB1Wqn9UEquekM66gtaDHjLsNHQLDQFt5/+wBOP1VtlnFlU3eR58RK1kIW1HYrgnGe10um0SusMD2lUtu4A2k= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH2PR12MB4118.namprd12.prod.outlook.com (2603:10b6:610:a4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct 2022 15:23:14 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88%3]) with mapi id 15.20.5723.034; Tue, 18 Oct 2022 15:23:14 +0000 From: "Chang, Abner" To: Sunil V L CC: "devel@edk2.groups.io" , Ray Ni , Michael D Kinney , "Attar, AbdulLateef (Abdul Lateef)" , Leif Lindholm Subject: Re: [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Topic: [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Index: AQHY4vZHa4HulFQXCEG2FJqF5iGZdq4URNwQ Date: Tue, 18 Oct 2022 15:23:14 +0000 Message-ID: References: <20221015114757.383-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-18T15:23:11Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ec9ec53d-f7e2-44b1-9dd7-72556aaaaaba; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH2PR12MB4118:EE_ x-ms-office365-filtering-correlation-id: 14bb085d-ffdb-4ce5-c83f-08dab11cacd7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nWpnu6IbxkHxaOTzr9QXqETeZkq9OqVua4jMXhUGX/z5B26B6epVnF0OBueXAAUpludUu5ohVmKlORdS6wZw4Pu+FThDvDEJON4Pm7cAbRPhFJW0tM/zd5anU+1aV1uGO/+lzrXj3dX5seTXObiq2V7+D1XpTgl2KtYFrk2g1wi18zCX0R6NTn7UeJV92nM/gzAaVckr+hPcXp3QezQdGjjGszaDd/piAX69aR+6CpNdwGiBCYUyZREDVgR0u7UkXQi/S7rNcLDmNo/q4OK7RwnJ1u0z2okkftBfpSBUSaFUWXxBbyPYGM8/iW7DxkENhi/5wmAufV/l2LluoFvr8BzTTr0WZgzmY1YM7aHjdVFlIfH9CRpRLRZ0469IP85eJQIxMsbaMieCpF/mS0Orj1QxlZgXRAlCAUVTESSuXE6Qt29aExsAOeYc91CcNUaqxwiwRKOTUZy+jog2FLQI37ncMWHmYLqsQ8fp0RefSuPJXtJTDgzQExADG5l9AnRs7Ft/LOKzgAEqm5KfiLQwz9yFLk2y7w1Z/AoAM5lkReYW5D3Yz4gipTAvAx03sNtpBLJoocJlpJz4fi56VeBUYdV3YLuR4ctxMzwfbxuINtxKF/9qzrFuOmFSu5+4u07HpoiX3nAMDkdIREbAtxl1OvUCHP4MBNHNi14bYWvbcFSeUW/HHqnE6m02qoxt4vSjOp+oQO1byZhcOKohE6/lC7fsYjET+aOetvGRD6Cm15equrRAAg9ZpNJ3FXwO+Ywnwc+u61CN1f8s3D6WinpacG2Eb70CtEdAeLNR5Qc9Orc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(376002)(396003)(136003)(346002)(451199015)(38070700005)(38100700002)(122000001)(966005)(478600001)(45080400002)(9686003)(15650500001)(33656002)(6506007)(7696005)(4326008)(54906003)(316002)(186003)(6916009)(76116006)(66946007)(66556008)(64756008)(66476007)(66446008)(8676002)(55016003)(71200400001)(53546011)(5660300002)(2906002)(26005)(8936002)(86362001)(52536014)(83380400001)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mld572BxUylxgDRobaDBDr/2R++p9dNjxwVovflATab3cGBJ01QaG3WGOqm2?= =?us-ascii?Q?dE5TLwTht2UfKAQAJ2fQtOymSe5GpXDux2C3LunJh7JJ29weDGhzHQ68snQ8?= =?us-ascii?Q?4X0ap6ssXKaEp3Zik5WjrMtYz9l56tTk5I+ncPs+HtkNdXo3S+0300IqzqOq?= =?us-ascii?Q?RcVJI51Bb+Z6JAyfNwU6fCDYiyOY9Yxd2HSjoMXGueQSkwr9MxDZeRPxwIqN?= =?us-ascii?Q?pudBSWxuVzOQQodZBZxZwKSC/h/Nrgc+WLFiYtwjdkAGbW59omzg9WSnm5iI?= =?us-ascii?Q?CYqpbDe3npFjJ+QutI741jN6SeLQ5j9yrvwiTbmyGoij8lKMLZOVRwZkGeAK?= =?us-ascii?Q?x7PLU3Wiujahp4k7iui7jb1EQsJCcP++HuK0JZ1PDAl4/6FcDoNHeRciHOBN?= =?us-ascii?Q?er+CR0LdGthXIJik3rw95lhe/X1tk1ik2g1EN7O9WP9u5F4IgSI7Rj/Df4wx?= =?us-ascii?Q?etS5yUvNraaGI6AJ7UpxRyI/piCmI6mtLzKBC/+f/Y06K3KBJ1ak0YiF4ERB?= =?us-ascii?Q?EJ2UTCvwUmLsckqItW91EAP9V1dsfPbPbcVSJUN8EUDsXs0hqqFc7bNrELMB?= =?us-ascii?Q?smW0SWEwMTd1/7IU0Vphpp0JsG7Q5JIK4NZNEACC5VaUIxgI36xdmGIAnhcm?= =?us-ascii?Q?nhkpEJE8ryRG4nOR+tfGShtIhKcnoNipqRBknzMr3/p+NIpk/LSG0iqChcdN?= =?us-ascii?Q?itzRoNtaWL//wMOTP/Ab+r+kmR1MPkTzb8klLqPahKRIrypaFKMOAhThKXhJ?= =?us-ascii?Q?+fSyTp+rE/q5M76CnyGrvGXI6ujm6000PvGfmxEKNYNff60Y2YsJk73Ftl/4?= =?us-ascii?Q?OHnQ4YgoZbx0yISnA2PDxPPRB95NJ9kIs55ag7MigJQxl2KbGrcQ+xtWETUM?= =?us-ascii?Q?8YTVK++uQ9Z8/fzkXTFlbPRutfva7ohLsQDW0mfTdgWg9QvV5bo4zLvKerZO?= =?us-ascii?Q?jRV0E0XXLIoPG+4EWhDH496BGsip54WvhH0XVE3tPPY0mJeXDBMwZtag31uW?= =?us-ascii?Q?JJ+/OylwXsU9nJ4DmbVVlKvvrjv+2upBn/6rGyqkxP7zGTTv17RQg2XhWWVh?= =?us-ascii?Q?l44cgDF6UW93OIsHC6AjAraql+Nvh4Y1v4YyBneIS6CiNlrmrXPczwhP+3af?= =?us-ascii?Q?kiNfMEM6oO9lxax8dzWNOdlaUPjr8x53WRij6EB7dkKCzs4cbD6M3Hg1i9xM?= =?us-ascii?Q?3GeYFHoNocNCdJMDUHFSBV+RXfF5+WJbTtx4no1RzR9z+QogPxFHLvefGgA9?= =?us-ascii?Q?3UayXFTR8rjRiQP05M1TtwumI9bJCKZqOllGbBfdfkjFAyqkehtBRRaai2hA?= =?us-ascii?Q?P8gOZCGGWxKF2sZ1zMbX2tVimXU67cYI7xQ0Dxui9J814SCjNWZbb9vmtTmf?= =?us-ascii?Q?6BB3V/U7lKB+zKz1qgW1lI1OdsZXS3tjtQ1eZkC9dUpk9JU0YFPFZ8pK7qfA?= =?us-ascii?Q?2+fJIpjycckrsrEwayJZu4FLjvCouLaZTXc8lZ0ObpFadbG+fL+xOsU+SPzM?= =?us-ascii?Q?jIK+ZbMgM3LQ+c550AjgzM/mUCdc1K1uP0GlbEPHDk/JDcgu6RBoF0JHvRKF?= =?us-ascii?Q?ccp7LNjcrlK4ksXT97Js4LqpJXjyy5gP6gcjMY+X?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14bb085d-ffdb-4ce5-c83f-08dab11cacd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 15:23:14.2901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kE68PvePK5YbrkOgSDU84CJobcugIFKglD2fUk0KaulmlD7fiJwZZZKDqXabReXuqrg+4yZ+rSqq7hTY4K+Gkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4118 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Just fixed they all. Will send out the next version. Thanks Sunil. Abner > -----Original Message----- > From: Sunil V L > Sent: Tuesday, October 18, 2022 9:34 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Ray Ni ; Michael D Kinney > ; Attar, AbdulLateef (Abdul Lateef) > ; Leif Lindholm > Subject: Re: [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: > Updates 4.2 and 4.3 sections >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Hi Abner, >=20 > Just few minor comments below. Otherwise, >=20 > Acked-by: Sunil V L >=20 >=20 > On Sat, Oct 15, 2022 at 07:47:57PM +0800, abner.chang@amd.com wrote: > > From: Abner Chang > > > > Updates 4.2 Directory names and 4.3 file names for the guidelines of > > module directory and file naming. > > > > PR: > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > > ub.com%2Ftianocore-docs%2Fedk2- > CCodingStandardsSpecification%2Fpull%2F > > > 2%2Ffiles&data=3D05%7C01%7Cabner.chang%40amd.com%7C61ac30c1dc > 764eb57 > > > cd708dab10d67d2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 > 38016968 > > > 393253054%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > oiV2luMzIi > > > LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D4OFcJ > qJ%2FNVV > > KwYFDxe%2BASxPZGmMj8VchZE1%2BLF03LXQ%3D&reserved=3D0 > > > > Signed-off-by: Abner Chang > > Cc: Ray Ni > > Cc: Michael D Kinney > > Cc: Sunil V L > > Cc: Abdul Lateef Attar > > Cc: Leif Lindholm > > --- > > 4_naming_conventions/42_directory_names.md | 101 > +++++++++++++++++++ > > 4_naming_conventions/43_file_names.md | 108 > ++++++++++++++++++++- > > 2 files changed, 208 insertions(+), 1 deletion(-) > > > > diff --git a/4_naming_conventions/42_directory_names.md > > b/4_naming_conventions/42_directory_names.md > > index 766ccb1..959a3c9 100644 > > --- a/4_naming_conventions/42_directory_names.md > > +++ b/4_naming_conventions/42_directory_names.md > > @@ -2,6 +2,7 @@ > > 4.2 Directory Names > > > > Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > > reserved.
> > + Copyright (c) 2022, Intel Corporation. All rights reserved.
> > > > Redistribution and use in source (original document form) and 'compi= led' > > forms (converted to PDF, epub, HTML and other formats) with or > > without @@ -28,3 +29,103 @@ > > ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > > > --> > > + > > +## 4.2 Directory Names > > +Below sections are the directory naming guidelines for EDK II > > +modules. The guidelines are not just considering the the uniformity > > +of directory naming, but it also provides the flexibility of > ^ An extra "the". >=20 > "it also provides" -> "they also provide" ? >=20 > > +directory name construction for the scenario of different EDK II > > +module designs; such as the support for multiple processor > > +architectures and vendors. It may require the further discussions >=20 > "the further" -> further >=20 > > +between EDK II maintainers and contributors in order to determine the > > +best naming of the EDK II > ^ remove "in order" ? > > +module directory. > > + > > +#### 4.2.1 EDKII package directory > > + > > +``` > > +Pkg > > + > > + REQUIRED * > > +``` > > + > > +#### 4.2.2 EDKII Module directory > > + > > +* The guideline below is applied to all CPU architectures support, spe= cific > CPU architecture and vendors support, or the implementation is shared by > certain CPU archs: >=20 > Better to use architectures instead of "archs" ? >=20 > Thanks > Sunil