From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.75]) by mx.groups.io with SMTP id smtpd.web11.160128.1673848016751867458 for ; Sun, 15 Jan 2023 21:46:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=B91mxZBo; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.75, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oo/PIRDEo+hsuDi8v/5TMq4MeP5DVPN0RlrIYZuGh1XXwOOGPW6ssVfaBXX8EpzEhPbI39op15VMiNcL1arz4P6xmNIM15h6xtNR9BDPdwtG7L+/eifI/ft/E9ZaPqVywPotKXvEByiJ0oSAxrLvpue9KKs9EmkltZ1F6kh9J3mpmKvfFUSe2JjGQJVbLSoyQYz69uEPf/QygL35nJmY1XDvi2tXBYgFImLSOdS+VxoF2BTHMeXKaacczgeyh9NYO6CXOhv9cXrehHeP22SsBwMX4tDW2pEJaSX0M8PxhRwL/e6JI7FtVNfpvA4YHk8P4lG5E9oCqKHQYYaxqx0/sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3cd4rZfuq6vJrRTlULtp8FK+t1IQo10AP19SYbN3UhY=; b=WYe6eQnj8Bovqt3tWkZKvByH9OD8DsV3wgBf+2SkNxNHoeX2RUxVpeFJZriJ2NFpG4Tfkj56c2uwKsWAqRueSWCWFleIxRwaZtUAgLIk0ejs2pZGNc745gbH5NDC1JExMMM8wq36cSGv0+hK7gQ1wack9MpbpQxul3J/VXcJDd+3ZLUj/p36kM0houLxGOmVZyQe2zMvSgpLb8PDi1tufKOFhBwzJZMlFSg1IyPmd977LpwIM4Gq48Q7bpMlIaosqjW0BGfJ0qvfiZMpiEXRWsZYQQK0byqx+tyAO5XAvMUaJYWZN+gd6cwP4yDo/NHzIDrkkZkLzoI0BtOzF+MqgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3cd4rZfuq6vJrRTlULtp8FK+t1IQo10AP19SYbN3UhY=; b=B91mxZBoZHKo52pI0sG+Phc8YURMjwEIak3Bw0zBN3RzJGgE38da70kMvBfjb7hvvAqrq9uxgS2r26SYceTFT9InvXtCnVdj9qxM7ygFzFFSom1PpgB4Ye5zLLnSCL+UUwDO0wkxeN5fpxPhh84G/5vCvDJDQJsd8Tchm/FWmaM= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DS0PR12MB7897.namprd12.prod.outlook.com (2603:10b6:8:146::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Mon, 16 Jan 2023 05:46:54 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5986.022; Mon, 16 Jan 2023 05:46:54 +0000 From: "Chang, Abner" To: "Ni, Ray" , "devel@edk2.groups.io" , "Wu, Jiaxin" CC: "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE Thread-Topic: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE Thread-Index: AQHZJ2QdUZ0bWZxIs024HNKuJGnk8a6ghelwgAAEzYCAAAHrAA== Date: Mon, 16 Jan 2023 05:46:54 +0000 Message-ID: References: <20230113153045.13060-1-jiaxin.wu@intel.com> <20230113153045.13060-4-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-16T05:46:51Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=03ea876e-0937-4a72-bb78-d3b1ed64de92; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DS0PR12MB7897:EE_ x-ms-office365-filtering-correlation-id: dc4cb912-0456-42e6-c04a-08daf785129a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YxdG9DnrUnba4T7UZNPLikxC7sC3mOS5D0YE9nckiXosGWpCkYJZJTUiwCCozQe4VlatA2gDzzfcmZW8jpoxz+v5RdVrpj/dTYGTepBHXxjFWP+X9OA5nF3Eb0DKUZgSq+uVCeLGao4YUnZ0VcyNla9tVAyYLnXqN+tQOknBIM/gCACclv7qfck7R5vOcTN19A3n61LN86RHg+2FyZftxugFAAhj9q07UZQp0rIbJ/Ss/TTZfvikMm2LRznsZW4cq9OdSmxhUnPCtSSCwY9PWdMBFMQjhx9tNCiUqFytUpmJoOwHLERj53ul5IJphzWbjjaa96alajxdTuT6W0yzk5GA1nyiOHqCY3pM2t6zq1fg6Uk9HjLVbxtOcuXxiOdKpjmdVi6QOZbkUDJGlAWvfgg4cOoEdsAqmZALaaDX0Pm72CaK44JCBHzXSmcNNMyAANBRQHtgpIFv+O/UQ7+Reoh/ujg72LvUuGZrpbcsCR3XdikwIrkv8lFKb3HQGRu3NKqoMBtBvfb0j28w6eBnv9HWtO+dZxQ7JXtGQl/ciaUfkMwaGynnJcOh6NIGBvL2hLMfmfeivN3EbJY9X5DhGWc4wBSVCeSf8euxjSxQ5LTqjc9HnOnBJ8nO3EWlETM+I2FUjYr5z5UHJlLjKe69K+t/bhcaKDfVVdsXMvw3obpdrHVbCYFgVR2wl9Ioe+ugt4OaSlKcb68xfBzGCi2EZEtvfZAaWEwkO5lUafMX2T2XRk+f0K3R5T+t5w69N7Hz x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(6506007)(9686003)(26005)(53546011)(186003)(71200400001)(122000001)(7696005)(64756008)(38100700002)(478600001)(38070700005)(86362001)(55016003)(83380400001)(33656002)(52536014)(8936002)(5660300002)(66556008)(66946007)(76116006)(316002)(2906002)(8676002)(66476007)(66446008)(110136005)(4326008)(54906003)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2VN/d8SzX3ytQRNsWE8hE3VwYzU+6fs0JchsfP1OSvWIiEFlbnbyHJe3XX0N?= =?us-ascii?Q?OlOV6Lwc+ZE2AnCrUx1FdGzMKcS7fqCf3Nr6RVxIqS18vLEOZsXpzIrONsIy?= =?us-ascii?Q?yZ41bC4LXKx204Nb+Jkal6z8wiiZmUgIC7sQan2qKWM6imTiCbjaF2Qgv4Ju?= =?us-ascii?Q?/HT8WW3eyjcIGD+uJyPkWPwVfaNLc4Vn98Fax8zVJssTXYTYZHohKJZjVv/U?= =?us-ascii?Q?CseWM8mxGywNuW4q5w6uqcO0/Oiux69OMQSMWCrTofJOslmrxo8m6PQvT+nT?= =?us-ascii?Q?TesWN6XdI+Upq/VYDTJiy1DAApEYp8J6FhFmwl0LLUzWk3sYUs26yrXzSRdV?= =?us-ascii?Q?FdxuZ0d8QTXVB5zNWbwQX7IYOg9WspxrV1tV/CAj3RE8RPtMtpBexyR8NMbt?= =?us-ascii?Q?X3GxVRZ9XTxDtupJXm//WEpFUOjIKeMyIgKJ9VUR+5rdqSo1+NwIPYZZsTor?= =?us-ascii?Q?1U0eU2Zc+N1cVtCgfUsN49b0aYkSwbgaYxWD/RIK65NfprXA66m3ocn1U0LE?= =?us-ascii?Q?4yU9XQwzWu9CGQ1cNSciSuirYHdwXGLszPJJxLvotVKbF0VyAdKXpN5OvISI?= =?us-ascii?Q?/qRRkEu2gTSn7IW6NoInvxhgm0ThzYhG+ht3bEo19X1K0QUr6zPfAPmJw0Np?= =?us-ascii?Q?ycXCbokLn8ve1acl+Izd9BUYbb5eyWJr1H3gmwOCvlkG98TQPXbIpbVn4Nsi?= =?us-ascii?Q?NK5HVrqQQ9Wtyf9AK6GcCSvw/43dR82DzZ0AvZFckmKzX44jVaDF5rjNF6/3?= =?us-ascii?Q?CHt2XixbHx0mGG7ubZRv82yZF5JWj/TO6ViBpXi1Wpbuj327pe8elUaAK6wB?= =?us-ascii?Q?hLq4R+sM787z+G0B6pd9LTdvxIRYgocNMArf42w5qyvsrMPcB0kPGACXV0p4?= =?us-ascii?Q?VwVQFM/MidtsEwujwBBad+PZeeBomUklkamOa55nTjwGwh8ndvIpyzyHtXX5?= =?us-ascii?Q?sFb5Sr+GQm/8Hwr69uwWG5eOSMUXI9U8o6d9RMx3aqKRn4pjGxLMIBSWxeq5?= =?us-ascii?Q?yvwLZiZpT6d2PVVq1HGYs6Ul+GX5XeYgItAtuDbj1mpKvw1Rsd0Gd2EPdbAf?= =?us-ascii?Q?kIOnT7YqrmW9odAbhxoq2NXiqzELcfR/a3JUkoe1yRTY7rxKu/PWAcUcPmUW?= =?us-ascii?Q?DLPnqZ+k0kKcP8iKIrui8CheLUcfUXg9/mB6iFo/rwEe5NpX2uyOQi+piCgz?= =?us-ascii?Q?8PUn/wjXE4veVP8dI6XqoBJre5tw4K/2loU6XClQf6+BkaJMUs6plw5hiNXm?= =?us-ascii?Q?OkgwlAPzlp/b0wSGHZCGmJ3g9Xlyk/oPHIfcknRZIH3gff1XvK6OZboVOiDw?= =?us-ascii?Q?FVjPBaLPOH7oPhQUlnu7HiwZB/V74HAyl2dgUWMZDfuqpaZhitvttViOZ0KG?= =?us-ascii?Q?qv5hedPsBFi5otOJzPG7It7evM+2a/jKLwncHv9OWCAiqWr4FLbLgMjJEgBJ?= =?us-ascii?Q?TKCPksvH7O88zh8ia0Mv4hQ3Oak+3nvGSm7sWUygcyflycUPfIVXD2zO07U3?= =?us-ascii?Q?wHZ+P8GDU5K5KmJylWLojBiOjOFdRwMA2VGvKX/TUdHpdUQvPCXV7x4k3Ueh?= =?us-ascii?Q?ldWH1F7RdQay0o9LKQFdGRUb2tmB/3KveotfJL/X?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc4cb912-0456-42e6-c04a-08daf785129a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 05:46:54.1032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WJT0L/NgrgUnXXzHQs0M8Lh6oajAi6Sw1z0vNE/oLZgSSqtw/xGe06YM7T1c/CNghIzJ31DtjlQQVzmDZX9RZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7897 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] > -----Original Message----- > From: Ni, Ray > Sent: Monday, January 16, 2023 1:38 PM > To: devel@edk2.groups.io; Chang, Abner ; Wu, > Jiaxin > Cc: Dong, Eric ; Zeng, Star ; > Laszlo Ersek ; Gerd Hoffmann ; > Kumar, Rahul R > Subject: RE: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: > Skip to configure SMBASE >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > > > + // > > > + // If gSmmBaseHobGuid found, means SmBase info has been relocated > > > and > > > + recorded // in the SmBase array. > > > + // > > > + mSmmCpuFeaturesSmmRelocated =3D (BOOLEAN)(GetFirstGuidHob > > > + (&gSmmBaseHobGuid) !=3D NULL); > > We can have this code and mSmmCpuFeaturesSmmRelocated in the > > SmmCpuFeaturesLibConstructor so this mechanism can be leverage by > other vendors. >=20 > Abner, > I guess you found this logic is useful in AMD flow. > Let's keep the current change as is and you could refactor the code later= to > present a full picture how AMD flow is like. This is also fine to me. Thanks Abner >=20 > Thanks, > Ray