From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3D6F29410E6 for ; Tue, 31 Oct 2023 06:52:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oso/jE7X73n5KvwKtFve+Gr2vLBvDVKZxVh6BGArRYg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698735158; v=1; b=WiO1K16IDedzIPv/nw2+w+ezNLHEJnYbp2dastz8iKWZCHBOxtfUDdOhV2IwC0zoO3U4LkxM vg7RrqGrNVUTsFLSHuQUm1O257zyDqL2OGiy76v+n+HaVGWuRFtEofujL2MAP0xq9b4kVHRla5w I8AZHEugLF9EZI9p0eTCjjnY= X-Received: by 127.0.0.2 with SMTP id cxbAYY7687511xzSGEvhTsP5; Mon, 30 Oct 2023 23:52:38 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.62]) by mx.groups.io with SMTP id smtpd.web11.181011.1698735157700154647 for ; Mon, 30 Oct 2023 23:52:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3hh1k8lglcD0k4+OLA57O+9EZ/FOBanUk/+l0gH3YVI+K3CkPDA8IfPVk34QDhuqGtCHpQyeU1vDI5gWyroHAXckb+I6DxSGNojR6Fd+J8JA/p6V8D4xhjhUfwGigxABNU/kCiNBEhVAEtn3m1kdDPZuBQiBoU+EvVh8M0SYuDMUUX9yoacBvcvem/TJ7hdFyL+LQJuBLDu39KZZ00ECqsj4Hvl3CqpHjwriyFQo8atz81ab86kts31n9wTc7e9Y83ut+RN8YmTT3q7fxRMNC+sRFXKWwf4UZVxnVMcdrVFFTUR107TlVCUgwGJ9tIN/d6fBKjzEwpqqWisC7j/8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X9YOuTdhs7NE3Ye/aUS+947Tdl8ta7W19Uqxa2Uusps=; b=f1uJXwroV4ZcsUKmz/SscyhviyaOBi9I6NoTOn0WnFmyoyQhBs/3KDLCD4Jd6JzaSguP5x4v1cTzm1b9yXpc+EM46IOwj2z6vH4UCw5XTX0b5E3RmNBtY6K4JtkwCCvMEMyMJbBnAlnw09tmSeVetdh+vYyMffFY4zLtt5Q7gmtYnkaqrNF2XxyEaKqEZZDUzHLeYnA4sfaDovNqiP8JLbksCI4gdH2XZHKp5scG4N5ACWMheYyUFtEAQlB+HuBde0KG6crdJg1xDRfH3PY5tiJ+v1o+FuK9pGjHot7o43JiB7ZfNXptG+Hv0OYyqrZVcnCIHSPpkYbOWElnnEGvLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL0PR12MB5010.namprd12.prod.outlook.com (2603:10b6:208:17c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Tue, 31 Oct 2023 06:52:33 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.029; Tue, 31 Oct 2023 06:52:33 +0000 From: "Chang, Abner via groups.io" To: Lixia Huang , "devel@edk2.groups.io" CC: Nate DeSimone Subject: Re: [edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaC8LVu+X7klR89U2ItMurt8TONLBjdcrg Date: Tue, 31 Oct 2023 06:52:32 +0000 Message-ID: References: <20231031062338.1501-1-lisa.huang@intel.com> In-Reply-To: <20231031062338.1501-1-lisa.huang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=87aefbbc-6af5-4d70-be03-038165b24554;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-31T06:51:20Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL0PR12MB5010:EE_ x-ms-office365-filtering-correlation-id: 4cebd11b-58cd-4a8c-e394-08dbd9ddf51c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: cZjqcIbzL3lusoVzcbZf5mMVO+aCwYOih2JohUVEkkhwKRJFtb5O6tS3h7SrvNWEFab0pmWrYXFgiKw/h0h8mLd2rICCX5KNLiNar6Bdx3jASDoVSUKfSeLQdCurAjTzQsLWzoJyfhAvEW1RhVZb/coFD5E+nJQuzqt/eJ9Dmc4FblWVSk4H4zxKFK6rkaCxowSbpEQ8HhFOdJkOxrnmvQJiWVVgEajbjvOVHQo025aPePm8uqEJbW6kOvpNe+lvWocqpqoQMapCnHLm6pczR/ggm7VF57gh/aDy1lVJkE5WGAbcoZfe5RoBqQn8ibanfxNYhtOoIFHAuIErqKkkuOZZBM748JKG8qB7TMTKbxIdQ+C6dLPp3mNAB1lheC4ar+O5gmgNNxwZ1eXvkYxNdfbEvemD4+iJyCsu16DuTk6Yd1dqfkICTm9RPvIa4Vc7ORHzBOPxgiOv3z8XA9nMwhjdNVVIuE21G2Tzu7oJpLmRn0LPFhYBu7RTlhsRC0L/q8OJ/mYZ8HXUl1DJyPRo0eBs6B1O7PhBsvpYfUwtaYsaw61Up0wJ16HJchcuo/bEBf2kH0QYWjlFFC54HuDIIBWHviIt5MCZciIG9+VMvTjsI4UZnjtgRT75a+c+oWXLDtYQCfiBzWHfhTamLnD2DCDkeX9q2yzSOf8/4KlzItQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+3dhdXAb5SzwASNjaYcOjqOaq4eaT9lw/IDdcgTWhcR62CL7DsvDHaVglWHz?= =?us-ascii?Q?Rw6s3bdfdhatPLzWFzBPn0vOaY3smOlEeM4YeeVHo/hmnuvi2x0tEzo5yEbQ?= =?us-ascii?Q?5b3ODaY8oaeL6o26ZjlJtoLwSIAvJ/Tl8P4VcicJBuUH0VvwVb3b1NQmt+jk?= =?us-ascii?Q?Tyt6muqrSJ/3le7R/5rGS5rhqWDAgSyv3VwsgKD+iD42XhJ6ohssgjBBWJMs?= =?us-ascii?Q?wRSiXrDzyYd8b0CVYZLylYIDQnmiQiVH22JVuFt52BH8NdqSorwK4adTpw0v?= =?us-ascii?Q?TIqCX7nySGrdlsiepoXFAj8PGmgmBz151R4VQ/1dK9+53bzb/ZJmr0mEReW+?= =?us-ascii?Q?mEGE9fLa4jF0r3kDqfLloemNn4+NTj+gQ68eXl8DmgM7LW13BVUp/0OlxDvT?= =?us-ascii?Q?a0jU2tK2AAFWzSBRZqAg5pcxgCi4HoWIn+pC1UkPKHFPiZs7FLusvW8EBPt7?= =?us-ascii?Q?vy0FKu/nRmGY4xqgnB4/qk5S8bLBut0oF1F71OknI7sTd6Lkh0762rcwIlFR?= =?us-ascii?Q?BGDgLQq1uVUeBS7uSLg40dTATt8nejdPtQWiv4/nkj4LRQKM0KkYvvvl7Mns?= =?us-ascii?Q?csaVDYXtBtOFDXfmrQHast5Qv2D75ruohJ7yRz+CbWIpkYS5BanF0JfZtjdO?= =?us-ascii?Q?iC2w2ux65go5EEnqFnpFSVLzAbX2K5SWz7MP9lTdH2Mqe6ZCvetLbZpIfryf?= =?us-ascii?Q?iMPjmPbNzVnnZzcnh9J4h6E6v9q4PAX4TzwnJzlG21k85laegYPfYqFQddGy?= =?us-ascii?Q?kDFraSnHVMf8q/SpdF2YmfphiSXu+kQOT1An03vrkeJ/GyMjsODCTvZSvSiO?= =?us-ascii?Q?efNLNHaaa1KqjIwFIa3fmQG9tp91PF6eCmnXXb54ctBALKJHkim73t/To9ce?= =?us-ascii?Q?ea/33/XEP+Eq+GvHMHZn+IjOYDNlBuGfFnwejVKSyeVDflZc7OcOClbJoouC?= =?us-ascii?Q?pd5I2esTXMjVovZOuQQ6mooBlVjIE3doRdoLb5LqQSzuxwJsM4mtWCkVmdTC?= =?us-ascii?Q?nz4XdAacPigUZHDWvBJ+Alt3KoWZLjn8YbZOiW02OWurkqZI5rdLjTFyhKGr?= =?us-ascii?Q?pDEzdyTjIcbtlLeb4tzU2kkqTYjTcuW+H5+US5sNBp3vN7ynrTS6n7OxV77x?= =?us-ascii?Q?mDMpShfNUzCampwFgOTvTnFlBUg4HDpK8D43y3gJ/nGOt+7NQtX9b0+EaDJN?= =?us-ascii?Q?znjytLBtO/dZ4O41ijRtt7MX4l14y5f6VG1Lb41SpXIlifdILzzaEnE3jmOI?= =?us-ascii?Q?bnPaF6tfmSCo+aKZS66/T1UchGk91lNLCVHZGvDx8FS3wFEiazX/MRhXG0wP?= =?us-ascii?Q?difHWtgEpl5Ir3RHL+aTmK4SYuCAsRJKSYEL44Mcbe2yLbzqeeI667fVDGdU?= =?us-ascii?Q?Jy+4wwDm0RyHN1aOswHapIoROa0PGIVOuhboGzn1Z9r/AbTDrq12nJSbHpJs?= =?us-ascii?Q?B+jE1TzYpnpwecx+AwiwbWSajdOXb94B3G533W58QHlj7CqHWs77uzPpn9AK?= =?us-ascii?Q?jgeuzGnCDTczAuTFcCYz/lPq/B0n2ocIPqdfu398mHrra6XFYFwvsB/kTH0+?= =?us-ascii?Q?Bl/2/WoD10hXGqeS9YrHxduNSww48RFt79l+tyzU?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cebd11b-58cd-4a8c-e394-08dbd9ddf51c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2023 06:52:32.5741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cmTu1QiQkYVJSys/wDVsJydHkisfApW7FiO8iRopYILfgXb1ir+sMR3IXEqVTUWrsoeMcaqOrVJSX8/NzBloHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5010 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lgBidvEp4GEMeAZSE8ftsIRIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WiO1K16I; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang I can help to merge this change if maintainer or review have no problem wit= h it, as I am not any of those. Abner > -----Original Message----- > From: Lixia Huang > Sent: Tuesday, October 31, 2023 2:24 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nate DeSimone > > Subject: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone > MM > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > Cc: Abner Chang > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 146 ++++++++++++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 51 +++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 199 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..d808e2517c99 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,146 @@ > +/** @file > + Generic StandaloneMm IPMI stack driver > + > + Copyright 2023 Intel Corporation.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +// > +// Statements that include other files > +// > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "IpmiHooks.h" > +#include "IpmiBmcCommon.h" > +#include "IpmiBmc.h" > + > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > +EFI_HANDLE mHandle; > + > +/** > +Routine Description: > + Setup and initialize the BMC for the SMM phase. In order to verify th= e BMC > is functioning > + as expected, the BMC Selftest is performed. The results are then chec= ked > and any errors are > + reported to the error manager. Errors are collected throughout this r= outine > and reported > + just prior to installing the driver. If there are more errors than > MAX_SOFT_COUNT, then they > + will be ignored. > + > +Arguments: > + ImageHandle - Handle of this driver image > + SystemTable - Table containing standard EFI services > + > +Returns: > + EFI_SUCCESS - Successful driver initialization > + > +**/ > +EFI_STATUS > +SmmInitializeIpmiKcsPhysicalLayer ( > + VOID > + ) > +{ > + EFI_STATUS Status; > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > + > + Status =3D gMmst->MmAllocatePool ( > + EfiRuntimeServicesData, > + sizeof (IPMI_BMC_INSTANCE_DATA), > + (VOID **)&mIpmiInstance); > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > + return Status; > + } else { > + > + // > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > + // > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > KCS_DELAY_UNIT; > + > + // > + // Initialize IPMI IO Base, we still use SMS IO base to get device I= D and > Seltest result since SMM IF may have different cmds supported > + // > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > + > + mHandle =3D NULL; > + Status =3D gMmst->MmInstallProtocolInterface ( > + &mHandle, > + &gSmmIpmiTransportProtocolGuid, > + EFI_NATIVE_INTERFACE, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > + > + return EFI_SUCCESS; > + } > +} > + > +/** > + The module Entry Point of driver. > + > + @param[in] ImageHandle The firmware allocated handle for the EFI > image. > + @param[in] SystemTable A pointer to the MM System Table. > + > + @retval EFI_SUCCESS The entry point is executed successfully. > + @retval Other Some error occurs when executing this entry poi= nt. > + > +**/ > +EFI_STATUS > +InitializeGenericIpmiStandaloneMm ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_MM_SYSTEM_TABLE *SystemTable > + ) > +{ > + SmmInitializeIpmiKcsPhysicalLayer (); > + return EFI_SUCCESS; > +} > + > +/** > + Unloads an image. > + > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > + > + @retval EFI_SUCCESS The image has been unloaded. > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > + > +**/ > +EFI_STATUS > +EFIAPI > +GenericIpmiStandaloneMmUnload ( > + IN EFI_HANDLE ImageHandle > + ) > +{ > + EFI_STATUS Status; > + > + Status =3D EFI_SUCCESS; > + if (mIpmiInstance !=3D NULL) { > + if (mHandle !=3D NULL) { > + Status =3D gMmst->MmUninstallProtocolInterface ( > + mHandle, > + &gSmmIpmiTransportProtocolGuid, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + } > + gMmst->MmFreePool (mIpmiInstance); > + } > + > + return Status; > +} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..170e0a8d136b > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,51 @@ > +## @file > +# StandaloneMm Generic IPMI SMM Driver. > +# > +# Copyright 2023 Intel Corporation.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D StandaloneMmGenericIpmi > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > + MODULE_TYPE =3D MM_STANDALONE > + VERSION_STRING =3D 1.0 > + PI_SPECIFICATION_VERSION =3D 0x00010032 > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > + > +[Sources] > + ../Common/IpmiHooks.h > + ../Common/IpmiHooks.c > + ../Common/IpmiBmcCommon.h > + ../Common/KcsBmc.c > + ../Common/KcsBmc.h > + ../Common/IpmiBmc.c > + ../Common/IpmiBmc.h > + StandaloneMmGenericIpmi.c > + > +[Packages] > + MdePkg/MdePkg.dec > + IpmiFeaturePkg/IpmiFeaturePkg.dec > + > +[LibraryClasses] > + MemoryAllocationLib > + BaseLib > + MmServicesTableLib > + DebugLib > + StandaloneMmDriverEntryPoint > + IoLib > + ReportStatusCodeLib > + TimerLib > + > +[Protocols] > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > + > +[Guids] > + > +[Pcd] > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > + > +[Depex] > + gIpmiTransportProtocolGuid > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > @@ -129,4 +129,6 @@ > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > + > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > -- > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110376): https://edk2.groups.io/g/devel/message/110376 Mute This Topic: https://groups.io/mt/102292409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-