Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Thanks Mike. CI is running now, I will push it once it passes CI.

Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, June 30, 2023 5:05 PM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Sorry, I created a PR for the change to edk2-redfish-client but that
> depends on this change to edk2.
>
> I created a new PR to edk2 for this patch:
> https://github.com/tianocore/edk2/pull/4592
>
> Thanks,
> Mike
>
> On Fri, Jun 30, 2023 at 5:13 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Mike,
> > I see there are CI errors for this PR, could you please check it? Thanks!
> > Abner
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Friday, June 30, 2023 6:44 AM
> > > To: Chang, Abner <Abner.Chang@amd.com>
> > > Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> > > Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Sure!
> > > https://github.com/tianocore/edk2-redfish-client/pull/43
> > >
> > > Thanks,
> > > Mike
> > >
> > >
> > > On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner <Abner.Chang@amd.com>
> > > wrote:
> > > >
> > > > [AMD Official Use Only - General]
> > > >
> > > > Hi Mike, could you please create a PR for this change? Then I can merge it
> > > once the change passed CI.
> > > >
> > > > Thanks
> > > > Abner
> > > >
> > > > > -----Original Message-----
> > > > > From: Chang, Abner
> > > > > Sent: Wednesday, June 21, 2023 8:26 AM
> > > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>;
> devel@edk2.groups.io
> > > > > Cc: nicklew@nvidia.com; igork@ami.com
> > > > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > > >
> > > > > Reviewed-by: Abner Chang <abner.chang@amd.com>
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > > > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > > > >
> > > > > > Caution: This message originated from an External Source. Use proper
> > > > > caution
> > > > > > when opening attachments, clicking links, or responding.
> > > > > >
> > > > > >
> > > > > > BaseSortLib is the library instance name not the class name.
> > > > > >
> > > > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > > > ---
> > > > > >  RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > > > > >  RedfishPkg/RedfishLibs.dsc.inc                            | 2 +-
> > > > > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > @@ -25,7 +25,7 @@
> > > > > >
> > > > > >
> > > > > >  [LibraryClasses]
> > > > > >
> > > > > >    BaseLib
> > > > > >
> > > > > > -  BaseSortLib
> > > > > >
> > > > > > +  SortLib
> > > > > >
> > > > > >    DebugLib
> > > > > >
> > > > > >    MemoryAllocationLib
> > > > > >
> > > > > >    UefiRuntimeServicesTableLib
> > > > > >
> > > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> > > b/RedfishPkg/RedfishLibs.dsc.inc
> > > > > > index 6e497899b556..03b7ef6f3289 100644
> > > > > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > > > > @@ -14,7 +14,7 @@
> > > > > >  !if $(REDFISH_ENABLE) == TRUE
> > > > > >
> > > > > >    RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > > > > >
> > > > > >
> > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > > > > >
> > > > > > -  BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > > > >
> > > > > > +  SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > > > >
> > > > > >
> > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > >
> > > > > >    JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > > > > >
> > > > > >    RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > > > > >
> > > > > > --
> > > > > > 2.32.0 (Apple Git-132)
> > > >