From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EBDAC7803CE for ; Sun, 29 Oct 2023 02:07:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uRBmBff4tLVCtWP4cPnop82RfebUi6QcusuZJr5GTW4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698545226; v=1; b=e/PUCST08I19png05GJJpPQwo+k0N6f6eBnRMISu6fNgFFIY+i4NgKl4tsyBKL7A5rbCGGCH RPZ5TNZi79/lhAaSJjjE5i178DdkmiQj9U7M/M8AHVg8L4DorcMNZsV6UqfdurfVJmszEN1VWXE xZ759Z0CBQicH8WdKss4vdgc= X-Received: by 127.0.0.2 with SMTP id oNfMYY7687511xRqN2nmNqT9; Sat, 28 Oct 2023 19:07:06 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.66228.1698545225500787124 for ; Sat, 28 Oct 2023 19:07:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=goJ35/fQLwwXjOetHXo7lUy/7tCpznYRdYH88rNTXmBnRETt6qxx8Blo+bB8M+He5O0iJsbuBmxbvQK3fsCbs64zi1p2aRZT6aFvdWiRdjlCdZ6ZqUuXOnvvS/DDkA5UUO7HUBa8K+01zuZJ+uGbq/dvvzVHkO4HWFQduljt1b6mFLtngHb+comWUmWhIoA961oVYtv4UcB85s31gzX4Ykib126bAYq5MWRRqxKJx1ghiUGF2Ys+rFzB4oIAjZpFBDMcNq7fdLbFgUwu+cUeu2nlJTEiKvqFmpOZ1aG+DUnhOZYy8RXFvSll88lF8Yh7GCZSTjEDqHLjxCMjQD6XPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1eeIxvdwShyGP+BR+D4aVLTH4akRASde62nUU5/qmCU=; b=fyFZSfa41qnSiQM+jFJxwGac6+TRz/VCalXlB/W7Xt9fKL3UoiWwBbGqFasepW3qL1UhSegK9jCNa16bcGvyrijPohIFWH4dM2ynH8w5KDeDuho07UOd0cWdSnTVCQldO5p8RWskv7hcps9OVl9CxWEXKzGm1K6nKfCnOAg7pxBvwQupeVHHPzi/H5DlLpVWcpQesSmMkN6N+89TvXkDaqp4YaRAcf9k2jXtxp4k1gpdrHTA5//jsqcg4y7/CJUXCZG+/b+fi+0tYfBIWlpjVNUXgrXI/EFyZgsRhRmD5XlDzu89aWTElqAJqJR17fj+meNx701JiKDb4k4803mWkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW3PR12MB4473.namprd12.prod.outlook.com (2603:10b6:303:56::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.25; Sun, 29 Oct 2023 02:07:02 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.025; Sun, 29 Oct 2023 02:07:02 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , Isaac Oram , Nickle Wang , Nate DeSimone , Liming Gao Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg Thread-Index: AQHZ+1L9z8DqZjyq+0G/Q4BBjCa/Y7BPBtzAgBEPpNA= Date: Sun, 29 Oct 2023 02:07:02 +0000 Message-ID: References: <20231010082223.1421-1-abner.chang@amd.com> <178CB15EC6448604.24994@groups.io> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=685fa825-2f3f-48c3-93dd-682c8fb07ca5;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-18T04:51:28Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW3PR12MB4473:EE_ x-ms-office365-filtering-correlation-id: 84b0a018-183d-4c15-4100-08dbd823bde2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: uu5dZ+r8Q0FlpL3IvBDx7hsxSBdTeVh3a5oOVn1g0gYbQaPDCXYknNV5xpaGwvbejs+YBY0ZUcVMV+iURbfK+UDCNrdmiMSC98pAyRGSXGMWVCdZxyJCEzie64trDLYxaHeYWs0Fn1fXB/SkgzSMxM2HGNTwPJ8GCKA64r92n3GS0Nx4A0tGaaluHUy82eymwQavqQb22Am470sAMGn39m/45Gw3YKTAOhXdSmGnVgC9OQp2fiwXO4vhZ3eCI5FJ35mk1Ioh/PwEyppgdC7Oheg6Npo7WervFPg2ehRdLCJ8TXyWC1tm/OgepZgHCPTQ5fiXG8WT0WsOsEzPcPE8AwlMQBcMnR/CRmqhCXMVyUyr2pM7Yg+L7+Sh79CNkHVy+DQRlnpbL8U5rkIRqT8fGlA0x8S0Vl97b/N7HB3nLrTIGMIcyckIY3n5vS1RmHGl17k4uL0KIcv4H+Z5z/KykPMxje+pMIbfu1ZocnI1jVO2K8i/KYk72c6mnuRReZd4C7lxApOXtZ5IxL7Gtiqs3rpdRdT7QM6Y6FbixykQx5SPDbIfFY91DFRrZ7zDtJ0jzX9LfnDhGZoDENZhJCcQWi6mUSQmI6X1mrizahWJ7haib+gAVnk3uSSC/SXZ1cALJTcu0HvEoOCsoxlU2NZuuQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dzhSQTmw/abxZ8sdejI25Dm4OvTIQCcMOMZt8Be+wZxdnkFjgOO8t75ao7Hy?= =?us-ascii?Q?EjQ95t6J5YDB0DgRdTeTSG97RgQa82YGcQ5XxaRCUC4vYiQEpnq2P03kkYHu?= =?us-ascii?Q?UaoslitNFN6Tp82V1VyWZ7S0KhLici2170xP3GMkDbBO+ZeW9A0oFWb3LG/f?= =?us-ascii?Q?xAGomTUcpl59fQgS9oQDKsdQ+3ac+BBq2p/YDx5MhnhWLAzkc/CwktCZv9kS?= =?us-ascii?Q?D6BGGjSNYsP9EQHHxOoPkl5Q6qwbKqnEv/lCc4tWpMBzlpGnGStv5+HjIfvF?= =?us-ascii?Q?puEaXsmt8nL1EwtCJHOVaEkC0U4oRv3n47MiH3VrmqAlwxBz6oUYvaxxzIFy?= =?us-ascii?Q?ASO0v/jmci8ylG5LT+XKDk+0v8KLWiSGNX1rxCWC1OYWmCgEOYDZKwXOThsO?= =?us-ascii?Q?G9NmunfSBt0AjxZmltlSQI/37uaI+zgj7X4ou+4roRIsBZOY7pEapgI4Wjt0?= =?us-ascii?Q?+xMTpJLF7nUouBWofxx5D8gX4ogRUJ7E8BHqdXwY5a4+1gQCV/3LEG3iXBgW?= =?us-ascii?Q?1DxkN746WiFsun8QZEACWfHnnWcLbifoCunqGo9WU2k6MqSO/dsQJx+L8Lhr?= =?us-ascii?Q?DdHXFbnrRTJPp8qHeaD4dMAVjOQyUu254NZlHhM7BXVmuTqOZkGyuv12jQBj?= =?us-ascii?Q?a+tEx4HhqluUQWrWpUgq2RPQR6V/P3dk4mX4jNYStWgGBXr8C8KtIW2KWii1?= =?us-ascii?Q?2O7RbLJcMmP2DK2qsF+HdyP7oxYLZHO7BrdYtnt2CgRLT68sIfV4CdwHHscT?= =?us-ascii?Q?dbw4+YR9FcNdnD3SPiRsXBcYK+XZg0yOAa64WSSeZDxAz9MGK2MiN2KLqYqR?= =?us-ascii?Q?EKtx8hLgbj/0sOpsww0BBXriekzB45OQDeDC9Auak/aF/hDENLQtV/sNPkML?= =?us-ascii?Q?YcOF057PwCnN5mrDVFTgl0i7WCdgBocWB/DCe0DO0Dd/WgwDpvmkfFp7Glg4?= =?us-ascii?Q?glRHpOfDrRAirkdxc7sCPc/Pw97TWT7qNKXiDj0BAU/6W/Dp2qushoireaX9?= =?us-ascii?Q?U1oG94MgHRBU236ZD0edY9iCAEpm89UScwjtkzl2oOoIpZKzM2xdUerGON6h?= =?us-ascii?Q?NB1rKdmJqUWXMTqu0zOOtWQ0uOIBwEyfkmOCEMG+rB2k8lr0Sdbxai0lb1lB?= =?us-ascii?Q?Vww+ohuwSvCsNUUVpeqMcV9A8AZ2+4FCQqAxiilYq5/QgYlgSIveTr9OP+Va?= =?us-ascii?Q?poAWlSOkSn6Pc6JavnuEURX11//pUPC9jZ40XQxCuW/PIWVPADMinsW2FTk8?= =?us-ascii?Q?f3ONsQELqIYqRsr3lmY/qGBiKj8GNDCsC+S2D5xtJeUmnsWCgPiHjgn4ne3v?= =?us-ascii?Q?20XWiyrOpoYYstZoRtYC6RQ7UXV3xncXcEZ2bSUGJyL9jij7D20907Tw4ipI?= =?us-ascii?Q?VF/tUlN5WHlCP7fe7gD7egFJk5En9deODlDusf0+5cNo3XC81gbLShdEwpht?= =?us-ascii?Q?WfHlaYPZ/7GiBBvgnnSZ+0GXUNQCB2yzGIl59X292dr5S6RnrwGtOBHip+YZ?= =?us-ascii?Q?VYK8xBFkos/VgXVARqlpRWBqhIJVl+gglaCbxFgV9NtOHP5wZKSGmWdA+zQf?= =?us-ascii?Q?rI+G31XrIovGeHIpBPo=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84b0a018-183d-4c15-4100-08dbd823bde2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2023 02:07:02.4091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1IeJ5vJYY4VfLDCPjL6Ua/Tvr4klUztqmQyG01v+sHRVRnAyZvH5M2qWCcPoxwxsngBncKKcwQP4tv7GsmYoSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4473 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qAkdJpXX8idjgykSFCmxC91Xx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="e/PUCST0"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Please ignore this, Liming already gave RB. (https://edk2.groups.io/g/devel= /message/109510) Thanks > -----Original Message----- > From: Chang, Abner > Sent: Wednesday, October 18, 2023 12:53 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac > Oram ; Nickle Wang ; Nate > DeSimone ; Liming Gao > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH 2/2] > OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from > IpmiFeaturePkg > > [AMD Official Use Only - General] > > Hi Nate and Liming, > Please help to review this patch. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Tuesday, October 10, 2023 4:22 PM > > To: devel@edk2.groups.io > > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaa= c > > Oram ; Nickle Wang ; Nate > > DeSimone > > Subject: [edk2-devel] [edk2-platforms][PATCH 2/2] > > OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h > from > > IpmiFeaturePkg > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > From: Abner Chang > > > > Remove duplicate IpmiCommandLib.h and use the one > > under MdeModulePKg instead. > > > > Signed-off-by: Abner Chang > > Cc: Abdul Lateef Attar > > Cc: Isaac Oram > > Cc: Nickle Wang > > Cc: Isaac Oram > > Cc: Nate DeSimone > > --- > > .../IpmiFeaturePkg/BmcElog/BmcElog.inf | 1 + > > .../IpmiFeaturePkg/Frb/FrbPei.inf | 1 + > > .../GenericIpmi/Dxe/GenericIpmi.inf | 1 + > > .../GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + > > .../GenericIpmi/Smm/SmmGenericIpmi.inf | 1 + > > .../IpmiFeaturePkg/IpmiFru/IpmiFru.inf | 1 + > > .../IpmiFeaturePkg/OsWdt/OsWdt.inf | 1 + > > .../IpmiFeaturePkg/SolStatus/SolStatus.inf | 1 + > > .../Include/Library/IpmiCommandLib.h | 314 ------------------ > > 9 files changed, 8 insertions(+), 314 deletions(-) > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/Ipm > > iCommandLib.h > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > index 388dd2740c..1e7a7658b7 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > @@ -21,6 +21,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > index 797dbe6a07..bfd80d4a98 100644 > > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > +++ > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > @@ -20,6 +20,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > index 1564ceb08a..d37d1c5046 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > @@ -37,6 +37,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > P > > eiGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > > PeiGenericIpmi.inf > > index 3a73180ce6..d7fb7f1c5b 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > P > > eiGenericIpmi.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > > PeiGenericIpmi.inf > > @@ -36,6 +36,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > index 12dc17ae84..75162007ce 100644 > > --- > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > +++ > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > @@ -28,6 +28,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > index 322f061a0f..f5778f3468 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > @@ -21,6 +21,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > index 3fd1078271..e90cd4d55e 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > @@ -20,6 +20,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > index 9019b849ac..8690c493a1 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > @@ -21,6 +21,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [Pcd] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > > pmiCommandLib.h > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > > pmiCommandLib.h > > deleted file mode 100644 > > index d5f8f1d01b..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > > pmiCommandLib.h > > +++ /dev/null > > @@ -1,314 +0,0 @@ > > -/** @file > > - This library abstract how to send/receive IPMI command. > > - > > -Copyright (c) 2018-2021, Intel Corporation. All rights reserved.
> > -Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > > - > > -SPDX-License-Identifier: BSD-2-Clause-Patent > > - > > -**/ > > - > > -#ifndef _IPMI_COMMAND_LIB_H_ > > -#define _IPMI_COMMAND_LIB_H_ > > - > > -#include > > -#include > > - > > -// > > -// NetFnApp > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiGetDeviceId ( > > - OUT IPMI_GET_DEVICE_ID_RESPONSE *DeviceId > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelfTestResult ( > > - OUT IPMI_SELF_TEST_RESULT_RESPONSE *SelfTestResult > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiResetWatchdogTimer ( > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetWatchdogTimer ( > > - IN IPMI_SET_WATCHDOG_TIMER_REQUEST *SetWatchdogTimer, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetWatchdogTimer ( > > - OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE *GetWatchdogTimer > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetBmcGlobalEnables ( > > - IN IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST *SetBmcGlobalEnables, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetBmcGlobalEnables ( > > - OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE > *GetBmcGlobalEnables > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiClearMessageFlags ( > > - IN IPMI_CLEAR_MESSAGE_FLAGS_REQUEST *ClearMessageFlagsRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetMessageFlags ( > > - OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE *GetMessageFlagsResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetMessage ( > > - OUT IPMI_GET_MESSAGE_RESPONSE *GetMessageResponse, > > - IN OUT UINT32 *GetMessageResponseSize > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSendMessage ( > > - IN IPMI_SEND_MESSAGE_REQUEST *SendMessageRequest, > > - IN UINT32 SendMessageRequestSize, > > - OUT IPMI_SEND_MESSAGE_RESPONSE *SendMessageResponse, > > - IN OUT UINT32 *SendMessageResponseSize > > - ); > > - > > -/** > > - This function gets the system UUID. > > - > > - @param[out] SystemGuid The pointer to retrieve system UUID. > > - > > - @retval EFI_SUCCESS UUID is returned. > > - @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer. > > - @retval Others Other errors. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSystemUuid ( > > - OUT EFI_GUID *SystemGuid > > - ); > > - > > -/** > > - This function gets the channel information. > > - > > - @param[in] GetChannelInfoRequest The get channel informat= ion > > request. > > - @param[out] GetChannelInfoResponse The get channel informat= ion > > response. > > - @param[out] GetChannelInfoResponseSize When input, the expected > size > > of response. > > - When output, the exact s= ize of the returned > > - response. > > - > > - @retval EFI_SUCCESS Get channel information successfully. > > - @retval EFI_INVALID_PARAMETER One of the given input parameters is > > invalid. > > - @retval Others Other errors. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChannelInfo ( > > - IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest, > > - OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse, > > - OUT UINT32 *GetChannelInfoResponseSize > > - ); > > - > > -// > > -// NetFnTransport > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiSolActivating ( > > - IN IPMI_SOL_ACTIVATING_REQUEST *SolActivatingRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSolConfigurationParameters ( > > - IN IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST > > *SetConfigurationParametersRequest, > > - IN UINT32 SetConfigurationP= arametersRequestSize, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSolConfigurationParameters ( > > - IN IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST > > *GetConfigurationParametersRequest, > > - OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE > > *GetConfigurationParametersResponse, > > - IN OUT UINT32 > > *GetConfigurationParametersResponseSize > > - ); > > - > > -/** > > - This function gets the LAN configuration parameter. > > - > > - @param[in] GetLanConfigurationParametersRequest Request data > > - @param[out] GetLanConfigurationParametersResponse Response data > > - @param[in,out] GetLanConfigurationParametersSize When input, th= e > > expected size of response data. > > - When out, the = exact size of response data. > > - > > - @retval EFI_SUCCESS Lan configuration parameter is return= ed in the > > response. > > - @retval EFI_INVALID_PARAMETER One of the given input parameters is > > invalid. > > - @retval Others Other errors. > > - > > -**/ > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetLanConfigurationParameters ( > > - IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST > > *GetLanConfigurationParametersRequest, > > - OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE > > *GetLanConfigurationParametersResponse, > > - IN OUT UINT32 *GetLanConfigu= rationParametersSize > > - ); > > - > > -// > > -// NetFnChasis > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChassisCapabilities ( > > - OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE > > *GetChassisCapabilitiesResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChassisStatus ( > > - OUT IPMI_GET_CHASSIS_STATUS_RESPONSE *GetChassisStatusResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiChassisControl ( > > - IN IPMI_CHASSIS_CONTROL_REQUEST *ChassisControlRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetPowerRestorePolicy ( > > - IN IPMI_SET_POWER_RESTORE_POLICY_REQUEST > *ChassisControlRequest, > > - OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE > > *ChassisControlResponse > > - ); > > - > > -// > > -// NetFnStorage > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSystemBootOptions ( > > - IN IPMI_SET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > > - OUT IPMI_SET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSystemBootOptions ( > > - IN IPMI_GET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > > - OUT IPMI_GET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > > - ); > > - > > -// > > -// NetFnStorage > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiGetFruInventoryAreaInfo ( > > - IN IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST > > *GetFruInventoryAreaInfoRequest, > > - OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE > > *GetFruInventoryAreaInfoResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiReadFruData ( > > - IN IPMI_READ_FRU_DATA_REQUEST *ReadFruDataRequest, > > - OUT IPMI_READ_FRU_DATA_RESPONSE *ReadFruDataResponse, > > - IN OUT UINT32 *ReadFruDataResponseSize > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiWriteFruData ( > > - IN IPMI_WRITE_FRU_DATA_REQUEST *WriteFruDataRequest, > > - IN UINT32 WriteFruDataRequestSize, > > - OUT IPMI_WRITE_FRU_DATA_RESPONSE *WriteFruDataResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelInfo ( > > - OUT IPMI_GET_SEL_INFO_RESPONSE *GetSelInfoResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelEntry ( > > - IN IPMI_GET_SEL_ENTRY_REQUEST *GetSelEntryRequest, > > - OUT IPMI_GET_SEL_ENTRY_RESPONSE *GetSelEntryResponse, > > - IN OUT UINT32 *GetSelEntryResponseSize > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiAddSelEntry ( > > - IN IPMI_ADD_SEL_ENTRY_REQUEST *AddSelEntryRequest, > > - OUT IPMI_ADD_SEL_ENTRY_RESPONSE *AddSelEntryResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiPartialAddSelEntry ( > > - IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST > *PartialAddSelEntryRequest, > > - IN UINT32 PartialAddSelEntryRequestSi= ze, > > - OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE > > *PartialAddSelEntryResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiClearSel ( > > - IN IPMI_CLEAR_SEL_REQUEST *ClearSelRequest, > > - OUT IPMI_CLEAR_SEL_RESPONSE *ClearSelResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelTime ( > > - OUT IPMI_GET_SEL_TIME_RESPONSE *GetSelTimeResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSelTime ( > > - IN IPMI_SET_SEL_TIME_REQUEST *SetSelTimeRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSdrRepositoryInfo ( > > - OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE > > *GetSdrRepositoryInfoResp > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSdr ( > > - IN IPMI_GET_SDR_REQUEST *GetSdrRequest, > > - OUT IPMI_GET_SDR_RESPONSE *GetSdrResponse, > > - IN OUT UINT32 *GetSdrResponseSize > > - ); > > - > > -#endif > > -- > > 2.37.1.windows.1 > > > > > > > >=20 > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110255): https://edk2.groups.io/g/devel/message/110255 Mute This Topic: https://groups.io/mt/102033908/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-