From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.54]) by mx.groups.io with SMTP id smtpd.web11.2818.1675474608001061092 for ; Fri, 03 Feb 2023 17:36:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=dUrlASgu; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.54, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TV/Pyw6+v181w/U2tqyKiSGBpgZLDYrHvEwGSjJ050AUN9ZHd2kemmO77rbDyttBO8earthAaHJqgm+0u9zDoSwa/w0SjgNESZkgUYK36QusaEQXOLGCLpk7/PCzJ35WuUpA7SK/FmovHYylNshAfxbsMXp2/GSxiOdUy54b30wumaECz2Toju19DhM/UBL2HC2W32n1fIHEHj2Gen0UKU9KAIAkxI1nh0wqCGjLEwnD8dv5sp9N7LHGAfuo0tt/J6qoenV7mNaCIQ7+yTqpi62N3VpbGRD1urv4iGzl1N8HTnVGcCNES3TmTazizUegrRlYeiYhbuH3OwKhXJAUsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KnG/Aa9pcC+cf8zM/WTYmhPT78CnDmavyvEjx/21FfU=; b=IbZZ1p4ijZZdHG0xFx+aSHwiVrA/llhqZ6gw7k5u4xzMYNATFrayvtX4JXu0IbiTuk+6BhkHY321hWaaeQi19UfbZAPbHr6H2gTh9JtkYknGqSydUf/Su+tZeITLVRIfYDuNWu8Jh470bsEQiW+9HXfc5VSNXAN4pRFy+4oajkACn+kE897gOpWT/dJG2PLwlmO1tw4Q8sSVlmClB6S9lhYvDxBcFWUU/au2Zcj7gqJ2YZJTmZ6NzES2Uyo9wXwps7bcLGcUt1+mDP+L3xKBrRaLGxjKrs6mUBX7DQQuu1/zv+lWliNSkftA/LxVL3l89eUqzc0CnUbGLPOFJ9EJ4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KnG/Aa9pcC+cf8zM/WTYmhPT78CnDmavyvEjx/21FfU=; b=dUrlASguvHo7ihrPCjHpymZyqJQbKIN0jA3fC5/mNZC3vCCFIdnVz1LskaVMlK4e6Hi3IkUSB7a/uwnw3wL7SEQN3e0yB/lVY5LYTcTn5cgJ5q/wX/o2zDozrjqnStuWaze4uVuoZfW8gUCz+OdlPJC+dyoq+ulqhz1WkDpPz7I= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB7456.namprd12.prod.outlook.com (2603:10b6:510:20f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Sat, 4 Feb 2023 01:36:45 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::d606:ab63:cf3:5d36]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::d606:ab63:cf3:5d36%5]) with mapi id 15.20.6064.031; Sat, 4 Feb 2023 01:36:45 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [PATCH] RedfishPkg: fix multiple SMBIOS type 42 version issue Thread-Topic: [PATCH] RedfishPkg: fix multiple SMBIOS type 42 version issue Thread-Index: AQHZNeUnHRUPFniMoUimfnltKlUpe66+BmOQ Date: Sat, 4 Feb 2023 01:36:45 +0000 Message-ID: References: <20230201023012.122-1-nicklew@nvidia.com> In-Reply-To: <20230201023012.122-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-02-04T01:36:44Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e83227fd-738d-4254-a713-adcb08f74d6e; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB7456:EE_ x-ms-office365-filtering-correlation-id: f969bd8e-68ab-4303-2fda-08db065046a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ev2x6AIzk8V4U7/pCRrmWbq1pqknzvoQuCC8uP7z5c0hsX4mnX0lfkHWM9vb01m00I11u6XFbBRPErbu7ZICqzQ5MGzNHRR1iUT69yucggVOKfUQvsztuFm/Q3aVgyZPpdeOlCBQuxe42RRvLVocfP0y1+Ni6R57xGzC/kQwoGqJ6NYgCUFPz7GN8n2WSl58eC8PAhqU1sv59RdLzHKB9sV5pNyxfW+Vb6TZ9ws34BLKg+MJFlyDwofI7o1is6EDnhRM2LVJTpEr6ooR1+62QH81Xpick0SIuCanY/ngtUWxodTYX2fhGKeTpO1EOSx3GwPNB6U8lqN2vwQSkflHvmnOr4Pt9g6KyiKISNoXiflPYnO513Ego/E9PUqt76k+kiVNOs/5Rcf49LLUufDY60KwUAOXaFzwSYcGW9avL7g7SAIk0UQlaptT0Y++9f00Yo5n5/T8JH1H6QUPNYIxcG2/IwnCcZBdkeU6CjogVkGqPKTrm4FjdSl7JkoQTStQEGKhGnfbs0FbUjmnhbcq8i7aYYtcgUM2wq6xMVLvFLGpYY/g3/3dTphA159inB4hN1p+pF9GvrWISvAh1M5KSYb83SJf/eLYY+YAXy8bwOreeIZKZPcv895axrpUSirP1a7L0+1Xjq+SkJAn368wHhwrGWwtJ6ASUaq5JvzE3xrbjtQSwhz14E3gff+z5bOdKRHUsDFrleW1A0iF9BBNFw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199018)(38070700005)(38100700002)(122000001)(83380400001)(9686003)(26005)(186003)(478600001)(86362001)(6506007)(53546011)(7696005)(71200400001)(110136005)(8676002)(316002)(54906003)(19627235002)(66946007)(66476007)(66556008)(64756008)(4326008)(76116006)(66446008)(41300700001)(8936002)(52536014)(5660300002)(55016003)(2906002)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ln5Q8iG8gQv3QUm/BSvLf4WQtGxdf69ue6X+borsBuoqb0lvoBpIPwUi74eg?= =?us-ascii?Q?kBBRSIap0TJ5vxyLHWBG2TzeS1NwMKauTe95pChAGeQD3kyKMtm/LrEXQgJ9?= =?us-ascii?Q?YYqn/8q+Wisykg8/1Ab1ZjrtbBKIQVJg9PiIJsOd7zTmN/wyfXN8uz9chKgd?= =?us-ascii?Q?Q/IFX8024gTp0XlZDP1O4h6SyJfqh8VnWCim8bnx/BHDQ0pOa+uDVqsilMoo?= =?us-ascii?Q?c8uY+QEeZ7HaDESHi4f6Jje1aThRWQhKZAl36UPl07CqCaAE3ChahWCjIKcJ?= =?us-ascii?Q?ioBCi2H65+lG7SocgdaX3v9yXvB5SS/FgEldhI4IW+rSNFYg9Jw7u2pAIN6q?= =?us-ascii?Q?kGTgcscLxjr2dz7tIHbbC0C7v7z3FsUmGiRGuhfvgtH5ljpi3FN0iMGo9eL3?= =?us-ascii?Q?t1QOUrkz7yknFWDiYGQHa/gkUCub1dGKZEebJ2nUWeJvTS8PypSTj09fvNU/?= =?us-ascii?Q?zQKws4MsFrVcP2YBg9dGVF96lwEBHZKq6Dnq64Jjhvl0C1loZwVf6Hseg1LJ?= =?us-ascii?Q?0lT4bc2kg9LqlEufJEVxcqKm2Y1ihZHnXAeGc7OSxJ6p8+WsPbfFtPE2MiKI?= =?us-ascii?Q?dw+paYH+TwcdW2pPZLiIJ+upTgPODvYpnIaUSRPO35JoY6M0zAbU14Hwwx2K?= =?us-ascii?Q?x18HB+p5oHq/k+r/1q00X9LzbeoV62zrazl2+5EdAQx7Cfh97O4qm+dn5ct4?= =?us-ascii?Q?a1OEgUGEHqtZEf4iAyUdQHsTNoNxpJiqUfVA80t+4xWuHiOzmzUNOhK7JDP+?= =?us-ascii?Q?S/JR3UIMxrf/boCobB7h+IEan6s2WOE4RiuxWcrD+3TVbZIdifvMQDmZN8xE?= =?us-ascii?Q?qcUdemg4krY9Nqh8KCoGfJExSZHWQMVDtOKiRcp1/2a7/Cmosg9hEKL5UXAG?= =?us-ascii?Q?W005c6Z2u+qsta1L6gDUYUKG5Tp61nZq9FxYAR4URnuZLPJeoTWdYbSH0B51?= =?us-ascii?Q?U5RmatSN5ee8Fxgr2jT3TjBRvC9lRRCDeQX8Cl1PlyIvWaP+dq/200RfAwUe?= =?us-ascii?Q?WUOIt60Jp7LegExt+n7P64Tddy8Nyd5f7Xughnt5GcKE7ocRDJkjXPuKdN0u?= =?us-ascii?Q?gy5cCkmrVQJtC9JeqRSKM7MvXakVLY1CLkNu2eigUvSdWmi/ZCwmSz3bldbo?= =?us-ascii?Q?CcNsYkIYaYt9xr2oPAqSM8A9PRTGH2B+Ue30w8pVCcrTO5E5olpcg4CPaKtL?= =?us-ascii?Q?V9FSaY48O0Nwiyt+UokYqAQzYBQGz5iPvE0nWm2ZxxKiJVhGmzFAGRPApr93?= =?us-ascii?Q?VYXWrGrEcdHXAzubkBo3PzDsCSI2Iz0oRpeo1L/vivGscBrfBTF4L1PXadaW?= =?us-ascii?Q?E81dg9Xns5R+2wHWWOPyKFblgqhCnaOgOz+J7v7DrEB2BrvH4hSIA4mYerwT?= =?us-ascii?Q?XnLaGgR9OocDgAwrkP7ojd9ToUK2nlGuhQh5X+CHC4Iik7iv5S8TXFXMgY/r?= =?us-ascii?Q?W5iY78WkY/s3qbmpOqFPLoc8+tTgAyEAG8l0MODNqCmONWgcjqI/v1+4lpxA?= =?us-ascii?Q?XJPqsHkUz/VM865CaNHVb4ixIDeGzEgTcZWmbNYMuT7l0MvngP2B7lTPl1CZ?= =?us-ascii?Q?W+UnhvzzMSZ2NfQZSx0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f969bd8e-68ab-4303-2fda-08db065046a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2023 01:36:45.5085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P7f6EWeSajf5tDFj7IJ9ZT0xhr15bikPe1hGaGZhvzXxUTTV4zVeUOIsl0JYbVtXjMBCKv4iIc/TqNnE9dqoQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7456 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, February 1, 2023 10:30 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg: fix multiple SMBIOS type 42 version issue >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > RedfishHostInterfaceDxe does not close protocol notify event in event cal= lback > function. This could cause multiple version of type 42 records issue if t= he > protocol is installed more than once. > Close the event in callback function so we only create one type 42 record= . >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > index 3e12e0c8b9..872cf3ae06 100644 > --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > @@ -7,6 +7,7 @@ > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved. > + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -260,6 +261,13 @@ PlatformHostInterfaceInformationReady ( > DEBUG ((DEBUG_INFO, "%a: Platform Redfish Host Interface informtion is > ready\n", __FUNCTION__)); >=20 > RedfishCreateSmbiosTable42 (); > + > + // > + // Close event so we don't create multiple type 42 records // > + gBS->CloseEvent (Event); mPlatformHostInterfaceReadylEvent =3D NULL; > + > return; > } >=20 > -- > 2.39.1.windows.1