From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Konstantin Aladyshev <aladyshev22@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
"zhiguang.liu@intel.com" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg/Pldm.h: Add define for the PLDM response flag
Date: Wed, 18 Oct 2023 05:37:32 +0000 [thread overview]
Message-ID: <MN2PR12MB3966099703E5B58701B05138EAD5A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231016131753.6598-2-aladyshev22@gmail.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Chang, Abner <Abner.Chang@amd.com>; Konstantin
> Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH 2/2] MdePkg/Pldm.h: Add define for the PLDM response flag
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> The PLDM protocol uses Request bit to help differentiate between PLDM
> request and response messages.
> Currently the Pldm.h header only have a flag for the request message.
> Add a flag for the response message as well.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> MdePkg/Include/IndustryStandard/Pldm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Pldm.h
> b/MdePkg/Include/IndustryStandard/Pldm.h
> index c821f081f8..c2909dbd76 100644
> --- a/MdePkg/Include/IndustryStandard/Pldm.h
> +++ b/MdePkg/Include/IndustryStandard/Pldm.h
> @@ -40,6 +40,7 @@ typedef struct {
> typedef PLDM_MESSAGE_HEADER PLDM_REQUEST_HEADER;
>
>
>
> #define PLDM_MESSAGE_HEADER_IS_REQUEST 1
>
> +#define PLDM_MESSAGE_HEADER_IS_RESPONSE 0
>
> #define PLDM_MESSAGE_HEADER_IS_DATAGRAM 1
>
> #define PLDM_MESSAGE_HEADER_INSTANCE_ID_MASK 0x1f
>
>
>
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109708): https://edk2.groups.io/g/devel/message/109708
Mute This Topic: https://groups.io/mt/101994933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-18 5:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:17 [edk2-devel] [PATCH 1/2] MdePkg/Mctp.h: Correct typo in structure member name Konstantin Aladyshev
2023-10-16 13:17 ` [edk2-devel] [PATCH 2/2] MdePkg/Pldm.h: Add define for the PLDM response flag Konstantin Aladyshev
2023-10-18 5:37 ` Chang, Abner via groups.io [this message]
2023-10-18 5:41 ` [edk2-devel] [PATCH 1/2] MdePkg/Mctp.h: Correct typo in structure member name Chang, Abner via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3966099703E5B58701B05138EAD5A@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox