Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo

["Chang, Abner" <abner.chang@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 3987 bytes --]

[AMD Official Use Only - General]

Hi Rebecca,
I think you replied to the wrong email thread? This is the typo fix on the edk2-staing but not the one you contributed to RedfishPkg.

But yes, I tried to have a PR from your branch to edk2 in order to merge the patch from your repo, however, the PR is out of date and I can't have a rebase on your branch. So I cherry pick the change from your branch and created a PR from my personal GitHub.
So your change is merged to edk2 now, please just ignore this error message. Or does it require my actions to fix the error?

Thanks for the helps on this.
Abner

> -----Original Message-----
> From: Rebecca Cran <rebecca@quicinc.com>
> Sent: Monday, December 5, 2022 11:17 PM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>;
> nicklew@nvidia.com
> Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez
> <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-
> staging/RedfishClientPkg: Fix typo
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> I see you created a PR for this change. But
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Ftianocore%2Fedk2%2Fpull%2F3712&amp;data=05%7C01%7Cabn
> er.chang%40amd.com%7C2751d64c172f465f91f308dad6d3bb0b%7C3dd8961f
> e4884e608e11a82d994e183d%7C0%7C0%7C638058502132324738%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=RHJ7YdPlTwgLE9K
> Mm%2Fm9pd%2B2pNRyTygsg5ZxpKCli1M%3D&amp;reserved=0 is failing
> with a strange error, and I don't have the setting it's talking about so
> something seems to have gone wrong.
> 
> "The merge-queue pull request can't be update
> Details: `Pull request can't be updated with latest base branch changes
> 
> Mergify needs the author permission to update the base branch of the pull
> request.
> @bcran needs to authorize modification on its head branch.
> err-code: 85842`"
> 
> --
> Rebecca Cran
> 
> On 11/30/22 20:30, Chang, Abner via groups.io wrote:
> > [AMD Official Use Only - General]
> >
> > Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Nickle
> >> Wang via groups.io
> >> Sent: Thursday, December 1, 2022 11:29 AM
> >> To: devel@edk2.groups.io
> >> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> >> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> >> Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2-
> >> staging/RedfishClientPkg: Fix typo
> >>
> >> Caution: This message originated from an External Source. Use proper
> >> caution when opening attachments, clicking links, or responding.
> >>
> >>
> >> Fix typo in RedfishPlatformConfigImpl.c
> >>
> >> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> >> Cc: Abner Chang <abner.chang@amd.com>
> >> Cc: Igor Kulchytskyy <igork@ami.com>
> >> Cc: Nick Ramirez <nramirez@nvidia.com>
> >> ---
> >>   RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2
> +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git
> >> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c
> >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c
> >> index 525e666b6c..b2bb5f64e4 100644
> >> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c
> >> +++
> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c
> >> @@ -1,6 +1,6 @@
> >>   /** @file
> >>
> >> -  The implementation of EDKII Redfidh Platform Config Protocol.
> >> +  The implementation of EDKII Redfish Platform Config Protocol.
> >>
> >>     (C) Copyright 2021-2022 Hewlett Packard Enterprise Development
> >> LP<BR>
> >>
> >> --
> >> 2.38.1.windows.1
> >>
> >>
> >>
> >> 
> >>

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 18510 bytes --]