From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.72]) by mx.groups.io with SMTP id smtpd.web11.1049.1684888403718244974 for ; Tue, 23 May 2023 17:33:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=GCEgqWWW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.93.72, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HL4aYOUDm4jSMjK4X33V4vbiyXlrqkNuZuMkiP3oTwZM3zbvJ1Rtju8HwJfv7iaGXuk/dztD5xHoavjPfv8pzOQbjG0hLBFRuvpPYGTx6Z8R9N5lb+kxhxqK8Jx3UopdG+GMedVaL9LRG0AgyPdUVaXPbnvtEDV77/yYZ2JLdlRPkOnCGJskILFDiwo+M5Gi/GPhQxN7yJ6GCJc/k1lSbqAlajjULFqk3so3uMKPG4bEbUELiDcf34bh5XLw5wyNsLf+KpfNeDz9tjd4Wnl97S+FQrdyyQKEBeEQL52Q6UQLKb7z4HBl69D4r+wzsqa8b0JxrlmUIshi/MRfXRTz3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jaQNQsa/PUl2FRGtHrSS4m6orTBOkVSD+Ab0HdCsmKE=; b=dZeW58BGbR0GCDAnVgTTEzfm/uhVqP2dGA+/sn73Lqof1RC1hVgKIFM68UouZnIO7LeB50/46oURZ5aFQz2BcKctZoJ3vQVPKp0IKS7ibBVBI+ktbfTUJV3Y3bzMvSJSi659ECx7TJPO8eBB/nAxJx8h9sYaQcFc28uqS+ZaDoqk5Eq67wDlQD245DfmyvEO3syFQPRvloPPffP+3DzWcntflFGVXgnPBfsiteCOgKTLIlUNvze5KGvTGPz9ue1o1kiO2Us7jFVRgKTB2M/LNvCHOaJQH/hO5wJFEo5Myp9vWjzIWSOY6EkiAzQuSxGCf/I9DwKDIE4Ne9aeHnhlVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jaQNQsa/PUl2FRGtHrSS4m6orTBOkVSD+Ab0HdCsmKE=; b=GCEgqWWW+CuY5R+Vc5CytRDRxd2SPvDwCipihwcmNU5JO4y8kQXwE73FRf4nxBA01kJ2IfV3PTRLiBmVxRvnwsjaLnGl29kKeGWUBqnQ560G+ok1fRgOZpA/rHUvPDDzrM86EkknYncUmCY5ixjSuSnEs1hlrEn6yAU0M5GzgbA= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ2PR12MB8136.namprd12.prod.outlook.com (2603:10b6:a03:4f8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Wed, 24 May 2023 00:33:21 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6411.028; Wed, 24 May 2023 00:33:20 +0000 From: "Chang, Abner" To: "Hsueh, Hong-Chih (Neo)" , "devel@edk2.groups.io" CC: "He, Jiangang" , Hao A Wu , Ray Ni Subject: Re: [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjZkboPIVCDc180mWVLPxgzEKQq9okKWQ Date: Wed, 24 May 2023 00:33:20 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=12def4d7-49f2-45e1-911d-9ed8360fe359;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-24T00:23:10Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ2PR12MB8136:EE_ x-ms-office365-filtering-correlation-id: d4a07487-4174-43eb-1fa3-08db5bee79e6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YhJuwizt/Jlk2StVxd4i+y+FrZv+o/kq6zUT6ElnpgsvAjbBhbSpBayVos79O8aievdRgU4J21WMr87+KNQXClZBrltqc4zhOXvTl9vZ2PcG05m26vY54/ctWpi1hYaMn2DlAIn7kEWGTHSZmibimXD5FsBtVMBjAShFULR8oumwfRM/5xPnCzT6+hvGmmMxlzWnOD31y6wbn4Efii/WE1quPgFISycnFDFgz7mGPwYqPFzgkrcVpsNo8lI3vOtHBn7Bs87Uy9m0Gp4ylPAglpmqwcV0x0I0GvyNkfolOYD7/m5EfwqfjciyIN5iH1rahsgIZtSDb5YqXoD/fesDwQRYJXA2QkwQLQ45/GAEWX4NFGunJSLoCGBXvgwE6W546zmgBHRSXCdoGyn0p8Hz2SZYf4X9EBwRQrIG5j3md+m6pfP8NvsLfE2li3CmokH9dqJDnCrMa6QNuAgqDUcLyB5klvkgzjx2to7IDnpfWnTC/HZn9xSjMcF/abFYaT9QwXOQtfmDbC6BQbrLa1zXOiRkdulHWmfug3H6tfZdze26kjHSQ2rTZ8x8Ptf34CnTpuPQiMFSgZWXFj0E6qb1Z+rwc4H1r9iw46sNbjpX97m43ukCwrsMdlu3N7AR3Rin x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(39860400002)(376002)(346002)(396003)(451199021)(38100700002)(76116006)(66946007)(66556008)(66446008)(66476007)(64756008)(478600001)(41300700001)(7696005)(110136005)(54906003)(316002)(71200400001)(52536014)(38070700005)(4326008)(86362001)(8676002)(5660300002)(8936002)(26005)(33656002)(186003)(53546011)(122000001)(55016003)(9686003)(6506007)(83380400001)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HAZsuXT1dz3UFvoPQLf2P5jQQw05fGvZvVihTo6tdDjfYScOiIsJFXPyRuqr?= =?us-ascii?Q?f16sKjiciEQ2lYOczvF5p2CRtPTFO7yno5VVoWYyKu/Oi1z60pQJqsdZlO2B?= =?us-ascii?Q?pND8gt1hcwkIgebz3RK10VgtZvH+FWwmowKPfiG7Knv7wrZenvy/28s7GGmO?= =?us-ascii?Q?nuZbRLh7xzfybay10O5fXSUAUuErSFT6M1MFa99tb/SVkaP+zGGJHpt6Kmrm?= =?us-ascii?Q?gZDdowHX5dgQZKF8Fxk9KDKAXZHqvGM2KC6zBYUNguLfLblcAo3fMX4/85w7?= =?us-ascii?Q?SeZTKJElw4ElvctLfnhVlBwolDVnaQkqqO2J0HPwk2L97NRnTf/kxa6+Vg3M?= =?us-ascii?Q?ZpC1ZATs3xNbNzSuDg2DLrF0VrwiaC8e8lt7XVFnaikpMosGGAEV41rjjQ6V?= =?us-ascii?Q?L9bhYkopYAyPixz3quj1AGFO/mnxYTNwMooFoXHULtTpCLgRd2MkX2gE9UVE?= =?us-ascii?Q?cM1RT96nmDHd2hfGzEim8EMgAn8R4Q0vF+xnhkoxK6bLCwcjXoBwvPPJnnYM?= =?us-ascii?Q?NZwz2FoO2dhplFk2rH5kVXyjrBWqbV4Am3QtM1tsFD8BLLKds6bCpZh8kxLQ?= =?us-ascii?Q?kLuUHwsw/ZYo4/P8+8s7kjrm0ktxZhFOJQ99ldvaEYHeHkIcwW16rLdI0tZI?= =?us-ascii?Q?8onhl0n74iTrDAUyFuKLvq5Yg1rTdidiZLjE34sEwKAnw6yceaEY9MzarJNU?= =?us-ascii?Q?jUQM3SxvbFnApd8Kkdiura/99zZDDhSNZCq8WNez8VT9YB0ASpncDXJRtQJq?= =?us-ascii?Q?jP/i9npmfGOfM/5aaJSfk2UQHjgGwJAarcIEYOtUMdNW0aQS3fzAw29U+lSO?= =?us-ascii?Q?epiPU3b4Vj0uU7MnElztaoHx/sut0vCaGoPEh0GDI443KZZBBSpeviuK0Z0+?= =?us-ascii?Q?ApC17a2dbU8OnWTCmCAor6eYIDPNvPnmmiMv4m3/nexqQ3k10Kl3oEADMjhf?= =?us-ascii?Q?23t7XEqNs/Xd1rfNkqmJxFg5wgjCcacpLHDeU98uXLECs/NvNUPdFghWkaUR?= =?us-ascii?Q?W9ler/0HZg0Stu8ghq/Mq7/kIbsgocL2eEyZLajxW30f1WKy8FbzRzixQ0uU?= =?us-ascii?Q?XNArNCDeReFwxzb3F398Yeg80SvJqxZAPCbVflnXmNaX1hmMlW6L2Z7wihDA?= =?us-ascii?Q?8SjdEV5+tyJdRcNhAFBVPY2GVKIjCXBQ/Wpj3HZQdQg7pqzEexbwCXiz/HoK?= =?us-ascii?Q?08CdhTPleNUGtjO+wJfSmkKyZNX3paUktsZEXvNr5YqIqQuXmnhf7n+en9M5?= =?us-ascii?Q?VsSUUSNFz8/oooDBoPMVUuHr2pgpymTSl23MbJJ0rlu2yBii+VN1CUQ5mPkl?= =?us-ascii?Q?W/cDYwwZvjXO+FeEhCUmGingy+RBRUhif1ulrfBk06lMDOAA1EfrOP5AR0Ix?= =?us-ascii?Q?2B/hKylEUfrp2ZKvLmOXSlyMc4H/bPRmu9s4V1ujlkLvsCy6rn9vUu/s+x3R?= =?us-ascii?Q?9rhmOAGrRn3CjxHaHR7F+y6jxowFwqDiSUMfISgVolDYVj6Z5cbL8nE9WAd/?= =?us-ascii?Q?NhQZPjVHh15enH4mi58OczGDnv+OyH1g/kSz5RS4iXYDIJv69uld8SL+Zi85?= =?us-ascii?Q?NeDWvp9wXlul5YrUj/s=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4a07487-4174-43eb-1fa3-08db5bee79e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 00:33:20.8159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rfyL8D+OkafraFmf1fEWnoyCvxxR+nD103yGhnk3yxwA51F3KRPiFuLM8ZsJeTBwSeohDjwrnl2F7ZbdZNHLpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8136 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Neo, I don't see you add the maintainers either in commit message or email CC li= st. I added them. To this patch, Acked-by: Abner Chang Thanks Abner > -----Original Message----- > From: Hsueh, Hong-Chih (Neo) > Sent: Wednesday, May 24, 2023 1:07 AM > To: devel@edk2.groups.io > Cc: He, Jiangang ; Chang, Abner > ; Hsueh, Hong-Chih (Neo) Chih.Hsueh@amd.com> > Subject: [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM > > If there is no port multiplier, PortMultiplierPort should be converted > to 0 to follow AHCI spec. > The same logic already applied in AtaAtapiPassThruDxe driver. > > Signed-off-by: Neo Hsueh > --- > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > index cd55272c96..7bd04661d0 100644 > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > @@ -3,6 +3,7 @@ > mode at PEI phase. > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( > { > EFI_STATUS Status; > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > + // > + // If there is no port multiplier, PortMultiplierPort will be 0xFFFF > + // according to UEFI spec. Here, we convert its value to 0 to follow > + // AHCI spec. > + // > + PortMultiplierPort =3D 0; > + } > + > switch (Packet->Protocol) { > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > Status =3D AhciNonDataTransfer ( > -- > 2.40.0.windows.1