From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D301594110E for ; Mon, 18 Dec 2023 04:58:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RS1RhJYhEnxH+3N+gBX1o4pIK3+bH9x75rPeuQ8nBpI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702875509; v=1; b=T0087nBWqGG7TZMu2VFpF2U8QyN1/V2ZkIAGqUFscsSuO4sRE2WaU1aPkZTUdWZg+afICucg jjDWJ+6FyrIqfxmzJ5UMo3PRQ8jS5XFLfqyVkm/usUmLlstdAU6I11OXHdx976bUmLy4TNYxUIk YDcxyVYnFDQUBdNNxV/lCW6Y= X-Received: by 127.0.0.2 with SMTP id 0KRmYY7687511xdRE7zwEUFs; Sun, 17 Dec 2023 20:58:29 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.45]) by mx.groups.io with SMTP id smtpd.web11.35988.1702875508500253312 for ; Sun, 17 Dec 2023 20:58:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kKyMdszmSG9AMYeK9LTfZxIxmK9NaBwq4lNRhNSrNZx0ygJiZtYMB7D7o5k0jAS3JZ7AbsnMGa9YW8BMuRnVD4qOZiQB3uNTWaR2yjBZaZvkLqQOtjpqFk3t55kpROeho35eHQEvuF9at7IIbgupHXyvdoWQxHbwin88p2yWUS4vxijESxZckw9yMJ3uo1GCjeXTLvLJbuY0cHuTYGAfoivVVVaauSWVO7uK4uXfjU0bDDK43uVyZqIw0jF9/RjAUFM4Q7Yqq0l0DymC8T34S9C4pftIgOajHF70XuWQK1XW8akSQ0POfdMN9HJIm5nCQj6J3AcEQBrFRGKadzegYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQTYgDexfm8M8EUKreMofUPsb5kALJpE+12/FMkX0Oo=; b=cN8dqjCrYdl0wUUPoBTiiVxUf14QfYdlrnWZew777cyTr6vLUP8TMbDiKABHnoZcSiA4eVorc5sISfk9Lf8aR1c8o2YRWRbpWJfi4WWlkZ5uqcGBz6ZJSfIv86CHC5kZed41WPK4bv8pYE06uiSwAQRBgpOYvFiiQyq2E0ItlckdZz3i5mQNTJkmFhlMfpA4Jee8T81SWdtJEy3mhhr7kWJdCDg+lo+JwKVZ0WNEzEzJx0ooO14JB2x3JydWuiwI3QBxT99rl1ZO/JovT2mf/8/ECKYqzBWnAg38u4/aLBKf9nHSYZuS9DxKhjzJR58VSNnFZxx1T520SaX15wL5uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW4PR12MB7119.namprd12.prod.outlook.com (2603:10b6:303:220::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 04:58:23 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 04:58:23 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Thread-Topic: [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Thread-Index: AQHaLuTM+bVstgNtjEi4nnMZOqzGQ7CufxPA Date: Mon, 18 Dec 2023 04:58:23 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-15-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-15-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=5a2e3a85-7f8f-4cf8-a059-c5a617680f18;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-18T04:55:33Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW4PR12MB7119:EE_ x-ms-office365-filtering-correlation-id: fe00bec2-2a1e-407b-d9d1-08dbff85f64e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: HKme6A7V1eG+Mc5CwwHqRCG1BFAHuREY3VHapQMiId+8Nz56GwMNRZdymeC56LZIhws8sKhlZulKjfXAfcG4C0c3LQ43/Uc5SfMXaowH3UB4eQxp/444d5YBLObznVQnUVOJfavN1nJcP0TlsGwatFnwZmMPubcQ3Ps33wJamgB3zUlxIKh92DUJf8yx/zkBGEoZX/9kbB/GUGtEjB1dJZP8yNJ8vU1XkKE6pkElkYP23NVZJQFXn1r3CKsUKxddnOYFKHsBUeNdNg+4/0H33ud4IZls1PYiJJsSPrIwkS02DW9zc16i4wQGtqRtME++YFVZPIDg78275op6EXILRHaSQGEXspg7P2ISv49+QbIUsVHRgk7NjFPJBbq5SNKDPrAepHJPczqT/7rCNvtgew/j5xKXieVfamyOdPNpu0rq1sKLN1fVvqJWDEOeBVJsQbcEkMJ72DG/pgMIdeuzQ/ZyVU2xaX0sVUuFqOEIo7fr2P9ks7n/V/Vj3NfC5WDpS5nbh+COIHBDOYxcUoG/Il+XJr3mm6HqR5kaP/njZvRRyU47poBdXwX7Yqpt9svqa8pK8ubqCACmittwcmZ7Dfe3ZgPArxDNey0O/honXGvaG56SOqlP0RW7G/FZ9o12BjRvJd0+5MT8ctUIaIAnq1rdqmUKpCirZ2oYI2OAAWc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cyJthZZu7r0Jy27haRe+tUeT0L2k8mzEN8VJIUQ2fdZBcW/PslF+6x6JP+Vw?= =?us-ascii?Q?8uXaWx9ds6k2HV9YIGtnGJQr6Hfbzo9nk9kkGbtDPaXBcD6rv1qQRkr42M51?= =?us-ascii?Q?dEujwV8JFuEAE1HKdleJ0tmMfiZns1gisxJ3zZhLe2GKDPiU8Q29OJ8jUEMT?= =?us-ascii?Q?3YxngNCXLXAdJshrs2ROXazwSEK7junJdHc2GoqWQcfEVsmKecrAmKG/zmQ+?= =?us-ascii?Q?o29MaFz8TC8swRJP8A964jf9mphfOBCm4BUQIXQ22Rt8CHq6lWdTSSbZCJl9?= =?us-ascii?Q?8Wi3Ryhf79EpQ38xD6KZ019KVuLpVwc3BfZsqf/6DfoJdT81OTJzCo/iv6kL?= =?us-ascii?Q?g6vvch2AidrXRswCZi2xrxCqaRZ4B1zxFAME95KnkCUen+QM3ZTBQwgImafd?= =?us-ascii?Q?mUe4lhcQzhY1Tco4+RyWpyNINptZu0iJinCLLZb757qiuU0gc7KgR7E9V4A/?= =?us-ascii?Q?njOezoCt/dcqpp4YwNMmbDYOAlClozbtsHMpuYfNQ8T/vUV+d1M/oRpOtcrG?= =?us-ascii?Q?7PRJs0aMEkfAg8R61gMfypFFtKmuRyNDvZHj7ABikdO3Ezk53K+yMae2lkdJ?= =?us-ascii?Q?SmRkU7MnOHQTQbIjHwMVvhYs8x+XS+1o9v4PODyV9Tti1Kfu3tZQdUg77i1a?= =?us-ascii?Q?+giWHe8Tm2fQbxrOAxz+qp0hssfO/jvqz83PH6GWCTh4laizbRbc5tKLPScZ?= =?us-ascii?Q?OtIi4TACTvnvSQ1I8GEdZCw0J7bLFob3mFn7TeCarNe6pROmTOOK6Ksj3hMq?= =?us-ascii?Q?lFBTi8bc+UzV8ILKEp/FC2IaojMVForODOcWhrWZUMea7uYHxssWA9e3UNnA?= =?us-ascii?Q?WykGF2iEwBGdFylXpGi0BIi8G7nt7amu2pzDLRqkU5YYHokJXnBmYJr6IKuj?= =?us-ascii?Q?YMFWiQ5JakB6BYT+LlVgl8wzMw1eT06Ozll+BxVlxMWe9fwym8qArFfMGGDR?= =?us-ascii?Q?LHpVReCJfXsyS3YKXCiGc9/l31FN2qU3Q5nrTpk8UaoTnWK9kZyw9e6DoSSz?= =?us-ascii?Q?opB41Vwz8sr9wJoDp1OxupFjsPL5gZzH4UvruvAyQUaSswI06MeHY/nsJnuQ?= =?us-ascii?Q?1buI628eTeoQSUeU2a7oORne+MCiAx5zDndf8Yu7oq/WQehdfmIGOZpCpha4?= =?us-ascii?Q?y+y/vaTWCXShSUpDhkQKkveKSyVEXpp3U/bYHDggb+RcEWBE8Z5+N5kGM49u?= =?us-ascii?Q?eE8c9JdG/IKTPrLG4xM/ZwG8Gihld6kQURos5jiU/eJQhB3CkOitgajHYBNf?= =?us-ascii?Q?jWzIBwer4zOnjsY83g80IylhepIkB+8YLlJxv3DAZLAif4qoALb3bCwy7yWS?= =?us-ascii?Q?Cst3ieo5iI6V27dwZKu3xD9n7YmqQ3BW/c4oByepqZXUMgMc7vNhfxQBXgD4?= =?us-ascii?Q?Uy3a3wNkLBJTi/8ocHVbyVb1vMf8sIRLD4sl6pI5vNuKnJcUJeORofpJmf5a?= =?us-ascii?Q?zjYrqcnBdBMqzAxRmkv4lF3jem5jjeLN51qDWTEWugoSDvHrPGR7slAucznh?= =?us-ascii?Q?4qB7dBm1UNHxlS6MwBmKvYVksNFbcNBaP4yHto34QDYVx6mKVSMRhv8jFIV7?= =?us-ascii?Q?AY5U+qAZkhODEzu3WBgyhCzHU40bO5CB2kLogMzP?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe00bec2-2a1e-407b-d9d1-08dbff85f64e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 04:58:23.1061 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: emT9JxHvl4WdULQKcKdnDj64Pdph6ekcKr17VW6N8ygjRCqbWkX1316jO/yMSrGZHEAsYWqdq5cI1+0f5TvnVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7119 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CYWF28yVPkaNiKry2k3VvAh8x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=T0087nBW; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets= to > URI for IPv6 addresses > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > URI is generated based on the RedfishLocation containing an ASCII string > representing the IP address. So, in the case of IPv4 the canonical > representation of an IPv4 address was inserted into the resulting Unicode > string i.e: "http{,s}://X.X.X.X/". > > In the case of IPv6, to access resources, the IP address must be specifie= d > in brackets, i.e. the resulting string should look like: > "http{,s}://[X::X:X:X:X]/". > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 21 ++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 9d1678c3429e..38eaf4f6decc 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -715,6 +715,7 @@ DiscoverRedfishHostInterface ( > The function initalizes particular strings into > EFI_REDFISH_DISCOVERED_INFORMATION structure > > > > @param[in] Information EFI_REDFISH_DISCOVERED_INFORMATION > > + @param[in] IsIpv6 Flag indicating IP version 6 protoco= l is used > > @param[in] RedfishVersion Redfish version. > > @param[in] RedfishLocation Redfish location. > > @param[in] Uuid Service UUID string. > > @@ -729,6 +730,7 @@ STATIC > VOID > > InitInformationData ( > > IN EFI_REDFISH_DISCOVERED_INFORMATION *Information, > > + IN BOOLEAN IsIpv6, > > IN UINTN *RedfishVersion OPTIONAL, > > IN CONST CHAR8 *RedfishLocation OPTIONAL, > > IN CONST CHAR8 *Uuid OPTIONAL, > > @@ -738,7 +740,8 @@ InitInformationData ( > IN CONST CHAR8 *ProductVer OPTIONAL > > ) > > { > > - UINTN AllocationSize; > > + UINTN AllocationSize; > > + CONST CHAR8 *IpAddress; > > > > if (RedfishVersion !=3D NULL) { > > Information->RedfishVersion =3D *RedfishVersion; > > @@ -746,10 +749,21 @@ InitInformationData ( > } > > > > if (RedfishLocation !=3D NULL) { > > - AllocationSize =3D AsciiStrSize (RedfishLocation) * sizeof (C= HAR16); > > + AllocationSize =3D AsciiStrSize (RedfishLocation) * sizeof (CHAR16); > > + IpAddress =3D RedfishLocation; Not quite understand why do we need a copy of RedfishLocation in IpAddress? I think we can use RedfishLocation for UnicodeSPrintAsciiFormat later, righ= t? Thanks Abner > > + > > + if (IsIpv6) { > > + AllocationSize +=3D 2 * sizeof (CHAR16); // take into account '[' = and ']' > > + } > > + > > Information->Location =3D AllocatePool (AllocationSize); > > if (Information->Location !=3D NULL) { > > - AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, > AllocationSize); > > + if (IsIpv6) { > > + UnicodeSPrintAsciiFormat (Information->Location, AllocationSize, > "[%a]", IpAddress); > > + } else { > > + AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, > AllocationSize); > > + } > > + > > DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > Information->Location)); > > } else { > > DEBUG (( > > @@ -991,6 +1005,7 @@ AddAndSignalNewRedfishService ( > > > InitInformationData ( > > &DiscoveredInstance->Information, > > + CheckIsIpVersion6 (NetworkInterface), > > RedfishVersion, > > RedfishLocation, > > Uuid, > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112632): https://edk2.groups.io/g/devel/message/112632 Mute This Topic: https://groups.io/mt/103181051/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-