public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Nickle Wang <nicklew@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-redfish-client][PATCH 5/6] Tool/Redfish-Profile-Simulator: Add missing module
Date: Tue, 9 May 2023 06:06:46 +0000	[thread overview]
Message-ID: <MN2PR12MB39660CE95C8BFB3FD825617AEA769@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230508145202.16945-1-nicklew@nvidia.com>

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH 5/6] Tool/Redfish-Profile-Simulator:
> Add missing module
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Add missing module import for conditional, RfCollection, RfResource,
> RfResourceRaw, hashlib and OrderedDict
> 
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py | 5 ++++-
>  Tools/Redfish-Profile-Simulator/v1sim/resource.py    | 2 ++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py
> b/Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py
> index 35d3794c..53a44849 100644
> --- a/Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py
> +++ b/Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py
> @@ -1,7 +1,7 @@
>  #
>  # Copyright Notice:
>  # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> -# (C)
> Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +# (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  #  # Copyright Notice:
> @@ -16,6 +16,9 @@ from flask import request
> 
>  from .flask_redfish_auth import RfHTTPBasicOrTokenAuth
> 
> +from redfishProfileSimulator import conditional from v1sim.resource
> +import RfCollection, RfResource, RfResourceRaw
> +
>  from werkzeug.serving import WSGIRequestHandler
> 
>  def rfApi_SimpleServer(root, versions, host="127.0.0.1", port=5000, cert="",
> key=""):
> diff --git a/Tools/Redfish-Profile-Simulator/v1sim/resource.py
> b/Tools/Redfish-Profile-Simulator/v1sim/resource.py
> index 0c7a8382..f6bd15cf 100644
> --- a/Tools/Redfish-Profile-Simulator/v1sim/resource.py
> +++ b/Tools/Redfish-Profile-Simulator/v1sim/resource.py
> @@ -15,6 +15,8 @@ import os
>  import sys
> 
>  import flask
> +import hashlib
> +from collections import OrderedDict
> 
>  if sys.version_info >= (3, 5):
>      from typing import Type
> --
> 2.17.1

      reply	other threads:[~2023-05-09  6:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 14:52 [edk2-redfish-client][PATCH 5/6] Tool/Redfish-Profile-Simulator: Add missing module Nickle Wang
2023-05-09  6:06 ` Chang, Abner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB39660CE95C8BFB3FD825617AEA769@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox