From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CE83BAC0344 for ; Tue, 28 Nov 2023 02:01:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+YRzTpwjNDeZS577WGuVPRi3e9TzmytaQXC8WFG6itY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701136911; v=1; b=u0RDB0y4pAcTwUyf1Sc2wNwxCDAfyq9OUP6T/iZVdpoi5AkuUVP8pu+zD4L8BK06Ohh/1dXi hDt/PRUDQ09OgNDwAH6Y3nbWX/65gEaKTDceJe+RhRF5KlFr6+GP8c2N8MExETPU4h9pXMYMFz8 xW5sF5nVfGX7F51Qhf9Qekmc= X-Received: by 127.0.0.2 with SMTP id DePTYY7687511xIL0vApLFb9; Mon, 27 Nov 2023 18:01:51 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.72]) by mx.groups.io with SMTP id smtpd.web11.19419.1701136910624952263 for ; Mon, 27 Nov 2023 18:01:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fmd0me4OOh5OshFCg6/7CWUWlT2m+zfUWSJsnJg0g4i/NVXqr1C3VqsOnC1FWaRLhi0ve6Gq6Wh/Qj6/NyiRFVbvsB1v948btsSYg9UVcfrvB2k0OJDBe1AhaohrY5UywKFcVyTSsuZziBdvcOk7lWb3hgr0ZK4SMRXjbwzoAX6Kpv34MX1bb2X4li6+NZNr0MpJfA+tmSUrF2jHD99M9uOPTl4i8KBl0xZaz3NHleKhqYby12zLNAWIDjeh2EB5gri+nPz19E07a86y8su21tXlAAgnZ8DLaLhpojvNQSmZ0OL2oD8FRKzFIUTlaCRPsQvTZuQ3hiOHytNXiO4JhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ToMxr/ppKSWOkccWpUy1+z90KQP20lVed4HCdCpz5gk=; b=JWoIB3Owwi8eHvH2P7yGPDD/Z6RVYNljWQgQcOihSAt5w9fKl0UpvFLE3ybsyIuHRIk032qg9t9laejppFcr5mc/N+4hSo+NZrVy/2rbQ14pmCFq4Asxi6ugui5ND3WPjFFkdx3gcBxgn23s8GD7T+p3t4DE1I7k1w7LuMpwvW6SJbVFmak47DXI+bWFxYGhZIfkI5kJ9i4+P9kqvEPl8G2aNheatPawzQh68+iZ7+KSTpNZLwXfqMfoQjCFESasswmnES7Q/ejZ5ccxpOAa8P7Osrz8Q94oW+Kj3jEVVrlxp3zQONUCObC53my1SkXd0OSnt0Evw20DenUZK9X3Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by IA1PR12MB6457.namprd12.prod.outlook.com (2603:10b6:208:3ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Tue, 28 Nov 2023 02:01:46 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 02:01:46 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 1/1] RedfishClientPkg/RedfishFeatureCoreDxe: fix incorrect URI issue Thread-Topic: [edk2-redfish-client][PATCH 1/1] RedfishClientPkg/RedfishFeatureCoreDxe: fix incorrect URI issue Thread-Index: AQHaIZh+20W17YGcekib296XmnMJD7CO+k8A Date: Tue, 28 Nov 2023 02:01:46 +0000 Message-ID: References: <20231128011555.7596-1-nicklew@nvidia.com> In-Reply-To: <20231128011555.7596-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ea9d1127-5a38-45bd-8d51-b007d1dc8571;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-28T02:01:07Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|IA1PR12MB6457:EE_ x-ms-office365-filtering-correlation-id: 75c5ea22-2831-4cf5-9c1f-08dbefb5f9f1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qljRhxBLuhqURIIfBNhS8bkKMV4TT+0wQ46iZa/qYcDaLBFtsT8JV3lcuZaBr/WKZ3A7fLhOsX4xDHdHFN36U7w+HcwhongTKN2hWyJm0wyUqZBf4BUmSF/EKkoT0B9ClZAEjWGzomr4h/wvve4LwttjiUUTkVIaRCrWggoKBxh37ZGX6YVO2fB6ECbFjMDjmQ4tgj6lqZb9Pgzri/kISQgsqTvSsADpG/+c6iCCJUhSSNY+KsOEhNBYFzicXH2PstEwdDrY2nMR4z+Dp8GJp5uHKJpDwr4abxWMCFOTG7Mvi78YV9W5JjHKBtjmZ27T9GLAxxnzED5nz7H/luD5OEGgTA6xJgHi+L2aPggMZgXa8wirXIMGg02JJcnVoXnY3bGzstxKIdFFGuwT3CzdmkHhO1DJt+DvSl6XiXJ48aQOLokTeoZzYyvMKkqro0fZAgBMGbCVxDaxxywTP9zg8yk7QY4Upnz3/qjIxg2JkmCYc+oAI9FIhZsQ/p471aLwzDqP0TH0JxslnB3xIq+QHIMzS1Tlz8P/oP3CbSt4/pBtW0qqW07OCcK9MH9a+hqYIEr00VRFDQTo+wV/5+loNJ1CtpS+omqQi7pMajFfC9mF6NRorPOt5u3DYZ5oN1qfdObynLlG3mOUo6CTcWiWyysJdnRppaTCrjTT/ukVPDw= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2/DYMcr6dGuAoTyHzyajnZz6D3kp6CV+/bbJw4gIIdyBzGdhbAV15hVw4i7g?= =?us-ascii?Q?6IH/DottHVVdW97cvov0YLoC5nq1ZsLggR+cduHE+VMacY5NZ4jy+nsAiKHf?= =?us-ascii?Q?Ow9N8Q7NPE3z40zHP6frEiM5m0OMYWyPVFhB5v4sGLtiykt7ujFQmSg4kz9r?= =?us-ascii?Q?JKDu2RPEJiNasjISkqZCi9snPTRImY/1edH+zVNn0KTknIyv93sCg+tCBzMH?= =?us-ascii?Q?w8bhFMNGaT4uQqnVTpIlnjgO5WV6boE7hPSC2l0Hdc8d8VGZy82V4gJnhVqT?= =?us-ascii?Q?gAWNP9bQTObNjCYt6YMbL2rkQqYsU/GrjtQlEiTRe3TIm/fVf7iD2BdgoVr9?= =?us-ascii?Q?xJEu/wrUB6nb9UjSDbln8q/wyh14zwyenIFIRML2zSIg9aTuRiguFBE4eDsG?= =?us-ascii?Q?AhojkWeWJrHZ2zVO1KU3QKsRTCyfgt4ns+x/mfSgi6LP9rsrQplpaRH+irZk?= =?us-ascii?Q?QjQk88DjmQy2XguvZf4Q+SiyO0VH7LrMWjLCyvKqvN1vuOTztRpL6NvkmGB2?= =?us-ascii?Q?jyuRxP+oXF/ZF6sOwguxT183obzc9U6CHqZlWDPISap1Rz9O1A8dCskvdFbw?= =?us-ascii?Q?mtnB18YUMbPvl0Cvoz0PtzF8ccsmvP7oYWbpRLxZn4l5TRCen0IvfEwstACJ?= =?us-ascii?Q?7M1UwLlWt3HDdEI/nhyIzoIYlV7RlDDNmusVC3TSLys47c4+3J7afDusle6E?= =?us-ascii?Q?abBFnusIM+hz3yzYGYRrGciBOo9m9ktE53NRXYjQy89pPdSU1GaoUZsvmzTH?= =?us-ascii?Q?wovPbRZqKjtES384QKamzt8kln4MHRia4El2g/7+9tevXvisN+Md6Ilp8poV?= =?us-ascii?Q?BsvTKFnGSD7w58SWaDSlV2Lqo0cxqbRp7+qB8Vx7XZ4qyoIkKUDAGVvd9cao?= =?us-ascii?Q?gFzNHH3ukh7Az7sjd7GC6TJg+EMeu9NpwAumqBIAHBJ4YqTGHqx4i+CRiN83?= =?us-ascii?Q?IWvakkB9uCAPSIUdGZ/ZNSd9MLY/yFwZjbx3HyoKrndR7KPkfdCI8gsbM5Es?= =?us-ascii?Q?ofYklecAqOD2buUNUUKhhFXHB42m/5MZp9WLA2hh9o1ZeidD+xNnLgkfJlxM?= =?us-ascii?Q?MDKKDf70YIrvntqEwLMDFSbb48jXHslQVU6+v4hCPVDyj8/n1Amp0ib61az2?= =?us-ascii?Q?0jeCrl18qgkRXkrT+OcGeFZV0YSMk3xvtQ4jVQZYalfWzM5JAS5JCjKPlnkE?= =?us-ascii?Q?Q6uii2p+f0KXMZDmOzAopxWb8T/BlUmpO9sOrUOLILAlEOOQiDz4dOM5aczI?= =?us-ascii?Q?Hpyohzm/baFvDwItewWVlVbeKWHTsVRDsDbuGIIK0yb+8Oylven55Be2B+n1?= =?us-ascii?Q?O4cDTmn0dganK1lTvHEa1QixZLqG8/fUDDQPczYo9gjH/VGb+LLch4d0VBgN?= =?us-ascii?Q?UQCRKiaUDWkYF/+qwJ3rXtHs/ZX3oPRCY/osn3ppS56U4HcslqOQ3LU9DzvA?= =?us-ascii?Q?bYQdwPJ9O+QjVEhshbIlBn5BrZnSJUw1BWgNwyZrYsIsZGhe+mb7/2mLpqwR?= =?us-ascii?Q?9JaAJKwP1hSnjh0OBsh85Mo6NyOiUcNvL/b/+ZEsZqcZxPnlZkXG8GOHYgRb?= =?us-ascii?Q?mcrANkDf7VHdD4Kdsiw=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75c5ea22-2831-4cf5-9c1f-08dbefb5f9f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 02:01:46.3942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zyc7TJMkW4V+R/QZevGtNQVBENrXfpLk5j8/jpeSF//KRhj/oNNPO7jBF6qseRJ0z4TwtPIpYvbPJ2wcXO9ImQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6457 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8PBsHrQJX229lrAV7SkhBMkGx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=u0RDB0y4; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Looks good. Please go ahead to merge it. Reviewed-by: > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, November 28, 2023 9:16 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 1/1] > RedfishClientPkg/RedfishFeatureCoreDxe: fix incorrect URI issue > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > -Fix incorrect URI issue. There is missing "/" while > StartUpFeatureDriver() recursively calls itself. > -Fix typo. > -Update function name to follow the naming style. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishFeatureCoreDxe.h | 5 +- > .../RedfishFeatureCoreDxe.c | 51 ++++++++++--------- > 2 files changed, 31 insertions(+), 25 deletions(-) > > diff --git > a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.h > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.h > index 93139af2..acefa41b 100644 > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.h > +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.h > @@ -27,8 +27,9 @@ > > #define MaxNodeNameLength 64 > #define MaxParentUriLength 512 > -#define NodeSeperator L'/' > -#define UriSeperator L';' > +#define NodeSeparator L'/' > +#define NodeSeparatorStr L"/" > +#define UriSeparator L';' > #define NodeIsCollectionLeftBracket L'{' > #define NodeIsCollectionRightBracket L'}' > #define NodeIsCollectionSymbol L"/{}" > diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe= .c > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > index e2ae125f..51d0387c 100644 > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > @@ -20,13 +20,13 @@ RESOURCE_INFORMATION_EXCHANGE > *mInformationExchange; > Setup the information to deliver to child feature/collection driver. > > @param[in] ThisList REDFISH_FEATURE_INTERNAL_DATA ins= tance. > - @param[in] ParentConfgLanguageUri Parent configure language URI. > + @param[in] ParentConfigLanguageUri Parent configure language URI. > > **/ > EFI_STATUS > SetupExchangeInformationInfo ( > IN REDFISH_FEATURE_INTERNAL_DATA *ThisList, > - IN EFI_STRING ParentConfgLanguageUri > + IN EFI_STRING ParentConfigLanguageUri > ) > { > ThisList->InformationExchange->SendInformation.ParentUri =3D > (EFI_STRING)AllocateZeroPool (MaxParentUriLength * sizeof (CHAR16)); > @@ -52,7 +52,7 @@ SetupExchangeInformationInfo ( > // > // Setup parent config language URI > // > - StrCpyS (ThisList->InformationExchange->SendInformation.ParentUri, > MaxParentUriLength, ParentConfgLanguageUri); > + StrCpyS (ThisList->InformationExchange->SendInformation.ParentUri, > MaxParentUriLength, ParentConfigLanguageUri); > > // > // Full config language URI > @@ -63,7 +63,7 @@ SetupExchangeInformationInfo ( > ThisList->InformationExchange->SendInformation.ParentUri > ); > if (StrLen (ThisList->InformationExchange->SendInformation.FullUri) != =3D 0) { > - StrCatS (ThisList->InformationExchange->SendInformation.FullUri, > MaxParentUriLength, L"/"); > + StrCatS (ThisList->InformationExchange->SendInformation.FullUri, > MaxParentUriLength, NodeSeparatorStr); > } > > StrCatS (ThisList->InformationExchange->SendInformation.FullUri, > MaxParentUriLength, ThisList->InformationExchange- > >SendInformation.PropertyName); > @@ -77,7 +77,7 @@ SetupExchangeInformationInfo ( > > **/ > EFI_STATUS > -DestroryExchangeInformation ( > +DestroyExchangeInformation ( > IN REDFISH_FEATURE_INTERNAL_DATA *ThisList > ) > { > @@ -111,7 +111,7 @@ DestroryExchangeInformation ( > } > > /** > - Startup child feature drivers and it's sibing feature drivers. > + Startup child feature drivers and it's sibling feature drivers. > > @param[in] ThisFeatureDriverList This feature driver list. > @param[in] CurrentConfigLanguageUri The current parent configure > language URI. > @@ -121,7 +121,7 @@ DestroryExchangeInformation ( > VOID > StartUpFeatureDriver ( > IN REDFISH_FEATURE_INTERNAL_DATA *ThisFeatureDriverList, > - IN EFI_STRING CurrentConfigLanguageUri, > + IN EFI_STRING CurrentConfigLanguageUri OPTIONAL, > IN REDFISH_FEATURE_STARTUP_CONTEXT *StartupContext > ) > { > @@ -131,6 +131,10 @@ StartUpFeatureDriver ( > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList; > EFI_STRING NextParentUri; > > + if ((ThisFeatureDriverList =3D=3D NULL) || (StartupContext =3D=3D NULL= )) { > + return; > + } > + > NextParentUri =3D (EFI_STRING)AllocateZeroPool (MaxParentUriLength * s= izeof > (CHAR16)); > if (NextParentUri =3D=3D NULL) { > DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for parent configu= re > language.\n", __func__)); > @@ -174,7 +178,7 @@ StartUpFeatureDriver ( > // Copy RESOURCE_INFORMATION_RETURNED then destroy the > exchange information. > // > CopyConfiglanguageList (&ThisList->InformationExchange- > >ReturnedInformation.ConfigureLanguageList, &ConfigLangList); > - DestroryExchangeInformation (ThisList); > + DestroyExchangeInformation (ThisList); > // > // Modify the collection instance according to the returned > InformationTypeCollectionMemberConfigLanguage. > // > @@ -192,6 +196,7 @@ StartUpFeatureDriver ( > return; > } > } else { > + StrCatS (NextParentUri, MaxParentUriLength, NodeSeparatorStr); > StrCatS (NextParentUri, MaxParentUriLength, ThisList->NodeName); > StartUpFeatureDriver (ThisList->ChildList, NextParentUri, > StartupContext); > } > @@ -205,7 +210,7 @@ StartUpFeatureDriver ( > NextParentUri[0] =3D 0; > } > } else { > - DestroryExchangeInformation (ThisList); > + DestroyExchangeInformation (ThisList); > } > > // > @@ -340,7 +345,7 @@ NewInternalInstance ( > REDFISH_FEATURE_INTERNAL_DATA *NewInternalData; > > if ((PtrToNewInternalData =3D=3D NULL) || (NodeName =3D=3D NULL)) { > - DEBUG ((DEBUG_ERROR, "%a: Inproper given parameters\n", __func__)); > + DEBUG ((DEBUG_ERROR, "%a: Improper given parameters\n", __func__)); > return EFI_INVALID_PARAMETER; > } > > @@ -373,7 +378,7 @@ NewInternalInstance ( > Insert the URI node into internal data structure > > @param[in] HeadEntryToInsert The head entry to start the searc= hing. > - @param[in] PrevisouEntry Previsou entry. > + @param[in] PreviousEntry Previous entry. > @param[in] NodeName Name of URI node. > @param[in] NodeIsCollection TRUE means the node to add is the > collection node. > Otherwise it is a resource node. > @@ -390,7 +395,7 @@ NewInternalInstance ( > EFI_STATUS > InsertRedfishFeatureUriNode ( > IN REDFISH_FEATURE_INTERNAL_DATA *HeadEntryToInsert, > - IN REDFISH_FEATURE_INTERNAL_DATA **PrevisouEntry, > + IN REDFISH_FEATURE_INTERNAL_DATA **PreviousEntry, > IN EFI_STRING NodeName, > IN BOOLEAN NodeIsCollection, > IN OUT REDFISH_FEATURE_INTERNAL_DATA **NextNodeEntry, > @@ -422,10 +427,10 @@ InsertRedfishFeatureUriNode ( > if ((HeadEntryToInsert =3D=3D NULL) && (ResourceUriNodeList =3D=3D N= ULL)) { > ResourceUriNodeList =3D NewInternalData; > } else { > - (*PrevisouEntry)->ChildList =3D NewInternalData; > + (*PreviousEntry)->ChildList =3D NewInternalData; > } > > - *PrevisouEntry =3D NewInternalData; > + *PreviousEntry =3D NewInternalData; > *NextNodeEntry =3D NewInternalData->ChildList; > return EFI_SUCCESS; > } > @@ -439,12 +444,12 @@ InsertRedfishFeatureUriNode ( > if (StrCmp ((CONST CHAR16 *)ThisInternalData->NodeName, (CONST > CHAR16 *)NodeName) =3D=3D 0) { > *MatchNodeEntry =3D ThisInternalData; > *NextNodeEntry =3D ThisInternalData->ChildList; > - *PrevisouEntry =3D ThisInternalData; > + *PreviousEntry =3D ThisInternalData; > return EFI_SUCCESS; > } > > // > - // If sibing exist? > + // If sibling exist? > // > if (SiblingList =3D=3D NULL) { > Status =3D NewInternalInstance (&NewInternalData, NodeName, > NodeIsCollection); > @@ -453,7 +458,7 @@ InsertRedfishFeatureUriNode ( > } > > ThisInternalData->SiblingList =3D NewInternalData; > - *PrevisouEntry =3D NewInternalData; > + *PreviousEntry =3D NewInternalData; > *NextNodeEntry =3D NewInternalData->ChildList; > return EFI_SUCCESS; > } > @@ -483,7 +488,7 @@ InsertRedfishFeatureUriNode ( > on Redfish resource which is managed = by this Redfish > feature driver. > @param[in] Context The context of the registering featur= e driver. The > pointer > - to the conext is delivered through ca= llback function. > + to the context is delivered through c= allback function. > @retval EFI_SUCCESS Redfish feature driver is registered = successfully. > @retval EFI_SUCCESS Redfish feature driver is registered = successfully. > @retval EFI_INVALID_PARAMETER Improper given parameters or fail to > register > @@ -535,8 +540,8 @@ RedfishFeatureRegister ( > } > > NodeName[Index - AnchorIndex] =3D *(FeatureManagedUri + Index); > - if ((NodeName[Index - AnchorIndex] =3D=3D NodeSeperator) || > (NodeName[Index - AnchorIndex] =3D=3D UriSeperator) || (NodeName[Index - > AnchorIndex] =3D=3D (CHAR16)0)) { > - if (NodeName[Index - AnchorIndex] =3D=3D UriSeperator) { > + if ((NodeName[Index - AnchorIndex] =3D=3D NodeSeparator) || > (NodeName[Index - AnchorIndex] =3D=3D UriSeparator) || (NodeName[Index - > AnchorIndex] =3D=3D (CHAR16)0)) { > + if (NodeName[Index - AnchorIndex] =3D=3D UriSeparator) { > NewUri =3D TRUE; > } > > @@ -554,7 +559,7 @@ RedfishFeatureRegister ( > Index +=3D (StrLen (NodeIsCollectionSymbol)); > AnchorIndex +=3D (StrLen (NodeIsCollectionSymbol)); > ItsCollection =3D TRUE; > - if (*(FeatureManagedUri + Index) =3D=3D UriSeperator) { > + if (*(FeatureManagedUri + Index) =3D=3D UriSeparator) { > NewUri =3D TRUE; > } > } > @@ -569,7 +574,7 @@ RedfishFeatureRegister ( > > if (NewUri || ((Index + 1) >=3D UriLength)) { > // > - // Setup the callabck and restart the searching for the > + // Setup the callback and restart the searching for the > // next URI. > // > if (MatchNodeEntry !=3D NULL) { > @@ -639,7 +644,7 @@ EDKII_REDFISH_FEATURE_PROTOCOL > mRedfishFeatureProtocol =3D { > @param[in] ImageHandle Image handle this driver. > @param[in] SystemTable Pointer to SystemTable. > > - @retval EFI_SUCESS This function always complete successfully. > + @retval EFI_SUCCESS This function always complete successfully. > > **/ > EFI_STATUS > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111777): https://edk2.groups.io/g/devel/message/111777 Mute This Topic: https://groups.io/mt/102842987/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-