From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8D3BFAC0E21 for ; Wed, 18 Oct 2023 13:38:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UhFLFQAvlU3iY9mv9xLbGXBy+1m90uialmBB+XdFl/s=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697636292; v=1; b=fskTIduCd9ulPbPkr32gdIE6lD6X+uk5J4YExoCfOQ6gVqysvbkgncY26DYs+rhkVf2FAZVI Oz+kyNkcvAdd3W4j0ed1/Rh6nUqFdnxKgSVUuNlCmpsuUgS6FDnuqe3/a8sLJ/3r09UW5C5CiK0 hDQUUDpR6GCE3P2zzp9TcoBs= X-Received: by 127.0.0.2 with SMTP id GyFPYY7687511xvKWRGSxFJO; Wed, 18 Oct 2023 06:38:12 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.43]) by mx.groups.io with SMTP id smtpd.web10.281830.1697636291447571496 for ; Wed, 18 Oct 2023 06:38:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTToMNty0uwo/gLdTtaEAFdBhU1e2eZ4C8w7q2LRMJQ8RqMhBS7iMMUHMNYt3KReFjwxIMqvLjOIH1tAnIPfy7iTY6myHFe+jdrpImtFd+/5bqgEXKRPhDAKfgin1qR8JdIhWUq7Pj5T0rIOJUGd3VqgSazVqaIEijwDZWj7MN+4jvv+AaX/wRHcXQsm4WqeHTd3CU0zshPvWnOc9GJOMXzM6NvSduKfrTVBUfadGAznZyccvFsLzjkHe3qGchStE2rdx3s9uHSRsTM+0HoqfXl6LYJmoJxVTriFIk839fBwN7sJ40Y8eq4QgusFypC7COAYNkrx4q+n0SX/xcg1GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9hW+2cYHbDC7OSMQWp9Ky+SGvVvA8aVciN4uHwuU1xQ=; b=EwVrvMZXHSdsqe/FOP8tbnaUEjP+cvg5byv4I96VkN8F/EjzQBac6GM9bUUHoNrzgbtepRlKZiiGe7HkCDv/0d/6j86LChVsAvI7vOdhlELD9XhTY5gV6fy5wf4mlGvcx1snwGD21e/1HIKQKpmTx8Zj005gJhl6mDH/NxjIV/jLNVPKnL2WZzilmNtNobOfN86phtPcE+xeWDvFuMPF5kXKvGvY/t3aDUQ5Zp25vSmzTmeY2OZrae0Qzu2RDOLJXtYvy5xe7sEmlui4jeXJPmVYRlyiW7AbTeObuG5qOcP0WKFMVkq5o9Yztk/TERKz7BbzMFkxhhmgpaIGdrPFOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by IA0PR12MB8895.namprd12.prod.outlook.com (2603:10b6:208:491::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Wed, 18 Oct 2023 13:38:09 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b%6]) with mapi id 15.20.6907.021; Wed, 18 Oct 2023 13:38:09 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout Thread-Topic: [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout Thread-Index: AQHaAcQnjWWx6LF3l0GXEMha4rLyALBPjREQ Date: Wed, 18 Oct 2023 13:38:08 +0000 Message-ID: References: <20231018130743.7712-1-nicklew@nvidia.com> In-Reply-To: <20231018130743.7712-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ff57c937-8c2d-46b8-85bf-1adedd30b456;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-18T13:37:56Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|IA0PR12MB8895:EE_ x-ms-office365-filtering-correlation-id: 1e3b46de-b499-493b-4aee-08dbcfdf775c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 4DojzitS8Qi1PIZTe9ooscjiAJqXcZ1lpxLInixCvsj3iXh39fhU5fU5sq4tixBRZ/5uSX14gSoVQY29kfzqEHftFwpPgcI9u6cwC+Ba6yK+rIg5zEGOcnIjExN2pZB6uFPY5XwVveek+ZUyhGwJFvVEIdkOPCRqJfSHGWWgGvsgtv7umfUf9jFDsRFp2GMm25o6rdDQ52hNQcmcAqpwP2jHqkQ9k2FVdbr/SzDXHB+Vduhbmr0CNYb5nQXbNaUgXKCGmUckFhDa4aC6pDtDMyD17VCNjlTkNAcDkhDlZEDTfMmkDZbxJ2cp+5YAYExrL5KbKApKEQy8WoGcax3k6n9u3s1Ku8iJIiuxiKwHl4kOtr48ULE6JB8l1qvbxdsMCRGhlZxWzX+UaQmAbeztC43rokeRlaMLoNwGomW8ZFvgBpc4wRV/jjvMJdW6z4D+uLzWhtcnJZDTfsqKVP6fbo/Z83ZrZaqp3wglV08KXSV+e8tIjt3U3wwq49sMGCRL946724XIqNyu6Ty7ZgpA6Ljm/fj8Kj+u3+qB5Hwa4G1jrjiAXn/0eZdsy0kPeC/rO+KLcf0bhoHJwb6bod2ZDzR+CaLd1ZgasboYYWDWwGgbP6dQYOOufwihni8u47IrXVjqfhDTj1pMhUTOIswHnQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3wm7PfMnDiI9zP+X1KUwiEcjYW7gfsy5wyWTY4GDw6xFLY9YD8NlrUEN2Wp+?= =?us-ascii?Q?+UlnVlvhIzvYPg+k6WTBpLv/USZR3ka5MgDjtPtIv4pGi+TNqXQXAYA9eivU?= =?us-ascii?Q?v2QDE3nYktbkf7rKziGaOVFlMZIuoskSmy3cVFEbo45TAit7gZYTE+3Ke5IL?= =?us-ascii?Q?vE5JztEq0P3RWXHWaY0CpifF4webINlbUfnQVsUhbTaAg7aF//0Ydp3fYUkm?= =?us-ascii?Q?Ve2lQrbTn5rr3jwnJNUYm7Yem78FfifOSPNXEpnvBsbEceJ12ad0YA01iTJO?= =?us-ascii?Q?ciOYCu/VZe84XUKy/cj25CvstsVlGwqJSPPgejYIhmyf4a9CNsU01dG598HK?= =?us-ascii?Q?ADp2bdmIKcqGP5QFK/UQMHufQ/cn5Mxundw9m0t1LcwQTMV619qn0UfWE/xe?= =?us-ascii?Q?Bjo1i1eVATtNm+U8nlDPvMWhP2HxBPIYYqmyBXs1wpkuKKJys2vECBlieEF6?= =?us-ascii?Q?AHzFCpFi7UPH7l4XvSoLqrJjKpYdp0KRBeIpuzb2GATR16PD/4enYljaHP3i?= =?us-ascii?Q?3LrI2Ljf9yKsvjWCBx8bCxOq2iEXHxLDxr/jLLUAaO+xUyZuwAu/N0T2Go45?= =?us-ascii?Q?Kuz1g1riOqfx/HoNUQxRY8a0HZg11y1Hqw6ipeo6gwuxl4hnz8BbAd6wxYWE?= =?us-ascii?Q?D/PP3AnS/yGhKe2bjSUBaIVMbeQhZ+lwcN2dCY4K6hf5KKvhAg+rgdsVxrUB?= =?us-ascii?Q?3ZBmjRzrmM+A3czatn+lWsf70UBTAuu50/deA0y95QrLep0mG9RNSrCtGITV?= =?us-ascii?Q?Wq1cLuTFyJRrSjEkCCm9QWdSuB8dLG6IcEp/y+rAKiD9+3xTe+p4Bem80TsR?= =?us-ascii?Q?dVMe3//aRjDiFPNQ6Ex0bOUFVbEUKHtgmnk0DE3l4UCjLZubjyQqSW6m9BX+?= =?us-ascii?Q?brnvyJ5cuNK0T2WaPFvDjObiRlGqQvjR8JmumQ1/SqJweFq/IFX7+oQXBGjJ?= =?us-ascii?Q?fXoX02Z7yO3Z7LNbAn3OD9oR+QnRpK7GFkIsyyFfyO2e/YCdcCXBUPQjVpMP?= =?us-ascii?Q?af9TApaAUTAtdEYdopWfYbEOZqHeaQ1ts6UFTSlH2/wEGb6wkYc6CKGVv8L6?= =?us-ascii?Q?ODpFnix+s6VuzYg7vC0ghyQbbGrTBKc0pBEZudDETQg1FnnY9XL/gjYEFnjR?= =?us-ascii?Q?geY8cCEqiOY9S/1TEDuF5ydEog5Alv8w92LsvpJlYb6YgO3BCbQxhI+jSber?= =?us-ascii?Q?gKEl7fdRvYcMD57eZreyVgNv2DSTN4fyKIPlqGBPjs0IjKf95qkO89kWByKj?= =?us-ascii?Q?yau/s+nE3K6BHnE/sU8bgvgJjU7xfbJyVtTPCHqlbh9D6IGryggqTaevBEzu?= =?us-ascii?Q?LOJf4jaJ3RLKMYd3pG5FhDrOUQbb+j2F+n0E/Lh7ajMp3/A3Z4fNlyllbjxM?= =?us-ascii?Q?/327RimP+CvAfzK1SB7fknfi90A9pAFAJmLgRnTlCFFMtLa15iQ5s5D30iTG?= =?us-ascii?Q?dQbuC6kNdFm37nUSzsnlRaxFYGS6Q71OaLBmXzfKFOguXfEZMu1T6Nr94ctR?= =?us-ascii?Q?6dU60Pbo74kFel4+LFZIJxizk671z+2q4mK7cJ8vYa8/d1z8GUUPmBkZau/G?= =?us-ascii?Q?jTvrNmF/pZwk+8uISoWE/GP5CGt7kpHo/uuaAZMD?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3b46de-b499-493b-4aee-08dbcfdf775c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2023 13:38:09.0144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ndnN9GVbwlutqHRqJSDEg1CrWtPG4uA/IOge7Y1KiPxI0FWgHhJvgXpqbCmXu8KV1EySvsbcPnA7DDB0w568Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8895 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NcK1liAQ8A8u2vLpqT8DQQDYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fskTIduC; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, October 18, 2023 9:08 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce > PcdRedfishSendReceiveTimeout > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe > driver. The SendReceiveTimeout is hard-code value in Redfish discover > driver. With this PCD, platform owner can configure timeout value > easily. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > RedfishPkg/RedfishPkg.dec | 5 +++++ > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf | 2 +- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index cdb1528cedc9..0f18865cea0b 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -142,3 +142,8 @@ > # This PCD indicates that if BMC bootstrap credential service will be = disabled > by BIOS or not. > # > > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService| > FALSE|BOOLEAN|0x00001007 > + # > + # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that > RedfishDiscoverDxe driver > + # set to EFI_REST_EX_PROTOCOL. > + # > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT3 > 2|0x00001008 > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > index 950098bf6a0d..c982056fd700 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > @@ -54,4 +54,4 @@ > > [Pcd] > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand ## > CONSUMES > - > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout ## > CONSUEMS > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 17c88ad82db4..2f9e604f6cd6 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -877,7 +877,7 @@ AddAndSignalNewRedfishService ( > goto EXIT_FREE_CONFIG_DATA; > } > > - RestExHttpConfigData->SendReceiveTimeout =3D 5000; > + RestExHttpConfigData->SendReceiveTimeout =3D PcdGet= 32 > (PcdRedfishSendReceiveTimeout); > RestExHttpConfigData->HttpConfigData.HttpVersion =3D HttpVe= rsion11; > RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6 =3D > CheckIsIpVersion6 (NetworkInterface); > if (RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6) { > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109749): https://edk2.groups.io/g/devel/message/109749 Mute This Topic: https://groups.io/mt/102038456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-