From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2FB0978003C for ; Wed, 1 Nov 2023 13:34:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FYjO/4D1wP9OQooImWHlX26uGVLezYsa3i5r5hxo598=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698845666; v=1; b=vDbAmKUon0Zxz7EyUj1E3SuSIKoamhG9PkKonieRmHv48PbuRAAf7+VJH/sOjWkEbDp/u0Kj o/LA+K6Ee5nRo8pomnQ5rF9xvTIFo26A/qEa2FhkmCt4IWGyQc4eEdl5uPU044Ve8qQhh1JuaaQ HzcKR7/UzLaJpQkN0HEBkC7Q= X-Received: by 127.0.0.2 with SMTP id lVHaYY7687511xZQ9Nke1dYB; Wed, 01 Nov 2023 06:34:26 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.53]) by mx.groups.io with SMTP id smtpd.web10.7422.1698845666168538492 for ; Wed, 01 Nov 2023 06:34:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJW0078bMQDufNGjZjagNfhK1hIOWPvX1XAdxnHjwOchzRHnxRHpS9PIjOshpIsbScG2xKxPiyIXxbzQb1rgWD0qmLb+gH6SjFNrCg0yLXEtmYb3IYDE/m5YyR3XiEwlh5NTQL6sSOmv+ZsMEwVb7B0vwQMfGn+YCr7Bo/1d3C886NEACCok6nBi9L8SubqOr3x8P9vd8PxQlHFa6Tt/5L2GevAYPeeTtYahJVinYY2SjeNdvvd2qFK4IIsKz/88sOtBSAwK4hT6k2t/TDehNe2vczjN1lcJSzSZBVzAWuxUUWPbqx6cBgQH/dM/KhC9cDde4rc7LKnFbY2bAYzpqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwLD9xk1rS1y7+1U09S9023LzuV8PoUYaNbVTiZnIe8=; b=WcbgxPuSYXvvLPmoc5kqJRwMex3qBikQeJi67/M/0aRf1vkiyZP8NYXYbSIte9kq5ok7B4qmyZp3vWsW5h+XX4/+yO7TAC9qGlxER1a3xCpbz4bSDg2Gf1hvwsZMtCH1coY+Tr7V4JvgrihiiQJmqlg0dh1PkoGVrbW2Va165J5GvD1T5rnaRUYyGfJZe3npve+IFnmJUXTAeqbnA4KoUo6kwOY5PwuoY4BOTxmwNe9L7k50Z5tDLzXxRKDaDxraPnrtf8Vmcr0hpf+QqgGcEj7y4ZXXa3kEzF4V9cJLJ+c0fq7WeyJ8NeIfUlTQL2raZoJCYW8EDVzZvV/gs8KQZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by IA0PR12MB8373.namprd12.prod.outlook.com (2603:10b6:208:40d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.28; Wed, 1 Nov 2023 13:34:22 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%7]) with mapi id 15.20.6954.019; Wed, 1 Nov 2023 13:34:22 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue Thread-Topic: [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue Thread-Index: AQHaC84wWQJZpGPveU+pjybakUEqH7BleJYQ Date: Wed, 1 Nov 2023 13:34:22 +0000 Message-ID: References: <20231031074458.23606-1-nicklew@nvidia.com> In-Reply-To: <20231031074458.23606-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c9e6ca38-925d-452a-8766-707b1ee5c8bf;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-01T13:34:12Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|IA0PR12MB8373:EE_ x-ms-office365-filtering-correlation-id: f43d5788-6b75-4f39-c038-08dbdadf4236 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: IAq6h6FRL9+j8HV6kxN69E7ViMKn8kNTq71zv/fJn0gI83+rlS3lYK/a5Ounh+54fhD/spULsEgtHbpMYA8rfdcNiup7afzYGRXhTKjSlAxKFGYw4LTTgeYHacHVyswsxgPLCKxrRnKjDWDAi8RgjR8RpAsFqOxH2IDNLh0IgsechYXUB58HfvsN4aHTGtdaQplb/vra/039MtmMr4A0o7FAVGdG3PKTua63m89nCtpF8MQ5oPqGBth6FMNW7xm4HQok4ErmTfa4BYyKAEWMVVc6j2rwt95LzFXohWPsCq+tVJ/8mVoy5uHxFCFuDsN9kBo28hXHShkYMaRC0obfJENpPqy6MBvAlJVmZ9wVhHH82wgTZI5gN39hW/3XeYCUQG1NcSb9D+hr43GfaUC+RJPBKEllMiIHfhuBkvX72IbF/ImLYitCAEGVTK35RyXD0RdrMH/k3rWwJSRpDJ5Cy05h5sunQNH6EvILiWlieq4GvWK9npeUVCuL9c96VHv3eep/yig6ZY/+cNw7TEBukXsioNjlPlFAYg8jOGrW9lyEEgfZGmhV9Z4ifYCPlHFjNqeDZLXq1zCFTyYBq/HLzKA5FvnG7k0i9c+Ip+/j7Ee6lzfdYKL2hk6hxyGmOhqn6Jj+SF4FtZhd3iDOdU1Tx0EKvdQMKT/88yeq7zu/cPVNO42rmvx5TSqRQe6BsGCV x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1KKtQzATMtGhzIGwI+Du14pZqO1WyoDPDbtoFDn6szwBKU4abssvs93QNTpO?= =?us-ascii?Q?/aPAljfAYZW3BvB2v360oVDOrNfl8PpIag743eiH0TjVcCcqHm626wQ0Tg2K?= =?us-ascii?Q?Ud7g+bcs9Lej0Uga6SYhI0CK3Tp5ftLFTbMgY8l7rHxjWq3LEEeWOgwnyqrG?= =?us-ascii?Q?ciwDgDp5ukthZkxOuKfJuJEaNRjXEzUw6KyjfVFV0CuV/9W4xWvK/BESjSO3?= =?us-ascii?Q?WcZPFqpWmtb/ye50fr8t17giOcBJi3Bxfn16MTggBemMJcwNvnR14LksQ6nR?= =?us-ascii?Q?79d2SDwN9VJbmeiNdy06tVStGsHqKSjXInnP4cm+zzk2EdwphfkP1IFA9H72?= =?us-ascii?Q?1WHzi8+3W14d061FK3qy/27gRx6tJvBnK0YmVHZTJS0xNgY2KTAIz5hr4Imx?= =?us-ascii?Q?ImHRxRgDdJmH1c47VBLfxZHvvh9dK9EsqUrmSai5bQM3E7nXM/LulFdkhtfo?= =?us-ascii?Q?9JVgro4GpbnUGDX0lkahfOtLXvw9dssUgyvLKE+K00vT0XnF2GtF8EkogeTf?= =?us-ascii?Q?SwgF5bKaSXUt95YDFg35Z+q/v2ZlZnvQsyejE0UZWDcflTf9Ky9+pZkI//be?= =?us-ascii?Q?Vp4G+btRTC53X5ydtMRIvhE5o0SdwGkZAwTumilgp8owgrtttBgbSs6rsr9V?= =?us-ascii?Q?IQe5d8sWvTmOjbdLxTMdPkkavn/DFuS58Al/xb0ImC0ep7AAPj8yxW5Yl4D4?= =?us-ascii?Q?+RBiU/auP0jidwRMihJGgFtvDWC2AdV7iECuMfiiZlgrsRRAjqYDaayox8JN?= =?us-ascii?Q?b6hXgpCz1ODzbUNYCeh0PKvmDuK+zij1WZxGPocwhBllc975lrk0YkbsOBxl?= =?us-ascii?Q?+XA3wHamhRJrkpmhkqP/MmPxgskuBDDrORHgVUbK1FyK0MIGVPN4vsVtr4ln?= =?us-ascii?Q?eWCpFIgYo6p8PS/aAQm427SyBBPD4BEiENrxydXNbWls6w47EhQbQU4bdpp1?= =?us-ascii?Q?idHA3jzLgfKr8ij5CJnFWJ2GIzHcZnZF4bpVZfI0LBO8pmy43bOFN0NpdanA?= =?us-ascii?Q?jNXO6EBc0APccgudIiXHAFo94mk+694fZfUNt3tMtrjiTv/P6Z3xP+G4Iy/X?= =?us-ascii?Q?4wdb2Ybbx1Jt0Dad8DgZ2U1ykGVxfW0pK5E/M8ZMA03gg7Fdvrj4vgP0PPcQ?= =?us-ascii?Q?q7k7UKlHPtQSVi6lRiMRmJFuf8n+2y/9tsxAlHIir7HxOJoaE3mN+m1krxgg?= =?us-ascii?Q?SwvJh09Md4XjWbuf1QWDtAVuW8tcvtapCy5eDaMt7roqNP+qugrp6p15GCHy?= =?us-ascii?Q?mf9WgyOtyEMhKC0utbesdkORYhVcvNva3lrjmzZ0QY15p+647rHZAzGOMfeH?= =?us-ascii?Q?VmzAoNZ3xhDPI6GouiHDJt3hOn98QzDdVkwJCAbYy7D/8YCbnMDKVTIvfpxM?= =?us-ascii?Q?IJvIY3PXRMy+ml2Ta8wo9l9AhNnhR7ft4Z8+uivI+zKqCkkaYClBvfvEZgcs?= =?us-ascii?Q?LeA+3BU/G73HvkprEIx/kSOUZre2PgdBRAsfNHyXaQOxidAgotQ1jVnb3rWp?= =?us-ascii?Q?k/nw1/7iOkTKCXB+1nKISlaloOSam+pq24JYB3O2gS95tZJycQbAUAxchJL8?= =?us-ascii?Q?zcBy4qh7Q7BURJbMCng=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f43d5788-6b75-4f39-c038-08dbdadf4236 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2023 13:34:22.5986 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7Vc3dP08/yK8r7bxp2PMstB/m6SRl7SfidgQ0AmzPJrQy/CW8B2+RYc95GZPAm9cVT9VfQ1rNX+OhzzYP6PLPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8373 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2emu0y4FP8dbpALyIvJtATfzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vDbAmKUo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 2/3] > RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > -RedfishConfigLangMapDxe relies on variable arch protocol. > -Status variable is not initialized. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf | 4 ++-- > .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > index 821f0552..42d9daf2 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > +++ > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > @@ -1,7 +1,7 @@ > ## @file > # > # (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> -# Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > +# Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -45,4 +45,4 @@ > gEfiRedfishClientVariableGuid ## CONSUMED ## > > [Depex] > - TRUE > + gEfiVariableArchProtocolGuid > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > index 6a72afed..97f29549 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > +++ > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > @@ -1,7 +1,7 @@ > /** @file > > (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> - Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > + Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -756,6 +756,7 @@ RedfishConfigLangMapDriverEntryPoint ( > InitializeListHead (&mRedfishConfigLangMapPrivate- > >ConfigLangList.Listheader); > mRedfishConfigLangMapPrivate->VariableName =3D AllocateCopyPool (StrSi= ze > (CONFIG_LANG_MAP_VARIABLE_NAME), > CONFIG_LANG_MAP_VARIABLE_NAME); > if (mRedfishConfigLangMapPrivate->VariableName =3D=3D NULL) { > + Status =3D EFI_OUT_OF_RESOURCES; > goto ON_ERROR; > } > > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110482): https://edk2.groups.io/g/devel/message/110482 Mute This Topic: https://groups.io/mt/102293048/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-