From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.72]) by mx.groups.io with SMTP id smtpd.web10.7157.1664638782302434536 for ; Sat, 01 Oct 2022 08:39:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Fiqegi66; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.72, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gcpxzyUz7dVIskkacjA2Hwo1PV2jqEcJiu361IuJvHbxFcGj0JHIZpJzJLSjpByx+SGB6Wtz4AsBFTnY45xezdWxCl2AVtmBA+8rynXK6lQ2UARq2HKOokcCuIGRlNHBptKVsyb3afaKTPIHW1ejwLtBUq+PsmdVwas7O4kdt+oS0LTyi6eMEKziWoY6F2UmLnMXB3vsY0W9D3vo6ipIe8CYaitWPgLWBvvlwkl367Zv4aLx9ECL4TOdw+VKvkCnLoMn/Bzjhm0xiKoj9gvHHwLSPj1rQ2qCUIGc0aQ9N/Td7GfYL9cFdiaUG1K0uwQx9OJoZeGmdyQZ+riy2Oltog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eNCx5HzAY9ibWNsWZnWfHMN+rKiDyBzeDWY5u3OylkM=; b=c/W3Y0K/o4yKreZZB1LhWydr7xjuksRMFFBEaggwBCJ4z6sH65u4590bwic0Xq+Plr/wXVAHxlZPJghOijUbK/hQzBRWMlh5eQQLMv8jXLFZtEUjsOuumxbSc92LKAlbn6Qq55aOPbP3uFaSOuzg9MD0+l0iu7bw6mou2w4yarz1hQWYuICfCn7K5KMBXAVXJaHxQl7KIffCH5edy6pTVvDNiSbif2Efdze6zehEWVsdhqn0BB7McLhnerEsAUl+O51JrGZEe/G+nVvh83EybnU52TE4UJ6ER9SDhVt+G2j72KdwAC3iL3GIExZzJWBKGyj9AJ6JVNgxP3fv5ldj2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eNCx5HzAY9ibWNsWZnWfHMN+rKiDyBzeDWY5u3OylkM=; b=Fiqegi66crm+iUt0BItRs+cn4NJ00C+c9r+grqimUBOfUhhkPqm3yCobcvbnog8FfRE1klo+lA354/i+692gHJnK11EB/AR4zfONEp5DuZnI/3/Me13YWROfiwxwybliP+c3MZGNCM7iTBkDor5zDePmL56Qw8S/AnMpV4DBd3k= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB6636.namprd12.prod.outlook.com (2603:10b6:510:212::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Sat, 1 Oct 2022 15:39:38 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::20a8:22ab:9ad5:f29e]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::20a8:22ab:9ad5:f29e%4]) with mapi id 15.20.5676.024; Sat, 1 Oct 2022 15:39:36 +0000 From: "Chang, Abner" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , "Kirkendall, Garrett" , "Grimes, Paul" , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH 0/2] Reconstruction on SmmCpuFeaturesLib Thread-Topic: [edk2-devel] [PATCH 0/2] Reconstruction on SmmCpuFeaturesLib Thread-Index: AQHY1LJhLYLpfDx2LECrm8UyiTJ1Iq34FAewgAGZS0A= Date: Sat, 1 Oct 2022 15:39:36 +0000 Message-ID: References: <20220930095156.1827-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-01T15:39:33Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=36020615-74c3-4626-bfc8-e61319853a26; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB6636:EE_ x-ms-office365-filtering-correlation-id: ed8ad834-9470-44b1-c20b-08daa3c32564 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6UN0qoGPPVkOoVLTJu39nnI9Et3Ne14RbXMViG7jKScOXvQKgGowh0d66Yl4ELdMpw8VANMu0g6n7mQinuLcVf5dhJ3A8uPmPRcho2fJl5dFvmM/HfhubHgVu4Cfk6AC1PbGNyinaGDlICS7izSIdgstjw0seAY1VV3KXLR/ezXaHizI2zL1L8n3JphPqd5Eo2seqSi3i49bs/qsSP80kNSQ5/LTwsOJrld8RR9Q2r01g/Cr9S6PyfFVD/bMED4gxRMRPjhI3qfswmZe0+44rliK8CeWSFeiZ45U1PedS++DvXWMmXnavI/kQHi1Lg6nXOVSJFm5kJM5PImpIqXi94fdqAHCsQZCzsvyuBap+sUNQbFbHq60Dgp+p+9czYp2y/l+lgLW9+xv/zswQcRdvPkpesGRjOKqQfrDBkmr9HudR/YlCke/P8yzQ/0LAeXA348n/PE0RXULr5XniAMXTfp6qjvINuUFUaBUCajY3oK8gAAfsTWiezEckiq1k5eYMTOUb5yBqYdd7znS9MG6kY/bcrhl8LdxV8KcVZxm9MwSmzK04otywoTTQuUbdUMk5jYnHr6Dr1PM7FezGx+z9yaqXonYL6vmfRLZGs7WKb1Rd5v7uOMZQzFA1cY4kTmQckXuwdYOflSPB9ROi4bShQy0OMiGHKou3pF4PZBAcgrFFJNSCv1+yNWSD6Z81Hv6dTVQuN+55kU+pkrmL/NunFjRsq6VFfl7siMkZ/z+obL49RVCSmIYkXDtUilUVm/R+NvcWzaqU1BRT0laaIRKs5GpyJqzG+X6wQCdKXbFWFxWZ5f8/reLRtMPT+JGMuq/mQLByAGSxWIiY5s1t6Zvzw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(451199015)(71200400001)(66476007)(7696005)(55236004)(6506007)(53546011)(316002)(38070700005)(38100700002)(66899015)(83380400001)(186003)(478600001)(9686003)(122000001)(45080400002)(26005)(966005)(54906003)(55016003)(41300700001)(66946007)(8936002)(5660300002)(33656002)(64756008)(8676002)(2906002)(76116006)(4326008)(66556008)(52536014)(66446008)(110136005)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0eXS/95q4JM2V7tK2HSBFUONQ0Jcxz7b90UU4HyVfh39P4h4ZZrHYtStD0I9?= =?us-ascii?Q?DBczarLklcE7NQttgYdc+rBon4WuCNBykEAtJy9mF9yT8MyBWIS0kKUXfxrA?= =?us-ascii?Q?1A2j4a2d0WFT8vMpMDxoINrrqSAWsW4ekB5x0f4cfBOKZy4XXsI7yaxSswr4?= =?us-ascii?Q?eukeQ6db+03xhnAB/qjdpvW/ikPcvKzax7zSzYipEoR85Ku2f6O7qevOjXUL?= =?us-ascii?Q?YbK6reh+Co+5WYCS5ycLYrJRCo1xZ79/BA1SDbQInnJJ1hAfke7d0FEN2xKq?= =?us-ascii?Q?GouR9JW8hEJX7k28s5jhcANAckdZej2bhpbaPHVI3fox4osP3VBJQ0oLxnBn?= =?us-ascii?Q?fprlk/sdWb1Gj5TeKb6O1ef2iiRQrQPfYjf2Bzzb0gjBJ/YtnQ+lrfE9emxl?= =?us-ascii?Q?DeOwljiNldyfrb9JIWwNI7yaDQD6iOyh0DW/JMqKuGKOw0m5HPGZijgLetMV?= =?us-ascii?Q?4bphHnQkJKoJSkASmpjdFRarWxeAmnvJZwFaWRDts2P1/qqBhc7coVQZLwG2?= =?us-ascii?Q?rxwJpI96t89Np7GxYzpOxRTwhAM365BJEbUcOYIhhM09Gyx9AkDB3CPd4Zt4?= =?us-ascii?Q?oVJ/q5VYT3K3O/VvX222mv/7n2dofEwwBMaFtliibezxwi/QjzGDDgsdavtK?= =?us-ascii?Q?9fwhfM3mCnSEkj5FsBUL5wL0TU9kt4kEQ5P5PhrWDYiYOD1sYjaYotWLBMnr?= =?us-ascii?Q?HlpbJFAjdhK5bwS7se44Ul13gPIDYbA5+h7ihUYcczxap4vVGFqt/axBCXVj?= =?us-ascii?Q?SrslR5vdsxTgns9vfqJwE7+SjjClvBZqsIQjDvDpUp8jqd2+UyQl+Gpoxw/w?= =?us-ascii?Q?dDaTPWHRdqeLveLlaHsBS+4iUrLzcOWcI1f6QK0k+ykVl9FBcvpyb1Xztkfn?= =?us-ascii?Q?etIa6IF3I74kLB4UVEDUTAjJ3u37SVoPhcBpZEreY9YUWBaFp9l4HxmGRgV5?= =?us-ascii?Q?Y7u5yipC4UgvCyebOEOzH4Mg8AFeI8+LWkNNsbQLRp1DJJ9hJ1f1RoW2YVuH?= =?us-ascii?Q?n4O8P7H90YXJKyDor7nlLqANYfugLSjgz0Pehl9RCqnIvVdBACIdCGT98KT9?= =?us-ascii?Q?U6fgtJzdj5g/xwchNQn6se7lUbr7fBGmkIo86haAzIsKL5YvGOrbiWrI14Fy?= =?us-ascii?Q?hwaOTxzOzoyab0kK5VGbr5FerkLVkq+aPmtoh3NyxLQRy3SdK3rkRqZ1k60z?= =?us-ascii?Q?z6SFERXmLd8iTVN1QJZieubVUlHb22Z2ELl2lsb8A3tdDPKPbu923nCwqK9P?= =?us-ascii?Q?vTOHEjHN/pN+igWUh8kO/3/GS6+8Al9dLJC+4SQqezAhi7EYRdB2zo1FqvIA?= =?us-ascii?Q?nZ2NhQXVCIO2z7vTdrLoQR8DwuTXvZtikxo8qwUHFL+Ty2yusRywFAalQ+1b?= =?us-ascii?Q?7xIjzGE7glHLTuWAZ5Ks6KL6y9kp1W0fuFA4dMLEpW3Du7hXIVU7zbfwMWkB?= =?us-ascii?Q?M+T74cOTmXMsjdwLBu4x8pSImPzHoP9c6qTpjicrrDsQb2+58p2dMd4yIYp1?= =?us-ascii?Q?rc8JhqNVgRaiOFnQDEptjTFX21uNUqSfPHOzcI5jeizqWklL6KtBlar+JD7p?= =?us-ascii?Q?gKSc5q/N+836chDA1Ns=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed8ad834-9470-44b1-c20b-08daa3c32564 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2022 15:39:36.7500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ATF+dMeaBbZydgGACmP0NuTdLYRsddxYa1b1H3nllU2h8ozB6PwkaZdWyx/YC06IXP4sozbvAVckmPAoTsij1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6636 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Mike, I think we don't need to git mv for this case. IntelSmmCpuFeaturesLib.c is = a new file and the content is moved from SmmCpuFeatureslibCommon.c. SmmCpuFeatureslibCommon.c still has the complete history. Did I miss someth= ing? Abner > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, September 30, 2022 11:11 PM > To: devel@edk2.groups.io; Chang, Abner ; Kinney, > Michael D > Cc: Attar, AbdulLateef (Abdul Lateef) ; Kirken= dall, > Garrett ; Grimes, Paul ; > Dong, Eric ; Ni, Ray ; Kumar, Rahu= l R > > Subject: RE: [edk2-devel] [PATCH 0/2] Reconstruction on SmmCpuFeaturesLib >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > Hi Abner, >=20 > Did you use git mv to rename the file. It can help track history of chan= ges. >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Friday, September 30, 2022 2:52 AM > > To: devel@edk2.groups.io > > Cc: Abdul Lateef Attar ; Garrett Kirkendall > > ; Paul Grimes ; Dong, > > Eric ; Ni, Ray ; Kumar, Rahul R > > > > Subject: [edk2-devel] [PATCH 0/2] Reconstruction on SmmCpuFeaturesLib > > > > From: Abner Chang > > > > This patch set is part of below BZ 3860: > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbug= z > > > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D3860&data=3D05%7C01%7Cabn > er > > .chang%40amd.com%7C8e21740be3a54f50521708daa2f5f70d%7C3dd8961fe > 4884e60 > > > 8e11a82d994e183d%7C0%7C0%7C638001474543728133%7CUnknown%7CTWF > pbGZsb3d8 > > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > 7C3 > > > 000%7C%7C%7C&sdata=3DtJUZ5hTCB0sBXd4bx5HG5XDV%2FWyU1dKwIDDzI > KNjegA%3 > > D&reserved=3D0 > > > > This is the reconstruction on SmmCpuFeaturesLib to accommodate AMD > > implementation of SmmCpuFeaturesLib. Intel specific implementation is > > stripped away from SmmCpuFeaturesLibCommon.c and put into > > IntelSmmCpuFeaturesLib.c. > > > > This patch set is the preparation for AMD SmmCpuFeaturesLib upstream. > > In the follow up pacthes, AMD will create a new INF file > > SmmAmdSmmCpuFeaturesLib.inf under \SmmCpuFeaturesLib, > > AmdSmmCpuFeaturesLib.c for the AMD specific implementation. > > > > Signed-off-by: Abner Chang > > Cc: Abdul Lateef Attar > > Cc: Garrett Kirkendall > > Cc: Paul Grimes > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > > > Abner Chang (2): > > UefiCpuPkg/SmmCpuFeaturesLib: Abstract arch dependent code > > UefiCpuPkg/SmmCpuFeaturesLib: Clean up header file inclusion in > > SmmStm.c > > > > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 1 + > > .../SmmCpuFeaturesLibStm.inf | 1 + > > .../StandaloneMmCpuFeaturesLib.inf | 1 + > > .../SmmCpuFeaturesLib/CpuFeaturesLib.h | 6 + > > .../IntelSmmCpuFeaturesLib.c | 403 ++++++++++++++++++ > > .../SmmCpuFeaturesLibCommon.c | 391 +---------------- > > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 3 - > > 7 files changed, 413 insertions(+), 393 deletions(-) create mode > > 100644 UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c > > > > -- > > 2.37.1.windows.1 > > > > > > > >=20 > >