From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "nicklew@nvidia.com" <nicklew@nvidia.com>,
"igork@ami.com" <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements
Date: Tue, 26 Dec 2023 01:40:58 +0000 [thread overview]
Message-ID: <MN2PR12MB39661588A5077544BFB37DE4EA98A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com>
[AMD Official Use Only - General]
Hi Mike,
I had RB on this patch set. Please update PR with my RB. Also let me know when you reset it.
Thanks
Abner
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Monday, December 25, 2023 6:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH v3 0/16] Redfish related fixes and improvements
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> This is an expanded version of the original set of 9 patches with
> additional patch introducing brackets for IPv6 Redfish resource location
> with required changes according to comments for the initial RFC patch.
>
> PR: https://github.com/tianocore/edk2/pull/5149
>
> diff from v2:
> added Abner's R-b
> refined copyrights
> added additional patches [13-14] deallocating stings stored in
> EFI_REDFISH_DISCOVERED_INFORMATION
> changed const to CONST in intermediate patches (patch 10)
> reworked Product and ProductVer strings handling in accordance with the
> comments
> removed IpAddress local variable in the last patch
>
> diff from v1:
> fixed typo double "that that"
> removed variable declaration in block scope
> added patches 10-13
> removed unnecessary casts
> added checks for memory allocation result
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112898): https://edk2.groups.io/g/devel/message/112898
Mute This Topic: https://groups.io/mt/103354119/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-26 1:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 22:59 [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 01/16] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 02/16] RedfishPkg: fix RedfishPlatformCredentialLib " Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 03/16] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 04/16] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 05/16] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 06/16] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Mike Maslenkin
2023-12-26 1:12 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 07/16] RedfishPkg: add proper initialization of IPMI request Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 08/16] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 09/16] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 10/16] RedfishDiscoverDxe: introduce InitInformationData helper function Mike Maslenkin
2023-12-26 1:14 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 11/16] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 12/16] RedfishDiscoverDxe: refine InitInformationData() function Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function deallocating string resources Mike Maslenkin
2023-12-26 1:17 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 14/16] RedfishDiscoverDxe: release resources when refreshing information data Mike Maslenkin
2023-12-26 1:20 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 15/16] RedfishDiscoverDxe: handle memory allocation error conditions Mike Maslenkin
2023-12-26 1:22 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 16/16] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Mike Maslenkin
2023-12-26 1:39 ` Chang, Abner via groups.io
2023-12-26 1:40 ` Chang, Abner via groups.io [this message]
2023-12-26 16:10 ` [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements Mike Maslenkin
2023-12-27 2:54 ` Chang, Abner via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB39661588A5077544BFB37DE4EA98A@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox