From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 837777803CC for ; Tue, 26 Dec 2023 01:41:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MtX3TXULE45+n2SFTnkIEp9fJ4f37g3pUcner/HFSeU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703554861; v=1; b=CnG7vtPKT4b6aMdMgSpcTvAMjic4e0rC8Tc/wzOQQ3OqE3HHcIO9ed1ChsKisCXiCKjv7ant 7mBr5yhxMuvAH1K+5w7DTS8cSi5BIGZx+d7ed59gRii/wjfXO6EIEV/dRZr8J+oHfTTNI4D1DU2 skycNSOfIiiKOfTuua4mn+sg= X-Received: by 127.0.0.2 with SMTP id Na2EYY7687511x2DA6H9dLad; Mon, 25 Dec 2023 17:41:01 -0800 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.41]) by mx.groups.io with SMTP id smtpd.web11.73058.1703554860673479538 for ; Mon, 25 Dec 2023 17:41:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DcF2YBiJeDM/yI9ae2oFD2870lwP6p0yHVKpQJm6PVUgb9nr3BlJKSQ9rsaHhpE5aDlM8NEvUhPsPbDSLOEuCobtKXGN27wqFX+QymBdUEvKC3dVuZetYvguHIZymMVM5lOgOPxKUhROkQnqWGu1hYYvhYdfcIc5OQlFliwCaAMAV5p6U/yoVrGgCy64rPhepEIJo0Qmn1awTvX5kZ/1iCJDoLQanHqaTWKS1W65SAj7MRYgL8wSQBGXc/ktMvLf2xcAFdc3f/Pc0DJ2u42yq3H6npBov5gcp0O5dwAifjZskcI5bIrmzfOSnlRIFfrY64Gm3MhC6//VX8NdzjgU7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WLVLqh4AGoolRCujZVkv5Ztdvq5TJUYra9DkuItXG1E=; b=AGIZmW/cStaIvXRjbt8jXKXu3WTwtqwe0Whu8K59wHyFT1JLJ0Jsoq3R/NdiTBq4QzUsbtaauIN/5zZDeZCDl/LD6+6nQo2i4o2JgxYWzyIUZGTtWEgitWlafyHei9MvqLDyBxKN1gE7mnNNeFlNKuNWCyUXgK+aKSUNwAx9jzVZ8nECnaXMS7DsDxcOMw/lbKR0qh42FScpBrpxMHtgBN/OMX68levaSBll/gj//5U6kl1DL392ooC2bX/qPzdVJ6cSO8cImxf5TS31IMp5nAFLrm3LE0la/PdtotI9E4IioXmtQKBqI1v0bwLKpH98+ZoyON8/JrJdmXDohNkAzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CYYPR12MB8964.namprd12.prod.outlook.com (2603:10b6:930:bc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 01:40:58 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 01:40:58 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements Thread-Topic: [PATCH v3 0/16] Redfish related fixes and improvements Thread-Index: AQHaNrzdc+oBabKkS0mTLoNPl/EAlbC6y1Aw Date: Tue, 26 Dec 2023 01:40:58 +0000 Message-ID: References: <20231224225927.9119-1-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=16e32564-1220-46d1-987e-3e699ddef9d8;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-26T01:39:41Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CYYPR12MB8964:EE_ x-ms-office365-filtering-correlation-id: d1170fc9-b197-4040-bc65-08dc05b3b5aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 03s0owg/X5KNOk3Jxy8G/YrQ9CSoJfbjH2BBhNOrEE+TV8tTS0FSniC4a5vzpMCwVqUynlVcSbanbErgHaE+LuGHazwcuqOLoBFAHWYQ8R0eA4GuHLv8QI02zNINsjhw52Y6gwn/gyIDRzYIpQZ5SPjOll0MOZlHzXqPa56ov3rzUmSqcT2TxdJg0POtBEbQwbctn+G+AaCspBlYgBYH9KyYBdGWKY6FSHnUeycUYzxlA6E1hRRHimSnUwb1eTwmzfSUwTIwLG4kaE5hCzrYa1ONRJmY9PEqlLcFqI2vX5cwM59sXAih7yja9vrizYHc5MsGVKqwchNSrWa9cJaMjUkJoAx1VU4rD28AK2wgF0aNxeYWytNOb7HE0adz1ceijdt4+FJbPgla9BqBmM+wAWv4mAP7+Gnk8z6y3/vOpt4bMCG12/K0aaxS7T0RPgDhsZP0e0NwTDpID8IWr9AecwV3Owcj09CBcXo+zkJs3tbHudpm4TyVoe0EcFlcvYX40XURgy4ZYLX5ePHXlG9f7Z65hG7IMR+g6nF+YTNhFpFG0vDtS+BZH+FJgPfuCmk855wL1fNfb7esCYHZYaCg3Z51h/CrIohH6VGS0NZAI+wvmp95zsWR1WCYWIyzwzpo365XvybOwI/RlB93Fv6HgA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6c3mDdOdRQ8UYnwBD8RpC9lwF8BDjMkdKxm2e6iFj22YdsCi18T4KDFk8HGM?= =?us-ascii?Q?0qS5kS28iBDKKDZj0uxCVuIsQmKEI8lJxIorwp3moCf3/4p057N+JzthORNI?= =?us-ascii?Q?S9NrdBrNpbHSR9UYIEVVGocDpcQI8lcmlpY/6sF/g/xa3BeBeoO3W4xavSeF?= =?us-ascii?Q?ke/3LHfBgRTCR19zhS/jHHrwIpuX1rVx96eeN71e5VSm3VIxKJQO6m4X7qNf?= =?us-ascii?Q?VY6GS2vpU8xDoDIUhOYH+u5jM1Srb1HGL0CRWo3bzyiIzPp7Nc9jDVQ8Xjtq?= =?us-ascii?Q?PY/DgNDhrDwDUjM41bwYxWnkXL1dvjGpaNGUiawxX27v+aCTfzwt2meeGkib?= =?us-ascii?Q?q0pQZfVQ5zBFv4bwShFDM+MkXM1eIzBhnMC6k3ECZmKX5UTwP7EkzZ/4SOUf?= =?us-ascii?Q?kNDppEDvYxhlN8GB3lujoIS3635vUWzC4p049fIVN3ISPb3NAGjb8o2f/km5?= =?us-ascii?Q?1pDKLEDWzj1vafoGSFhia14+45/jSxfr6b6SIorNQtUx1ouWisjUCSdxDMWx?= =?us-ascii?Q?1IO/Pbi1IX3YsGj+K+a8KIfzuwNXaPxFICNA6LEj7Y7y4eGHdw1ufbch8L8U?= =?us-ascii?Q?M5M4PjtLcghyP3A+tv54ic2UxN2I9/uPdvrnPmYHvV2KMvbcnMpPlb337dDv?= =?us-ascii?Q?P4/SObQoxv+1EfmWIqeTuU9DMdPtvc9pwxXyQNLLyU7ueD0BVbhzfHptg7p0?= =?us-ascii?Q?XqN0Rru7JYFTPlFcqrbeObgg33FGZLljsVYxity2OTbwexiuzUhWVdssS1/6?= =?us-ascii?Q?is7pv5IB4/2eUgip34nzjl2eI2L4YuuvjDw/V7wARW09I+0DUsz43+PPx6f4?= =?us-ascii?Q?5nUBw4cGc5hlyvEbJ/8/a+JAGZ49jFlMIwZCQOhypFujiwcH/ektaN6Pnk/T?= =?us-ascii?Q?3DkijAbgyAcVqyHpWZESOossCkU6wMR7sSPcGwLU17ZgrqrC96qEDmo6Awo6?= =?us-ascii?Q?quh9uI0k7f+gGWMPIBDpipyu3MCvJe/MdhHZBgrkunjrN9VDnslCBYCGmAd2?= =?us-ascii?Q?RnzkAR2FhYYGXHlGn0FHercNtrYet1aLytBD2lX5OlzNNN9te8tnIB1ZGaDw?= =?us-ascii?Q?Ge/k+Bt3iD8VPv7rTWSs4Xz4PqZDwEB4mZGaBXgovwfkUn/UskBio9/KCfef?= =?us-ascii?Q?IQ4KYV7RDA3h/ixIDRsm1SjTySPAjMzmmyfMDjmAPTINOp/0Fg6NIcycgjYE?= =?us-ascii?Q?9ks1MQh3HHyjhD0gQEZgfW9ld7ztTAPi4wZxbbxdsAjW7vAcnphtlGUxCnSn?= =?us-ascii?Q?uCoU8iR6gbhd3117Rw5TgQOZ49EnT6QiPi1JE+OjmMHrAsi2q/FZFj8a+s5D?= =?us-ascii?Q?+iqzSFCsOWgcvQMC6croKT/ck6WQ1B78fryBuL8b4wgnjtS1+8gksfPxSvTO?= =?us-ascii?Q?13exnWgq6iKhmegOHSjHayY7ScVZ5uA2L2FGdIgtnZ8HSXditxQYgXqBA9dn?= =?us-ascii?Q?7AI5yKOutduQEdB86NGgT/IipPjpSLA4MHXMZrziShiB+oEBdpcmJHnVrzUa?= =?us-ascii?Q?nDdHSNLN7Wjy8ZgisJ1tho4tehuEHGmxCyqmq8LrUZ9oXrs7te3YxMKJXhsv?= =?us-ascii?Q?NwnseEeNID8FfKmREBE=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1170fc9-b197-4040-bc65-08dc05b3b5aa X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 01:40:58.4287 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RmbDrbVgoCIOobmka1o4fLUyxFujFbkPr4pVc5bVBzDW8vXszZoSEskQkB7qN3D9bN8w3uVDcrytVeLL5WrRww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8964 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: G8BRjXLTjxJ0glZ6roIK9q5tx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CnG7vtPK; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Mike, I had RB on this patch set. Please update PR with my RB. Also let me know w= hen you reset it. Thanks Abner > -----Original Message----- > From: Mike Maslenkin > Sent: Monday, December 25, 2023 6:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v3 0/16] Redfish related fixes and improvements > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This is an expanded version of the original set of 9 patches with > additional patch introducing brackets for IPv6 Redfish resource location > with required changes according to comments for the initial RFC patch. > > PR: https://github.com/tianocore/edk2/pull/5149 > > diff from v2: > added Abner's R-b > refined copyrights > added additional patches [13-14] deallocating stings stored in > EFI_REDFISH_DISCOVERED_INFORMATION > changed const to CONST in intermediate patches (patch 10) > reworked Product and ProductVer strings handling in accordance with the > comments > removed IpAddress local variable in the last patch > > diff from v1: > fixed typo double "that that" > removed variable declaration in block scope > added patches 10-13 > removed unnecessary casts > added checks for memory allocation result > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112898): https://edk2.groups.io/g/devel/message/112898 Mute This Topic: https://groups.io/mt/103354119/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-