From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.87]) by mx.groups.io with SMTP id smtpd.web11.8031.1687824331776163138 for ; Mon, 26 Jun 2023 17:05:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=UP5lDPpy; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.87, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPLqsx36GpyP63lz2H2k/UPIcz8RIoL409x0YBkbelyWym964KI+roqh8hDnI1DTgOq0F6C8NHW3xwISKYKrQAuZEx4XLXnAOfwE53U97Mc4cMFSI41wk9kF9+F9uESNR0C6YeVXr9OTnk2KBPxl3fvZah4M/ASwBCX1Ko6vFHZW1KZCo8gm2pyuvxFF8xagaIpCFTgypB7YUB+H8D9ZkB8zij9OKk8eq5EwVVFOdtchIsRLKoNcsYWK7TV02jHBsnXhs9QG17X7/6iJe7Hjxh/CD6K0MM13wTF+5SALn8SVn4wIM/gOaOiV/VtAzQB4aJ5sh/PxM0xndMLuYzGJFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CGwSvIFfgq/3HipEgHNdJRM4OTfQ2GmESv6FXdXio1c=; b=SUJvtmiAGVCZdirRkjGqM+9Q2pwIDeoQ3KIizAUYj+h/GmxL+PSQk3pnwLiekoOLTFrlzz5IhVbcLcljYT9csS77CqYpiiuPB1vF3ce3CmcCu+0Yqa/zKs+Gn61Fkfqj23VFHBf8MCVqoOXIYSBWjb9StZi2D7qx0C255+7yj38ADTzzE5Ylv4cc4ig6USXnMezXS9mMSiqAimA8/1INMEBrDsSBISTWiAVw/Zs3hkWlYoIj1DiBt98wAVCKqZbL+JuNU0ylTLfgyLoOog2WKnn464/p1e6gJvEp9LXThZeTUQi7imYRK8c9UeqbZtYdOuF8qmIA8Gukvi9Dsrqemg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CGwSvIFfgq/3HipEgHNdJRM4OTfQ2GmESv6FXdXio1c=; b=UP5lDPpys9SYMgcRKUW0UjL41eLUrqOTnGcaet/TlhpGIaTWXVjFsbliUXwbXvQcg+C95+D3/J9wFOXTjBw6uKTLj20VI4Si5rynV1hL297I6nmy4tj8a6DzyoIrtAx1bda3EZgxO288JhBKXEfEACHEZabsuNB2346Q6lhZZn0= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ2PR12MB8926.namprd12.prod.outlook.com (2603:10b6:a03:53b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 00:05:26 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 00:05:26 +0000 From: "Chang, Abner" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo. Thread-Topic: [PATCH] RedfishPkg: Fix SortLib library class name typo. Thread-Index: AQHZo750VIBXLxWHvkykcJJ/kxJwSa+UZkcggAloNDA= Date: Tue, 27 Jun 2023 00:05:26 +0000 Message-ID: References: <20230620212950.28118-1-mike.maslenkin@gmail.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=bbf189bf-1c31-4cb9-8f91-ad8324677995;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-21T00:25:29Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ2PR12MB8926:EE_ x-ms-office365-filtering-correlation-id: a4a7eaec-77e2-4ddc-7bba-08db76a235d2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: njPL8E09R4lp6eJcg6GnfRj9TE70CcRDu6ODYarCGPtRHOQpqDzWsByD5Z8ddJ9xSX0LYpYxVSv8Ijydaqu+msZBsgbSYsZztNDMVrMD3CVxelEhuuuUgSBV6OGGcNrTOPKXXtHbkxXnTVaJ4zXynXbfFmEbTq5XWZzHJMcepppP6a3V9f54fLgLuQvDKwLXH1EsQuzjwntGAYX3WcpDYomtZjtBNPvwchq8rV3eT+B3liky1kROICjZgoi6BwhSpuidDREtNoXddj/jCJ73Xaze5pDz574Zr8RULa241X02406IGLZ7GhJUS0r34HNnHakQr1Mvec7Ft65r/AZndVcTpOo0tQqKCfKlP/rGw/PaM2gBzBGxK8l+/dMyRTiLCtlXHpXx9uNK0xg2GR7D7ufbHND34ZvIIGJYV5e2hJC32oWwz8OSl38Ug78ljAgaMjqxPEy8R9+CGBdJ7WNrZX/6Ldnzdboild/KDXQUDJjT8E1eIbe8P+7RRlb7Ib1+gTMZ4mMCCasHkBnZKYhiS3Ngt4hEc1JTPttbQjJy2nLVl7AhdNIJIOWeZoWla6Wq8f0UP14y0x+oq1WdTvLeoJZ5qEKK4qScO2QQTiJeyvb8S3uW3v+zmBLvVfxY6TNC x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(366004)(136003)(396003)(451199021)(478600001)(2906002)(54906003)(110136005)(38070700005)(55016003)(316002)(66946007)(66556008)(76116006)(4326008)(41300700001)(64756008)(66446008)(83380400001)(66476007)(33656002)(122000001)(7696005)(38100700002)(71200400001)(86362001)(9686003)(8676002)(26005)(6506007)(52536014)(186003)(8936002)(5660300002)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hTbzdIUMnECRcxNLRqjJJCZS12FL4TKwp9YquPMk9CMyMSPwMD2MbVdaf4ml?= =?us-ascii?Q?HUSGlkTYUo9kiltbUeW3kUVmXHA17x9/2sUBYmGEexTLyfdcq7PMYVA9l5qB?= =?us-ascii?Q?JiQvuMfsmoh6PQVmt5b5aBBTs4wzn0XkrI+/9+9PFmI/pVd3wAi0hXS6hDY9?= =?us-ascii?Q?BR3G6qNbHJBNqL6ozxJiIV6UScqceFDEZUQKbAujm4Jcyz9rH9k6A5Ffq3OY?= =?us-ascii?Q?niICRue55CjNQm4yNRORZVEXiqcrMtbIFyMV4fXVjn6AwH6QF9afxERRVkTN?= =?us-ascii?Q?s4GNycsEPVtkrpABa71F5n+s1v2UgKCVPOUxhvGwI31y2VBVNKJm6toaHGb9?= =?us-ascii?Q?g+N9hmAzZgdFsGxxr3sHo+U36bGM6zGh+8LJfffV3uQj3/G6krnFZ0q8l1XS?= =?us-ascii?Q?X/EjT09o8iUyBkNoJk2PHMmfGSlaAsWfpUdaJA/d84p1KMLT3GITHR01MHO6?= =?us-ascii?Q?2LKB5YWZML4RXF7/IxyGqgJJnpi0iZ9V0phubzb0vPajeo5l2+dzjGWNuqUN?= =?us-ascii?Q?kFDoLMTAtJG5HJnwiBrPoLn0nThGbylEyOxlMnF+eTyWT2my0B/PCTj0qcqu?= =?us-ascii?Q?C7qDv9FlQzniu8quGI2yjNaNEmFQBPwkpJb2YE1PHqfqOJ6TNmXip+Q/eaCo?= =?us-ascii?Q?Z3mJ664X+aJTQqhiXUyj2vjrnCVvLyqZhYFhbwq3IAvCA4CiDLQnB2riiaPg?= =?us-ascii?Q?a9CxpdM4OFhFEnDSNqAc2fdhsLcybj8RnJS+k2f9PBNwo5Marp2I5YjJV8yl?= =?us-ascii?Q?jmq5Fzs1TRfZLH/uIc5bSuDAU6OCIMe+5aP0vdxp7TzE2niKknzetWoX7sUe?= =?us-ascii?Q?0Xteufna+u3nYLDMlgg61aZW4NFZGDAxd9oT0NI+E/Cx0ngYb8qUyauHWLRc?= =?us-ascii?Q?ErrnBxre4AD56kfI6pxF86pIVPG1S51mKEfHQawhNV1EWBqFjPSSsPKylvn9?= =?us-ascii?Q?2xFd8SR709i9D4+WWC9MwVpJiFbeH5Gg0BRUpn8P3/Tkc8GwPt7ZSRL4iUqv?= =?us-ascii?Q?VHe6QvPtkaw+gP1z/dcAhcMxCYYkhn7PbG5RZK4DaRWq9iKiQKPAomzWe3ch?= =?us-ascii?Q?/xSRlW3ujeHBTabpFvKRgSAnDnJ/pihxZ1K757VemlE7ZQ2b5sLo9V/o4LGo?= =?us-ascii?Q?VfwIQiK5gOAIlO2/6Q7Um+o2HOT+iLBxgAdOAAdbsQVerBqLjsYcvZEwH/Wy?= =?us-ascii?Q?rFeWoZss15YYYT5jM4B81GzYqb+5iz7DQ0RmIBCHcgc1mIkHxMGEQQAyqv+m?= =?us-ascii?Q?wkRzZjDabieZOuloIjPREVEvL/E9wyHjH0wYocGrY/54ZkTke/31/00V0HDw?= =?us-ascii?Q?/eyv0nvle5eRfDIejVL3r/lRw0XDJVQSp3yPdA9AcJj4cf0UFgtkeaC9YB9Z?= =?us-ascii?Q?fsp+LLMwQ9z/Mv3yl6Dc9pAsisCcRBVEY3S3oVnInxxX1pJ6uK3e9VW0X9du?= =?us-ascii?Q?DGw0cObwEguGOq1xIEMZoPgzuSBMAL5avI8Xkz6HNQ2RPOvOpVaU0AmMl5A5?= =?us-ascii?Q?bRz+5GGCooTFeBdSSXgooqW91meP4KloW712HheD9E3nhPBxh1x0hj6qt+0u?= =?us-ascii?Q?XUbhA65RA4sDR6mmuNA=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4a7eaec-77e2-4ddc-7bba-08db76a235d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2023 00:05:26.2717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bJiSSPJ7VS1QPDuTPpVx42hQ1yufTZOaxbKOHMym9Gxq1i7wEVQya2vR8UCOGZy6CXsBUbXlzSlOxWpi9BCOoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8926 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Mike, could you please create a PR for this change? Then I can merge it = once the change passed CI. Thanks Abner > -----Original Message----- > From: Chang, Abner > Sent: Wednesday, June 21, 2023 8:26 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: nicklew@nvidia.com; igork@ami.com > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > Reviewed-by: Abner Chang > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Wednesday, June 21, 2023 5:30 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nicklew@nvidia.com; > > igork@ami.com; Mike Maslenkin > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > BaseSortLib is the library instance name not the class name. > > > > Signed-off-by: Mike Maslenkin > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > --- > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +- > > RedfishPkg/RedfishLibs.dsc.inc | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > index 5c1c7cffa650..6ff5dba75c30 100644 > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > @@ -25,7 +25,7 @@ > > > > > > [LibraryClasses] > > > > BaseLib > > > > - BaseSortLib > > > > + SortLib > > > > DebugLib > > > > MemoryAllocationLib > > > > UefiRuntimeServicesTableLib > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.ds= c.inc > > index 6e497899b556..03b7ef6f3289 100644 > > --- a/RedfishPkg/RedfishLibs.dsc.inc > > +++ b/RedfishPkg/RedfishLibs.dsc.inc > > @@ -14,7 +14,7 @@ > > !if $(REDFISH_ENABLE) =3D=3D TRUE > > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf > > > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.= inf > > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf > > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf > > > > -- > > 2.32.0 (Apple Git-132)