From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.77]) by mx.groups.io with SMTP id smtpd.web11.5510.1660487240279789953 for ; Sun, 14 Aug 2022 07:27:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=XCDpd2Fz; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.77, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIh6INSLQJxM7L659JvMuAdDyvTPZcqdC6VjK5fkwyn0gKEZ2v1UqkzKJUzCQYwz67f/dJsTlVWkjjVk62J+MvYDBGBfAFeBOTXeIfFRZl+siUfhEE9ztQU/1rZeBEK48pSKLkEIsmENIriz/A+C4ak3lv/7fg3+K9t2DziTmA0vyKPo1zEiiK/OM6kXz4tkuj/zlNm2JPMBpZa5VkAx7sHHaVB4JtNxQcGnYjAAJuRlLR54bbsA3olaNvYCRiLNEoCsMurxbsG9FrnpWXDPGtVv3GLED4OXRaCmfWfDmYJGxDqHvK/zcxTx4LmylYd0k0UkfcSfc/tceZfhuXOyvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GuHoeYe/VputkYMe8KOjLo31fAlPBBj0SY7u6CDi5/Y=; b=FqIYOlH2XHwuNiWy2gk7n/hNSMd6uMZA0f7vCXQbUlLsWABTnkvtTYN2bi9bmkVtkaMJc5GLnZMVp9gMvAPY0qL9YkVVWXDtWpO/TUQMST0Scd2QTGlHF/ttEvvn2FJEKvY7FnSt8XddG2Edump183nFkFO6kr4tQ8qfY4i1S7g4E+H5ntpendBU/+Gob5xdu9nwWil6M6zZacQF7CO+ggjS5Sn3M2tjuCCS6eI6TGgg9ssRJQR+Misu9UQZ+ebKSRJYgw128UsqRVy9XMqJysZ06wnebGuTafyq4f0mYTX7yldpwZcbIUaDsl1dplPslZ2vddbvTmJ9WlitFfhkhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GuHoeYe/VputkYMe8KOjLo31fAlPBBj0SY7u6CDi5/Y=; b=XCDpd2FzxhAKta5hVbV1j84U7b3rZPfHkjWEfArDMP1xVXgj2XtosIhUYJKf0hrynHi22h7ky5HcMqD/k1llFs1rHYgLZKYm2GCWbte263VT8aT+JkU2Ny+X9wzlEwP29ITSKF1ohjQo4qWebZ2YZjyM2bQf7McA0zM3NQUQrMs= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (10.255.237.18) by BYAPR12MB2918.namprd12.prod.outlook.com (20.179.94.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Sun, 14 Aug 2022 14:27:14 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f%4]) with mapi id 15.20.5504.027; Sun, 14 Aug 2022 14:27:14 +0000 From: "Chang, Abner" To: Igor Kulchytskyy , "devel@edk2.groups.io" CC: "nickle.wang@hpe.com" Subject: Re: [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYrnBt4bS3+gJhfkSTogLvgxu6Ia2udu1g Date: Sun, 14 Aug 2022 14:27:14 +0000 Message-ID: References: <1660325080-8432-1-git-send-email-igork@ami.com> In-Reply-To: <1660325080-8432-1-git-send-email-igork@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-14T14:27:12Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=eb6eb028-77ba-4fc2-b5a6-6e3b782ee903; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67a033a1-3d4b-48fd-2213-08da7e01156a x-ms-traffictypediagnostic: BYAPR12MB2918:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C/fukRvZY49IzaHjCjoZxjOW0YonVI2FpYQfRiOJAIy1R0HFh/gX0xsyUisXTTYyHA0ickZhejLTHEqKB4KoYITqAmiB7fHBJyBV9AN15TLXwYthgI3CQQT7kBYVHAWBgib60jsw5kTQFNiH+EhqQ27qICMWWJFm62NrqLd/bvfUcJBLMhKogtAVoLOtnbUoF13FWJ1A01xG3KXTOvVvvzyBF90JA+fWLQ55de8uSjLSR5N38JPBeuXFtUUydRoiCvNG8gPFfE2qB4op8D54/RTbQEwxc5NdoTXyCeykMeN/ueeG06NiDizFCG6NPWJNAPe6XY1Q6sz5hOj27QZorIprJLBZTo/+kh6zlyLEckKTGqj5nwhMGhhpd1aiZqTAO9JE35DhbG3XObBYd0hba4PJEzZrame8m1ltncRCTmOiKyZnOIPoAPDs5sQdaJt2z8WMxSjQy2SxE93ZAgrz1DQB2Qp3oYskGFCArAaCM1SE02zMLvSTJy/7WjWiCI78zC+8Rlm16KnmvQA68YQEyCOoKpRBYyuHVUSQQ4b1/YkPKgOt9k4YPXXiSb1onl9im9SgUh5jo6hFcOxdY1rxch4xpjfnubdcGSsV29fQzvIGywR773aq3hPUVxnlqb8wY811pgs+TeCkiiLhwc7/Q3+MRjicP9U9lzvF6nGFmdKOE2HlZMtI4L8EhIiJ2hbqqOxp7ITgdz6JsPXTxkZEpxs8en/SiRZu6AcMF/cMg043bAKEyBiluKlR/sTit5Nfqfvc5I7jt90bDD61OyI1XbFik8FwEYAGpx2C/bZvpotvkWBaZ2vFF2oHQBoQ/l1v x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(366004)(346002)(376002)(5660300002)(55016003)(83380400001)(41300700001)(9686003)(7696005)(52536014)(71200400001)(53546011)(38070700005)(8936002)(6506007)(478600001)(2906002)(33656002)(64756008)(8676002)(66556008)(76116006)(66946007)(66476007)(66446008)(38100700002)(4326008)(40140700001)(316002)(86362001)(186003)(122000001)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S7lJMgb1KvsMgWk0wG/Wr73w22ngy9gnFA/5eJmlaVxfc8N9MlyBUa3vWWzt?= =?us-ascii?Q?OYK1voQTl0Um9HwC7F45v+LRw6l2CHA+Qrr4CSJefapzLhIM2UldRwj06V8c?= =?us-ascii?Q?XDL451DJ9g3mqBeS1HpMN8YgGK4bJAnwS8TUffNy6to4G4lmg/Y41lnmBB/i?= =?us-ascii?Q?EcMFrT4vc+Xks25siRf8NZp3DMsJ3I6o2Xtkaaxe2ihjLNng1g+RyrL8buPg?= =?us-ascii?Q?WhV5na9prmY/gVhBDXCdGV343hPfhn882yONQh8PXA0ZHhcI73ymUHermlpB?= =?us-ascii?Q?Sp1YDeBzU/LmebtQv2OtNOh9uuzEr6WX9gxTQbfUB3j+RTOWw7EQzHrqxgUL?= =?us-ascii?Q?f8DFlgtDiPEp/OhG6aNjrHdUFDKiqp2QUXuc4nVpQzFHkHGzTztpFb7EjmSI?= =?us-ascii?Q?ygVvZnR0NWlGb5LGTRIYmIxILb+zE12+mrWOY5SQhQIqKVt62GEGJym8yx8t?= =?us-ascii?Q?9Ly3qVwRAHS/0xYvhGmZS8V6y1EbAUJ5g9/s6XQ9APm++hk9ZtktiVuqHTb3?= =?us-ascii?Q?ylvGvrCIYY84ZrQQYbwemBQd1/CkMgH/ifLhyyTe071k/kQZdlWDKEqUe2S9?= =?us-ascii?Q?Q6SvA7s8Iiko4qd60ZsGB0nQOEc0bKNdPrUdZKlRAGvwryTHBFYoeBjSubP+?= =?us-ascii?Q?PEwCnyoE3I0W/ZcEDADs2kAYqLeW2rfjydk/OK213A/ShAapFiVaDT+LzARI?= =?us-ascii?Q?CyTZQ6HEFxAulN3dLNqUGuPHXDHgy+vfKuoJkamDiRd8O4UvBF41jVWs206l?= =?us-ascii?Q?7iYxbg6dHkzEc5jJI3/an4RXKvPYFDMOQvleoEZ839G9j7jmBRlgQiHlI5hz?= =?us-ascii?Q?DI157BWusZvnEWciHbeWGCXGaK4US6JCjRDFEVgfI0eSKIbunMIEotvjxHzN?= =?us-ascii?Q?371pAFDO0vsPIK84UoXwJo8DuP10ii9wcqbHd7JGoK/HqWYPWVUC+nHHPlxZ?= =?us-ascii?Q?kDD4vQtZlQYeYo7gvd5pK6Yl+jMh/xz79bnurWeZvhx3VBqGDN/wspQAbjPO?= =?us-ascii?Q?0Gw8/QcMKqUkMP6hyrb3CfPrSoyMHbmKkElOp/2tluWpuL12pypnYeoK0ei7?= =?us-ascii?Q?L7scMOMbE7IiT2GGyvvpZRUftzGUQ/0/IpvJ5cNUhL7gqdq3ZuMrmQB4vGZY?= =?us-ascii?Q?+mmLGqBuVjbmSBmu4gt97md4Pwo34/a3mQbMW5DHeSIUSU1UnGeWBpQaCbPP?= =?us-ascii?Q?+eMNknUaVF6xJ6t6D5li1qc9VWEFU4ppXTn/LlZ9O6cudMkojq77+cLQOh7R?= =?us-ascii?Q?VDIZiy03r8AaOrnsIyrekDSgHy1vpu3Ssk+QbUBC3gBiNRXYj87CT2+1ky8Z?= =?us-ascii?Q?u/9PKLzmd14cmufhaTpTwOHzfdp6n7BykN88YGEW7Uv/CSe+r9pyU7q0HGQl?= =?us-ascii?Q?jZnraD4EeB72b9xwnse/HPaIFWpsIxeH6C3oIH53yGBdhEs2WCZI96cFkG1p?= =?us-ascii?Q?a74obHRowbZ37wAUl7LX4r/mfupHJrUcP9QFYXajOeMnkOEYmYSAtLN1jyRC?= =?us-ascii?Q?LwdjDeDrTxlKWk0LeA1xavsLkpZ9PXyo9UL6RzuxbWOjoPzdvOs3XZ1SsQZL?= =?us-ascii?Q?3wM8KH/RGBUq+RXttz7+j7GD4QBJfKQ+bkN28drPYWKueWkuyTgmBFJPs0Hd?= =?us-ascii?Q?kv5anCBc/KJnSqq2ay11mh6gwCwwYtFiZHklYn+uW9qh?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67a033a1-3d4b-48fd-2213-08da7e01156a X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2022 14:27:14.5065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cZyw2Y7pOcg1fyCIUJJd8J1R0RAwBx4auLMTQfNWIbwzhivTrzP5vNttY5a/tBvXWWMdyWq9ALZaR5mbmrQz7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2918 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Igor Kulchytskyy > Sent: Saturday, August 13, 2022 1:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.wang@hpe.com; Igor > Kulchytskyy ; Chang, Abner > Subject: [PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported >=20 > [CAUTION: External Email] >=20 > Host Interface details are described by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > The function only supports PCI-E host interface type. >=20 > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Igor Kulchytskyy > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 10 > +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..0090525 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,14 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; >=20 > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is > supported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } else { > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.