From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.43]) by mx.groups.io with SMTP id smtpd.web11.2873.1665454863364490926 for ; Mon, 10 Oct 2022 19:21:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=2TylJ48f; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.102.43, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAfOJa2dKD+X4zm6fAaNX7rU+DR3gnV9rME/sJGrmf2JC4G8UHnYwh5P+Ak9rIKT5DnyyQSNQzvQwL/dTRZbCrN94cysBKalbuuenSpmS3pW48S+x6AO729r2CbUuw7dn+Z1tUZ0J0bPlwaR2B9Z0N+JfBnrGB7fbxyVX9Q1yeIU9IFezDwgy5FH1AFwjfDpG7IpC4YMVkLlH6PjlRFuvTu0PDE/ZtMvbMuN7ksyvxSMEr8nvXXqitxfqy78Ctx+6yOUAvgt4VLxB5M7Ukw2KKr64pCFdZ+HRNyLCqQTosW65gVscg0D9mzCYhbsaWWDL/ZJHjDbDSSEFBu+WlP18g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4qZPmk5gI14Pg1TM1N6P/g2wIZ5jprToDftqdmy4ng=; b=gkZZzeGyRihJxGZiavGVarY0c5nLSwz5rJGyo56ddf5NzYZI9rnARs3S3BYeDw2/tELYF++wMBq3rhgwLT/vvp04zQEcg4tIK8IRbla3fO2vEeqbw5ew+LlQ+To7W6v5MZDGTEnepC+LoqxAPBewZj85TYQFMugiPLJNphFSq48lDj8mF3OhCjf1iuC/sYs8Qg+tLyHW++s+Cd8TEgHBVXh59+Vp9GBpNt8Tn0lrQfYYbi8RXc7UXBW1Vy7/DPHR93romBUMKtK40ZJIrBsaN0Sb6G2uDx7q0N+dqx7fCoNlB7WFp5zMpXscG/OWtkv4HJzS46Zlc3YmENQg4QL6Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4qZPmk5gI14Pg1TM1N6P/g2wIZ5jprToDftqdmy4ng=; b=2TylJ48fJMqeyeLqrPe8Razt3R8SoTOsu+fQaMuFJ93SuRT7OECzXQcrCef5fFpi/QugIcPlGR+QsMmLll/Qq68lkfwN+WNGYOlc+F3eXEqVh4FnvLQXFIqb/nDiwXxcrS/mgDnij4K3HhE7AwYQoCOgLlxhITvjxiS9glLaM7E= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by LV2PR12MB5751.namprd12.prod.outlook.com (2603:10b6:408:17d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 11 Oct 2022 02:20:59 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::dd29:6efb:1027:cfb2]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::dd29:6efb:1027:cfb2%5]) with mapi id 15.20.5709.019; Tue, 11 Oct 2022 02:20:57 +0000 From: "Chang, Abner" To: "Ni, Ray" , "Kinney, Michael D" , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "Attar, AbdulLateef (Abdul Lateef)" , Sunil V L CC: lichao , "Kirkendall, Garrett" , "Grimes, Paul" , "He, Jiangang" , Andrew Fish Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs Thread-Topic: [edk2-devel] The principles of EDK2 module reconstruction for archs Thread-Index: AdjPX4ZZG0rDXS4WTdOIWvoiYOLYcgC9rttQAC2dmIAADxJbkAAiVmtwAABqVrAAMdRUkAARY7IwAAF/rYAABYT70AB0Z6+AAAYqDgAAADksgAAYA9igACxnOYAAAHOkMAAgQPVgADh436AA7UPNIAAAfyYc Date: Tue, 11 Oct 2022 02:20:57 +0000 Message-ID: References: <0c1ee7b8-9ecf-3f46-ac36-9d1464831263@quicinc.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-06T08:37:09.0000000Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|LV2PR12MB5751:EE_ x-ms-office365-filtering-correlation-id: 5caf10b5-f3e6-4b72-c86c-08daab2f3b84 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SXWIu7F9AanbPW3BvsSkxWfAq65P6wAGpGU/chvyYZ//kdy19szBx85Zi0bMJSDngRYwRtLJKlfWouw2fkJ9sEqJZeo8kqCQqIbgn4E0F5CVDSMt8I/uICR32NUDEVWUF9wee/+nShgziEFaoH8r3FKXiQSK8P1n6pALEBGR0wk6xqVllihLL8CIpy5KPTAnMu3NC0GAfz/PO3ZqXwsxZTuL8nvUUvt9nQLybEBqpt14T0reLQaKpI9RYjtudj8cI+Eyu1JKgFID3fWxajwHq+E8qVI8TpK4Bxv5lvxG3q5x4wmBXxAC7ursdJVleYgtqekEWhj40ASqiTD335mEj/E4kPhN9zrIB3ygmicWtphoim1kyex6roHbGQRobE6R8AXA7Bra8HenYRIEEuZOerKgMVKIn0WVO2UL8DFYXKvX+JzjHLaNwPQnG6zverqiFYoSGzMuENuvvzmP7ClB2zERtvKrFUawB0snCmT4Rd9UF+Q/gYaqSvTVUDRjeLXkj43A5TYwJMhdazFt+6/AM2MKYed9ibI9L76EbSJPA4zK022DI5SCzmUiBSiV1WNpdqJlJITkPLTV6R7u1DXDH7RLuJrf7bsVM1Vdxu0ehbtjcYYUbr5xFTCQ8XOj0/qeD87FE0Niom4O1oS9b5lubR20ZvGyUPQ/IRr5Z+gYWytlfny7XYH0xcOQ1n9DUEXCJb8cvdaWc/TVivdMrq/TFawa0nz3dqkb8z6z8stVPw9/h5eFid8hTAJZZB5XHJlZdvbgIE/DClIWzoD5IEcEZYWhTzQKIXvSiGcXp+Ak1MZU4aZ32pclsCkkLoebhpm+GDAMIE9+J/vLf5hurzhRJA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(376002)(39860400002)(136003)(451199015)(45080400002)(966005)(478600001)(71200400001)(66946007)(7696005)(91956017)(6506007)(54906003)(316002)(110136005)(4326008)(53546011)(76116006)(19627235002)(8676002)(26005)(9686003)(66899015)(66556008)(166002)(41300700001)(8936002)(186003)(5660300002)(83380400001)(66446008)(52536014)(64756008)(66476007)(2906002)(30864003)(122000001)(33656002)(55016003)(38100700002)(38070700005)(86362001)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RfAAEPchQh8mGgrqHKL0bdmG5JWvuQKTYmGWJbLMGj7FuM3BvIIMcoPJ6GnI?= =?us-ascii?Q?063A4KVeJQA1YG9hOl9PqMROUWqCtQFbKzHyiY6/8nAhJPEVDNeWANtPTxDX?= =?us-ascii?Q?hjZagIy0yGC4BU42vgvgg7Icc9VJYmiqWSMSfrw5Oq+lpjhjHNTVCg5Gl0c6?= =?us-ascii?Q?7F0MWWyY3GoGOD+1nSXG/vabQxOcA1qyxSvCaO0W0bY9NKTlHFslqlF/r9Oy?= =?us-ascii?Q?YevCBM9r/D9fHX7aehxwUGQpymKm0b2gPVfN/3efQU2OkLH0ootq1yutvYyX?= =?us-ascii?Q?kx75g8MsG8Ak8x7MY+xWYjPmYfQ37MgaixDsGBW39d4pFh6v5sULiq10o0qp?= =?us-ascii?Q?Tmzsq6iHlEPrAn5xAPFv2DqoiB75pimHeoMbjRB7vU8f8Fr4o54ka/1731Ha?= =?us-ascii?Q?ebc7M45dcCW8o/1nACTrPH/mx/FDZnnunBIQ7WmTA5ahARkfFTmrAQdiMFL2?= =?us-ascii?Q?N+3i7iu62Sw2lv3DjJdtvxnkOvU9LErRfie7ytPpVbzEi3ImdtZu6PQNeZKn?= =?us-ascii?Q?XzKleSWym/Zy9cv/om1YZXJErHVtxxbFxEU496y1f9B/vFGEUr6CJy2n5k7y?= =?us-ascii?Q?wAUUhc0+S6H+NG/CxFFobEtphWMG8EXAihVIo77TxNNAzc4PcNiXlQMpNweo?= =?us-ascii?Q?gcvPOn72EihwYPJW7JGRH+dARZXjfohg0+F3iMOJOcP7fSOBo4nMvEf1AxYa?= =?us-ascii?Q?GEiKn5v5Pf1Ktq/IdM3Im3Z6xEP25prjNsXzvaKYaDvss+Ql7P8Qvn2LPGZ9?= =?us-ascii?Q?vZnOlDzCuDBdHmtYcs1SlSkgFTYtfODLwmEh97RBQMFTNe8VL+0GGRtoPG0/?= =?us-ascii?Q?GoFHWL9FwJ9aVtrZ9A6uT+YLWM9+bTRZbCWNpt2XZ3MuWi+XVQwioZqiH4kM?= =?us-ascii?Q?A2+oxFCmjVDP3F7NxM3xeQ6Medqlv38rZU0Phv7rw9xFxk2oRoiCxw+AwDdI?= =?us-ascii?Q?q9TSBGoTuo/gfJ1yMWS6iiPrwlWx80Nf30fRsSpg9pJcHxTmlPPp//K/UWti?= =?us-ascii?Q?V9J56I3iZQV2dd5ygjBOwuiuRTAN0HzY9rO4gKwWJIIeeneQ+hgaIr1oj9El?= =?us-ascii?Q?/eMM8kfSRwKcmPvJ0zCfqdETS75DCv2g4hPbhZUNN3CvLHJuV3QOunFhqWNV?= =?us-ascii?Q?kXg7Xu4G3ePN/TXGw5jQGyY0yzWIsKXYzNAgYiPCslaZ8Vy2/+Baw0H8+uUu?= =?us-ascii?Q?Gwol4JVFRlmiPgct34BqNHj+gqezFkG8gTp0WZObEvR6+NxgX260wW2A059A?= =?us-ascii?Q?MUJnLDYINNSIoJHTZTx364UW5sHQ+n61qg82kGJMVPMqZiuNW1m6LubAsCJn?= =?us-ascii?Q?kY58yMt+ndDdg7szwQQR7yiVcmL0kFYWwCn8Yn/ifHajYNSw17iqbXuTgsJu?= =?us-ascii?Q?coC0VoQ1LGdm4pNG9dQckuPNDn5QVBegiUDAvOXZRz/ujcpi3N3wp34HDRfZ?= =?us-ascii?Q?QpSOZQ7UfqiYsnKSoiRmhAFACadJm3mQNpEWwtLApQXcJwfHIS4w8Z2dhifg?= =?us-ascii?Q?67CEojEPZyutP2rQwfivonBt2LQOrGwLPqQKIRHLYLjuxjZaqQUAxrjQEcCe?= =?us-ascii?Q?b1FW8LA9QWD77UEm+6Ia0EsVpe1VNworF1XeCTWe6gPquzOxCbbSJ8UmHrtX?= =?us-ascii?Q?9Q=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5caf10b5-f3e6-4b72-c86c-08daab2f3b84 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 02:20:57.6404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JK4kVsgC1vbDU1L44qjQ6CsV0kvmtheBHFfr5gWf6ZQYjTiidII/udXQgSbmVz2rvV2HOPQRy3R1tDUQ5G+heA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5751 Content-Language: zh-CN Content-Type: multipart/alternative; boundary="_000_MN2PR12MB39661D53541E7596A7CB6F63EA239MN2PR12MB3966namp_" --_000_MN2PR12MB39661D53541E7596A7CB6F63EA239MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Removing '_' seems make the folder hard to read, but not too bad to me thou= gh. I am fine with removing '_'. Leif and Mike, how do you think? Ex: Riscv64Ia32X64 compares Riscv64_Ia32_X64. ArmAArch64 compares to Arm_AArch64. Abner Get Outlook for Android ________________________________ From: Ni, Ray Sent: Tuesday, October 11, 2022 9:51:24 AM To: Chang, Abner ; Kinney, Michael D ; devel@edk2.groups.io ; quic_llindhol@qui= cinc.com ; Attar, AbdulLateef (Abdul Lateef) ; Sunil V L Cc: lichao ; Kirkendall, Garrett ; Grimes, Paul ; He, Jiangang ; Andrew Fish Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for = archs Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Abner, Mike, Leif, "Ia32_X64" is the first case in edk2 that underscore "_" is used as part of= file path. Shall we use "Ia32X64" (removing "_")? I know that Sunil is following the guideline. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F94912%3Fp%3D%252C%252C%252C20%252C0%252C0%2= 52C0%253A%253Arecentpostdate%252Fsticky%252C%252CUefiCpuPkg%252FCpuTimerLib= %252C20%252C2%252C0%252C94233015&data=3D05%7C01%7CAbner.Chang%40amd.com= %7C1c6973cf412c4ba09ef908daab2b1ea6%7C3dd8961fe4884e608e11a82d994e183d%7C0%= 7C0%7C638010498938218357%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj= oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D5wOiTA= rZyySLos4A%2FQHOC3gryUIZ8K4SgNxeTwfANMY%3D&reserved=3D0 Thanks, Ray > -----Original Message----- > From: Chang, Abner > Sent: Thursday, October 6, 2022 4:37 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > quic_llindhol@quicinc.com; Ni, Ray ; Attar, AbdulLateef > (Abdul Lateef) ; Sunil V L > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction fo= r > archs > > [AMD Official Use Only - General] > > Here is the update of the Wiki page for the consistency with edk2 C Codin= g > Standard Spec. > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fchangab%2Ftianocore.github.io%2Fwiki%2FThe-Guidelines-of-&data= =3D05%7C01%7CAbner.Chang%40amd.com%7C1c6973cf412c4ba09ef908daab2b1ea6%7C3dd= 8961fe4884e608e11a82d994e183d%7C0%7C0%7C638010498938218357%7CUnknown%7CTWFp= bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%= 7C3000%7C%7C%7C&sdata=3Di5RSe41cuzD48VB32KeG0M3Vp7T%2FEqe3ncKNfGCjfIU%3= D&reserved=3D0 > Reconstruct-EDK-II-Modules-for-Processor-Architectures-and-Vendors'- > Implementation > > Thanks > Abner > > > -----Original Message----- > > From: Chang, Abner > > Sent: Wednesday, October 5, 2022 1:39 PM > > To: Kinney, Michael D ; > devel@edk2.groups.io; > > quic_llindhol@quicinc.com; Ni, Ray ; Attar, AbdulLate= ef > > (Abdul Lateef) ; Sunil V L > > > > Cc: lichao ; Kirkendall, Garrett > > ; Grimes, Paul ; > He, > > Jiangang ; Andrew Fish > > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction = for > > archs > > > > [AMD Official Use Only - General] > > > > PR updated > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= hub.com%2Ftianocore-docs%2Fedk2-&data=3D05%7C01%7CAbner.Chang%40amd.com= %7C1c6973cf412c4ba09ef908daab2b1ea6%7C3dd8961fe4884e608e11a82d994e183d%7C0%= 7C0%7C638010498938218357%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj= oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DYDYXOD= grQhuLlP8DTsLr%2F4ct2JH3aw8y2SPg8tk5fgg%3D&reserved=3D0 > > CCodingStandardsSpecification/pull/2/commits. Please check it. > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Kinney, Michael D > > > Sent: Tuesday, October 4, 2022 10:18 PM > > > To: Chang, Abner ; devel@edk2.groups.io; > > > quic_llindhol@quicinc.com; Ni, Ray ; Attar, > > > AbdulLateef (Abdul Lateef) ; Sunil V L > > > ; Kinney, Michael D > > > > > > Cc: lichao ; Kirkendall, Garrett > > > ; Grimes, Paul ; > > He, > > > Jiangang ; Andrew Fish > > > Subject: RE: [edk2-devel] The principles of EDK2 module reconstructio= n > > > for archs > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > I would not add link to Wiki from EDK II C Coding Standard Specificat= ion. > > > > > > We want documents published from tianocore-docs to support > standalone > > > formats such as PDF and if there is a link in one of those documents, > > > we want to know that it is a permanent link. I am concerned we may > > > reorganize Wiki pages and links in PDF would become stale. > > > > > > Links from Wiki to specs makes sense. > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Chang, Abner > > > > Sent: Tuesday, October 4, 2022 7:05 AM > > > > To: Kinney, Michael D ; > > > > devel@edk2.groups.io; quic_llindhol@quicinc.com; Ni, Ray > > > > ; Attar, AbdulLateef (Abdul Lateef) > > > > ; Sunil V L > > > > Cc: lichao ; Kirkendall, Garrett > > > > ; Grimes, Paul > ; > > > > He, Jiangang ; Andrew Fish > > > > > Subject: RE: [edk2-devel] The principles of EDK2 module > > > > reconstruction for archs > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Kinney, Michael D > > > > > Sent: Tuesday, October 4, 2022 12:54 AM > > > > > To: devel@edk2.groups.io; Chang, Abner ; > > > > > quic_llindhol@quicinc.com; Ni, Ray ; Attar, > > > > > AbdulLateef (Abdul Lateef) ; Sunil V L > > > > > ; Kinney, Michael D > > > > > > > > > > Cc: lichao ; Kirkendall, Garrett > > > > > ; Grimes, Paul > > ; > > > > > He, Jiangang ; Andrew Fish > > > > > > > Subject: RE: [edk2-devel] The principles of EDK2 module > > > > > reconstruction for archs > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > proper caution when opening attachments, clicking links, or > responding. > > > > > > > > > > > > > > > Hi Abner, > > > > > > > > > > responses below. > > > > > > > > > > Mike > > > > > > > > > > > -----Original Message----- > > > > > > From: devel@edk2.groups.io On Behalf Of > > > > > > Chang, Abner via groups.io > > > > > > Sent: Sunday, October 2, 2022 10:37 PM > > > > > > To: Kinney, Michael D ; > > > > > > devel@edk2.groups.io; quic_llindhol@quicinc.com; Ni, Ray > > > > > > ; Attar, AbdulLateef (Abdul Lateef) > > > > > > ; Sunil V L > > > > > > > > > > > > Cc: lichao ; Kirkendall, Garrett > > > > > > ; Grimes, Paul > > > > > > ; > > > > > He, > > > > > > Jiangang ; Andrew Fish > > > > > > Subject: Re: [edk2-devel] The principles of EDK2 module > > > > > > reconstruction for archs > > > > > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > > > Mike, > > > > > > Agree. This can be mentioned on the Wiki page. Also, this would > > > > > > require the discussion between maintainer and contributor. I > > > > > > would say > > > > > maintainer has the responsibility to make sure an arch folder is > > > > > only created when necessary. > > > > > > > > > > Agreed > > > > Ok, I will update Directory and file names section. > > > > > > > > > > > > > > > > > Do you agree with the arch concatenate solution for arch folder= ? > > > > > > That > > > > > means IA32_X64 instead of X86 (I am fine with this)? > > > > > > > > > > Yes > > > > > > > > > > > However, there is one scenario. Assume there were two arch > > > > > > folders > > > > > > IA32_X64 and RISCV64. Then ARM shares the code with IA32_X64, > we > > > > > > may > > > > > rename IA32_X64 to IA32_X64_ARM. > > > > > > Although the directory naming is not real a problem to the > > > > > > build, a separate ARM folder seems easier? Or we can just allow > > > > > > this kind of folder > > > > > naming structure, however we let maintainer to make the decision? > > > > > > > > > > I would let the maintainer make the decision. For your example, > > > > > another approach may be to move the IA32_X64 content up a level s= o > > > > > it is common and is used by IA32, X64, ARM. And leave RISCV64 > > > > > folder for an arch that has special requirements. I think having > > > > > some flexibility in the guidelines is very beneficial. The main > > > > > goal is for consistency when a specific guideline is followed. > > > > I think we can have the naming rules in the edk2 C coding standard > > > > spec and > > > put these guidelines on the Wiki page. > > > > Is that ok to have a link to Wiki page in the edk2 C coding standar= d spec? > > > > > > > > Abner > > > > > > > > > > > > > > > > > > > > > Abner > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Kinney, Michael D > > > > > > > Sent: Monday, October 3, 2022 1:18 PM > > > > > > > To: Chang, Abner ; > > devel@edk2.groups.io; > > > > > > > quic_llindhol@quicinc.com; Ni, Ray ; Attar, > > > > > > > AbdulLateef (Abdul Lateef) ; Sunil > > > > > > > V L ; Kinney, Michael D > > > > > > > > > > > > > > Cc: lichao ; Kirkendall, Garrett > > > > > > > ; Grimes, Paul > > > > > > > ; He, Jiangang > ; > > > > > > > Andrew Fish > > > > > > > Subject: RE: [edk2-devel] The principles of EDK2 module > > > > > > > reconstruction for archs > > > > > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > > > proper caution when opening attachments, clicking links, or > > responding. > > > > > > > > > > > > > > > > > > > > > Abner, > > > > > > > > > > > > > > I think another guideline is to minimize the number of > > subdirectories. > > > > > > > > > > > > > > Only create them if it helps with the organization and long > > > > > > > term maintenance of the component. > > > > > > > > > > > > > > Mike > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Chang, Abner > > > > > > > > Sent: Sunday, October 2, 2022 8:13 PM > > > > > > > > To: Kinney, Michael D ; > > > > > > > > devel@edk2.groups.io; quic_llindhol@quicinc.com; Ni, Ray > > > > > > > > ; Attar, AbdulLateef (Abdul Lateef) > > > > > > > > ; Sunil V L > > > > > > > > > > > > > > > > Cc: lichao ; Kirkendall, Garrett > > > > > > > > ; Grimes, Paul > > > > > ; > > > > > > > He, > > > > > > > > Jiangang ; Andrew Fish > > > > > > > > > > > > > > > > Subject: RE: [edk2-devel] The principles of EDK2 module > > > > > > > > reconstruction for archs > > > > > > > > > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > > > > > > > Hi Mike and Leif, > > > > > > > > First of all, we don't use arch folder if the module is > > > > > > > > mainly for a specific arch in obviously. So we will have > > > > > > > > both common and arch-specific > > > > > > > files constructed under module/library root. > > > > > > > > > > > > > > > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F > > > > > ed > > > > > > > k > > > > > > > 2 > > > > > > > > > > > > > > > > > > .groups.io%2Fg%2Fdevel%2Fmessage%2F94567&data=3D05%7C01%7C > A > > > > > > > bner.Chan > > > > > > > > > > > > > > > > > > > > > > > > > > g%40amd.com%7Cd49cbbe6d3d942bd69a308daa4fea41b%7C3dd8961fe4884 > > > > > > > e608e11a > > > > > > > > > > > > > > > > > > > > > > > > > > 82d994e183d%7C0%7C0%7C638003710850252776%7CUnknown%7CTWFpbGZ > > > > > > > sb3d8eyJWI > > > > > > > > > > > > > > > > > > > > > > > > > > joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > > > > > > 000%7 > > > > > > > > > > > > > > > > > > > > > > > C%7C%7C&sdata=3DeiLOC0G9WZWKqm2ALcAiKr7SPBP5AgDdAxogHlv5pI > > > > > > > M%3D&r > > > > > > > > eserved=3D0 > > > > > > > > SmmCpuFeatureLib\Ia32 > > > > > > > > SmmCpuFeatureLib\X64 > > > > > > > > SmmCpuFeatureLib\SmmCpuFeatureLib.c > > > > > > > > SmmCpuFeatureLib\SmmCpuFeatureLibCommon.c > > > > > > > > SmmCpuFeatureLib\IntelSmmCPuFeaturesLib > > > > > > > > SmmCpuFeatureLib\AmdlSmmCPuFeaturesLib > > > > > > > > > > > > > > > > > > > > > > > > > > Could we concatenate architectures? > > > > > > > > > > I.e. AARCH64_ARM, IA32_X64, AARCH64_RISCV64... ? > > > > > > > > Looks like below? > > > > > > > > > > > > > > > > CpuDxe\IA32_X64\IA32\abc.nasm > > CpuDxe\IA32_X64\X64\abc.nasm > > > > > > > > CpuDxe\IA32_X64\CpuDxe.c CpuDxe\IA32_X64\AmdCpuDxe.c > > > > > > > > CpuDxe\IA32_X64\IntelCpuDxe.c CpuDxe\RiscV64\CpuDxe.c > > > > > > > > CpuDxe\ARM\CpuDxe.c CpuDxe\ > > > > > > > > CpuDxeCommon.c // If required. > > > > > > > > CpuDxe.inf // Use INF section= arch modifier for > X86, > > > > > RISC-V > > > > > > > and ARM. > > > > > > > > CpuDxeAmd.inf // Separate INF for AM= D. > > > > > > > > > > > > > > > > Seems ok, but is AARCH64_RISCV64 a real case? Or it means > > > > > > > > we can create a folder "AARCH64_RISCV64" when there are > some > > > > > > > > common > > > > > files > > > > > > > shared by AARCH64 and RISCV64? > > > > > > > > > > > > > > > > For the 32/64 bit support, it can still stay under module > > > > > > > > root and don't need to assign a folder for them unless the > > > > > > > > arch has the different > > > > > > > implementation. > > > > > > > > Regards, > > > > > > > > Abner > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Kinney, Michael D > > > > > > > > > Sent: Saturday, October 1, 2022 2:52 AM > > > > > > > > > To: devel@edk2.groups.io; quic_llindhol@quicinc.com; > > > > > > > > > Chang, Abner ; Ni, Ray > > > > > > > > > ; Attar, AbdulLateef (Abdul Lateef) > > > > > > > > > ; Sunil V L > > > > > > > > > ; Kinney, Michael D > > > > > > > > > > > > > > > > > > Cc: lichao ; Kirkendall, Garrett > > > > > > > > > ; Grimes, Paul > > > > > > > > > ; He, Jiangang > > ; > > > > > > > > > Andrew Fish > > > > > > > > > Subject: RE: [edk2-devel] The principles of EDK2 module > > > > > > > > > reconstruction for archs > > > > > > > > > > > > > > > > > > Caution: This message originated from an External Source. > > > > > > > > > Use proper caution when opening attachments, clicking > > > > > > > > > links, or > > > > > responding. > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Leif, > > > > > > > > > > > > > > > > > > Concatenation is a good idea. Makes it more obvious and > > > > > > > > > can be easily adopted for new CPU archs. > > > > > > > > > > > > > > > > > > There is an additional case where an implementation does > > > > > > > > > not have differences based on CPU Arch or Vendor, but it > > > > > > > > > does have differences based on the bit- width of the CPU. > > > > > > > > > Take BaseSafeIntLib as > > > > > > > an example. > > > > > > > > > It has source files for 32-bit CPUs, 64-bit CPUs, and CPU > > > > > > > > > arch specific file for Ebc because Ebc adapts to 32-bit o= r > > > > > > > > > 64-bit depending on the CPU type the EBC Interpreter is > running. > > > > > > > > > > > > > > > > > > MdePkg/Library/BaseSafeIntLib/ > > > > > > > > > BaseSafeIntLib.inf > > > > > > > > > SafeIntLib.c > > > > > > > > > SafeIntLib32.c > > > > > > > > > SafeIntLib64.c > > > > > > > > > SafeIntLibEbc.c > > > > > > > > > > > > > > > > > > Should we add "32" and "64" as supported suffices in file > names? > > > > > > > > > > > > > > > > > > If we wanted to put type content into a subdirectory, wha= t > > > > > > > > > would be the suggested directory name for "32" and "64". > > > > > > > > > Or do we want to require this type of difference to alway= s > > > > > > > > > be files in top level directory of > > > > > > > the modules/library? > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > > > Mike > > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > From: devel@edk2.groups.io On > > > > > > > > > > Behalf Of Leif Lindholm > > > > > > > > > > Sent: Friday, September 30, 2022 9:09 AM > > > > > > > > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > ; Chang, Abner > > > > > > > ; > > > > > > > > > > Ni, Ray ; Attar, AbdulLateef (Abdul > > > > > > > > > > Lateef) ; Sunil V L > > > > > > > > > > > > > > > > > > > > Cc: lichao ; Kirkendall, Garrett > > > > > > > > > > ; Grimes, Paul > > > > > > > ; > > > > > > > > > > He, Jiangang ; Andrew Fish > > > > > > > > > > > > > > > > > Subject: Re: [edk2-devel] The principles of EDK2 module > > > > > > > > > > reconstruction for archs > > > > > > > > > > > > > > > > > > > > I agree similar things will certainly happen for > > > > > > > > > > ARM/AARCH64, which will probably be noticeable when I > > > > > > > > > > start eradicating ArmPkg and putting the arch-standard > > > > > > > > > > bits into > > > (mostly) MdePkg. > > > > > > > > > > > > > > > > > > > > But I like the ability to see already at the filesystem > > > > > > > > > > level which files belong to the architecture I'm > > > > > > > > > > currently working on and > > > > > > > which don't. > > > > > > > > > > > > > > > > > > > > Could we concatenate architectures? > > > > > > > > > > I.e. AARCH64_ARM, IA32_X64, AARCH64_RISCV64... ? > > > > > > > > > > > > > > > > > > > > / > > > > > > > > > > Leif > > > > > > > > > > > > > > > > > > > > On 2022-09-30 08:28, Michael D Kinney wrote: > > > > > > > > > > > Hi Abner, > > > > > > > > > > > > > > > > > > > > > > One comment is on adding a new CPU type dir name of > 'X86' > > > > > > > > > > > for content that is common for IA32/X64. > > > > > > > > > > > > > > > > > > > > > > I can imagine a similar case for ARM/AARCH64 and for > > > > > > > > > > > the RISCV (32, 64, 128) cases. > > > > > > > > > > > > > > > > > > > > > > I think I would prefer to drop X86 and if there are > > > > > > > > > > > files that are common to multiple CPU architectures > > > > > > > > > > > then they are considered common and are in top > > > > > > > > > > > directory of module and the file header and INF file > > > > > > > > > > > can clearly document which CPU archs the file > > > > > > > applies. > > > > > > > > > > > > > > > > > > > > > > Mike > > > > > > > > > > > > > > > > > > > > > >> -----Original Message----- > > > > > > > > > > >> From: Chang, Abner > > > > > > > > > > >> Sent: Friday, September 30, 2022 12:11 AM > > > > > > > > > > >> To: Ni, Ray ; Attar, AbdulLateef > > > > > > > > > > >> (Abdul > > > > > > > > > > >> Lateef) ; Sunil V L > > > > > > > > > > >> ; devel@edk2.groups.io; > > > > > > > > > > >> Kinney, Michael D > > > > > > > > > > >> Cc: lichao ; Kirkendall, Garrett > > > > > > > > > > >> ; Grimes, Paul > > > > > > > > > > >> ; He, Jiangang > > > > > ; > > > > > > > Leif > > > > > > > > > > >> Lindholm ; Andrew Fish > > > > > > > > > > >> > > > > > > > > > > >> Subject: RE: [edk2-devel] The principles of EDK2 > > > > > > > > > > >> module reconstruction for archs > > > > > > > > > > >> > > > > > > > > > > >> [AMD Official Use Only - General] > > > > > > > > > > >> > > > > > > > > > > >> Thanks Ray, here are my responses. > > > > > > > > > > >> https://nam11.safelinks.protection.outlook.com/?url= =3Dh > > > > > > > > > > >> tt > > > > > > > > > > >> ps%3 > > > > > > > > > > >> A%2F > > > > > > > > > > >> %2Fg > > > > > > > > > > >> ithub.com%2Ftianocore-docs%2Fedk2- > > > > > > > CCodingStandardsSpecification > > > > > > > > > > >> %2Fp > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > ull%2F2&data=3D05%7C01%7CAbner.Chang%40amd.com%7C7c3292c8bd2 > > > > > > > f4 > > > > > > > > > 86f > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > 920908daa314e8e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 > > > > > > > > > 3800 > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > 1607445876768%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > > > > > > > JQ > > > > > > > > > IjoiV > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata > > > > > > > =3D > > > > > > > > > HAq > > > > > > > > > > >> > > > > > > > > > > > > > > ou4JyY1yxDthuQ1dEKcF7Q3o4W77Oo9rOOvkXNWU%3D&reserved=3D0 > > > > > > > > > > >> > > > > > > > > > > >> @Kinney, Michael D we may also need your > > > > > > > > > > >> clarification on the > > > > > > > comments. > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >>> -----Original Message----- > > > > > > > > > > >>> From: Ni, Ray > > > > > > > > > > >>> Sent: Thursday, September 29, 2022 3:42 PM > > > > > > > > > > >>> To: Attar, AbdulLateef (Abdul Lateef) > > > > > > > > > > >>> ; Chang, Abner > > > > > > > > > > >>> ; Sunil V L > > > > > > > > > > >>> ; devel@edk2.groups.io > > > > > > > > > > >>> Cc: Kinney, Michael D ; > > > > > > > > > > >>> lichao ; Kirkendall, Garrett > > > > > > > > > > >>> ; Grimes, Paul > > > > > > > > > > >>> ; He, Jiangang > > > > > ; > > > > > > > > > > >>> Leif Lindholm ; Andrew > > > > > > > > > > >>> Fish > > > > > > > > > > >>> Subject: RE: [edk2-devel] The principles of EDK2 > > > > > > > > > > >>> module reconstruction for archs > > > > > > > > > > >>> > > > > > > > > > > >>> Caution: This message originated from an External > Source. > > > > > > > > > > >>> Use proper caution when opening attachments, > > > > > > > > > > >>> clicking links, or > > > > > > > responding. > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> Abner, > > > > > > > > > > >>> Comments in > > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url= =3D > > > > > > > > > > >>> ht > > > > > > > > > > >>> tps% > > > > > > > > > > >>> 3A%2 > > > > > > > > > > >>> F%2F > > > > > > > > > > >>> gith > > > > > > > > > > >>> ub.com%2Ftianocore-docs%2Fedk2- > > > > > > > > > > >>> > CCodingStandardsSpecification%2Fpull%2F2%23pullreque > > > > > > > > > > >>> st > > > > > > > > > > >>> revi > > > > > > > > > > >>> ew- > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 1124763311&data=3D05%7C01%7CAbner.Chang%40amd.com%7Cd825e24 > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 8625541e3f43e08daa1ee2883%7C3dd8961fe4884e608e11a82d994e183d%7C0 > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > %7C0%7C638000341502885565%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM > C > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000% > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > 7C%7C%7C&sdata=3DRXxgpbEr6ivbqP1R6%2B3Rxl%2ByJAnaUJuaYYKdfCH > > > > > > > > > > >>> 8jo8%3D&reserved=3D0 > > > > > > > > > > >>> > > > > > > > > > > >>> We can discuss more in tomorrow's meeting. > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>>> -----Original Message----- > > > > > > > > > > >>>> From: Attar, AbdulLateef (Abdul Lateef) > > > > > > > > > > >>>> > > > > > > > > > > >>>> Sent: Thursday, September 29, 2022 3:11 PM > > > > > > > > > > >>>> To: Chang, Abner ; Sunil V L > > > > > > > > > > >>>> ; devel@edk2.groups.io; > > > > > > > > > > >>>> Ni, Ray > > > > > > > > > > >>>> Cc: Kinney, Michael D = ; > > > > > > > > > > >>>> lichao ; Kirkendall, Garrett > > > > > > > > > > >>>> ; Grimes, Paul > > > > > > > > > > >>>> ; > > > > > > > > > > >>> He, > > > > > > > > > > >>>> Jiangang ; Leif Lindholm > > > > > > > > > > >>>> ; Andrew Fish > > > > > > > > > > >>>> > > > > > > > > > > >>>> Subject: RE: [edk2-devel] The principles of EDK2 > > > > > > > > > > >>>> module reconstruction for archs > > > > > > > > > > >>>> > > > > > > > > > > >>>> Hi Abner, > > > > > > > > > > >>>> Looks good to me. > > > > > > > > > > >>>> Reviewed-by: Abdul Lateef Attar > > > > > > > > > > >>>> > > > > > > > > > > >>>> Thanks > > > > > > > > > > >>>> AbduL > > > > > > > > > > >>>> > > > > > > > > > > >>>> -----Original Message----- > > > > > > > > > > >>>> From: Chang, Abner > > > > > > > > > > >>>> Sent: 28 September 2022 20:31 > > > > > > > > > > >>>> To: Sunil V L ; > > > > > > > > > > >>>> devel@edk2.groups.io; ray.ni@intel.com > > > > > > > > > > >>>> Cc: Kinney, Michael D = ; > > > > > > > > > > >>>> lichao ; Kirkendall, Garrett > > > > > > > > > > >>>> ; Grimes, Paul > > > > > > > > > > >>>> ; > > > > > > > > > > >>> He, > > > > > > > > > > >>>> Jiangang ; Attar, AbdulLateef > > > > > > > > > > >>>> (Abdul > > > > > > > > > > >>>> Lateef) ; Leif Lindholm > > > > > > > > > > >>>> ; Andrew Fish > > > > > > > > > > >>>> > > > > > > > > > > >>>> Subject: RE: [edk2-devel] The principles of EDK2 > > > > > > > > > > >>>> module reconstruction for archs > > > > > > > > > > >>>> > > > > > > > > > > >>>> [AMD Official Use Only - General] > > > > > > > > > > >>>> > > > > > > > > > > >>>> I just had created PR to update edkII C coding > > > > > > > > > > >>>> standard spec for the file and directory naming. W= e > > > > > > > > > > >>>> can review and confirm this update first and then > > > > > > > > > > >>>> go back to the principles of EDK2 module > > > > > > > > > reconstruction for archs. > > > > > > > > > > >>>> Here is the PR: > > > > > > > > > > >>>> > > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url= =3D > > > > > > > > > > >>> ht > > > > > > > > > > >>> tps% > > > > > > > > > > >>> 3A%2 > > > > > > > > > > >>> F%2F > > > > > > > > > > >>> gith > > > > > > > > > > >>>> ub.com%2Ftianocore-docs%2Fedk2- > > > > > > > > > > >>> &data=3D05%7C01%7CAbner.Chang%40amd.c > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > om%7Cd825e248625541e3f43e08daa1ee2883%7C3dd8961fe4884e608e11a82 > > > > > > > > > > >>> d994e18 > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 3d%7C0%7C0%7C638000341502885565%7CUnknown%7CTWFpbGZsb3d8eyJ > > > > > > > > > > >>> WIjoiMC4wLj > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C% > > > > > > > > > > >>> 7C%7C&a > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > mp;sdata=3DX4z9puj81nIGTqtMxC9igDZyBPOT6OTWSU%2BjoIowo%2BE%3D&a > > > > > > > > > > >>> mp;reserv > > > > > > > > > > >>>> ed=3D0 > > > > > > > > > > >>>> CCodingStandardsSpecification/pull/2 > > > > > > > > > > >>>> > > > > > > > > > > >>>> The naming rule is mainly for the new module or ne= w > file > > IMO. > > > > > > > > > > >>>> Some existing module may not meet the guidelines > > > > > > > > > > >>>> mentioned in this > > > > > > > > > spec. > > > > > > > > > > >>>> Thus we need the principles of EDK2 module > > > > > > > > > > >>>> reconstruction on the existing module to support > > > > > > > > > > >>>> other processor archs and not impacting the > > > > > > > > > > >>> existing platforms (e.g. > > > > > > > > > > >>>> rename the INF file or directory to meet the > guidelines). > > > > > > > > > > >>>> > > > > > > > > > > >>>> Sunil, seems RISC-V CpuDxe meet the guideline. > > > > > > > > > > >>>> Please check > > > > > it. > > > > > > > > > > >>>> Just feel that having CpuDxe.c to Riscv64 folder > > > > > > > > > > >>>> is not quite a best solution. I think at least we > > > > > > > > > > >>>> can abstract the protocol structure and protocol > > > > > > > > > > >>>> installation under CpuDxe\ and have the arch > > > > > > > > > > >>>> implementation under arch folder. We can discuss > > > > > > > > > > >>>> this later after we confirming the > > > > > > > > > > >>> guideline and principles. > > > > > > > > > > >>>> > > > > > > > > > > >>>> Thanks > > > > > > > > > > >>>> Abner > > > > > > > > > > >>>> > > > > > > > > > > >>>>> -----Original Message----- > > > > > > > > > > >>>>> From: Sunil V L > > > > > > > > > > >>>>> Sent: Wednesday, September 28, 2022 3:34 PM > > > > > > > > > > >>>>> To: devel@edk2.groups.io; ray.ni@intel.com > > > > > > > > > > >>>>> Cc: Chang, Abner ; Kinney, > > > > > Michael > > > > > > > > > > >>>>> D ; lichao > > > > > > > > > > >>>>> ; Kirkendall, Garrett > > > > > > > > > > >>>>> ; Grimes, Paul > > > > > > > > > > >>>>> ; He, Jiangang > > > > > > > > > > >>>>> ; Attar, AbdulLateef (Abdul > > > > > > > > > > >>>>> Lateef) ; Leif > Lindholm > > > > > > > > > > >>>>> ; Andrew Fish > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> Subject: Re: [edk2-devel] The principles of EDK2 > > > > > > > > > > >>>>> module reconstruction for archs > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> Caution: This message originated from an External > > Source. > > > > > > > > > > >>>>> Use proper caution when opening attachments, > > > > > > > > > > >>>>> clicking links, or > > > > > > > responding. > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> On Wed, Sep 28, 2022 at 03:33:45AM +0000, Ni, Ray > > wrote: > > > > > > > > > > >>>>> Hi Ray, > > > > > > > > > > >>>>>> > > > > > > > > > > >>>>>> 1. When a new arch's implementation is > > > > > > > > > > >>>>>> introduced to the existing > > > > > > > > > > >>>>> module which was developed for the specific arch: > > > > > > > > > > >>>>>> > > > > > > > > > > >>>>>> 1. The folder reconstruction: > > > > > > > > > > >>>>>> > > > > > > > > > > >>>>>> * Create arch folder for the existing arch > > implementation > > > > > > > > > > >>>>>> [Ray] Do you move existing arch implementation t= o > > > > > > > > > > >>>>>> that arch > > > > > > > folder? > > > > > > > > > > >>>>>> It will > > > > > > > > > > >>>>> break existing platforms a lot. > > > > > > > > > > >>>>>> > > > > > > > > > > >>>>>> * Create the arch folder for the new introd= uced > > arch > > > > > > > > > > >>>>>> [Ray] I agree. But if we don't create arch folde= r > > > > > > > > > > >>>>>> for existing arch > > > > > > > > > > >>>>> implementation, the pkg layout will be a mess. > > > > > > > > > > >>>>>> > > > > > > > > > > >>>>>> [Ray] Hard for me to understand all the principl= es > here. > > > > > > > > > > >>>>>> Maybe we review > > > > > > > > > > >>>>> existing code including to-be-upstreamed code and > > > > > > > > > > >>>>> decide how > > > > > > > to go. > > > > > > > > > > >>>>>> > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> Could you please take a look below changes which > > > > > > > > > > >>>>> is trying to add RISC-V support for CpuDxe? > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url= =3D > > > > > > > > > > >>> ht > > > > > > > > > > >>> tps% > > > > > > > > > > >>> 3A%2 > > > > > > > > > > >>> F%2F > > > > > > > > > > >>> gith > > > > > > > > > > >>>>> ub.com%2Ftianocore%2Fedk2- > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > staging%2Fcommit%2Fbba1a11be47dd091734e185afbed73ea75708749& > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > data=3D05%7C01%7Cabner.chang%40amd.com%7Ca419e6a010d34fde464b08d > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > aa123e080%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63799947 > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 2732494527%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > ata=3DVq6pJLnn8yJrJhFZn7LfLbZzrtpG4n1VLWgAil6J38U%3D&reserved=3D0 > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url= =3D > > > > > > > > > > >>> ht > > > > > > > > > > >>> tps% > > > > > > > > > > >>> 3A%2 > > > > > > > > > > >>> F%2F > > > > > > > > > > >>> gith > > > > > > > > > > >>>>> ub.com%2Ftianocore%2Fedk2- > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > staging%2Fcommit%2F7fccf92a97a6d0618a20f10622220e78b3687906&da > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > ta=3D05%7C01%7Cabner.chang%40amd.com%7Ca419e6a010d34fde464b08daa1 > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 23e080%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63799947273 > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 2494527%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata > > > > > > > > > > >>>>> > > > > > > > > > > >>>> > > > > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > =3DxFmvUv58vh4AUAM17Qy9G5jZWFZlK2Ozt3njpG1e8%2BY%3D&reserv > > > > > > > > > > >>>>> ed=3D0 > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> What do you suggest with above example? > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> 1) Common INF for all architectures - but modify > > > > > > > > > > >>>>> INF alone, no > > > > > > > > > > >>>>> X86 folder creation. > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> This is what I have done in the commit above. May > > > > > > > > > > >>>>> be of least impact to existing code since it is o= nly INF > > change. > > > > > > > > > > >>>>> But like you mentioned this is bit weird that X86 > > > > > > > > > > >>>>> files will remain in root folder directly along > > > > > > > > > > >>>>> with some common > > > > > files. > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> 2) Common INF (CpuDxe.inf) + create arch folders > > > > > > > > > > >>>>> X86, X64, IA32, > > > > > > > > > > >>>>> RiscV64 etc > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> IMO, this is probably the best approach. What > > > > > > > > > > >>>>> would be the challenges with this? > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> 3) Separate INF for arch like CpuDxe.inf for x86, > > > > > > > > > > >>>>> CpuDxeRiscV64.inf for > > > > > > > > > > >>>> RISC-V. > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> This again probably is not a good idea. > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> 4) If the module/library is specific to one arch = (ex: > > > > > > > > > > >>>>> SMM(X86), SBI(RISC-V)), then create separate INF. > > > > > > > > > > >>>>> > > > > > > > > > > >>>>> Thanks! > > > > > > > > > > >>>>> Sunil > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > --_000_MN2PR12MB39661D53541E7596A7CB6F63EA239MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Removing '_' seems make the folder hard to read, but not too bad to me thou= gh. I am fine with removing '_'. 
Leif and Mike, how do you think?

Ex:
Riscv64Ia32X64 compares Riscv64_Ia32_X64.
ArmAArch64 compares to Arm_AArch64.

Abner
From: Ni, Ray <ray.ni@in= tel.com>
Sent: Tuesday, October 11, 2022 9:51:24 AM
To: Chang, Abner <Abner.Chang@amd.com>; Kinney, Michael D <= michael.d.kinney@intel.com>; devel@edk2.groups.io <devel@edk2.groups.= io>; quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Attar,= AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Sunil V L <sunilvl@ventanamicro.com>
Cc: lichao <lichao@loongson.cn>; Kirkendall, Garrett <Garre= tt.Kirkendall@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>; He, Ji= angang <Jiangang.He@amd.com>; Andrew Fish <afish@apple.com>
Subject: RE: [edk2-devel] The principles of EDK2 module reconstructi= on for archs
 
Caution: This message originated from an External = Source. Use proper caution when opening attachments, clicking links, or res= ponding.


Abner, Mike, Leif,
"Ia32_X64" is the first case in edk2 that underscore "_"= ; is used as part of file path.
Shall we use "Ia32X64" (removing "_")?

I know that Sunil is following the guideline.
https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%= 2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F94912%3Fp%3D%252C%252C%252C20%252C= 0%252C0%252C0%253A%253Arecentpostdate%252Fsticky%252C%252CUefiCpuPkg%252FCp= uTimerLib%252C20%252C2%252C0%252C94233015&amp;data=3D05%7C01%7CAbner.Ch= ang%40amd.com%7C1c6973cf412c4ba09ef908daab2b1ea6%7C3dd8961fe4884e608e11a82d= 994e183d%7C0%7C0%7C638010498938218357%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL= jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a= mp;sdata=3D5wOiTArZyySLos4A%2FQHOC3gryUIZ8K4SgNxeTwfANMY%3D&amp;reserve= d=3D0

Thanks,
Ray

> -----Original Message-----
> From: Chang, Abner <Abner.Chang@amd.com>
> Sent: Thursday, October 6, 2022 4:37 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.g= roups.io;
> quic_llindhol@quicinc.com; Ni, Ray <ray.ni@intel.com>; Attar, Ab= dulLateef
> (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Sunil V L
> <sunilvl@ventanamicro.com>
> Cc: lichao <lichao@loongson.cn>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Grimes, Paul <Paul.Grimes@amd.c= om>; He,
> Jiangang <Jiangang.He@amd.com>; Andrew Fish <afish@apple.com&= gt;
> Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction= for
> archs
>
> [AMD Official Use Only - General]
>
> Here is the update of the Wiki page for the consistency with edk2 C Co= ding
> Standard Spec.
> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fchangab%2Ftianocore.github.io%2Fwiki%2FThe-Guidelines-of-&amp;dat= a=3D05%7C01%7CAbner.Chang%40amd.com%7C1c6973cf412c4ba09ef908daab2b1ea6%7C3d= d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638010498938218357%7CUnknown%7CTWF= pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D= %7C3000%7C%7C%7C&amp;sdata=3Di5RSe41cuzD48VB32KeG0M3Vp7T%2FEqe3ncKNfGCj= fIU%3D&amp;reserved=3D0
> Reconstruct-EDK-II-Modules-for-Processor-Architectures-and-Vendors'- > Implementation
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Chang, Abner
> > Sent: Wednesday, October 5, 2022 1:39 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io;
> > quic_llindhol@quicinc.com; Ni, Ray <ray.ni@intel.com>; Atta= r, AbdulLateef
> > (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Sunil V L
> > <sunilvl@ventanamicro.com>
> > Cc: lichao <lichao@loongson.cn>; Kirkendall, Garrett
> > <Garrett.Kirkendall@amd.com>; Grimes, Paul <Paul.Grimes@= amd.com>;
> He,
> > Jiangang <Jiangang.He@amd.com>; Andrew Fish <afish@apple= .com>
> > Subject: RE: [edk2-devel] The principles of EDK2 module reconstru= ction for
> > archs
> >
> > [AMD Official Use Only - General]
> >
> > PR updated
> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Ftianocore-docs%2Fedk2-&amp;data=3D05%7C01%7CAbner.Chang%40amd.com= %7C1c6973cf412c4ba09ef908daab2b1ea6%7C3dd8961fe4884e608e11a82d994e183d%7C0%= 7C0%7C638010498938218357%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj= oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DYD= YXODgrQhuLlP8DTsLr%2F4ct2JH3aw8y2SPg8tk5fgg%3D&amp;reserved=3D0
> > CCodingStandardsSpecification/pull/2/commits. Please check it. > >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com> > > > Sent: Tuesday, October 4, 2022 10:18 PM
> > > To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.gro= ups.io;
> > > quic_llindhol@quicinc.com; Ni, Ray <ray.ni@intel.com>;= Attar,
> > > AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>= ; Sunil V L
> > > <sunilvl@ventanamicro.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: lichao <lichao@loongson.cn>; Kirkendall, Garrett > > > <Garrett.Kirkendall@amd.com>; Grimes, Paul <Paul.Gr= imes@amd.com>;
> > He,
> > > Jiangang <Jiangang.He@amd.com>; Andrew Fish <afish@= apple.com>
> > > Subject: RE: [edk2-devel] The principles of EDK2 module reco= nstruction
> > > for archs
> > >
> > > Caution: This message originated from an External Source. Us= e proper
> > > caution when opening attachments, clicking links, or respond= ing.
> > >
> > >
> > > I would not add link to Wiki from EDK II C Coding Standard S= pecification.
> > >
> > > We want documents published from tianocore-docs to support > standalone
> > > formats such as PDF and if there is a link in one of those d= ocuments,
> > > we want to know that it is a permanent link.  I am conc= erned we may
> > > reorganize Wiki pages and links in PDF would become stale. > > >
> > > Links from Wiki to specs makes sense.
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Chang, Abner <Abner.Chang@amd.com>
> > > > Sent: Tuesday, October 4, 2022 7:05 AM
> > > > To: Kinney, Michael D <michael.d.kinney@intel.com>= ;;
> > > > devel@edk2.groups.io; quic_llindhol@quicinc.com; Ni, Ra= y
> > > > <ray.ni@intel.com>; Attar, AbdulLateef (Abdul Lat= eef)
> > > > <AbdulLateef.Attar@amd.com>; Sunil V L <sunilv= l@ventanamicro.com>
> > > > Cc: lichao <lichao@loongson.cn>; Kirkendall, Garr= ett
> > > > <Garrett.Kirkendall@amd.com>; Grimes, Paul
> <Paul.Grimes@amd.com>;
> > > > He, Jiangang <Jiangang.He@amd.com>; Andrew Fish > <afish@apple.com>
> > > > Subject: RE: [edk2-devel] The principles of EDK2 module=
> > > > reconstruction for archs
> > > >
> > > > [AMD Official Use Only - General]
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Kinney, Michael D <michael.d.kinney@intel= .com>
> > > > > Sent: Tuesday, October 4, 2022 12:54 AM
> > > > > To: devel@edk2.groups.io; Chang, Abner <Abner.C= hang@amd.com>;
> > > > > quic_llindhol@quicinc.com; Ni, Ray <ray.ni@inte= l.com>; Attar,
> > > > > AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@a= md.com>; Sunil V L
> > > > > <sunilvl@ventanamicro.com>; Kinney, Michael = D
> > > > > <michael.d.kinney@intel.com>
> > > > > Cc: lichao <lichao@loongson.cn>; Kirkendall,= Garrett
> > > > > <Garrett.Kirkendall@amd.com>; Grimes, Paul > > <Paul.Grimes@amd.com>;
> > > > > He, Jiangang <Jiangang.He@amd.com>; Andrew F= ish
> > <afish@apple.com>
> > > > > Subject: RE: [edk2-devel] The principles of EDK2 m= odule
> > > > > reconstruction for archs
> > > > >
> > > > > Caution: This message originated from an External = Source. Use
> > > > > proper caution when opening attachments, clicking = links, or
> responding.
> > > > >
> > > > >
> > > > > Hi Abner,
> > > > >
> > > > > responses below.
> > > > >
> > > > > Mike
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of
> > > > > > Chang, Abner via groups.io
> > > > > > Sent: Sunday, October 2, 2022 10:37 PM
> > > > > > To: Kinney, Michael D <michael.d.kinney@in= tel.com>;
> > > > > > devel@edk2.groups.io; quic_llindhol@quicinc.c= om; Ni, Ray
> > > > > > <ray.ni@intel.com>; Attar, AbdulLateef = (Abdul Lateef)
> > > > > > <AbdulLateef.Attar@amd.com>; Sunil V L<= br> > > > > > > <sunilvl@ventanamicro.com>
> > > > > > Cc: lichao <lichao@loongson.cn>; Kirken= dall, Garrett
> > > > > > <Garrett.Kirkendall@amd.com>; Grimes, P= aul
> > > > > > <Paul.Grimes@amd.com>;
> > > > > He,
> > > > > > Jiangang <Jiangang.He@amd.com>; Andrew = Fish <afish@apple.com>
> > > > > > Subject: Re: [edk2-devel] The principles of E= DK2 module
> > > > > > reconstruction for archs
> > > > > >
> > > > > > [AMD Official Use Only - General]
> > > > > >
> > > > > > Mike,
> > > > > > Agree. This can be mentioned on the Wiki page= . Also, this would
> > > > > > require the discussion between maintainer and= contributor. I
> > > > > > would say
> > > > > maintainer has the responsibility to make sure an = arch folder is
> > > > > only created when necessary.
> > > > >
> > > > > Agreed
> > > > Ok, I will update Directory and file names section.
> > > > >
> > > > > >
> > > > > > Do you agree with the arch concatenate soluti= on for arch folder?
> > > > > > That
> > > > > means IA32_X64 instead of X86 (I am fine with this= )?
> > > > >
> > > > > Yes
> > > > >
> > > > > > However, there is one scenario. Assume there = were two arch
> > > > > > folders
> > > > > > IA32_X64 and RISCV64. Then ARM shares the cod= e with IA32_X64,
> we
> > > > > > may
> > > > > rename IA32_X64 to IA32_X64_ARM.
> > > > > > Although the directory naming is not real a p= roblem to the
> > > > > > build, a separate ARM folder seems easier? Or= we can just allow
> > > > > > this kind of folder
> > > > > naming structure, however we let maintainer to mak= e the decision?
> > > > >
> > > > > I would let the maintainer make the decision. = ; For your example,
> > > > > another approach may be to move the IA32_X64 conte= nt up a level so
> > > > > it is common and is used by IA32, X64, ARM.  = And leave RISCV64
> > > > > folder for an arch that has special requirements.&= nbsp; I think having
> > > > > some flexibility in the guidelines is very benefic= ial.  The main
> > > > > goal is for consistency when a specific guideline = is followed.
> > > > I think we can have the naming rules in the edk2 C codi= ng standard
> > > > spec and
> > > put these guidelines on the Wiki page.
> > > > Is that ok to have a link to Wiki page in the edk2 C co= ding standard spec?
> > > >
> > > > Abner
> > > >
> > > > >
> > > > > >
> > > > > > Abner
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Kinney, Michael D <michael.d.ki= nney@intel.com>
> > > > > > > Sent: Monday, October 3, 2022 1:18 PM > > > > > > > To: Chang, Abner <Abner.Chang@amd.com= >;
> > devel@edk2.groups.io;
> > > > > > > quic_llindhol@quicinc.com; Ni, Ray <r= ay.ni@intel.com>; Attar,
> > > > > > > AbdulLateef (Abdul Lateef) <AbdulLate= ef.Attar@amd.com>; Sunil
> > > > > > > V L <sunilvl@ventanamicro.com>; Ki= nney, Michael D
> > > > > > > <michael.d.kinney@intel.com>
> > > > > > > Cc: lichao <lichao@loongson.cn>; K= irkendall, Garrett
> > > > > > > <Garrett.Kirkendall@amd.com>; Grim= es, Paul
> > > > > > > <Paul.Grimes@amd.com>; He, Jiangan= g
> <Jiangang.He@amd.com>;
> > > > > > > Andrew Fish <afish@apple.com>
> > > > > > > Subject: RE: [edk2-devel] The principles= of EDK2 module
> > > > > > > reconstruction for archs
> > > > > > >
> > > > > > > Caution: This message originated from an= External Source. Use
> > > > > > > proper caution when opening attachments,= clicking links, or
> > responding.
> > > > > > >
> > > > > > >
> > > > > > > Abner,
> > > > > > >
> > > > > > > I think another guideline is to minimize= the number of
> > subdirectories.
> > > > > > >
> > > > > > > Only create them if it helps with the or= ganization and long
> > > > > > > term maintenance of the component.
> > > > > > >
> > > > > > > Mike
> > > > > > >
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Chang, Abner <Abner.Chang@= amd.com>
> > > > > > > > Sent: Sunday, October 2, 2022 8:13 = PM
> > > > > > > > To: Kinney, Michael D <michael.d= .kinney@intel.com>;
> > > > > > > > devel@edk2.groups.io; quic_llindhol= @quicinc.com; Ni, Ray
> > > > > > > > <ray.ni@intel.com>; Attar, Ab= dulLateef (Abdul Lateef)
> > > > > > > > <AbdulLateef.Attar@amd.com>; = Sunil V L
> > > > > > > > <sunilvl@ventanamicro.com> > > > > > > > > Cc: lichao <lichao@loongson.cn&g= t;; Kirkendall, Garrett
> > > > > > > > <Garrett.Kirkendall@amd.com>;= Grimes, Paul
> > > > > <Paul.Grimes@amd.com>;
> > > > > > > He,
> > > > > > > > Jiangang <Jiangang.He@amd.com>= ;; Andrew Fish
> > > > > > > > <afish@apple.com>
> > > > > > > > Subject: RE: [edk2-devel] The princ= iples of EDK2 module
> > > > > > > > reconstruction for archs
> > > > > > > >
> > > > > > > > [AMD Official Use Only - General] > > > > > > > >
> > > > > > > > Hi Mike and Leif,
> > > > > > > > First of all, we don't use arch fol= der if the module is
> > > > > > > > mainly for a specific arch in obvio= usly. So we will  have
> > > > > > > > both common and arch-specific
> > > > > > > files constructed under module/library r= oot.
> > > > > > > >
> > > > > > >
> > > > >
> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F > > > > > ed
> > > > > > > k
> > > > > > > 2
> > > > > > >
> > > > >
> > >
> > > .groups.io%2Fg%2Fdevel%2Fmessage%2F94567&amp;data=3D05%7= C01%7C
> A
> > > > > > > bner.Chan
> > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> g%40amd.com%7Cd49cbbe6d3d942bd69a308daa4fea41b%7C3dd8961fe4884
> > > > > > > e608e11a
> > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 82d994e183d%7C0%7C0%7C638003710850252776%7CUnknown%7CTWFpbGZ
> > > > > > > sb3d8eyJWI
> > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > > > > > > 000%7
> > > > > > > >
> > > > > > >
> > > > >
> >
> C%7C%7C&amp;sdata=3DeiLOC0G9WZWKqm2ALcAiKr7SPBP5AgDdAxogHlv5pI
> > > > > > > M%3D&amp;r
> > > > > > > > eserved=3D0
> > > > > > > > SmmCpuFeatureLib\Ia32
> > > > > > > > SmmCpuFeatureLib\X64
> > > > > > > > SmmCpuFeatureLib\SmmCpuFeatureLib.c=
> > > > > > > > SmmCpuFeatureLib\SmmCpuFeatureLibCo= mmon.c
> > > > > > > > SmmCpuFeatureLib\IntelSmmCPuFeature= sLib
> > > > > > > > SmmCpuFeatureLib\AmdlSmmCPuFeatures= Lib
> > > > > > > >
> > > > > > > >
> > > > > > > > > > Could we concatenate arch= itectures?
> > > > > > > > > > I.e. AARCH64_ARM, IA32_X6= 4, AARCH64_RISCV64... ?
> > > > > > > > Looks like below?
> > > > > > > >
> > > > > > > > CpuDxe\IA32_X64\IA32\abc.nasm
> > CpuDxe\IA32_X64\X64\abc.nasm
> > > > > > > > CpuDxe\IA32_X64\CpuDxe.c CpuDxe\IA3= 2_X64\AmdCpuDxe.c
> > > > > > > > CpuDxe\IA32_X64\IntelCpuDxe.c CpuDx= e\RiscV64\CpuDxe.c
> > > > > > > > CpuDxe\ARM\CpuDxe.c CpuDxe\
> > > > > > > >      =           CpuDxeCommon.c = // If required.
> > > > > > > >      =            CpuDxe.inf&nbs= p;            &= nbsp; // Use INF section arch modifier for
> X86,
> > > > > RISC-V
> > > > > > > and ARM.
> > > > > > > >      =            CpuDxeAmd.inf&= nbsp;       // Separate INF for AMD.
> > > > > > > >
> > > > > > > > Seems ok, but is AARCH64_RISCV64 a = real case?  Or it means
> > > > > > > > we can create a folder "AARCH6= 4_RISCV64" when there are
> some
> > > > > > > > common
> > > > > files
> > > > > > > shared by AARCH64 and RISCV64?
> > > > > > > >
> > > > > > > > For the 32/64 bit support, it can s= till stay under module
> > > > > > > > root and don't need to assign a fol= der for them unless the
> > > > > > > > arch has the different
> > > > > > > implementation.
> > > > > > > > Regards,
> > > > > > > > Abner
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Kinney, Michael D <mi= chael.d.kinney@intel.com>
> > > > > > > > > Sent: Saturday, October 1, 202= 2 2:52 AM
> > > > > > > > > To: devel@edk2.groups.io; quic= _llindhol@quicinc.com;
> > > > > > > > > Chang, Abner <Abner.Chang@a= md.com>; Ni, Ray
> > > > > > > > > <ray.ni@intel.com>; Atta= r, AbdulLateef (Abdul Lateef)
> > > > > > > > > <AbdulLateef.Attar@amd.com&= gt;; Sunil V L
> > > > > > > > > <sunilvl@ventanamicro.com&g= t;; Kinney, Michael D
> > > > > > > > > <michael.d.kinney@intel.com= >
> > > > > > > > > Cc: lichao <lichao@loongson= .cn>; Kirkendall, Garrett
> > > > > > > > > <Garrett.Kirkendall@amd.com= >; Grimes, Paul
> > > > > > > > > <Paul.Grimes@amd.com>; H= e, Jiangang
> > <Jiangang.He@amd.com>;
> > > > > > > > > Andrew Fish <afish@apple.co= m>
> > > > > > > > > Subject: RE: [edk2-devel] The = principles of EDK2 module
> > > > > > > > > reconstruction for archs
> > > > > > > > >
> > > > > > > > > Caution: This message originat= ed from an External Source.
> > > > > > > > > Use proper caution when openin= g attachments, clicking
> > > > > > > > > links, or
> > > > > responding.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Hi Leif,
> > > > > > > > >
> > > > > > > > > Concatenation is a good idea.&= nbsp; Makes it more obvious and
> > > > > > > > > can be easily adopted for new = CPU archs.
> > > > > > > > >
> > > > > > > > > There is an additional case wh= ere an implementation does
> > > > > > > > > not have differences based on = CPU Arch or Vendor, but it
> > > > > > > > > does have differences based on= the bit- width of the CPU.
> > > > > > > > > Take BaseSafeIntLib as
> > > > > > > an example.
> > > > > > > > > It has source files for 32-bit= CPUs, 64-bit CPUs, and CPU
> > > > > > > > > arch specific file for Ebc bec= ause Ebc adapts to 32-bit or
> > > > > > > > > 64-bit depending on the CPU ty= pe the EBC Interpreter is
> running.
> > > > > > > > >
> > > > > > > > > MdePkg/Library/BaseSafeIntLib/=
> > > > > > > > >   BaseSafeIntLib.inf=
> > > > > > > > >   SafeIntLib.c
> > > > > > > > >   SafeIntLib32.c
> > > > > > > > >   SafeIntLib64.c
> > > > > > > > >   SafeIntLibEbc.c > > > > > > > > >
> > > > > > > > > Should we add "32" a= nd "64" as supported suffices in file
> names?
> > > > > > > > >
> > > > > > > > > If we wanted to put type conte= nt into a subdirectory, what
> > > > > > > > > would be the suggested directo= ry name for "32" and "64".
> > > > > > > > > Or do we want to require this = type of difference to always
> > > > > > > > > be files in top level director= y of
> > > > > > > the modules/library?
> > > > > > > > >
> > > > > > > > > Best regards,
> > > > > > > > >
> > > > > > > > > Mike
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > > -----Original Message----= -
> > > > > > > > > > From: devel@edk2.groups.i= o <devel@edk2.groups.io> On
> > > > > > > > > > Behalf Of Leif Lindholm > > > > > > > > > > Sent: Friday, September 3= 0, 2022 9:09 AM
> > > > > > > > > > To: devel@edk2.groups.io;= Kinney, Michael D
> > > > > > > > > > <michael.d.kinney@inte= l.com>; Chang, Abner
> > > > > > > <Abner.Chang@amd.com>;
> > > > > > > > > > Ni, Ray <ray.ni@intel.= com>; Attar, AbdulLateef (Abdul
> > > > > > > > > > Lateef) <AbdulLateef.A= ttar@amd.com>; Sunil V L
> > > > > > > > > > <sunilvl@ventanamicro.= com>
> > > > > > > > > > Cc: lichao <lichao@loo= ngson.cn>; Kirkendall, Garrett
> > > > > > > > > > <Garrett.Kirkendall@am= d.com>; Grimes, Paul
> > > > > > > <Paul.Grimes@amd.com>;
> > > > > > > > > > He, Jiangang <Jiangang= .He@amd.com>; Andrew Fish
> > > > > > > <afish@apple.com>
> > > > > > > > > > Subject: Re: [edk2-devel]= The principles of EDK2 module
> > > > > > > > > > reconstruction for archs<= br> > > > > > > > > > >
> > > > > > > > > > I agree similar things wi= ll certainly happen for
> > > > > > > > > > ARM/AARCH64, which will p= robably be noticeable when I
> > > > > > > > > > start eradicating ArmPkg = and putting the arch-standard
> > > > > > > > > > bits into
> > > (mostly) MdePkg.
> > > > > > > > > >
> > > > > > > > > > But I like the ability to= see already at the filesystem
> > > > > > > > > > level which files belong = to the architecture I'm
> > > > > > > > > > currently working on and<= br> > > > > > > > which don't.
> > > > > > > > > >
> > > > > > > > > > Could we concatenate arch= itectures?
> > > > > > > > > > I.e. AARCH64_ARM, IA32_X6= 4, AARCH64_RISCV64... ?
> > > > > > > > > >
> > > > > > > > > > /
> > > > > > > > > >    &n= bsp; Leif
> > > > > > > > > >
> > > > > > > > > > On 2022-09-30 08:28, Mich= ael D Kinney wrote:
> > > > > > > > > > > Hi Abner,
> > > > > > > > > > >
> > > > > > > > > > > One comment is on ad= ding a new CPU type dir name of
> 'X86'
> > > > > > > > > > > for content that is = common for IA32/X64.
> > > > > > > > > > >
> > > > > > > > > > > I can imagine a simi= lar case for ARM/AARCH64 and for
> > > > > > > > > > > the RISCV (32, 64, 1= 28) cases.
> > > > > > > > > > >
> > > > > > > > > > > I think I would pref= er to drop X86 and if there are
> > > > > > > > > > > files that are commo= n to multiple CPU architectures
> > > > > > > > > > > then they are consid= ered common and are in top
> > > > > > > > > > > directory of module = and the file header and INF file
> > > > > > > > > > > can clearly document= which CPU archs the file
> > > > > > > applies.
> > > > > > > > > > >
> > > > > > > > > > > Mike
> > > > > > > > > > >
> > > > > > > > > > >> -----Original Me= ssage-----
> > > > > > > > > > >> From: Chang, Abn= er <Abner.Chang@amd.com>
> > > > > > > > > > >> Sent: Friday, Se= ptember 30, 2022 12:11 AM
> > > > > > > > > > >> To: Ni, Ray <= ray.ni@intel.com>; Attar, AbdulLateef
> > > > > > > > > > >> (Abdul
> > > > > > > > > > >> Lateef) <Abdu= lLateef.Attar@amd.com>; Sunil V L
> > > > > > > > > > >> <sunilvl@vent= anamicro.com>; devel@edk2.groups.io;
> > > > > > > > > > >> Kinney, Michael = D <michael.d.kinney@intel.com>
> > > > > > > > > > >> Cc: lichao <l= ichao@loongson.cn>; Kirkendall, Garrett
> > > > > > > > > > >> <Garrett.Kirk= endall@amd.com>; Grimes, Paul
> > > > > > > > > > >> <Paul.Grimes@= amd.com>; He, Jiangang
> > > > > <Jiangang.He@amd.com>;
> > > > > > > Leif
> > > > > > > > > > >> Lindholm <qui= c_llindhol@quicinc.com>; Andrew Fish
> > > > > > > > > > >> <afish@apple.= com>
> > > > > > > > > > >> Subject: RE: [ed= k2-devel] The principles of EDK2
> > > > > > > > > > >> module reconstru= ction for archs
> > > > > > > > > > >>
> > > > > > > > > > >> [AMD Official Us= e Only - General]
> > > > > > > > > > >>
> > > > > > > > > > >> Thanks Ray, here= are my responses.
> > > > > > > > > > >> https://nam11.safelinks.protection.outlook.com/?url=3Dh
> > > > > > > > > > >> tt
> > > > > > > > > > >> ps%3
> > > > > > > > > > >> A%2F
> > > > > > > > > > >> %2Fg
> > > > > > > > > > >> ithub.com%2Ftian= ocore-docs%2Fedk2-
> > > > > > > CCodingStandardsSpecification
> > > > > > > > > > >> %2Fp
> > > > > > > > > > >>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> ull%2F2&amp;data=3D05%7C01%7CAbner.Chang%40amd.com%7C7c3292c8bd2 > > > > > > > f4
> > > > > > > > > 86f
> > > > > > > > > > >>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 920908daa314e8e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> > > > > > > > > 3800
> > > > > > > > > > >>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 1607445876768%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC
> > > > > > > JQ
> > > > > > > > > IjoiV
> > > > > > > > > > >>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata > > > > > > > =3D
> > > > > > > > > HAq
> > > > > > > > > > >>
> > > > > > >
> > > > >
> > ou4JyY1yxDthuQ1dEKcF7Q3o4W77Oo9rOOvkXNWU%3D&amp;reserved=3D0<= br> > > > > > > > > > > >>
> > > > > > > > > > >> @Kinney, Michael= D we may also need your
> > > > > > > > > > >> clarification on= the
> > > > > > > comments.
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > > > > >>> -----Origina= l Message-----
> > > > > > > > > > >>> From: Ni, Ra= y <ray.ni@intel.com>
> > > > > > > > > > >>> Sent: Thursd= ay, September 29, 2022 3:42 PM
> > > > > > > > > > >>> To: Attar, A= bdulLateef (Abdul Lateef)
> > > > > > > > > > >>> <AbdulLat= eef.Attar@amd.com>; Chang, Abner
> > > > > > > > > > >>> <Abner.Ch= ang@amd.com>; Sunil V L
> > > > > > > > > > >>> <sunilvl@= ventanamicro.com>; devel@edk2.groups.io
> > > > > > > > > > >>> Cc: Kinney, = Michael D <michael.d.kinney@intel.com>;
> > > > > > > > > > >>> lichao <l= ichao@loongson.cn>; Kirkendall, Garrett
> > > > > > > > > > >>> <Garrett.= Kirkendall@amd.com>; Grimes, Paul
> > > > > > > > > > >>> <Paul.Gri= mes@amd.com>; He, Jiangang
> > > > > <Jiangang.He@amd.com>;
> > > > > > > > > > >>> Leif Lindhol= m <quic_llindhol@quicinc.com>; Andrew
> > > > > > > > > > >>> Fish <afi= sh@apple.com>
> > > > > > > > > > >>> Subject: RE:= [edk2-devel] The principles of EDK2
> > > > > > > > > > >>> module recon= struction for archs
> > > > > > > > > > >>>
> > > > > > > > > > >>> Caution: Thi= s message originated from an External
> Source.
> > > > > > > > > > >>> Use proper c= aution when opening attachments,
> > > > > > > > > > >>> clicking lin= ks, or
> > > > > > > responding.
> > > > > > > > > > >>>
> > > > > > > > > > >>>
> > > > > > > > > > >>> Abner,
> > > > > > > > > > >>> Comments in<= br> > > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url=3D
> > > > > > > > > > >>> ht
> > > > > > > > > > >>> tps%
> > > > > > > > > > >>> 3A%2
> > > > > > > > > > >>> F%2F
> > > > > > > > > > >>> gith
> > > > > > > > > > >>> ub.com%2Ftia= nocore-docs%2Fedk2-
> > > > > > > > > > >>>
> CCodingStandardsSpecification%2Fpull%2F2%23pullreque
> > > > > > > > > > >>> st
> > > > > > > > > > >>> revi
> > > > > > > > > > >>> ew-
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 1124763311&amp;data=3D05%7C01%7CAbner.Chang%40amd.com%7Cd825e24 > > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 8625541e3f43e08daa1ee2883%7C3dd8961fe4884e608e11a82d994e183d%7C0
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> > %7C0%7C638000341502885565%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%<= br> > > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> >
> 7C%7C%7C&amp;sdata=3DRXxgpbEr6ivbqP1R6%2B3Rxl%2ByJAnaUJuaYYKdfCH > > > > > > > > > > >>> 8jo8%3D&= amp;reserved=3D0
> > > > > > > > > > >>>
> > > > > > > > > > >>> We can discu= ss more in tomorrow's meeting.
> > > > > > > > > > >>>
> > > > > > > > > > >>>
> > > > > > > > > > >>>> -----Ori= ginal Message-----
> > > > > > > > > > >>>> From: At= tar, AbdulLateef (Abdul Lateef)
> > > > > > > > > > >>>> <Abdu= lLateef.Attar@amd.com>
> > > > > > > > > > >>>> Sent: Th= ursday, September 29, 2022 3:11 PM
> > > > > > > > > > >>>> To: Chan= g, Abner <Abner.Chang@amd.com>; Sunil V L
> > > > > > > > > > >>>> <suni= lvl@ventanamicro.com>; devel@edk2.groups.io;
> > > > > > > > > > >>>> Ni, Ray = <ray.ni@intel.com>
> > > > > > > > > > >>>> Cc: Kinn= ey, Michael D <michael.d.kinney@intel.com>;
> > > > > > > > > > >>>> lichao &= lt;lichao@loongson.cn>; Kirkendall, Garrett
> > > > > > > > > > >>>> <Garr= ett.Kirkendall@amd.com>; Grimes, Paul
> > > > > > > > > > >>>> <Paul= .Grimes@amd.com>;
> > > > > > > > > > >>> He,
> > > > > > > > > > >>>> Jiangang= <Jiangang.He@amd.com>; Leif Lindholm
> > > > > > > > > > >>>> <quic= _llindhol@quicinc.com>; Andrew Fish
> > > > > > > > > > >>>> <afis= h@apple.com>
> > > > > > > > > > >>>> Subject:= RE: [edk2-devel] The principles of EDK2
> > > > > > > > > > >>>> module r= econstruction for archs
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> Hi Abner= ,
> > > > > > > > > > >>>> &nb= sp;    Looks good to me.
> > > > > > > > > > >>>> Reviewed= -by:  Abdul Lateef Attar <abdattar@amd.com>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> Thanks > > > > > > > > > > >>>> AbduL > > > > > > > > > > >>>>
> > > > > > > > > > >>>> -----Ori= ginal Message-----
> > > > > > > > > > >>>> From: Ch= ang, Abner <Abner.Chang@amd.com>
> > > > > > > > > > >>>> Sent: 28= September 2022 20:31
> > > > > > > > > > >>>> To: Suni= l V L <sunilvl@ventanamicro.com>;
> > > > > > > > > > >>>> devel@ed= k2.groups.io; ray.ni@intel.com
> > > > > > > > > > >>>> Cc: Kinn= ey, Michael D <michael.d.kinney@intel.com>;
> > > > > > > > > > >>>> lichao &= lt;lichao@loongson.cn>; Kirkendall, Garrett
> > > > > > > > > > >>>> <Garr= ett.Kirkendall@amd.com>; Grimes, Paul
> > > > > > > > > > >>>> <Paul= .Grimes@amd.com>;
> > > > > > > > > > >>> He,
> > > > > > > > > > >>>> Jiangang= <Jiangang.He@amd.com>; Attar, AbdulLateef
> > > > > > > > > > >>>> (Abdul > > > > > > > > > > >>>> Lateef) = <AbdulLateef.Attar@amd.com>; Leif Lindholm
> > > > > > > > > > >>>> <quic= _llindhol@quicinc.com>; Andrew Fish
> > > > > > > > > > >>>> <afis= h@apple.com>
> > > > > > > > > > >>>> Subject:= RE: [edk2-devel] The principles of EDK2
> > > > > > > > > > >>>> module r= econstruction for archs
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> [AMD Off= icial Use Only - General]
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> I just h= ad created PR to update edkII C coding
> > > > > > > > > > >>>> standard= spec for the file and directory naming. We
> > > > > > > > > > >>>> can revi= ew and confirm this update first and then
> > > > > > > > > > >>>> go back = to the principles of EDK2 module
> > > > > > > > > reconstruction for archs.
> > > > > > > > > > >>>> Here is = the PR:
> > > > > > > > > > >>>>
> > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url=3D
> > > > > > > > > > >>> ht
> > > > > > > > > > >>> tps%
> > > > > > > > > > >>> 3A%2
> > > > > > > > > > >>> F%2F
> > > > > > > > > > >>> gith
> > > > > > > > > > >>>> ub.com%2= Ftianocore-docs%2Fedk2-
> > > > > > > > > > >>> &amp;dat= a=3D05%7C01%7CAbner.Chang%40amd.c
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> om%7Cd825e248625541e3f43e08daa1ee2883%7C3dd8961fe4884e608e11a82
> > > > > > > > > > >>> d994e18
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 3d%7C0%7C0%7C638000341502885565%7CUnknown%7CTWFpbGZsb3d8eyJ
> > > > > > > > > > >>> WIjoiMC4wLj<= br> > > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C% > > > > > > > > > > >>> 7C%7C&a<= br> > > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> mp;sdata=3DX4z9puj81nIGTqtMxC9igDZyBPOT6OTWSU%2BjoIowo%2BE%3D&a > > > > > > > > > > >>> mp;reserv > > > > > > > > > > >>>> ed=3D0 > > > > > > > > > > >>>> CCodingS= tandardsSpecification/pull/2
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> The nami= ng rule is mainly for the new module or new
> file
> > IMO.
> > > > > > > > > > >>>> Some exi= sting module may not meet the guidelines
> > > > > > > > > > >>>> mentione= d in this
> > > > > > > > > spec.
> > > > > > > > > > >>>> Thus we = need the principles of EDK2 module
> > > > > > > > > > >>>> reconstr= uction on the existing module to support
> > > > > > > > > > >>>> other pr= ocessor archs and not impacting the
> > > > > > > > > > >>> existing pla= tforms (e.g.
> > > > > > > > > > >>>> rename t= he INF file or directory to meet the
> guidelines).
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> Sunil, s= eems RISC-V CpuDxe meet the guideline.
> > > > > > > > > > >>>> Please c= heck
> > > > > it.
> > > > > > > > > > >>>> Just fee= l that having  CpuDxe.c to Riscv64 folder
> > > > > > > > > > >>>> is not q= uite a best solution. I think at least we
> > > > > > > > > > >>>> can abst= ract the protocol structure and protocol
> > > > > > > > > > >>>> installa= tion under CpuDxe\ and have the arch
> > > > > > > > > > >>>> implemen= tation under arch folder. We can discuss
> > > > > > > > > > >>>> this lat= er after we confirming the
> > > > > > > > > > >>> guideline an= d principles.
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> Thanks > > > > > > > > > > >>>> Abner > > > > > > > > > > >>>>
> > > > > > > > > > >>>>> ----= -Original Message-----
> > > > > > > > > > >>>>> From= : Sunil V L <sunilvl@ventanamicro.com>
> > > > > > > > > > >>>>> Sent= : Wednesday, September 28, 2022 3:34 PM
> > > > > > > > > > >>>>> To: = devel@edk2.groups.io; ray.ni@intel.com
> > > > > > > > > > >>>>> Cc: = Chang, Abner <Abner.Chang@amd.com>; Kinney,
> > > > > Michael
> > > > > > > > > > >>>>> D &l= t;michael.d.kinney@intel.com>; lichao
> > > > > > > > > > >>>>> <= lichao@loongson.cn>; Kirkendall, Garrett
> > > > > > > > > > >>>>> <= Garrett.Kirkendall@amd.com>; Grimes, Paul
> > > > > > > > > > >>>>> <= Paul.Grimes@amd.com>; He, Jiangang
> > > > > > > > > > >>>>> <= Jiangang.He@amd.com>; Attar, AbdulLateef (Abdul
> > > > > > > > > > >>>>> Late= ef) <AbdulLateef.Attar@amd.com>; Leif
> Lindholm
> > > > > > > > > > >>>>> <= quic_llindhol@quicinc.com>; Andrew Fish
> > > > > > > > > > >>>>> <= afish@apple.com>
> > > > > > > > > > >>>>> Subj= ect: Re: [edk2-devel] The principles of EDK2
> > > > > > > > > > >>>>> modu= le reconstruction for archs
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> Caut= ion: This message originated from an External
> > Source.
> > > > > > > > > > >>>>> Use = proper caution when opening attachments,
> > > > > > > > > > >>>>> clic= king links, or
> > > > > > > responding.
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> On W= ed, Sep 28, 2022 at 03:33:45AM +0000, Ni, Ray
> > wrote:
> > > > > > > > > > >>>>> Hi R= ay,
> > > > > > > > > > >>>>>><= br> > > > > > > > > > > >>>>>>&= nbsp;   1.  When a new arch's implementation is
> > > > > > > > > > >>>>>> = introduced to the existing
> > > > > > > > > > >>>>> modu= le which was developed for the specific arch:
> > > > > > > > > > >>>>>><= br> > > > > > > > > > > >>>>>>&= nbsp;   1.  The folder reconstruction:
> > > > > > > > > > >>>>>><= br> > > > > > > > > > > >>>>>>&= nbsp;   *   Create arch folder for the existing arch > > implementation
> > > > > > > > > > >>>>>> = [Ray] Do you move existing arch implementation to
> > > > > > > > > > >>>>>> = that arch
> > > > > > > folder?
> > > > > > > > > > >>>>>> = It will
> > > > > > > > > > >>>>> brea= k existing platforms a lot.
> > > > > > > > > > >>>>>><= br> > > > > > > > > > > >>>>>>&= nbsp;   *   Create the arch folder for the new introduc= ed
> > arch
> > > > > > > > > > >>>>>> = [Ray] I agree. But if we don't create arch folder
> > > > > > > > > > >>>>>> = for existing arch
> > > > > > > > > > >>>>> impl= ementation, the pkg layout will be a mess.
> > > > > > > > > > >>>>>><= br> > > > > > > > > > > >>>>>> = [Ray] Hard for me to understand all the principles
> here.
> > > > > > > > > > >>>>>> = Maybe we review
> > > > > > > > > > >>>>> exis= ting code including to-be-upstreamed code and
> > > > > > > > > > >>>>> deci= de how
> > > > > > > to go.
> > > > > > > > > > >>>>>><= br> > > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> Coul= d you please take a look below changes which
> > > > > > > > > > >>>>> is t= rying to add RISC-V support for CpuDxe?
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url=3D
> > > > > > > > > > >>> ht
> > > > > > > > > > >>> tps%
> > > > > > > > > > >>> 3A%2
> > > > > > > > > > >>> F%2F
> > > > > > > > > > >>> gith
> > > > > > > > > > >>>>> ub.c= om%2Ftianocore%2Fedk2-
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> staging%2Fcommit%2Fbba1a11be47dd091734e185afbed73ea75708749&amp; > > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> data=3D05%7C01%7Cabner.chang%40amd.com%7Ca419e6a010d34fde464b08d
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> aa123e080%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63799947
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 2732494527%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sd > > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> >
> ata=3DVq6pJLnn8yJrJhFZn7LfLbZzrtpG4n1VLWgAil6J38U%3D&amp;reserved= =3D0
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>> https://nam11.safelinks.protection.outlook.com/?url=3D
> > > > > > > > > > >>> ht
> > > > > > > > > > >>> tps%
> > > > > > > > > > >>> 3A%2
> > > > > > > > > > >>> F%2F
> > > > > > > > > > >>> gith
> > > > > > > > > > >>>>> ub.c= om%2Ftianocore%2Fedk2-
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> staging%2Fcommit%2F7fccf92a97a6d0618a20f10622220e78b3687906&amp;da=
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> ta=3D05%7C01%7Cabner.chang%40amd.com%7Ca419e6a010d34fde464b08daa1
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 23e080%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63799947273
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 2494527%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> >
> 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata > > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > >
> > > > > > >
> > > > >
> >
> =3DxFmvUv58vh4AUAM17Qy9G5jZWFZlK2Ozt3njpG1e8%2BY%3D&amp;reserv
> > > > > > > > > > >>>>> ed= =3D0
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> What= do you suggest with above example?
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> 1) C= ommon INF for all architectures - but modify
> > > > > > > > > > >>>>> INF = alone, no
> > > > > > > > > > >>>>> X86 = folder creation.
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> This= is what I have done in the commit above. May
> > > > > > > > > > >>>>> be o= f least impact to existing code since it is only INF
> > change.
> > > > > > > > > > >>>>> But = like you mentioned this is bit weird that X86
> > > > > > > > > > >>>>> file= s will remain in root folder directly along
> > > > > > > > > > >>>>> with= some common
> > > > > files.
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> 2) C= ommon INF (CpuDxe.inf) + create arch folders
> > > > > > > > > > >>>>> X86,= X64, IA32,
> > > > > > > > > > >>>>> Risc= V64 etc
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> IMO,= this is probably the best approach. What
> > > > > > > > > > >>>>> woul= d be the challenges with this?
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> 3) S= eparate INF for arch like CpuDxe.inf for x86,
> > > > > > > > > > >>>>> CpuD= xeRiscV64.inf for
> > > > > > > > > > >>>> RISC-V.<= br> > > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> This= again probably is not a good idea.
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> 4) I= f the module/library is specific to one arch (ex:
> > > > > > > > > > >>>>> SMM(= X86), SBI(RISC-V)), then create separate INF.
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> Than= ks!
> > > > > > > > > > >>>>> Suni= l
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
--_000_MN2PR12MB39661D53541E7596A7CB6F63EA239MN2PR12MB3966namp_--