public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Michael D Kinney <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Nickle Wang <nicklew@nvidia.com>, Igor Kulchytskyy <igork@ami.com>
Subject: Re: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file
Date: Tue, 6 Dec 2022 08:23:56 +0000	[thread overview]
Message-ID: <MN2PR12MB39661EACFA54571FA2D94436EA1B9@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221206004446.12-1-michael.d.kinney@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Michael D Kinney <michael.d.kinney@intel.com>
> Sent: Tuesday, December 6, 2022 8:45 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path in
> DEC file
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Update ReadfishPkg.dec to remove PrivateInclude from the
> [Includes.Common.Private] section.  The PrivateInclude directory does not
> contain any include files, and the PrivateInclude/Crt include path remaining in
> the [Includes.Common.Private] section providing the include path required
> to access the CRT related include files by components within the RedfishPkg.
> 
> Without this update, there are two forms of #include statements that can be
> used to include the CRT related include files.
> Include files should only be available using one form of #include statements.
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  RedfishPkg/RedfishPkg.dec | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index
> 0aa26883e220..d2b189b13d8c 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -17,7 +17,6 @@ [Includes]
>    Include
> 
>  [Includes.Common.Private]
> -  PrivateInclude                # Private header files for C RTL.
>    PrivateInclude/Crt            # Private header files for C RTL.
>    Library/JsonLib               # Private header files for jansson
>                                  # configuration files.
> --
> 2.37.1.windows.1

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 16328 bytes --]

  reply	other threads:[~2022-12-06  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  0:44 [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Michael D Kinney
2022-12-06  8:23 ` Chang, Abner [this message]
2022-12-06 14:32   ` Igor Kulchytskyy
2022-12-07  3:05     ` [edk2-devel] " Nickle Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB39661EACFA54571FA2D94436EA1B9@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox