* [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file @ 2022-12-06 0:44 Michael D Kinney 2022-12-06 8:23 ` Chang, Abner 0 siblings, 1 reply; 4+ messages in thread From: Michael D Kinney @ 2022-12-06 0:44 UTC (permalink / raw) To: devel; +Cc: Abner Chang, Nickle Wang, Igor Kulchytskyy Update ReadfishPkg.dec to remove PrivateInclude from the [Includes.Common.Private] section. The PrivateInclude directory does not contain any include files, and the PrivateInclude/Crt include path remaining in the [Includes.Common.Private] section providing the include path required to access the CRT related include files by components within the RedfishPkg. Without this update, there are two forms of #include statements that can be used to include the CRT related include files. Include files should only be available using one form of #include statements. Cc: Abner Chang <abner.chang@amd.com> Cc: Nickle Wang <nicklew@nvidia.com> Cc: Igor Kulchytskyy <igork@ami.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> --- RedfishPkg/RedfishPkg.dec | 1 - 1 file changed, 1 deletion(-) diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index 0aa26883e220..d2b189b13d8c 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -17,7 +17,6 @@ [Includes] Include [Includes.Common.Private] - PrivateInclude # Private header files for C RTL. PrivateInclude/Crt # Private header files for C RTL. Library/JsonLib # Private header files for jansson # configuration files. -- 2.37.1.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file 2022-12-06 0:44 [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Michael D Kinney @ 2022-12-06 8:23 ` Chang, Abner 2022-12-06 14:32 ` Igor Kulchytskyy 0 siblings, 1 reply; 4+ messages in thread From: Chang, Abner @ 2022-12-06 8:23 UTC (permalink / raw) To: Michael D Kinney, devel@edk2.groups.io; +Cc: Nickle Wang, Igor Kulchytskyy [-- Attachment #1: Type: text/plain, Size: 2019 bytes --] [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: Michael D Kinney <michael.d.kinney@intel.com> > Sent: Tuesday, December 6, 2022 8:45 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang > <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com> > Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path in > DEC file > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Update ReadfishPkg.dec to remove PrivateInclude from the > [Includes.Common.Private] section. The PrivateInclude directory does not > contain any include files, and the PrivateInclude/Crt include path remaining in > the [Includes.Common.Private] section providing the include path required > to access the CRT related include files by components within the RedfishPkg. > > Without this update, there are two forms of #include statements that can be > used to include the CRT related include files. > Include files should only be available using one form of #include statements. > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Nickle Wang <nicklew@nvidia.com> > Cc: Igor Kulchytskyy <igork@ami.com> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> > --- > RedfishPkg/RedfishPkg.dec | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index > 0aa26883e220..d2b189b13d8c 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -17,7 +17,6 @@ [Includes] > Include > > [Includes.Common.Private] > - PrivateInclude # Private header files for C RTL. > PrivateInclude/Crt # Private header files for C RTL. > Library/JsonLib # Private header files for jansson > # configuration files. > -- > 2.37.1.windows.1 [-- Attachment #2: winmail.dat --] [-- Type: application/ms-tnef, Size: 16328 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file 2022-12-06 8:23 ` Chang, Abner @ 2022-12-06 14:32 ` Igor Kulchytskyy 2022-12-07 3:05 ` [edk2-devel] " Nickle Wang 0 siblings, 1 reply; 4+ messages in thread From: Igor Kulchytskyy @ 2022-12-06 14:32 UTC (permalink / raw) To: Chang, Abner, Michael D Kinney, devel@edk2.groups.io; +Cc: Nickle Wang [-- Attachment #1: Type: text/plain, Size: 3211 bytes --] Reviewed-by: Igor Kulchytskyy <igork@ami.com<mailto:abner.chang@amd.com>> Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Chang, Abner <Abner.Chang@amd.com> Sent: Tuesday, December 6, 2022 3:23:56 AM To: Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com> Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: Michael D Kinney <michael.d.kinney@intel.com> > Sent: Tuesday, December 6, 2022 8:45 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang > <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com> > Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path in > DEC file > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Update ReadfishPkg.dec to remove PrivateInclude from the > [Includes.Common.Private] section. The PrivateInclude directory does not > contain any include files, and the PrivateInclude/Crt include path remaining in > the [Includes.Common.Private] section providing the include path required > to access the CRT related include files by components within the RedfishPkg. > > Without this update, there are two forms of #include statements that can be > used to include the CRT related include files. > Include files should only be available using one form of #include statements. > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Nickle Wang <nicklew@nvidia.com> > Cc: Igor Kulchytskyy <igork@ami.com> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> > --- > RedfishPkg/RedfishPkg.dec | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index > 0aa26883e220..d2b189b13d8c 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -17,7 +17,6 @@ [Includes] > Include > > [Includes.Common.Private] > - PrivateInclude # Private header files for C RTL. > PrivateInclude/Crt # Private header files for C RTL. > Library/JsonLib # Private header files for jansson > # configuration files. > -- > 2.37.1.windows.1 -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. [-- Attachment #2: Type: text/html, Size: 5215 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file 2022-12-06 14:32 ` Igor Kulchytskyy @ 2022-12-07 3:05 ` Nickle Wang 0 siblings, 0 replies; 4+ messages in thread From: Nickle Wang @ 2022-12-07 3:05 UTC (permalink / raw) To: devel@edk2.groups.io, igork@ami.com, Chang, Abner, Michael D Kinney [-- Attachment #1: Type: text/plain, Size: 4182 bytes --] Reviewed-by: Nickle Wang <nicklew@nvidia.com> Regards, Nickle From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Igor Kulchytskyy via groups.io Sent: Tuesday, December 6, 2022 10:32 PM To: Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io Cc: Nickle Wang <nicklew@nvidia.com> Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file External email: Use caution opening links or attachments Reviewed-by: Igor Kulchytskyy <igork@ami.com<mailto:abner.chang@amd.com>> Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>> Sent: Tuesday, December 6, 2022 3:23:56 AM To: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>> Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>> > -----Original Message----- > From: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> > Sent: Tuesday, December 6, 2022 8:45 AM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>>; Nickle Wang > <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>> > Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path in > DEC file > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Update ReadfishPkg.dec to remove PrivateInclude from the > [Includes.Common.Private] section. The PrivateInclude directory does not > contain any include files, and the PrivateInclude/Crt include path remaining in > the [Includes.Common.Private] section providing the include path required > to access the CRT related include files by components within the RedfishPkg. > > Without this update, there are two forms of #include statements that can be > used to include the CRT related include files. > Include files should only be available using one form of #include statements. > > Cc: Abner Chang <abner.chang@amd.com<mailto:abner.chang@amd.com>> > Cc: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>> > Cc: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> > --- > RedfishPkg/RedfishPkg.dec | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index > 0aa26883e220..d2b189b13d8c 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -17,7 +17,6 @@ [Includes] > Include > > [Includes.Common.Private] > - PrivateInclude # Private header files for C RTL. > PrivateInclude/Crt # Private header files for C RTL. > Library/JsonLib # Private header files for jansson > # configuration files. > -- > 2.37.1.windows.1 -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. [-- Attachment #2: Type: text/html, Size: 9391 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-07 3:05 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-06 0:44 [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Michael D Kinney 2022-12-06 8:23 ` Chang, Abner 2022-12-06 14:32 ` Igor Kulchytskyy 2022-12-07 3:05 ` [edk2-devel] " Nickle Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox