Re: [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

The Manageability package could be included by the AdvancedFeaturePkg.  The reason I didn't use common MinPlatform include metafiles is because there are many driver (plus the pull in libraries) which are no need to be built for ManageabilityPkg.
But to keep the consistent implementation is also important to Tianocore, so I may follow the package implementation under AdvancedFeaturePkg.

Thanks
Abner

> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Thursday, February 16, 2023 9:50 AM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>
> Subject: RE: [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> I think that the ManageabilityPkg shouldn't have a file like
> CommonLibs.dsc.inc that defines commonly used content.  It is the wrong
> scope.  I would prefer to use the MinPlatformPkg content on the theory that
> it will move MinPlatformPkg to a more general location once it is in wider use.
> 
> Put another way, either we want many packages to include it, which is weird
> since the content isn't scoped to this package, or it is just for this package and
> others shouldn't include it, in which case, separating it from
> ManageabilityPkg.dsc via an include doesn't add anything.
> 
> If you don't want to use MinPlatformPkg then I would suggest following the
> original buildable package convention and put this content in the
> ManageabilityPkg/ManageabilityPkg.dsc.
> 
> "Manageabilty" is misspelled in a number of places in these files.
> 
> Regards,
> Isaac
> 
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Tuesday, February 7, 2023 8:23 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Abdul Lateef Attar
> <abdattar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-platforms][PATCH 4/7] ManageabilityPkg: Initial package
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Initial commit of ManageabilityPkg
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  .../ManageabilityPkg/ManageabilityPkg.dec     | 18 +++++++++
>  .../Include/CommonLibs.dsc.inc                | 40 +++++++++++++++++++
>  .../ManageabilityPkg/ManageabilityPkg.dsc     | 23 +++++++++++
>  3 files changed, 81 insertions(+)
>  create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec
>  create mode 100644
> Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
>  create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc
> 
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
> b/Features/ManageabilityPkg/ManageabilityPkg.dec
> new file mode 100644
> index 0000000000..8a0e28f50b
> --- /dev/null
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -0,0 +1,18 @@
> +## @file
> +# Manageabilty Package
> +# This is the package provides the edk2 drivers and libraries # those
> +are related to the platform management.
> +#
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> +reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> +
> +[Defines]
> +  DEC_SPECIFICATION = 0x0001001d
> +  PACKAGE_NAME      = ManageabilityPkg
> +  PACKAGE_GUID      = 36310119-4FB2-4BA3-959D-74C16B849F9E
> +  PACKAGE_VERSION   = 1.0
> +
> +[Includes]
> +  Include
> diff --git a/Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
> b/Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
> new file mode 100644
> index 0000000000..2dc2d07f17
> --- /dev/null
> +++ b/Features/ManageabilityPkg/Include/CommonLibs.dsc.inc
> @@ -0,0 +1,40 @@
> +## @file
> +# Common libraries for Manageabilty Package # # Copyright (C) 2023
> +Advanced Micro Devices, Inc. All rights reserved.<BR> #
> +SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> +
> +[LibraryClasses]
> +
> +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntr
> +yPoint.inf
> +
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiB
> o
> +otServicesTableLib.inf
> +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> +  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> se
> +DebugPrintErrorLevelLib.inf
> +  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> +
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> oryAl
> +locationLib.inf
> +
> +[LibraryClasses.common.PEIM]
> +  PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
> +
> +PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt
> +/PeiServicesTablePointerLibIdt.inf
> +  PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> +
> +MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemor
> yAllo
> +cationLib.inf
> +  HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> +
> +[LibraryClasses.common.DXE_SMM_DRIVER]
> +
> +SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServices
> Table
> +Lib.inf
> +
> +MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe
> moryAllo
> +cationLib.inf
> +
> +[LibraryClasses.ARM, LibraryClasses.AARCH64]
> +  #
> +  # This library provides the instrinsic functions generated by a given
> compiler.
> +  #
> +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> new file mode 100644
> index 0000000000..9ae398277f
> --- /dev/null
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> @@ -0,0 +1,23 @@
> +## @file
> +# Manageabilty Package
> +# This is the package provides edk2 drivers and libraries # those are
> +related to the platform management.
> +#
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> +reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> +
> +[Defines]
> +  PLATFORM_NAME                  = ManageabilityPkg
> +  PLATFORM_GUID                  = 7A98123A-B194-40B6-A863-A52192F6D65D
> +  PLATFORM_VERSION               = 1.0
> +  DSC_SPECIFICATION              = 0x0001001e
> +  OUTPUT_DIRECTORY               = Build/ManageabilityPkg
> +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> +  SKUID_IDENTIFIER               = DEFAULT
> +
> +!include MdePkg/MdeLibs.dsc.inc
> +!include ManageabilityPkg/Include/CommonLibs.dsc.inc
> +
> --
> 2.37.1.windows.1