From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.58]) by mx.groups.io with SMTP id smtpd.web10.16780.1672934989247515207 for ; Thu, 05 Jan 2023 08:09:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=b8NJ4Kib; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.58, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HudxE4DDipOWYLrGt1tnotGF1RXankSB7KfcNV+NJYdTQJ6JYiCjvYrdy8YT6fvQ6ZY6BypBTeifRXlil343nrU/4G7HaoIzeQYIr6K3Ms3a49XrMcjwOMysp+ps5s5+sxkPWz5JcXDIEMjtCWyYCkue6H5/YdXTT4v6gQobxX2Fz78W5bluo6gJ/gJoHl+/GfmkkEZp0x2ZoCrCUDxcAUNpl4umpXvb2DRb2AHcbksPKjw+ATMJvIw01P4890FZdhwgOHsSHnObyGhNM1w2bgi5Ws0w3TnYoy2ni2bQhO/xyS0/QAe3zkFyFp0P7e4dygTTaAknhSydekdrpD09Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LW0Oe7/XoQ3xvz0v1RhZm0n5c3W8bRUjc25s5zyZVO8=; b=FKCGThuzlcdCWLVCnFviqkCrnTofJokkzS5IQ5t197TsrtiuqIgpQY4nCoIi0Q9cn6FG62R9o7z8NBn5YcT4HTHdfRvBQ8Ok2x/u5QrM6B3hIt9mawIGRFs4SbrkboeVYwHuiVEd44ymMYXllYTpnxjsg2kxcs3WmkMKwEFO+aflorSIRn2c5KfwVE5xYx6AsC47xCOoUtmke9zu90TQMtSbKKpmf+0v/htzdXXrDAl26KPk0a0L3/z3L3CU8t59bkCzJ38QmQgVbHDsCg6DWmKGVsvT6SwSvzFh2Rq6A1uogh8vG9+8E0OMb++38sjWgVcWulx1WoHSBNyE1k8J2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LW0Oe7/XoQ3xvz0v1RhZm0n5c3W8bRUjc25s5zyZVO8=; b=b8NJ4KibuD7moG0LKMy52B85iTnxHsdUQCQhhNEi3Tz/lf0ndtBqQOMXYfAlcYXze/oLjZilXLQD3tkn9vZFcNGpmtBvSBMNYfXxwCtVa6wueh0UAw8S3qQis3pSaVbhdYcrv78bj1wwlQJV7Ol6arKfwBsFHsTb4fcZk7cmeqQ= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB8162.namprd12.prod.outlook.com (2603:10b6:806:33a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:09:46 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:09:46 +0000 From: "Chang, Abner" To: Ard Biesheuvel , "devel@edk2.groups.io" CC: "quic_llindhol@quicinc.com" , "rebecca@quicinc.com" , "bob.c.feng@intel.com" , "gaoliming@byosoft.com.cn" , Sunil V L Subject: Re: [PATCH 1/4] BaseTools/tools_def RISCV: Make OpenSBI references RISCV-only Thread-Topic: [PATCH 1/4] BaseTools/tools_def RISCV: Make OpenSBI references RISCV-only Thread-Index: AQHZIR9/ByjgHV9Y1kiwHQcK7WyfMK6P/bNg Date: Thu, 5 Jan 2023 16:09:46 +0000 Message-ID: References: <20230105160503.1423627-1-ardb@kernel.org> <20230105160503.1423627-2-ardb@kernel.org> In-Reply-To: <20230105160503.1423627-2-ardb@kernel.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-05T16:09:44Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c3415d1c-fd29-4077-9681-afbcaddcc0f6; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA1PR12MB8162:EE_ x-ms-office365-filtering-correlation-id: 56e5e252-628b-46dd-6665-08daef3743e2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w3PNbdwkIGJSGRqGIufMmdK/Djk6vw3l35v1MTJmz1p0EO/VitpPyu4nGVGH+v4gzogEO/IQEWK7uVx0tjmPAcsrZSmqnoCyt4AW6fL3ICsOfgni43xWW4qgkBG00C8NXjVSyl6wNbpIt58KQkk2yu9gAnWDJW3q53sTB0ArPv2hO56w0O9chQfOfTG9+T2RgN7AD4iFSx1/xcMaoVceh2bFHnKXC2rgLnSgOxta6y72i968OcEjWElNXUWsHsufPZ9AP8q93urpkBeA9qc+YF2RXPIwPuyAh2lqr+HcAEA/ie8cy40a5tLZiLhWYPj3xxBqECqvLvEii128Y2VGkUcKOOlB08CFVf7TMpjh/KH78mFCIkyV7HK4J0CC6EVDa2woG+MwZsnMhF694WhPH+fhs/5ccuALUzKkIvAxhcfMm1OCN7ZpLBincXk/wpBbUHVR3stfdu7qpgf+ULUqD4nN9KzFOErzFnjEVKiRiDfFazAvqHj3NsDF50NX2qz86tWhyRsBhj3OSwbawZbLCdcA2K3+Ucf77yjHxVJchv4MaVna6Ip5nBoAHR1wY95IESEFi28HQXAxNF9oNJ2RmPq6GxvJ3s5qwKAas7DTdZVPMzDWhURv4iRRIzFdu7Zv4NIrWD1kGOVydgym0qxQ97122A1NsDVK7IiRJhGxPG+Gq85t8U408Hggop37BPPZG41z0Js/Vd0cwKJvG5mriQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(451199015)(55016003)(83380400001)(7696005)(186003)(26005)(6506007)(9686003)(33656002)(38070700005)(86362001)(122000001)(53546011)(38100700002)(8676002)(4326008)(8936002)(52536014)(41300700001)(5660300002)(2906002)(478600001)(71200400001)(54906003)(316002)(76116006)(66446008)(66476007)(64756008)(66946007)(110136005)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RXNoA6HSEHlBapaEezwLXTc4TsbbVxlofesJPNXHUMQopvg1l9JKzvbWW4sd?= =?us-ascii?Q?WI0MAgxmNxnbWW9dL33VG+Kl1Qceal2rpmATvhFc6govhFgGyJ6GXI/s+umt?= =?us-ascii?Q?IPI90Ai8RI6+5bjpZ7ECpQUEUGdfIyFK+JMM6wjqpfR5zHyf8wi/2piNWNcF?= =?us-ascii?Q?laqlRZ0qOgMG8d0SVRBitRmFt+0kho3XIIbYIXRMucyVKpFd4a+fgGBE8Y3Y?= =?us-ascii?Q?b7VWz7b6gbN7EA2mu7wcFfuhzllUXVubuUe1GwIW7wDCWDBKcg8f2cGvzM0j?= =?us-ascii?Q?t0+BMWKb+B2BncWsW/WrjTBeYxGEgpuZzC/eLkv2AwIGF9z7sBIS14ecj/G2?= =?us-ascii?Q?BItjd/xHokBKqrm+Mn1bK4yb5LEUWKHQOtq1FkGpIBug0a1NudYXyOEWcEiU?= =?us-ascii?Q?0VRuGyloALl3lrKClI5XkuMhr6gFKAkiEGk7y/mi43f2w9+WPdIzJsSzPuNJ?= =?us-ascii?Q?PtYjavruL/OzM9T/bjS6Bsb0W7Bx8jMwvSgEY02DQ1o6WHqE0pEEdqdHmjzG?= =?us-ascii?Q?Eb1gRUE1FIAe+uCGQoRX5JOxuZumWAxFgPe+hSsT6rBhu3GYWWsh+tFJ+Qs9?= =?us-ascii?Q?/WSNyOHFzoTe5Wr0JOVtKs5yA0V9WzLgakgyZ1EVM1KCPcUbzHVNZEyyoUJL?= =?us-ascii?Q?NVMlYpx1zoCGNQh8auErRJx8za97rPdPxo3hI4wZW5S6U2Zjo5c1Z6hxCjEr?= =?us-ascii?Q?lrRqabWaUcZ+J+UWeftEpXsSvRq3NYYykFp8oM1b4c6cnuMLU7HpnDz514tf?= =?us-ascii?Q?uvJfTiI7IcqZEGjioAODYea3TPDHn1oAuRcowHGWz2o0ar5m9YizSncMqV/J?= =?us-ascii?Q?gCnmyQ2hz6pIDp4QasQOHOwl8ymjoDV2pN4Kf8zTs8gDA27IeXgQgJCgPXPX?= =?us-ascii?Q?EsbRpjK8Fok/ZhAIazfYP2IP1TWRGpV+tdPFWaZ1d/DTidso+VJ1Ckc5/aGb?= =?us-ascii?Q?lyvE2iR2WgegycUj2WCjH3/4CUkSEmce/u6wDqTgGeHaUcl4PzMvMH12YLUT?= =?us-ascii?Q?QzU1TDMLa53vRcvy9ie/PeyXAPlWSL8ABOSvM6/wzSDRq6a2a8XrcfXZH6/Z?= =?us-ascii?Q?rXPcRG/n9PPyEE7hRCoMdrfy3i7EnjoZq3aKrS87Rex4OzBw7rFxb2avacRa?= =?us-ascii?Q?52QJyz7F17t9BwDKIUbF9GQrVtNXXTTT0/cmdfDVaJeqfSjBcjIpw84Wq9tH?= =?us-ascii?Q?/8iPgMkxyYx6zL4v+MOMPxKgXivEz4KgiJSrO4tuvp9Y1XI3O8igyuSTOA/Y?= =?us-ascii?Q?ntoTnhulIaNjgfv7gJhm61dUU8K4JLkw66cHJaRtTelJnEo6hPfCBylfGWGe?= =?us-ascii?Q?6KURo0ZMjmw/b2+LTVRTFC9Zdoxea8XZF9t6TwnyG8TPfwzov1HX74fCi6CG?= =?us-ascii?Q?lrC5QTH2JL76wAWpWPL5aZ29saIrSzgpupThdNKiHsjAOP1joYQqP0PowXx4?= =?us-ascii?Q?sqY4ypUAKfY2taJod5LUHlTi8t3rsmvsU2/VJDP33WdiHcaw09AG+/68HPKI?= =?us-ascii?Q?b7JCr1WvjTFLjVauXu3Wzt2dxq2OCK8uHBvsOAp9Z74xrlKi3ErC61ct3WuK?= =?us-ascii?Q?LeF5OVxOQjCtMhT13W8=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56e5e252-628b-46dd-6665-08daef3743e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 16:09:46.6872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qfgCyheAhVpDX07pqhuW3A4zq9CPELbFIaBMyU91qCJhia25Bg+1GY8AXKSA1whnREJTd7iC3ksnEmBBw/I0Yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8162 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Acked-by: Abner Chang Add Sunil to review this. > -----Original Message----- > From: Ard Biesheuvel > Sent: Friday, January 6, 2023 12:05 AM > To: devel@edk2.groups.io > Cc: quic_llindhol@quicinc.com; rebecca@quicinc.com; bob.c.feng@intel.com; > gaoliming@byosoft.com.cn; Ard Biesheuvel ; Chang, > Abner > Subject: [PATCH 1/4] BaseTools/tools_def RISCV: Make OpenSBI references > RISCV-only >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > The global GCC_PP_FLAGS tools_def variable now contains a reference to > OpenSBI specific C preprocessor variables, which means they are added to > the command line on every architecture, not just RISC-V. >=20 > This does not currently result in any issues, but it is a bit sloppy so l= et's clean > this up. Given that the GCC_PP_FLAGS definition appears twice, drop the > one that carries the OpenSBI reference, and move that reference to a new > RISC-V specific variable. >=20 > Cc: Abner Chang > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 805e903b23bb..4733040e3ef1 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1979,8 +1979,6 @@ DEFINE GCC5_LOONGARCH64_ASLDLINK_FLAGS > =3D DEF(GCC_LOONGARCH64_ASLDLINK_FLAGS) > DEFINE GCC5_LOONGARCH64_ASM_FLAGS =3D -x assembler-with-cpp - > mabi=3Dlp64d -march=3Dloongarch64 -fno-builtin -c -Wall -mno-explicit-rel= ocs >=20 > DEFINE GCC5_LOONGARCH64_PP_FLAGS =3D -mabi=3Dlp64d - > march=3Dloongarch64 DEF(GCC_PP_FLAGS) >=20 >=20 >=20 > -DEFINE GCC_PP_FLAGS =3D -E -x assembler-with-cpp = -include > AutoGen.h DEF(GCC5_RISCV_OPENSBI_TYPES) >=20 > - >=20 >=20 > ########################################################## > ########################## >=20 > # >=20 > # GCC 4.8 - This configuration is used to compile under Linux to produce >=20 > @@ -2456,6 +2454,7 @@ RELEASE_GCC5_AARCH64_DLINK_XIPFLAGS =3D -z > common-page-size=3D0x20 > *_GCC5_RISCV64_RC_FLAGS =3D DEF(GCC_RISCV64_RC_FLAGS) >=20 > *_GCC5_RISCV64_OBJCOPY_FLAGS =3D >=20 > *_GCC5_RISCV64_DTCPP_FLAGS =3D DEF(GCC_DTCPP_FLAGS) >=20 > +*_GCC5_RISCV64_PP_FLAGS =3D DEF(GCC_PP_FLAGS) > DEF(GCC5_RISCV_OPENSBI_TYPES) >=20 >=20 >=20 > ################## >=20 > # GCC5 LOONGARCH64 definitions >=20 > -- > 2.39.0